New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 34841 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
User never visited
Closed: Feb 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 10603

Blocking:
issue 4890

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

chrome.bookmarks.update does not allow changing the URL

Project Member Reported by arv@chromium.org, Feb 6 2010

Issue description

chrome.bookmarks.update only allows changing the title of a bookmark. I need 
to be able to change the URL as well.
 

Comment 1 by arv@chromium.org, Feb 6 2010

Scott, there is a TODO(sky) in bookmarks_util that we should add SetURL. Is there a 
reason why this was never done (besides lack of time)?

Comment 2 by sky@chromium.org, Feb 8 2010

Only lack of time. See 10603.

Comment 3 by arv@chromium.org, Feb 8 2010

Blockedon: 10603

Comment 4 by bugdro...@gmail.com, Feb 10 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38555 

------------------------------------------------------------------------
r38555 | arv@chromium.org | 2010-02-09 17:00:29 -0800 (Tue, 09 Feb 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmarks_module.cc?r1=38555&r2=38554
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=38555&r2=38554
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/bookmarks.html?r1=38555&r2=38554
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/tabs.html?r1=38555&r2=38554
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/bookmarks/test.js?r1=38555&r2=38554

Make it so that chrome.bookmarks.update can update the URL of a bookmark.

This changes the API slightly. Previously, if someone called update with an empty object ({}) it would set the title to "". This was only documented in the code and not on the API page. Now that we support updating both the url and title it seems more reasonable to ignore a missing title.

BUG= 34841 
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Bookmarks

Review URL: http://codereview.chromium.org/591006
------------------------------------------------------------------------

Comment 5 by arv@chromium.org, Feb 10 2010

Status: Fixed
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2012

Blockedon: -chromium:10603 chromium:10603
Blocking: -chromium:4890 chromium:4890
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 11 2013

Labels: -Feature-Extensions Cr-Platform-Extensions

Sign in to add a comment