New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 34781 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2010
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Pop-up settings changed in bubble appear not to be saved (but really are)

Reported by mberkowitz@chromium.org, Feb 5 2010

Issue description

Google Chrome 5.0.317.2 (Official Build 38193)
Implemented in Windows only at this point.

What steps will reproduce the problem?
--------------------------------------

Preconditions:
--------------
Options > Under the Hood > Content Settings... > Pop-ups: select "Do not 
allow any site to show pop-ups".

Repro:
------
1. Go to http://www.andrewkantor.com/popupdemo/popuptest.html
2. Click on the popup-blocker icon in the Omnibox.
3. Note that "Continue blocking pop-ups" is selected by default.
3. In the bubble, select "Always allow popups from www.andrewkantor.com".
4. Close, reopen the bubble.

What is the expected output?
----------------------------
"Always allow popups from www.andrewkantor.com" should still be selected.

What do you see instead?
------------------------
Selection has reverted to "Continue blocking pop-ups".

Note: although the new setting does not appear to persist, the Pop-up 
Exceptions dialog correctly shows an entry allowing popups from 
www.andrewkantor.com.  So it appears to be a problem within the bubble 
itself.


 
Labels: -Feature-PopupBlocker
Actually, this applies to all the Content Settings (except Cookies), not just the popup 
blocker.
Labels: -Pri-2 Pri-1 Mstone-4.1 ReleaseBlock-Beta
Status: Assigned
This is mine
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38388 

------------------------------------------------------------------------
r38388 | pkasting@chromium.org | 2010-02-08 12:46:00 -0800 (Mon, 08 Feb 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/content_blocked_bubble_gtk.cc?r1=38388&r2=38387
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/content_blocked_bubble_contents.cc?r1=38388&r2=38387

Set the initial state of the content blocked bubble radio buttons correctly.

BUG= 34781 
TEST=Go to a page where content is blocked, open the bubble, change the radio button to "allow", open the bubble again, and make sure it's still "allow".
Review URL: http://codereview.chromium.org/587003
------------------------------------------------------------------------

Status: Fixed
Fixed in r38388.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38390 

------------------------------------------------------------------------
r38390 | pkasting@chromium.org | 2010-02-08 12:50:15 -0800 (Mon, 08 Feb 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/content_blocked_bubble_contents.cc?r1=38390&r2=38389

Merge 38388 - Set the initial state of the content blocked bubble radio buttons correctly. 

BUG= 34781 
TEST=Go to a page where content is blocked, open the bubble, change the radio button to "allow", open the bubble again, and make sure it's still "allow".

Review URL: http://codereview.chromium.org/587003

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/586008
------------------------------------------------------------------------

Status: Verified
Chrome 4.1.249.1015 (Official Build 39565) / Windows
Chromium 5.0.336.0 (Developer Build 39611) / Windows

Verified.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment