New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 34692 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2010
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Multiple Exceptions windows can exist in the Content Settings UI

Reported by mberkowitz@chromium.org, Feb 5 2010

Issue description

Chrome 4.1.249.1003 (Official Build 38072)
Currently, feature exists on Windows only.

What steps will reproduce the problem?
--------------------------------------
1. Options > Content Settings.
2. Press "Exceptions..." button multiple times.

What is the expected output?
----------------------------
Only one Cookie Exceptions window should exist at any time.

What do you see instead?
------------------------
Multiple Cookie Exceptions windows pop up.

 
Summary: Multiple Exceptions windows can exist in the Content Settings UI
This applies to all the content settings, not just cookies.
Labels: -Pri-2 Pri-1 ReleaseBlock-Beta Mstone-4.1
Status: Assigned
I know how to fix this.
Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38516 

------------------------------------------------------------------------
r38516 | pkasting@chromium.org | 2010-02-09 13:58:22 -0800 (Tue, 09 Feb 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/exceptions_view.cc?r1=38516&r2=38515
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/exceptions_view.h?r1=38516&r2=38515

Prevent the user from triggering multiple copies of a particular exceptions window.

BUG= 34692 
TEST=Open the content settings dialog to any page, hit "Exceptions", move the exceptions window and hit "Exceptions" again; we shouldn't spawn another window.
Review URL: http://codereview.chromium.org/596020
------------------------------------------------------------------------

Status: Fixed
Fixed in r38516.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38517 

------------------------------------------------------------------------
r38517 | pkasting@chromium.org | 2010-02-09 13:59:48 -0800 (Tue, 09 Feb 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/options/exceptions_view.cc?r1=38517&r2=38516
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/options/exceptions_view.h?r1=38517&r2=38516

Merge 38516 - Prevent the user from triggering multiple copies of a particular exceptions window.

BUG= 34692 
TEST=Open the content settings dialog to any page, hit "Exceptions", move the exceptions window and hit "Exceptions" again; we shouldn't spawn another window.
Review URL: http://codereview.chromium.org/596020

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/593024
------------------------------------------------------------------------

Status: Verified
Chrome/Windows 4.1.249.1015 (Official Build 39565)
Chromium/Windows 5.0.336.0 (Developer Build 39611)

Verified.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Sign in to add a comment