Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 16 users
Status: Fixed
Owner:
Closed: Feb 2015
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 374782

Blocking:
issue 350535



Sign in to add a comment
Delete showModalDialog
Project Member Reported by jam...@chromium.org, Feb 21 2014 Back to list
See intent to remove thread here:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/xh9fPX0ijqk/ixHZCOH6GLgJ

based on usage data, we believe that it is web compatible to remove this API now.  This bug is to track the removal and keep track of any fallout.
 
Project Member Comment 1 by bugdroid1@chromium.org, Feb 24 2014
------------------------------------------------------------------------
r252883 | jamesr@chromium.org | 2014-02-24T05:58:31.137851Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/error-body-no-crash.html?r1=252883&r2=252882&pathrev=252883
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/showmodaldialog.html?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_impl.h?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/webdriver/test_data/alerts.html?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.h?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webkit_browsertest.cc?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.h?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=252883&r2=252882&pathrev=252883
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=252883&r2=252882&pathrev=252883

Remove tests and code for showModalDialog

This deletes the chromium-side implementation logic and a few tests for
showModalDialog. I believe more simplification is possible to do without the
design constraints imposed by showModalDialog but we should probably start
small in case we run into unexpected compat issues.

R=darin
BUG=345831

Review URL: https://codereview.chromium.org/165793003
------------------------------------------------------------------------
Project Member Comment 2 by bugdroid1@chromium.org, Feb 24 2014
------------------------------------------------------------------------
r252889 | haraken@chromium.org | 2014-02-24T07:49:45.335627Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/showmodaldialog.html?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_impl.h?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/webdriver/test_data/alerts.html?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.h?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webkit_browsertest.cc?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.h?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=252889&r2=252888&pathrev=252889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=252889&r2=252888&pathrev=252889
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/error-body-no-crash.html?r1=252889&r2=252888&pathrev=252889

Revert 252883 "Remove tests and code for showModalDialog"

This CL broke show-modal-dialog tests in Blink.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/open-window-min-size.html,fast/events/scroll-event-during-modal-dialog.html,fast/events/show-modal-dialog-onblur-onfocus.html,fast/harness/show-modal-dialog.html

> Remove tests and code for showModalDialog
> 
> This deletes the chromium-side implementation logic and a few tests for
> showModalDialog. I believe more simplification is possible to do without the
> design constraints imposed by showModalDialog but we should probably start
> small in case we run into unexpected compat issues.
> 
> R=darin
> BUG=345831
> 
> Review URL: https://codereview.chromium.org/165793003

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/177263002
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Feb 24 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167703

------------------------------------------------------------------------
r167703 | jamesr@chromium.org | 2014-02-24T21:44:39.474629Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=167703&r2=167702&pathrev=167703

Suppress test failures related to upcoming showModalDialog removal

BUG=345831
TBR=abarth

Review URL: https://codereview.chromium.org/178723002
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Feb 24 2014
------------------------------------------------------------------------
r252989 | jamesr@chromium.org | 2014-02-24T21:47:26.946125Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.h?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webkit_browsertest.cc?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.h?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=252989&r2=252988&pathrev=252989
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/error-body-no-crash.html?r1=252989&r2=252988&pathrev=252989
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/showmodaldialog.html?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_impl.h?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=252989&r2=252988&pathrev=252989
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/webdriver/test_data/alerts.html?r1=252989&r2=252988&pathrev=252989

Revert 252889 "Revert 252883 "Remove tests and code for showModa..."

Layout test failures are expected and suppressed on the blink side.

> Revert 252883 "Remove tests and code for showModalDialog"
> 
> This CL broke show-modal-dialog tests in Blink.
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/open-window-min-size.html,fast/events/scroll-event-during-modal-dialog.html,fast/events/show-modal-dialog-onblur-onfocus.html,fast/harness/show-modal-dialog.html
> 
> > Remove tests and code for showModalDialog
> > 
> > This deletes the chromium-side implementation logic and a few tests for
> > showModalDialog. I believe more simplification is possible to do without the
> > design constraints imposed by showModalDialog but we should probably start
> > small in case we run into unexpected compat issues.
> > 
> > R=darin
> > BUG=345831
> > 
> > Review URL: https://codereview.chromium.org/165793003
> 
> TBR=jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/177263002

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/178783002
------------------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Feb 25 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=167736

------------------------------------------------------------------------
r167736 | jamesr@chromium.org | 2014-02-25T06:54:21.387424Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/function-length.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/resources/wrapper-identity-base.js?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/null-page-show-modal-dialog-crash-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-call.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/CreateWindow.h?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/show-modal-dialog-test.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/script-tests/global-function-resolve.js?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/showModalDialog-returnValue.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-blur.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-arguments.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.h?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebWidgetClient.h?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-get-expected.txt?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8WindowCustom.cpp?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/http/tests/security/README?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/null-page-show-modal-dialog-crash.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.h?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash-expected.txt?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/window-properties.js?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/ManualTests/js-timers-beneath-modal-dialog.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DOMWindow.h?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/CreateWindow.cpp?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-put.html?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/global-function-resolve-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-get.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/function-length-expected.txt?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.cpp?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/WindowProperties.js?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-call-expected.txt?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-lookup-precedence.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/wrapper-identity-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-property-shadowing.html?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/Window.idl?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.cpp?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/EmptyClients.h?r1=167736&r2=167735&pathrev=167736
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ChromeClient.h?r1=167736&r2=167735&pathrev=167736
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DOMWindow.cpp?r1=167736&r2=167735&pathrev=167736

Remove deprecated window.showModalDialog()

Time to go.

BUG=345831

Review URL: https://codereview.chromium.org/174073007
------------------------------------------------------------------------
Blocking: chromium:350535
Project Member Comment 7 by bugdroid1@chromium.org, Mar 14 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=169277

------------------------------------------------------------------
r169277 | eseidel@chromium.org | 2014-03-14T21:17:25.478919Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/WindowProperties.js?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.cpp?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-call-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-lookup-precedence.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/wrapper-identity-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-property-shadowing.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/Window.idl?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.cpp?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/EmptyClients.h?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ChromeClient.h?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DOMWindow.cpp?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/function-length.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/null-page-show-modal-dialog-crash-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/resources/wrapper-identity-base.js?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-call.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/CreateWindow.h?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/ManualTests/show-modal-dialog-test.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/script-tests/global-function-resolve.js?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/ManualTests/showModalDialog-returnValue.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-blur.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-arguments.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.h?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebWidgetClient.h?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-get-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8WindowCustom.cpp?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/null-page-show-modal-dialog-crash.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/http/tests/security/README?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.h?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/window-properties.js?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/ManualTests/js-timers-beneath-modal-dialog.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/DOMWindow.h?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/CreateWindow.cpp?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-put.html?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/global-function-resolve-expected.txt?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-get.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/function-length-expected.txt?r1=169277&r2=169276&pathrev=169277
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html?r1=169277&r2=169276&pathrev=169277
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt?r1=169277&r2=169276&pathrev=169277

Add back window.showModalDialog

This is a revert of r167736 plus
changes to make it compile after the
Frame -> LocalFrame rename.

We are temporarily adding back window.showModalDialog
for M35, but plan to attempt removal again in M36.

BUG=345831

Review URL: https://codereview.chromium.org/200713002
-----------------------------------------------------------------
Comment 8 by jam...@chromium.org, Mar 14 2014
This'll expose window.showModalDialog to the web again, but it won't be functional without reverting chromium r252989.  However, that revert won't compile until this rolls in to DEPS.  So we wait.
Comment 9 by jam...@chromium.org, Mar 15 2014
Blink is still 4 revs shy of rolling this in and it's the end of my workday, so this'll wait until tomorrow or Monday.
Project Member Comment 10 by bugdroid1@chromium.org, Mar 16 2014
------------------------------------------------------------------
r257356 | jamesr@chromium.org | 2014-03-16T05:04:39.859880Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/showmodaldialog.html?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_impl.h?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/webdriver/test_data/alerts.html?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_widget.h?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webkit_browsertest.cc?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.h?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=257356&r2=257355&pathrev=257356
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=257356&r2=257355&pathrev=257356
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/error-body-no-crash.html?r1=257356&r2=257355&pathrev=257356

Revert 252883 "Remove tests and code for showModalDialog"

We're leaving this in for M35.

> Remove tests and code for showModalDialog
>
> This deletes the chromium-side implementation logic and a few tests for
> showModalDialog. I believe more simplification is possible to do without the
> design constraints imposed by showModalDialog but we should probably start
> small in case we run into unexpected compat issues.
>
> R=darin
> BUG=345831
>
> Review URL: https://codereview.chromium.org/165793003

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/201153003
-----------------------------------------------------------------
Project Member Comment 11 by bugdroid1@chromium.org, Mar 20 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=169379

------------------------------------------------------------------
r169379 | zmo@chromium.org | 2014-03-17T18:56:09.426920Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=169379&r2=169378&pathrev=169379

Gardening: test expectations update

The below one is flaky on linux/mac,fail on win
fast/dom/Window/open-window-min-size.html

The below three are passing
fast/events/scroll-event-during-modal-dialog.html
fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html

BUG=345831
TEST=
TBR=zmo@chromium.org

Review URL: https://codereview.chromium.org/198503006
-----------------------------------------------------------------
Comment 12 by kareng@google.com, Apr 7 2014
Labels: -M-35 MovedFrom-35 M-36
Moving all non essential bugs to the next Milestone.
Cc: jam...@chromium.org
Owner: abarth@chromium.org
Status: Assigned
Adam's agreed to take over the eng work here while I'm unavailable.  Thanks!
Project Member Comment 14 by bugdroid1@chromium.org, Apr 17 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171889

------------------------------------------------------------------
r171889 | eseidel@chromium.org | 2014-04-17T21:05:42.933552Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/Window.idl?r1=171889&r2=171888&pathrev=171889
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=171889&r2=171888&pathrev=171889

Make window.showModalDialog disabled at runtime

We would like to remove showModalDialog
based on its low usage (as high as ~120 of every 1M
reported page views on week days and as low as ~60
of 1M reported page views on weekends) and extremely
high complexity (showModalDialog requires running a
nested event loop at a arbitrary point inside a
renderer which then allows display of arbitrary web
content and execution of arbitrary JavaScript
inside this nested context).

60 views per million is our historical removal threshold
so this is a higher risk removal, however the
unique complexity and regular reports of security
bugs has pushed for an accelerated removal.

Mozilla has also long-deprecated showModalDialog
and is also considering removal:
https://bugzilla.mozilla.org/show_bug.cgi?id=981796

Intent To Remove thread has much more info:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/xh9fPX0ijqk/ixHZCOH6GLgJ

We removed showModalDialog from M35 Beta, but reverted
the changes before shipping. This removes showModalDialog
from M36 via a runtime flag which will allow us to
enable/disable with much lower risk as the feature
is still present in our testing configuration while
being diabled from our shipping configuration.

BUG=345831

Review URL: https://codereview.chromium.org/240533006
-----------------------------------------------------------------
I suspect r171889 broke browser_tests ShowModalDialog.BasicTest, as seen here: <http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2306>
Project Member Comment 16 by bugdroid1@chromium.org, Apr 18 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171921

------------------------------------------------------------------
r171921 | dominicc@chromium.org | 2014-04-18T03:49:09.733560Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=171921&r2=171920&pathrev=171921
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/Window.idl?r1=171921&r2=171920&pathrev=171921

Revert r171889 "Make window.showModalDialog disabled at runtime"

This broke browser_tests ShowModalDialogTest.BasicTest.

TBR=eseidel@chromium.org
BUG=345831

Review URL: https://codereview.chromium.org/242683002
-----------------------------------------------------------------
Project Member Comment 17 by bugdroid1@chromium.org, Apr 18 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=171964

------------------------------------------------------------------
r171964 | abarth@chromium.org | 2014-04-18T19:10:31.862207Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.cpp?r1=171964&r2=171963&pathrev=171964
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/Window.idl?r1=171964&r2=171963&pathrev=171964

Make window.showModalDialog configurable at runtime

This CL makes it possible to enable and disable showModalDialog with a runtime
flag. Currently, the flag is enabled in stable, but we'll likely change that at
some point soon.

BUG=345831

Review URL: https://codereview.chromium.org/243473002
-----------------------------------------------------------------
Project Member Comment 18 by bugdroid1@chromium.org, Apr 23 2014
------------------------------------------------------------------
r265711 | abarth@chromium.org | 2014-04-23T19:49:20.723668Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/showmodaldialog.html?r1=265711&r2=265710&pathrev=265711
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/browser_browsertest.cc?r1=265711&r2=265710&pathrev=265711
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/webkit_browsertest.cc?r1=265711&r2=265710&pathrev=265711
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/test/data/error-body-no-crash.html?r1=265711&r2=265710&pathrev=265711

Remove tests for showModalDialog

This deletes the chromium-side tests for showModalDialog. We're about to disable
this feature from the Blink side, which would otherwise break these tests. The
plan is to leave the implementation behind a flag for a release or two in case
we need to restore the feature on short notice.

This CL is a partial re-land of https://codereview.chromium.org/165793003.

R=darin@chromium.org
BUG=345831

Review URL: https://codereview.chromium.org/246013006
-----------------------------------------------------------------
Project Member Comment 19 by bugdroid1@chromium.org, Apr 23 2014
Labels: merge-merged-git-svn
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29354a78adb7f5f76313c3012caf8d3791db5fa3

commit 29354a78adb7f5f76313c3012caf8d3791db5fa3
Author: abarth@chromium.org <abarth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Apr 23 19:49:20 2014 +0000

Remove tests for showModalDialog

This deletes the chromium-side tests for showModalDialog. We're about to disable
this feature from the Blink side, which would otherwise break these tests. The
plan is to leave the implementation behind a flag for a release or two in case
we need to restore the feature on short notice.

This CL is a partial re-land of https://codereview.chromium.org/165793003.

R=darin@chromium.org
BUG=345831

Review URL: https://codereview.chromium.org/246013006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265711 0039d316-1c4b-4281-b951-d872f2087c98


Blockedon: chromium:374782
Labels: -M-36 MovedFrom-36
This issue has already been moved once and is lower than Priority 1,therefore removing mstone.
Project Member Comment 22 by bugdroid1@chromium.org, Jun 17 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6a06c8b5683cafc2f84729e377b1c42c4b52932

commit e6a06c8b5683cafc2f84729e377b1c42c4b52932
Author: jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Jun 17 20:39:14 2014

Add --enable-show-modal-dialog to chrome

This flag will be controlled via enterprise policy to reenable the
deprecated window.showModalDialog API to extend the time window for
porting apps to other APIs.

The flag will eventually be removed as well.

BUG=345831
R=atwilson@chromium.org

Review URL: https://codereview.chromium.org/334173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277858 0039d316-1c4b-4281-b951-d872f2087c98


Project Member Comment 23 by bugdroid1@chromium.org, Jun 17 2014
------------------------------------------------------------------
r277858 | jochen@chromium.org | 2014-06-17T20:39:14.251698Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=277858&r2=277857&pathrev=277858
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=277858&r2=277857&pathrev=277858
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=277858&r2=277857&pathrev=277858
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_process_observer.cc?r1=277858&r2=277857&pathrev=277858

Add --enable-show-modal-dialog to chrome

This flag will be controlled via enterprise policy to reenable the
deprecated window.showModalDialog API to extend the time window for
porting apps to other APIs.

The flag will eventually be removed as well.

BUG=345831
R=atwilson@chromium.org

Review URL: https://codereview.chromium.org/334173005
-----------------------------------------------------------------
Project Member Comment 24 by bugdroid1@chromium.org, Jun 19 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1733b78d997caca8d8553719d832b8bc949e78cf

commit 1733b78d997caca8d8553719d832b8bc949e78cf
Author: atwilson@chromium.org <atwilson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Jun 19 18:51:55 2014

Add a policy to re-enable deprecated web platform features.

This will give admins the ability to re-enable deprecated features
for a limited amount of time.

This is a re-upload of codereview.chromium.org/263423003 because I've taken
over that CL for mnissler.

R=joaodasilva@chromium.org, jochen@chromium.org
TBR=jar
BUG=345831

Review URL: https://codereview.chromium.org/344693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278436 0039d316-1c4b-4281-b951-d872f2087c98


Project Member Comment 25 by bugdroid1@chromium.org, Jun 19 2014
------------------------------------------------------------------
r278436 | atwilson@chromium.org | 2014-06-19T18:51:55.554322Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/policy/resources/policy_templates.json?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/policy_browsertest.cc?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/policy/configuration_policy_handler_list_factory.cc?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=278436&r2=278435&pathrev=278436
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/policy/policy_test_cases.json?r1=278436&r2=278435&pathrev=278436

Add a policy to re-enable deprecated web platform features.

This will give admins the ability to re-enable deprecated features
for a limited amount of time.

This is a re-upload of codereview.chromium.org/263423003 because I've taken
over that CL for mnissler.

R=joaodasilva@chromium.org, jochen@chromium.org
TBR=jar
BUG=345831

Review URL: https://codereview.chromium.org/344693004
-----------------------------------------------------------------
Project Member Comment 26 by bugdroid1@chromium.org, Jun 19 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=176540

------------------------------------------------------------------
r176540 | jochen@chromium.org | 2014-06-19T19:16:40.377764Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/build/scripts/make_runtime_features.py?r1=176540&r2=176539&pathrev=176540
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=176540&r2=176539&pathrev=176540

Introduce new runtime feature state "deprecated" and use it for showModalDialog

The state is an alias for testing, however, it makes it easier to see
that the feature is slated for removal, not launch.

BUG=345831
R=abarth@chromium.org,eseidel@chromium.org,jamesr@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/335453007
-----------------------------------------------------------------
Comment 27 Deleted
Comment 28 by Deleted ...@, Jul 10 2014
Seems that html5 standard provide a window.showModalDialog function:
http://www.w3.org/html/wg/drafts/html/master/webappapis.html#dialogs-implemented-using-separate-documents
Comment 29 by math...@qiwi.be, Jul 10 2014
Re: comment #28: The actual spec is here: http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#dom-showmodaldialog (You’re linking to the W3C’s fork.)

`showModalDialog` is being removed from several rendering engines as we speak (Blink being just one of them). Once that’s done, and no major compatibility issues come up, it will be removed from the standard too. See http://dev.opera.com/blog/showmodaldialog/ for more info.
Project Member Comment 30 by bugdroid1@chromium.org, Jul 22 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=178705

------------------------------------------------------------------
r178705 | pkasting@chromium.org | 2014-07-22T22:58:30.885681Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/SlowTests?r1=178705&r2=178704&pathrev=178705
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=178705&r2=178704&pathrev=178705

Update expectations for some tests that seem to be passing, and add one timeout expectation.

BUG=229207,345831,347484,350829,360889,371916,390488
TEST=none
TBR=haraken

Review URL: https://codereview.chromium.org/412683002
-----------------------------------------------------------------
Project Member Comment 31 by bugdroid1@chromium.org, Aug 28 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=181064

------------------------------------------------------------------
r181064 | enne@chromium.org | 2014-08-28T23:22:36.172088Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-blur.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-arguments.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt?r1=181064&r2=181063&pathrev=181064
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/null-page-show-modal-dialog-crash.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/console/console-long-eval-crash-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/js-timers-beneath-modal-dialog.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog-blur-selfclose.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/null-page-show-modal-dialog-crash-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/harness/show-modal-dialog-expected.txt?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/open-window-min-size.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/show-modal-dialog-test.html?r1=181064&r2=181063&pathrev=181064
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/FlakyTests?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/showModalDialog-returnValue.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/animation/request-animation-frame-during-modal.html?r1=181064&r2=181063&pathrev=181064
   D http://src.chromium.org/viewvc/blink/trunk/ManualTests/modal-dialog.html?r1=181064&r2=181063&pathrev=181064

Remove showModalDialog layout tests

This removes most of the automatic and manual tests using
showModalDialog.  The remaining tests are window property tests and
tests to make sure you can't call it from an iframe that can get cleaned
up when the function gets removed once and for all.

R=abarth@chromium.org,jamesr@chromium.org
BUG=345831

Review URL: https://codereview.chromium.org/512533002
-----------------------------------------------------------------
Comment 32 Deleted
Owner: jochen@chromium.org
Project Member Comment 34 by bugdroid1@chromium.org, Feb 27 2015
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9486224328b4b45bd06d85459d080982167a9659

commit 9486224328b4b45bd06d85459d080982167a9659
Author: jochen <jochen@chromium.org>
Date: Fri Feb 27 16:41:11 2015

Remove showModalDialog (Chrome side)

Also unhook the enterprise policy

BUG=345831
R=jam@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/964583002

Cr-Commit-Position: refs/heads/master@{#318465}

[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/chrome/browser/chrome_content_browser_client.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/chrome/browser/policy/policy_browsertest.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/chrome/common/chrome_switches.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/chrome/common/chrome_switches.h
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/chrome/renderer/chrome_render_process_observer.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/content/browser/renderer_host/render_view_host_impl.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/content/browser/renderer_host/render_view_host_impl.h
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/content/common/view_messages.h
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/content/renderer/render_view_impl.cc
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/content/renderer/render_view_impl.h
[modify] http://crrev.com/9486224328b4b45bd06d85459d080982167a9659/content/renderer/render_widget.h

Project Member Comment 35 by bugdroid1@chromium.org, Feb 27 2015
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=191017

------------------------------------------------------------------
r191017 | jochen@chromium.org | 2015-02-27T18:05:17.518679Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/http/tests/security/README?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/window-properties.js?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/CreateWindow.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-put.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/global-function-resolve-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-interface-listing-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-get.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/function-length-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/LocalDOMWindow.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/resources/WindowProperties.js?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-call-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-lookup-precedence.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/wrapper-identity-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-property-shadowing.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/Window.idl?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebRuntimeFeatures.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/Chrome.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/EmptyClients.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/ChromeClient.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebRuntimeFeatures.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/resources/wrapper-identity-base.js?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/function-length.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-call.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/LocalDOMWindow.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/CreateWindow.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/script-tests/global-function-resolve.js?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/custom/V8WindowCustom.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.cpp?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/public/web/WebWidgetClient.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.h?r1=191017&r2=191016&pathrev=191017
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/cross-frame-access-get-expected.txt?r1=191017&r2=191016&pathrev=191017

Remove Window.showModalDialog

Intent to Remove thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/Xp1qU_SeLEk/cJQRy7oOKXYJ

BUG=345831
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/964823002
-----------------------------------------------------------------
Status: Fixed
Labels: M-43
Comment 38 by a...@chromium.org, Feb 27 2015
Can you update https://www.chromestatus.com/feature/5608754573737984 ?
Comment 39 by a...@chromium.org, Feb 27 2015
I updated chromestatus.
Sign in to add a comment