New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Show useful error message when me2me remoting host does not successfully start.

Project Member Reported by anandc@chromium.org, Jan 9 2014

Issue description

Owing to some mismatched files on my machine, the remoting host on it doesn't start successfully:
Launch ToT Chrome.
Add remoting.webapp.
Launch Chromoting, enable remote connections on local machine.
In the Chrome console, we see this text:
Adding user anandc to group chrome-remote-desktop
2014-01-09 09:22:32,728:INFO:Daemon process started in the background, logging to '/tmp/chrome_remote_desktop_20140109_092232_rDEZfE'
Using host_id: 1a832045-a2e3-a9fd-0f04-3e3121748fa4
Launching X server and X session.
Starting /usr/bin/Xvfb-randr on display :20
Xvfb is active.
Launching X session: ['/usr/sbin/lightdm-session', '/usr/bin/gnome-session --session=ubuntu-2d']
Launching host process
['/opt/google/chrome-remote-desktop/chrome-remote-desktop-host', '--host-config=-', '--audio-pipe-name=/usr/local/google/home/anandc/.config/chrome-remote-desktop/pulseaudio#e55f0ddea4/fifo_output', '--server-supports-exact-resize', '--signal-parent']
Cleanup.
Terminating Xvfb

However, the user is shown a message box stating remote connections have been enabled for the machine.

Expected: Show more accurate and useful error message, instead of indicating success.

 
RemoteConnectionsEnabledAlthoughHostFailed.png
33.4 KB View Download
Owner: lambroslambrou@chromium.org
Status: Assigned
Lambros, it looks like the host script doesn't handle the case when the host binary is invalid to start.
Labels: Chromoting-Bug-Cleanup
Owner: ----
Status: Available
Labels: -OS-Linux OS-All M-51
Owner: jamiewa...@chromium.org
Status: Assigned
There are a couple of cases here:
-If the host startup fails, we should show this in the native UX
-We don't show the host as online until we have received a valid heartbeat.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dc4509a5cf240192dfeaafebf1986c0753814f7

commit 4dc4509a5cf240192dfeaafebf1986c0753814f7
Author: jamiewalch <jamiewalch@chromium.org>
Date: Tue Feb 16 22:14:21 2016

Add message from grandchild to parent to indicate successful host launch.

Previously, the grandparent process would assume the host started successfully
if the grandchild closed the pipe. However, this happens regardless of the
exit code of the grandchild process. This CL allows commands to be sent between
the processes in addition to log messages, and defines an explicit command to
indicate successful start-up; if the grandparent does not receive this command,
it indicates failure via a non-zero exit code.

BUG= 332930 
TEST=chmod -x remoting_me2me_host; linux_me2me_host.py --start; echo $? (should give 1)

Review URL: https://codereview.chromium.org/1685793003

Cr-Commit-Position: refs/heads/master@{#375680}

[modify] http://crrev.com/4dc4509a5cf240192dfeaafebf1986c0753814f7/remoting/host/linux/linux_me2me_host.py

Labels: -M-51 M-50
Status: Fixed (was: Assigned)
Host startup failure should now be reported by the app. I don't think the second part of this (not showing the host as online until we receive a heartbeat) is worth doing right now.
Status: Verified (was: Fixed)

Sign in to add a comment