New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 428595



Sign in to add a comment

Deprecate and remove CSSValue and friends

Reported by eseidel@chromium.org, Jan 4 2014

Issue description

Deprecate and remove CSSValue and friends

The W3C deprecated these over a decade ago:
http://lists.w3.org/Archives/Public/www-style/2003Oct/0347.html

A new CSSOM is in the works:
http://dev.w3.org/csswg/cssom/
 
Patch posted to deprecate these: https://codereview.chromium.org/101143005/

Comment 3 by tkent@chromium.org, Jan 6 2014

Labels: Cr-Blink-CSS
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=164897

------------------------------------------------------------------------
r164897 | eseidel@chromium.org | 2014-01-10T20:00:37.784389Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/svg/custom/path-getPresentationAttribute-crash-expected.txt?r1=164897&r2=164896&pathrev=164897
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.cpp?r1=164897&r2=164896&pathrev=164897
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/frame/UseCounter.h?r1=164897&r2=164896&pathrev=164897
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=164897&r2=164896&pathrev=164897
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/getPresentationAttribute-expected.txt?r1=164897&r2=164896&pathrev=164897
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleDeclaration.idl?r1=164897&r2=164896&pathrev=164897
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/svg/SVGElement.idl?r1=164897&r2=164896&pathrev=164897

Add deprecation warnings for CSSValue accessors.

CSSValue and friends were deprecated by the W3C over a decade ago!
http://lists.w3.org/Archives/Public/www-style/2003Oct/0347.html

A new CSSOM is in the works:
http://dev.w3.org/csswg/cssom/

BUG= 331608 

Review URL: https://codereview.chromium.org/101143005
------------------------------------------------------------------------
Cc: shans@chromium.org dstockwell@chromium.org
Cc: tabatkins@chromium.org

Comment 8 by timloh@chromium.org, Oct 30 2014

Owner: timloh@chromium.org
Status: Assigned
Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3VmxWFzcyJc

Comment 9 by timloh@chromium.org, Oct 30 2014

Blockedon: chromium:428595
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 1 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=184766

------------------------------------------------------------------
r184766 | timloh@chromium.org | 2014-11-01T03:55:13.793694Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/internal-properties-should-not-be-exposed-expected.txt?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValue.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSTransformValue.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RGBColor.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/internal-properties-should-not-be-exposed.html?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/Rect.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleDeclaration.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/Counter.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueList.idl?r1=184766&r2=184765&pathrev=184766
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSFilterValue.idl?r1=184766&r2=184765&pathrev=184766

Unexpose getPropertyCSSValue, CSSValue and friends

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/3VmxWFzcyJc/GFOnJxnWBN0J

This patch unexposes the following by putting them behind a runtime flag:
- CSSStyleDeclaration.getPropertyCSSValue
- CSSValue
- CSSValueList
- CSSPrimitiveValue
- Counter
- RGBColor
- Rect
- WebKitCSSFilterValue
- WebKitCSSTransformValue

Since a large number of tests still depend on these features, I'll need to rewrite or delete them before we can actually remove the idl files.

BUG= 331608 

Review URL: https://codereview.chromium.org/676873003
-----------------------------------------------------------------
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 12 2014

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185192

------------------------------------------------------------------
r185192 | timloh@chromium.org | 2014-11-12T08:24:23.635252Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/custom/V8CSSValueCustom.cpp?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSTransformValue.idl?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.cpp?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RGBColor.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/PannerNode.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSTransformValue.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorkerClients.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleDeclaration.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/Counter.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/platform/RuntimeEnabledFeatures.in?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueList.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGridLineNamesValue.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageValue.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValue.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/CacheStorage.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-expected.txt?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RGBColor.idl?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/serviceworkers/ServiceWorker.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/PropertySetCSSStyleDeclaration.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFilterValue.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/Rect.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageSetValue.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSStyleDeclaration.idl?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/Counter.idl?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueList.idl?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/RGBColor.cpp?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValue.idl?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/core/v8/custom/custom.gypi?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/presentation/Presentation.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSComputedStyleDeclaration.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValueList.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/AnimationPlayerTest.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/AnimationPlayer.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.h?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/Rect.idl?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSValue.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSTransformValue.h?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/WebKitCSSFilterValue.idl?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSFilterValue.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSGridLineNamesValue.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageValue.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/modules/webaudio/ScriptProcessorNode.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/EffectInputTest.cpp?r1=185192&r2=185191&pathrev=185192
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSPrimitiveValue.idl?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/PropertySetCSSStyleDeclaration.h?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/animation/AnimationTest.cpp?r1=185192&r2=185191&pathrev=185192
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/css/CSSImageSetValue.h?r1=185192&r2=185191&pathrev=185192

Clean up after getPropertyCSSValue

This patch removes the idl interfaces for getPropertyCSSValue and friends
(i.e. those behind the runtime flag CSSValue), and removes code that only
existed to support this.

BUG= 331608 

Review URL: https://codereview.chromium.org/717933002
-----------------------------------------------------------------
Status: Fixed
Success! Thanks to alancutter@ for looking over a ridiculous number of test changes to make this happen!

Sign in to add a comment