New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 3315 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2008
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

regression: encoding override does not work

Project Member Reported by js...@chromium.org, Oct 10 2008

Issue description

In 0.3.15[34].0, encoding override does not work any more. 

It may or may not be a regression due to webkit merge. I'll figure out when
this regressed  by trying builds at 

http://build.chromium.org/buildbot/continuous/
 

Comment 1 by xlyuan@chromium.org, Oct 13 2008

Reproduce on 0.3.155.0 (Developer Build 3281)

I get the build from http://build.chromium.org/buildbot/snapshots/chromium-rel-xp/

Comment 2 by xlyuan@chromium.org, Oct 14 2008

Start broken from 0.3.154.0 (Developer Build 2613), OK on 0.3.154.0 (Developer Build
2600).

You can get this build from:
http://build.chromium.org/buildbot/continuous/09-25-2008/

Comment 3 by xlyuan@chromium.org, Oct 14 2008

Encoding "Auto detect" doesn't work either.

Comment 4 by js...@chromium.org, Oct 17 2008

Labels: Mstone-1.0
Thanks a lot for narrowing down the range. 
I think r2612 is a culprit. ( http://codereview.chromium.org/4088 ) 



Comment 5 by js...@chromium.org, Oct 17 2008

Status: Started
It turned out that http://codereview.chromium.org/5005 is to blame (but it went into 
r2634).  

Comment 6 by ben@chromium.org, Oct 22 2008

Comment 7 by js...@chromium.org, Oct 22 2008

I already have a patch :-) ( http://codereview.chromium.org/7647 )



Comment 8 by js...@chromium.org, Oct 22 2008

Status: Fixed
fixed in r3759



Comment 9 by xlyuan@chromium.org, Oct 24 2008

Jungshik:

    For encoding manually override, fixed on both developer build and official build.

    For auto-detect, fixed on official build but still reproduce on latest developer
build, can you please check if this is a issue or not?

    Test file attached.

    Verified on:
    0.3.154.6 (Official Build 3810)
    0.3.155.0 (Developer Build 3911)

Regards,
Xiaolu

 
Japanese Shift-JIS.html
892 bytes View Download
Chinese GB2312.html
2.4 KB View Download
I think this bug started since the last official build, an dhas been fixed since the 
last developer build, so what you see sounds correct.
Another issue reproduce on latest trunk build but OK on latest official build: Chrome
doesn't highlight Thai encoding.

Steps:
1. Run latest trunk build
2. Go to http://1900.sanook.com/horoscope/horoscope_00045.php
3. Check the highlight under "Encoding" menu

Result:
No highlight

Expect:
Should highlight "Thai" sub menu

Notes:
This page has http header charset=TIS-620 and meta tag charset=windows-874

Other Browsers:
  Safari: No highlight
Firefox3: Highlight TIS-620
     IE7: Highlight Thai (Windows)
  



 


Hmm, sorry, Brett, I didn't see your comments till I already added my new comments,
but I meant still reproduce on latest trunk build rather than fixed.

Comment 13 by js...@chromium.org, Oct 24 2008

Xiaolu,  autodetect is a separate issue. Thai issue is yet another one. I filed issue  
3702 and  issue 3703 .



Comment 14 Deleted

Status: Verified
Verified on build 0.3.154.12 (Official Build 4978), fixed.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 18 by bugdroid1@chromium.org, May 23 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/557fbbe05ba48bcc20be684d11fe0edfc24c87ba

commit 557fbbe05ba48bcc20be684d11fe0edfc24c87ba
Author: Leon Scroggins III <scroggo@google.com>
Date: Tue May 23 15:28:37 2017

Add animation support to SkWebpCodec

TBR=reed@google.com
(No change to the public API, but changed a header file)

SkWebpCodec:
- Implement onGetFrameCount, onGetFrameInfo, and onGetRepetitionCount
- Respect the alpha reported by libwebp. Although the spec states that
  it is only a hint, the libwebp encoder uses it properly. Respecting
  allows us to draw opaque images faster and decode them to 565. This
  also matches other SkCodecs (and Chromium).
- onGetPixels:
  - Decode the frame requested, recursively decoding required frame if
    necessary
  - When blending with a prior frame, use SkRasterPipeline

SkCodec:
- Move check for negative index to getFrameInfo
- Reset the colorXform if one is not needed

SkCodecAnimation:
- Add new blend enum, for WebP's (and APNG's) non-blending option

SkFrameHolder:
- New base classes for frames and the owner of the frames, allowing
  code sharing between SkWebpCodec and SkGifCodec (particularly for
  determining whether a frame has alpha and what frame it depends on)
- When moving items from SkGIFFrameContext, use Skia conventions (i.e.
  int instead of unsigned)
- Rename "delay time" to "duration", to match e.g. SkFrameInfo::
  fDuration

SkGifImageReader:
- Move pieces to SkFrameHolder, and adapt to changes made in the
  process
- Make setAlphaAndRequiredFrame (now on the base class SkFrameHolder)
  more general to support webp, and add support for frames that do not
  blend
- Change SkGIFFrameContext from a struct to a class, to match how we
  use the distinction elsewhere (i.e. struct is a small object with
  public fields)
- Rework hasTransparentPixel (now hasTransparency, since it returns true
  in some cases where there is not a transparent pixel) to better fit
  with the modified setAlphaAndRequiredFrame. Also be more consistent
  when there is no transparent pixel but no color map.
- Simplify an if condition that was previously simplified in 2d61e717
  but accidentally got reverted in a4db9be6

CodecAnimTest:
- Test new animated webp files
- Rearrange the test to more cleanly print alpha type mismatches for
  the first frame

resources:
- webp-animated.webp
  - animated webp from Chromium
- blendBG.webp
  - new webp file using bits of webp-animated-semitransparent4.webp
    from Chromium
  - tests required frame and alpha when using the non-blending mode
  - frames have the following properties:
    - Frame 0: no alpha, fills screen
    - Frame 1: alpha, fills screen
    - Frame 2: no alpha, fills screen
    - Frame 3: alpha, fills screen, blendBG
    - Frame 4: no alpha, fills screen, blendBG
    - Frame 5: alpha, blendBG
    - Frame 6: covers 4, has alpha, blendBG
  - also used to test decoding to 565 if the new frame data has alpha
    but blends onto an opaque frame

DM.cpp:
- Test animated images to non-native 8888 and unpremul

DMSrcSink.cpp:
- Do not test non-native 8888 decodes to f16 dst
- Test unpremul decodes to f16
- Copy a frame of an animated image prior to drawing, since in unpremul
  mode, the DM code will premultiply first.

Bug: skia: 3315
Change-Id: I4e55ae2ee5bc095b37a743bdcfac644be603b980
Reviewed-on: https://skia-review.googlesource.com/16707
Commit-Queue: Mike Reed <reed@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Reviewed-by: Leon Scroggins <scroggo@google.com>
Reviewed-by: Matt Sarett <msarett@google.com>

[add] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/resources/blendBG.webp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/third_party/gif/SkGifImageReader.h
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/third_party/gif/SkGifImageReader.cpp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/dm/DMSrcSink.cpp
[add] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/src/codec/SkFrameHolder.h
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/include/codec/SkCodec.h
[add] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/resources/webp-animated.webp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/dm/DM.cpp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/tests/CodecAnimTest.cpp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/src/codec/SkWebpCodec.h
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/src/codec/SkCodec.cpp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/src/codec/SkWebpCodec.cpp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/src/codec/SkGifCodec.cpp
[modify] https://crrev.com/557fbbe05ba48bcc20be684d11fe0edfc24c87ba/src/codec/SkCodecAnimation.h

Sign in to add a comment