New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2010
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Feature
M-5

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 33068: Add local storage support to Mac cookie view

Reported by bulach@chromium.org, Jan 25 2010 Project Member

Issue description

This change:
http://codereview.chromium.org/523139

Adds local storage support for both GTK and Windows.
Mac now needs something similar, the basic idea is:

. Add "Local Storage" nodes per origin
. Depending on whether a cookie or a local storage node is selected, display 
a frame with the relevant information
. Update unit tests
 

Comment 1 Deleted

Comment 2 by bulach@chromium.org, Jan 25 2010

Reference screenshot on Windows.
Local storage created from:
http://people.w3.org/mike/localstorage.html
cookieview.png
14.8 KB View Download

Comment 3 by dhw@chromium.org, Jan 25 2010

Labels: PlatformParity

Comment 4 by mikesmith@chromium.org, Jan 25 2010

Labels: Mstone-5 ReleaseBlock-Beta
Status: Assigned
Is this still valid?

Comment 5 by jorlow@chromium.org, Jan 25 2010

Um...this was posted 2 hours ago, so I would think so.

Comment 6 by pinkerton@chromium.org, Feb 4 2010

Labels: -Pri-2 Pri-1

Comment 7 by rsesek@chromium.org, Feb 4 2010

Status: Started

Comment 8 by bugdro...@gmail.com, Feb 9 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38504 

------------------------------------------------------------------------
r38504 | rsesek@chromium.org | 2010-02-09 13:04:28 -0800 (Tue, 09 Feb 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=38504&r2=38503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Cookies.xib?r1=38504&r2=38503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookie_tree_node.h?r1=38504&r2=38503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookie_tree_node.mm?r1=38504&r2=38503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller.h?r1=38504&r2=38503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller.mm?r1=38504&r2=38503
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm?r1=38504&r2=38503

[Mac] Add local storage nodes to the cookie manager

* Add local storage getters to CookieTreeNode
* XIB: Embed cookie info labels into an NSView (inside the NSBox) and add
  another for info NSView for local storage.
* Roll GTM r280:293

BUG= 33068 
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed.

Review URL: http://codereview.chromium.org/599003
------------------------------------------------------------------------

Comment 9 by rsesek@chromium.org, Feb 9 2010

Status: Fixed

Comment 10 by ismail@chromium.org, Feb 11 2010

Status: Verified
Platform:
  Hostname: ismail-macbookpro15.local
  Mac OS X Version 10.5.8 (Build 9L31a)
  Processor: 2 Intel 2.33 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 5.0.322.0 r38504  <<<Release>>>
  QuickTime Player: 7.6.4
  QuickTime PlayerX: <unknown>
  Flash Player: 10.0.42

Comment 11 by bugdroid1@chromium.org, Oct 12 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 12 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Mstone-5 M-5

Comment 13 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment