New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 330264 link

Starred by 13 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Sign in to add a comment

Tracking bug: Migrate BrowserPlugin to use RenderFrame Architecture

Project Member Reported by ajwong@chromium.org, Dec 20 2013

Issue description

The Site Isolation project is building in support for rendering child frames out-of-process.  This is partially based off the <webview> BrowserPlugin architecture.

When the out-of-process child frame support in Site Isolation becomes mature enough, BrowserPlugin should migrate over to share code infrastructure. In particular, a <webview> should just be a variant of a RenderFrame and NOT a plugin.

This is a tracking bug for this task.
 
Showing comments 10 - 109 of 109 Older
We listen to a series of ChromeViewHostMsg* related to plugins (in order to implement an API that allows blocking the loading of plugins):

ChromeViewHostMsg_BlockedUnauthorizedPlugin
ChromeViewHostMsg_CouldNotLoadPlugin
ChromeViewHostMsg_BlockedOutdatedPlugin
ChromeViewHostMsg_NPAPINotSupported
ChromeViewHostMsg_OpenAboutPlugins
ChromeViewHostMsg_FindMissingPlugin
ChromeViewHostMsg_RemovePluginPlaceholderHost

We listen to extension messages to allow for extension APIs in <appview> guests:

ExtensionHostMsg_Request
ExtensionHostMsg_PostMessage,
ChromeViewHostMsg_DetailedConsoleMessageAdded

We listen for IPCs for:

IME
Graphics
Mouse Lock
Autosize
Resize
Edit Commands
Destruction
Geometry Updates
Changes to transparency state
Changes to visibility state
Changes to focus
Changes to window.name in guest


Comment 11 by jam@chromium.org, Mar 31 2014

re comment 10, for the "We listen for IPCs for:" part, is that in chrome or content?
That is in content currently. window.name behavior may not be iframe standard behavior (it's a convenience feature), transparency is in content but it's not an OOP iframe feature, autosize is not an OOP iframe feature but in content.

Comment 13 by jam@chromium.org, Mar 31 2014

I see. Are there no calls on RenderViewHost or RenderView?
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 15 2014

------------------------------------------------------------------
r263926 | fsamuel@chromium.org | 2014-04-15T18:19:45.203903Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.cc?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/chrome_geolocation_permission_context.cc?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/platform_apps/web_view/geolocation/cancel_request/embedder.js?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/actions/actions.xml?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_no_permission/embedder.js?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/browser_plugin_permission_type.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/platform_apps/web_view/geolocation/embedder_has_permission/embedder.js?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_constants.cc?r1=263926&r2=263925&pathrev=263926
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_geolocation_permission_context.cc?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc?r1=263926&r2=263925&pathrev=263926
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_geolocation_permission_context.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_permission_types.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_constants.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/guestview_constants.cc?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/guestview_constants.h?r1=263926&r2=263925&pathrev=263926
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=263926&r2=263925&pathrev=263926

<webview>: Move Geolocation permission to chrome layer.

This CL also exposes the userGesture field to the geolocation permissionrequest event.

BUG=330264

Review URL: https://codereview.chromium.org/235633002
-----------------------------------------------------------------
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 15 2014

------------------------------------------------------------------
r264029 | fsamuel@chromium.org | 2014-04-15T23:05:55.391814Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.cc?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.h?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/browser_plugin_permission_type.h?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_permission_types.h?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/actions/actions.xml?r1=264029&r2=264028&pathrev=264029
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=264029&r2=264028&pathrev=264029

<webview>: Move media request to chrome

BUG=330264

Review URL: https://codereview.chromium.org/235733002
-----------------------------------------------------------------
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 16 2014

------------------------------------------------------------------
r264117 | fsamuel@chromium.org | 2014-04-16T05:02:38.071215Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_permission_types.h?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/actions/actions.xml?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.cc?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.h?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/browser_plugin_permission_type.h?r1=264117&r2=264116&pathrev=264117
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=264117&r2=264116&pathrev=264117

<webview>: Move download permission to chrome

BUG=330264

Review URL: https://codereview.chromium.org/235923003
-----------------------------------------------------------------
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 16 2014

------------------------------------------------------------------
r264236 | fsamuel@chromium.org | 2014-04-16T17:18:25.379484Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.cc?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/browser_plugin_permission_type.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_constants.cc?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/guestview_constants.cc?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_constants.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_permission_types.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.cc?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/actions/actions.xml?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/guestview_constants.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.h?r1=264236&r2=264235&pathrev=264236
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=264236&r2=264235&pathrev=264236

<webview>: Move pointerLock permission to chrome

BUG=330264

Review URL: https://codereview.chromium.org/239113007
-----------------------------------------------------------------
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 17 2014

------------------------------------------------------------------
r264378 | fsamuel@chromium.org | 2014-04-17T01:35:36.123749Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/browser_plugin_permission_type.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_constants.cc?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_constants.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_permission_types.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.cc?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.cc?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/webview_guest.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=264378&r2=264377&pathrev=264378
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/javascript_dialog_helper.cc?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=264378&r2=264377&pathrev=264378
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guestview/webview/javascript_dialog_helper.h?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=264378&r2=264377&pathrev=264378
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/actions/actions.xml?r1=264378&r2=264377&pathrev=264378

<webview>: Move JavaScript Dialog API to chrome

BUG=330264

Review URL: https://codereview.chromium.org/239143007
-----------------------------------------------------------------
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 28 2014

Labels: merge-merged-git-svn
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a31e5f2d599d38a84f8a4a7462adabf9c92034

commit 54a31e5f2d599d38a84f8a4a7462adabf9c92034
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Apr 28 20:00:36 2014 +0000

Browser Plugin: Simplified guest attachment

BUG=330264

Review URL: https://codereview.chromium.org/250063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266640 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 21 by bugdroid1@chromium.org, May 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2456926a4579ff3bfa2b686c05a06014dab5b78f

commit 2456926a4579ff3bfa2b686c05a06014dab5b78f
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 06 03:31:30 2014 +0000

Towards moving guest management to chrome: Introduce GuestViewManager

This CL moves a lot of functionality from BrowserPluginGuestManager to GuestViewManager including instance ID allocation. 

Currently GuestViewManager is a BrowserPluginGuestManagerDelegate. 

In the future, GuestViewManager will completely replace BrowserPluginGuestManager. 

BUG=364141, 330264

Review URL: https://codereview.chromium.org/258373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268391 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 22 by bugdroid1@chromium.org, May 6 2014

------------------------------------------------------------------
r268391 | fsamuel@chromium.org | 2014-05-06T03:31:30.233646Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=268391&r2=268390&pathrev=268391
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/test_browser_context.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/app_list/test/fake_profile.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_constants.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/app_list/test/fake_profile.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/test_browser_context.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_host_browsertest.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_manager.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_profile.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_profile.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=268391&r2=268390&pathrev=268391
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/browser/shell_browser_context.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=268391&r2=268390&pathrev=268391
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_constants.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_context.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.h?r1=268391&r2=268390&pathrev=268391
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.cc?r1=268391&r2=268390&pathrev=268391
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_browser_context.cc?r1=268391&r2=268390&pathrev=268391
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_browser_context.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/browser/shell_browser_context.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.cc?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_host_factory.h?r1=268391&r2=268390&pathrev=268391
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl_unittest.cc?r1=268391&r2=268390&pathrev=268391

Towards moving guest management to chrome: Introduce GuestViewManager

This CL moves a lot of functionality from BrowserPluginGuestManager to GuestViewManager including instance ID allocation. 

Currently GuestViewManager is a BrowserPluginGuestManagerDelegate. 

In the future, GuestViewManager will completely replace BrowserPluginGuestManager. 

BUG=364141, 330264

Review URL: https://codereview.chromium.org/258373002
-----------------------------------------------------------------
Project Member

Comment 23 by bugdroid1@chromium.org, May 7 2014

------------------------------------------------------------------
r268753 | fsamuel@chromium.org | 2014-05-07T14:37:38.477457Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.h?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.h?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.h?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.cc?r1=268753&r2=268752&pathrev=268753
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.h?r1=268753&r2=268752&pathrev=268753

BrowserPlugin: Simplify content/public API

BUG=364141, 330264

Review URL: https://codereview.chromium.org/264943006
-----------------------------------------------------------------
Project Member

Comment 24 by bugdroid1@chromium.org, May 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70d4450270d54a051b3b5ea828814ced1c29857f

commit 70d4450270d54a051b3b5ea828814ced1c29857f
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 07 14:37:38 2014 +0000

BrowserPlugin: Simplify content/public API

BUG=364141, 330264

Review URL: https://codereview.chromium.org/264943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268753 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 25 by bugdroid1@chromium.org, May 10 2014

------------------------------------------------------------------
r269565 | fsamuel@chromium.org | 2014-05-10T11:50:06.666383Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_manager.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.cc?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.h?r1=269565&r2=269564&pathrev=269565
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/android/content_view_util.cc?r1=269565&r2=269564&pathrev=269565

BrowserPlugin: Move CreateGuest to chrome

BUG=364141, 330264

Review URL: https://codereview.chromium.org/261013005
-----------------------------------------------------------------
Project Member

Comment 26 by bugdroid1@chromium.org, May 10 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83100cd80c17003b00af053ef13b8bb127f78ea5

commit 83100cd80c17003b00af053ef13b8bb127f78ea5
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat May 10 11:50:06 2014

BrowserPlugin: Move CreateGuest to chrome

BUG=364141, 330264

Review URL: https://codereview.chromium.org/261013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269565 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 27 by bugdroid1@chromium.org, May 11 2014

------------------------------------------------------------------
r269680 | fsamuel@chromium.org | 2014-05-11T01:34:32.127987Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_message_filter.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_host_factory.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_host_browsertest.cc?r1=269680&r2=269679&pathrev=269680
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_manager.cc?r1=269680&r2=269679&pathrev=269680
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.cc?r1=269680&r2=269679&pathrev=269680
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_manager.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=269680&r2=269679&pathrev=269680
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest_manager.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_message_filter.cc?r1=269680&r2=269679&pathrev=269680
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.cc?r1=269680&r2=269679&pathrev=269680

Remove BrowserPluginGuestManager

This CL removes BrowserPluginGuestManager entirely, leaving BrowserPlugin relying on the BrowserPluginGuestManagerDelegate interface. This CL significantly reduces complexity in content.

In a subsequent patch, BrowserPluginGuestManagerDelegate will be renamed BrowserPluginGuestManager. I am leaving that separate so it is clear what's going on.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/269113002
-----------------------------------------------------------------
Project Member

Comment 28 by bugdroid1@chromium.org, May 11 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d05a1587e9fd1af5c29facbf72f37aa121747ad

commit 0d05a1587e9fd1af5c29facbf72f37aa121747ad
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sun May 11 01:34:32 2014

Remove BrowserPluginGuestManager

This CL removes BrowserPluginGuestManager entirely, leaving BrowserPlugin relying on the BrowserPluginGuestManagerDelegate interface. This CL significantly reduces complexity in content.

In a subsequent patch, BrowserPluginGuestManagerDelegate will be renamed BrowserPluginGuestManager. I am leaving that separate so it is clear what's going on.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/269113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269680 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 29 by bugdroid1@chromium.org, May 11 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/139355fc088b23f85a290471a7698861d0e804c5

commit 139355fc088b23f85a290471a7698861d0e804c5
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sun May 11 14:21:28 2014

Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager

BUG=364141, 330264
TBR=jamescook@chromium.org, michaelbai@chromium.org

Review URL: https://codereview.chromium.org/261363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269705 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 30 by bugdroid1@chromium.org, May 11 2014

------------------------------------------------------------------
r269705 | fsamuel@chromium.org | 2014-05-11T14:21:28.851236Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/app_list/test/fake_profile.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/test_browser_context.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/test_browser_context.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/app_list/test/fake_profile.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_host_browsertest.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_profile.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/testing_profile.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_message_filter.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=269705&r2=269704&pathrev=269705
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.h?r1=269705&r2=269704&pathrev=269705
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/browser/shell_browser_context.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/off_the_record_profile_impl.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_context.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profiles/profile_impl.h?r1=269705&r2=269704&pathrev=269705
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.cc?r1=269705&r2=269704&pathrev=269705
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager_delegate.cc?r1=269705&r2=269704&pathrev=269705
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager_delegate.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_browser_context.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_browser_context.h?r1=269705&r2=269704&pathrev=269705
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager.cc?r1=269705&r2=269704&pathrev=269705
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager.h?r1=269705&r2=269704&pathrev=269705
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/browser/shell_browser_context.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/download/download_manager_impl_unittest.cc?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=269705&r2=269704&pathrev=269705
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=269705&r2=269704&pathrev=269705

Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager

BUG=364141, 330264
TBR=jamescook@chromium.org, michaelbai@chromium.org

Review URL: https://codereview.chromium.org/261363002
-----------------------------------------------------------------
Project Member

Comment 31 by bugdroid1@chromium.org, May 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fed0d1ca028c4715ab0dcba188596ae29d5e3ad3

commit fed0d1ca028c4715ab0dcba188596ae29d5e3ad3
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 13 23:25:12 2014

Cleanup CanDownload WebContentsDelegate API

It seems we were passing an opaque request ID in WebContentsDelegate::CanDownload
that wasn't used anywhere. Instead, for <webview>, we would simply like the URL
that generated the download request. This CL simplifies the API and reduces cruft
and code complexity

BUG=364141, 330264
TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/286543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270242 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 32 by bugdroid1@chromium.org, May 13 2014

------------------------------------------------------------------
r270242 | fsamuel@chromium.org | 2014-05-13T23:25:12.830489Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/native/aw_web_contents_delegate.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_contents.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter_unittest.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_resource_throttle.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/native/aw_web_contents_delegate.h?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_resource_throttle.h?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/apps/web_view_browsertest.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_request_limiter.h?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.cc?r1=270242&r2=270241&pathrev=270242
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents_delegate.h?r1=270242&r2=270241&pathrev=270242

Cleanup CanDownload WebContentsDelegate API

It seems we were passing an opaque request ID in WebContentsDelegate::CanDownload
that wasn't used anywhere. Instead, for <webview>, we would simply like the URL
that generated the download request. This CL simplifies the API and reduces cruft
and code complexity

BUG=364141, 330264
TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/286543002
-----------------------------------------------------------------
Project Member

Comment 34 by bugdroid1@chromium.org, May 14 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c54341134bf266b76b99b2e81e5a1469fc4a76d8

commit c54341134bf266b76b99b2e81e5a1469fc4a76d8
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 14 06:44:41 2014

<webview>: Move Color Chooser and File Chooser to Chrome

BUG=364141, 330264

Review URL: https://codereview.chromium.org/280833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270348 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 35 by bugdroid1@chromium.org, May 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/660f18eddada5f9cc329333df1eb834698c03f3a

commit 660f18eddada5f9cc329333df1eb834698c03f3a
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 15 20:53:05 2014

<webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent

This CL makes BrowserPluginGuestDelegate::HandleKeyboardEvent match WebContentsDelegate::HandleKeyboardEvent.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/288113005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270809 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 36 by bugdroid1@chromium.org, May 15 2014

------------------------------------------------------------------
r270809 | fsamuel@chromium.org | 2014-05-15T20:53:05.908406Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=270809&r2=270808&pathrev=270809
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=270809&r2=270808&pathrev=270809

<webview>: Cleanup Pointer Lock & Simplify HandleKeyboardEvent

This CL makes BrowserPluginGuestDelegate::HandleKeyboardEvent match WebContentsDelegate::HandleKeyboardEvent.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/288113005
-----------------------------------------------------------------
Project Member

Comment 37 by bugdroid1@chromium.org, May 20 2014

------------------------------------------------------------------
r271703 | fsamuel@chromium.org | 2014-05-20T17:59:06.999056Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_messages.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/apps/web_view_interactive_browsertest.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/identity/identity_apitest.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/devtools/devtools_targets_ui.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc?r1=271703&r2=271702&pathrev=271703
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/browser_plugin_permission_type.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/plugin_permission_helper.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_permission_types.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h?r1=271703&r2=271702&pathrev=271703
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc?r1=271703&r2=271702&pathrev=271703
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/web_contents.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/javascript_dialog_helper.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_common.gypi?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.h?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc?r1=271703&r2=271702&pathrev=271703
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=271703&r2=271702&pathrev=271703

<webview>: Move NewWindow API to chrome

This CL moves the New Window API and navigation to chrome.

This CL removes a lot of unnecessary content APIs for BrowserPlugin now that permissions no longer live in content.

Up next, in a separate CL will be a huge cleanup that removes all WebContentsDelegate code out of BrowserPluginGuest and into WebViewGuest. This should significantly reduce the size of the BrowserPlugin content API.

BUG=364141, 330264
TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change.

Review URL: https://codereview.chromium.org/272573005
-----------------------------------------------------------------
Project Member

Comment 38 by bugdroid1@chromium.org, May 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d326ea8ae1b2a243a0b41980a781f62c77787a

commit 50d326ea8ae1b2a243a0b41980a781f62c77787a
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue May 20 17:59:06 2014

<webview>: Move NewWindow API to chrome

This CL moves the New Window API and navigation to chrome.

This CL removes a lot of unnecessary content APIs for BrowserPlugin now that permissions no longer live in content.

Up next, in a separate CL will be a huge cleanup that removes all WebContentsDelegate code out of BrowserPluginGuest and into WebViewGuest. This should significantly reduce the size of the BrowserPlugin content API.

BUG=364141, 330264
TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change.

Review URL: https://codereview.chromium.org/272573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271703 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 39 by bugdroid1@chromium.org, May 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/504073e1d18c781c36bfcb8268bc3925fc53b488

commit 504073e1d18c781c36bfcb8268bc3925fc53b488
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 22 18:17:46 2014

<webview>: Move name attribute to chrome

This CL introduces a new way to monitor changes to frame names from the content embedder, and setting the main frame name from the content embedder.

The name attribute is now managed by web_view.js, and not BrowserPlugin.

BUG=364141, 330264
TBR=kenrb@chromium.org (removing IPC messages).

Review URL: https://codereview.chromium.org/291483010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272241 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 40 by bugdroid1@chromium.org, May 22 2014

------------------------------------------------------------------
r272241 | fsamuel@chromium.org | 2014-05-22T18:17:46.093094Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_frame_observer.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/webview/webview_api.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_frame_observer.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/webview/webview_api.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_frame_impl.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view.js?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_messages.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_frame_observer.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_render_view_observer.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/view_messages.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/webview.json?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.cc?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_view_impl.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=272241&r2=272240&pathrev=272241
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/extension_function_histogram_value.h?r1=272241&r2=272240&pathrev=272241

<webview>: Move name attribute to chrome

This CL introduces a new way to monitor changes to frame names from the content embedder, and setting the main frame name from the content embedder.

The name attribute is now managed by web_view.js, and not BrowserPlugin.

BUG=364141, 330264
TBR=kenrb@chromium.org (removing IPC messages).

Review URL: https://codereview.chromium.org/291483010
-----------------------------------------------------------------
Project Member

Comment 42 by bugdroid1@chromium.org, May 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87acf4dd72e3b0494491893b4fc367a6025b1f3c

commit 87acf4dd72e3b0494491893b4fc367a6025b1f3c
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu May 22 22:18:49 2014

<webview>: Move PreHandleGestureEvent in chrome

BUG=364141, 330264

Review URL: https://codereview.chromium.org/293043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272344 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 43 by bugdroid1@chromium.org, May 23 2014

------------------------------------------------------------------
r272579 | fsamuel@chromium.org | 2014-05-23T19:24:10.856565Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=272579&r2=272578&pathrev=272579
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=272579&r2=272578&pathrev=272579

<webview>: Make HandleContextMenu easier to refactor

In the future, BrowserPluginGuest will no longer be a WebContentsDelegate, and so special handling for guests that relies on the internal implementation details of BrowserPlugin should be moved to chrome.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/296703005
-----------------------------------------------------------------
Project Member

Comment 44 by bugdroid1@chromium.org, May 27 2014

------------------------------------------------------------------
r272830 | fsamuel@chromium.org | 2014-05-26T15:50:25.754567Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_message_filter.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_message_filter.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/extension_information.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_dispatcher_host.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/speech/speech_recognition_dispatcher_host.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_view_aura.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prerender/prerender_link_manager.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/devtools/devtools_targets_ui.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_message_filter.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_content_browser_client.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_content_browser_client.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_widget_host_impl.cc?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_delegate.h?r1=272830&r2=272829&pathrev=272830
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=272830&r2=272829&pathrev=272830

Remove some RenderProcessHost::IsGuest call sites

This CL removes some of the callsites to RenderProcessHost::IsGuest.

BUG=364141, 330264
TBR=benm@chromium.org for trivial android_webview change.

Review URL: https://codereview.chromium.org/291403002
-----------------------------------------------------------------
Project Member

Comment 45 by bugdroid1@chromium.org, May 27 2014

------------------------------------------------------------------
r272889 | fsamuel@chromium.org | 2014-05-27T00:01:15.408927Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.h?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.h?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.cc?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=272889&r2=272888&pathrev=272889
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=272889&r2=272888&pathrev=272889

BrowserPluginGuest is no longer a WebContentsDelegate

BUG=364141, 330264
TBR=jam@chromium.org for code deletion in content/public/browser_plugin_guest_delegate.{cc|h}

Review URL: https://codereview.chromium.org/295083002
-----------------------------------------------------------------
Project Member

Comment 46 by bugdroid1@chromium.org, May 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a8350524b9f9626a4fc21cf121d35e0e30d0dff

commit 2a8350524b9f9626a4fc21cf121d35e0e30d0dff
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed May 28 01:42:00 2014

Remove BrowserPluginGuestDelegate::GuestProcessGone

BUG=364141, 330264

Review URL: https://codereview.chromium.org/297183010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273105 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 48 by bugdroid1@chromium.org, May 30 2014

------------------------------------------------------------------
r273733 | fsamuel@chromium.org | 2014-05-30T05:55:01.057994Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/render_process_host.h?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/mock_render_process_host.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/frame_host/render_frame_host_impl.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/mock_render_process_host.h?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.h?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_manager.h?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/frame_host/render_frame_host_manager.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/frame_host/navigation_controller_impl_unittest.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/frame_host/navigation_controller_impl.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_unittest.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/apps/web_view_interactive_browsertest.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/user_script_master.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/apps/web_view_browsertest.cc?r1=273733&r2=273732&pathrev=273733
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_browsertest.cc?r1=273733&r2=273732&pathrev=273733

Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Not all guests are created equal. <webview> guests are isolated from other processes.
In other words, the content of a <webview> cannot live in the same process as any other
non-<webview> content.

This is not true for <appview>. <appview> guests are NOT isolated. In the future,
BrowserPluginGuest::IsGuest and GuestViewBase::IsGuest may return true even if
RenderProcessHost::IsIsolatedGuest returns false.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/293093010
-----------------------------------------------------------------
Project Member

Comment 49 by bugdroid1@chromium.org, May 30 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe294cea741760116f7ec2d698e190f0a5679048

commit fe294cea741760116f7ec2d698e190f0a5679048
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri May 30 05:55:01 2014

Rename RenderProcessHost::IsGuest to RenderProcessHost::IsIsolatedGuest

Not all guests are created equal. <webview> guests are isolated from other processes.
In other words, the content of a <webview> cannot live in the same process as any other
non-<webview> content.

This is not true for <appview>. <appview> guests are NOT isolated. In the future,
BrowserPluginGuest::IsGuest and GuestViewBase::IsGuest may return true even if
RenderProcessHost::IsIsolatedGuest returns false.

BUG=364141, 330264

Review URL: https://codereview.chromium.org/293093010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273733 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 50 by bugdroid1@chromium.org, May 30 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70ab264c9dfa8e455d2daaf5a1d2ee8669ebbf19

commit 70ab264c9dfa8e455d2daaf5a1d2ee8669ebbf19
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri May 30 08:06:58 2014

Move guest lifetime management to chrome

Now, GuestViewBase takes full responsibility for managing the lifetime of the guest WebContents. The only signal coming from content is that indicating that the BrowserPlugin has been destroyed.

BUG=364141, 330264
TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion (w00t!)

Review URL: https://codereview.chromium.org/306003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273759 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 51 by bugdroid1@chromium.org, May 30 2014

------------------------------------------------------------------
r273759 | fsamuel@chromium.org | 2014-05-30T08:06:58.714600Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_guest_manager.cc?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.cc?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/test_browser_plugin_guest_delegate.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.cc?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/ad_view/ad_view_guest.h?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=273759&r2=273758&pathrev=273759
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=273759&r2=273758&pathrev=273759

Move guest lifetime management to chrome

Now, GuestViewBase takes full responsibility for managing the lifetime of the guest WebContents. The only signal coming from content is that indicating that the BrowserPlugin has been destroyed.

BUG=364141, 330264
TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion (w00t!)

Review URL: https://codereview.chromium.org/306003002
-----------------------------------------------------------------
Project Member

Comment 52 by bugdroid1@chromium.org, May 31 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba0dc14fb2a432cc3c0c1303dfe79664ba34b3c8

commit ba0dc14fb2a432cc3c0c1303dfe79664ba34b3c8
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat May 31 00:38:59 2014

Browser Plugin: Remove Zoom

With the zoom refactor in flight: https://codereview.chromium.org/287093002/, zoom
plumbing for BrowserPlugin in the content layer is now entirely dead code. We need to revisit zoom in
the chrome layer for <webview> so that the embedder's zoom is propagated to the guests.

This will be done at a later time when we need to get <webview> in WebUI working again.

BUG=330264
TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion.

Review URL: https://codereview.chromium.org/303423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273959 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 53 by bugdroid1@chromium.org, May 31 2014

------------------------------------------------------------------
r273959 | fsamuel@chromium.org | 2014-05-31T00:38:59.003930Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=273959&r2=273958&pathrev=273959
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=273959&r2=273958&pathrev=273959
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=273959&r2=273958&pathrev=273959
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=273959&r2=273958&pathrev=273959
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=273959&r2=273958&pathrev=273959
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=273959&r2=273958&pathrev=273959
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=273959&r2=273958&pathrev=273959

Browser Plugin: Remove Zoom

With the zoom refactor in flight: https://codereview.chromium.org/287093002/, zoom
plumbing for BrowserPlugin in the content layer is now entirely dead code. We need to revisit zoom in
the chrome layer for <webview> so that the embedder's zoom is propagated to the guests.

This will be done at a later time when we need to get <webview> in WebUI working again.

BUG=330264
TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion.

Review URL: https://codereview.chromium.org/303423002
-----------------------------------------------------------------
Project Member

Comment 54 by bugdroid1@chromium.org, May 31 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/feaa8cfb22d783a2285ed854f7526832734e5bae

commit feaa8cfb22d783a2285ed854f7526832734e5bae
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat May 31 03:57:14 2014

GuestView: Move Disable Drag and Drop Out to Chrome

BUG=364141, 330264
TBR=jam@chromium.org for content/public/browser_plugin_guest_delegate code deletion.

Review URL: https://codereview.chromium.org/301303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274002 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 55 by bugdroid1@chromium.org, May 31 2014

------------------------------------------------------------------
r274002 | fsamuel@chromium.org | 2014-05-31T03:57:14.915087Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=274002&r2=274001&pathrev=274002
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=274002&r2=274001&pathrev=274002
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=274002&r2=274001&pathrev=274002

GuestView: Move Disable Drag and Drop Out to Chrome

BUG=364141, 330264
TBR=jam@chromium.org for content/public/browser_plugin_guest_delegate code deletion.

Review URL: https://codereview.chromium.org/301303003
-----------------------------------------------------------------
Project Member

Comment 56 by bugdroid1@chromium.org, Jun 4 2014

------------------------------------------------------------------
r274801 | fsamuel@chromium.org | 2014-06-04T13:07:43.390967Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=274801&r2=274800&pathrev=274801
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=274801&r2=274800&pathrev=274801
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=274801&r2=274800&pathrev=274801
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=274801&r2=274800&pathrev=274801

Prevent derived classes of GuestViewBase from overriding key methods

This change removes the obligation for the derived class to call the base class' implementation at the end. This makes it easier to write GuestViewBase derived classes.

BUG=364141 330264

Review URL: https://codereview.chromium.org/318433002
-----------------------------------------------------------------
Project Member

Comment 57 by bugdroid1@chromium.org, Jun 4 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a868c6c14dd68ad3cb9717e4008dcdbcd124c84a

commit a868c6c14dd68ad3cb9717e4008dcdbcd124c84a
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 13:07:43 2014

Prevent derived classes of GuestViewBase from overriding key methods

This change removes the obligation for the derived class to call the base class' implementation at the end. This makes it easier to write GuestViewBase derived classes.

BUG=364141 330264

Review URL: https://codereview.chromium.org/318433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274801 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 59 by bugdroid1@chromium.org, Jul 30 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce49c9e780ed54eafb35d39b13eabe4fe3176392

commit ce49c9e780ed54eafb35d39b13eabe4fe3176392
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jul 30 16:33:55 2014

Browser Plugin: Remove embedder_frame_url

BUG=330264
TBR=fsamuel@chromium.org, kenrb@chromium.org

Review URL: https://codereview.chromium.org/422343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286535 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 60 by bugdroid1@chromium.org, Aug 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e761d6e0af602cba72847bb95a2195d8304bcd

commit 69e761d6e0af602cba72847bb95a2195d8304bcd
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat Aug 02 11:27:56 2014

<webview>: Ensure that createGuest is only called after element attached to DOM

BUG=330264
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/434523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287197 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 61 by bugdroid1@chromium.org, Aug 2 2014

------------------------------------------------------------------
r287197 | fsamuel@chromium.org | 2014-08-02T11:27:56.113979Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view.js?r1=287197&r2=287196&pathrev=287197

<webview>: Ensure that createGuest is only called after element attached to DOM

BUG=330264
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/434523003
-----------------------------------------------------------------
Project Member

Comment 62 by bugdroid1@chromium.org, Aug 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcf8d538fcc01221bdff418e0217725a02c17922

commit dcf8d538fcc01221bdff418e0217725a02c17922
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Aug 06 07:45:18 2014

<webview>: Move autosize from content to chrome.

BUG=330264
TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json

Review URL: https://codereview.chromium.org/427883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287732 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 63 by bugdroid1@chromium.org, Aug 6 2014

------------------------------------------------------------------
r287732 | fsamuel@chromium.org | 2014-08-06T07:45:18.758364Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/extension_function_histogram_value.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/guest_view_internal.json?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view_events.js?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_browsertest.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view.js?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_messages.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.cc?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.h?r1=287732&r2=287731&pathrev=287732
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.h?r1=287732&r2=287731&pathrev=287732

<webview>: Move autosize from content to chrome.

BUG=330264
TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json

Review URL: https://codereview.chromium.org/427883002
-----------------------------------------------------------------
Project Member

Comment 64 by bugdroid1@chromium.org, Aug 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb056f59f212a77760a7d508b6417c62d869d201

commit bb056f59f212a77760a7d508b6417c62d869d201
Author: tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Aug 06 10:07:27 2014

Revert 287732 "<webview>: Move autosize from content to chrome."

The AutoSize test was failing on Mac:
WebViewTest.AutoSize (run #1):
[ RUN      ] WebViewTest.AutoSize
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors
[9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors
[9340:71171:0806/013455:INFO:CONSOLE(14)] "guest.loadstop", source: chrome-extension://blepeeghknicglkaidbjijdlejjompdl/main.js (14)
ASSERTION FAILED: !enable || !minSize.isEmpty()

(log: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/26134/steps/browser_tests/logs/AutoSize)

> <webview>: Move autosize from content to chrome.
> 
> BUG=330264
> TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json
> 
> Review URL: https://codereview.chromium.org/427883002

TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/446823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287746 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 65 by bugdroid1@chromium.org, Aug 6 2014

------------------------------------------------------------------
r287746 | tommi@chromium.org | 2014-08-06T10:07:27.869967Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_browsertest.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view.js?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_messages.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/extension_function_histogram_value.h?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/guest_view_internal.json?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view_events.js?r1=287746&r2=287745&pathrev=287746
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=287746&r2=287745&pathrev=287746

Revert 287732 "<webview>: Move autosize from content to chrome."

The AutoSize test was failing on Mac:
WebViewTest.AutoSize (run #1):
[ RUN      ] WebViewTest.AutoSize
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:71171:0806/013452:ERROR:simple_menu_model.cc(135)] Not implemented reached in void ui::SimpleMenuModel::AddSeparator(ui::MenuSeparatorType)
[9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors
[9340:97283:0806/013453:WARNING:file_descriptor_set_posix.cc(22)] FileDescriptorSet destroyed with unconsumed descriptors
[9340:71171:0806/013455:INFO:CONSOLE(14)] "guest.loadstop", source: chrome-extension://blepeeghknicglkaidbjijdlejjompdl/main.js (14)
ASSERTION FAILED: !enable || !minSize.isEmpty()

(log: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%283%29/builds/26134/steps/browser_tests/logs/AutoSize)

> <webview>: Move autosize from content to chrome.
> 
> BUG=330264
> TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json
> 
> Review URL: https://codereview.chromium.org/427883002

TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/446823002
-----------------------------------------------------------------
Project Member

Comment 66 by bugdroid1@chromium.org, Aug 6 2014

------------------------------------------------------------------
r287822 | fsamuel@chromium.org | 2014-08-06T19:09:55.341747Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view.js?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_messages.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_constants.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/guest_view_base.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_constants.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view_events.js?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/guest_view_internal.json?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/extension_function_histogram_value.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.h?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_browsertest.cc?r1=287822&r2=287821&pathrev=287822
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_view_host_impl.cc?r1=287822&r2=287821&pathrev=287822

<webview>: Move autosize from content to chrome.

BUG=330264
TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287732

Review URL: https://codereview.chromium.org/427883002
-----------------------------------------------------------------
Project Member

Comment 67 by bugdroid1@chromium.org, Aug 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ca068639243b50bff72f64b53081dee2fa750c6

commit 5ca068639243b50bff72f64b53081dee2fa750c6
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Aug 06 19:09:55 2014

<webview>: Move autosize from content to chrome.

BUG=330264
TBR=kenrb@chromium.org for browser_plugin_messages.h, kalman@chromium.org for guest_view_internal.json

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287732

Review URL: https://codereview.chromium.org/427883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287822 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 68 by bugdroid1@chromium.org, Aug 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2101c4cb016ab1d6c948b8fc6e8f2ce85b1b72df

commit 2101c4cb016ab1d6c948b8fc6e8f2ce85b1b72df
Author: fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 22 00:16:16 2014

Remove BrowserPlugin's -internal-attach method

This CL exposes a much simpler content/public method:
void RenderView::AttachToBrowserPlugin(blink::WebNode&)

This removes BrowserPlugin's usage of NPAPI method bindings.
This will hopefully help us move towards using OOPIFs.

BUG=330264

Review URL: https://codereview.chromium.org/444813002

Cr-Commit-Position: refs/heads/master@{#291261}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291261 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 69 by bugdroid1@chromium.org, Aug 22 2014

------------------------------------------------------------------
r291261 | fsamuel@chromium.org | 2014-08-22T00:16:16.663486Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_extension_message_filter.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/chrome_extension_message_filter.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view.js?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_frame_impl.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_manager_impl.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/guest_view/app_view/app_view_guest.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_bindings.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/web_contents/web_contents_impl.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/web_view/web_view_guest.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/guest_view/extension_options/extension_options_guest.cc?r1=291261&r2=291260&pathrev=291261
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/guest_view_internal_custom_bindings.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_message_filter.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/extension_options.js?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_manager.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/guest_view/guest_view_base.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/guest_view/guest_view_manager.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_browsertest.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/mock_browser_plugin_manager.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_embedder.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/mock_browser_plugin_manager.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/child_frame_compositing_helper.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/renderer/render_frame.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_frame_impl.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/browser_plugin/browser_plugin_messages.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/app_view.js?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/guest_view/guest_view_internal_api.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_renderer.gypi?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/frame_host/render_widget_host_view_guest.cc?r1=291261&r2=291260&pathrev=291261
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/guest_view_internal_custom_bindings.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/chrome_extension_messages.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view_experimental.js?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/apps/web_view_interactive_browsertest.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/renderer/script_context.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extensions/web_view_events.js?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/browser_plugin/browser_plugin_manager.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_manager.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/browser_plugin_guest_delegate.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/renderer/script_context.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/guest_view/guest_view_manager.h?r1=291261&r2=291260&pathrev=291261
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/guest_view/guest_view_base.h?r1=291261&r2=291260&pathrev=291261

Remove BrowserPlugin's -internal-attach method

This CL exposes a much simpler content/public method:
void RenderView::AttachToBrowserPlugin(blink::WebNode&)

This removes BrowserPlugin's usage of NPAPI method bindings.
This will hopefully help us move towards using OOPIFs.

BUG=330264

Review URL: https://codereview.chromium.org/444813002
-----------------------------------------------------------------
Project Member

Comment 70 by bugdroid1@chromium.org, Sep 16 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd

commit 3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd
Author: fsamuel <fsamuel@chromium.org>
Date: Tue Sep 16 09:16:28 2014

Rename ChromeBrowserPluginDelegate to GuestViewContainer

This CL renames ChromeBrowserPluginDelegate to GuestViewContainer and moves it to extensions

This CL moves guest_view_constants to extensions/common/*

This CL also attaches a GuestViewContainer to all GuestViews.

BUG=330264, 352290

Review URL: https://codereview.chromium.org/577453002

Cr-Commit-Position: refs/heads/master@{#295034}

[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/chrome/browser/chrome_content_browser_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/chrome/chrome_renderer.gypi
[delete] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd//dev/null
[delete] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd//dev/null
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/content/renderer/render_frame_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/BUILD.gn
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/guest_view/guest_view_base.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/guest_view/guest_view_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/browser/guest_view/web_view/web_view_permission_helper.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/common/BUILD.gn
[rename] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/common/guest_view/guest_view_constants.cc
[rename] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/common/guest_view/guest_view_constants.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/extensions.gyp
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/renderer/BUILD.gn
[add] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/renderer/guest_view/guest_view_container.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/renderer/guest_view/guest_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/shell/renderer/shell_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3a3d128e45fb5c63bf7b5cbbf2619e704acc52fd/extensions/shell/renderer/shell_content_renderer_client.h

Project Member

Comment 71 by bugdroid1@chromium.org, Sep 18 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b

commit 212c6daa34e6a5fd1a2754b08973d18d6d09246b
Author: fsamuel <fsamuel@chromium.org>
Date: Thu Sep 18 16:16:15 2014

Move ContentWindow from BrowserPlugin To GuestView

This CL plumbs out the swapped out RenderView's routing ID out to the content embedder which then uses it to expose its contentWindow to an optional callback in the AttachGuest API Method.

This patch also makes it fairly trivial to support a contentWindow in other GuestViews.

BUG=330264

Review URL: https://codereview.chromium.org/564973004

Cr-Commit-Position: refs/heads/master@{#295477}

[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/common/browser_plugin/browser_plugin_constants.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/common/browser_plugin/browser_plugin_constants.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/public/browser/browser_plugin_guest_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/renderer/browser_plugin/browser_plugin.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/renderer/browser_plugin/browser_plugin_bindings.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/content/renderer/browser_plugin/browser_plugin_bindings.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/browser/guest_view/guest_view_base.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/browser/guest_view/guest_view_base.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/common/extension_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/renderer/guest_view/guest_view_container.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/renderer/guest_view/guest_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/212c6daa34e6a5fd1a2754b08973d18d6d09246b/extensions/renderer/resources/web_view.js

Project Member

Comment 72 by bugdroid1@chromium.org, Sep 19 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd

commit a135a78495712ed3da2d0c74685f7641348930cd
Author: fsamuel <fsamuel@chromium.org>
Date: Fri Sep 19 23:23:49 2014

Remove some dead BrowserPlugin and OOPIF compositing code.

BUG=330264

Review URL: https://codereview.chromium.org/590523003

Cr-Commit-Position: refs/heads/master@{#295804}

[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/browser/browser_plugin/browser_plugin_message_filter.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/browser/browser_plugin/browser_plugin_message_filter.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/common/frame_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/common/swapped_out_messages.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/renderer/browser_plugin/browser_plugin.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/renderer/child_frame_compositing_helper.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/renderer/child_frame_compositing_helper.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/renderer/render_frame_proxy.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a135a78495712ed3da2d0c74685f7641348930cd/content/renderer/render_frame_proxy.h

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae

commit 516005f409bc6d2221c4be32fe1c0920975cf1ae
Author: fsamuel <fsamuel@chromium.org>
Date: Sat Sep 20 16:57:58 2014

Browser Plugin: Remove dependency on NPAPI

The CL moves the final attribute on BrowserPlugin 'allowtransparency' out to the extensions module! No new content APIs had to be introduced! Transparency can be enabled from RenderWidgetHostView::SetBackgroundOpaque in the content embedder.

This means that BrowserPlugin no longer depends on NPAPI and so this patch removes a lot of unnecessary code.

TBR=asvitkine@chromium.org for histograms.xml, extension_function_histogram_value.h

TBR=asvitkine@chromium.org for histograms.xml, extension
BUG=330264

Review URL: https://codereview.chromium.org/584713002

Cr-Commit-Position: refs/heads/master@{#295879}

[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/chrome/browser/apps/web_view_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/common/browser_plugin/browser_plugin_constants.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/common/browser_plugin/browser_plugin_constants.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/content_renderer.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/content/renderer/browser_plugin/browser_plugin.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae//dev/null
[delete] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae//dev/null
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/api/web_view/web_view_internal_api.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/api/web_view/web_view_internal_api.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/extension_function_histogram_value.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/guest_view/web_view/web_view_constants.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/guest_view/web_view/web_view_constants.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/browser/guest_view/web_view/web_view_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/common/api/web_view_internal.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/extensions/renderer/resources/web_view.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/516005f409bc6d2221c4be32fe1c0920975cf1ae/tools/metrics/histograms/histograms.xml

Project Member

Comment 74 by bugdroid1@chromium.org, Sep 20 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac35203eb3d9ddfcec077883ad897c8136027762

commit ac35203eb3d9ddfcec077883ad897c8136027762
Author: fsamuel <fsamuel@chromium.org>
Date: Sat Sep 20 21:11:00 2014

Cleanup BrowserPluginGuest::SwapCompositorFrame

BUG=330264

Review URL: https://codereview.chromium.org/588033002

Cr-Commit-Position: refs/heads/master@{#295891}

[modify] https://chromium.googlesource.com/chromium/src.git/+/ac35203eb3d9ddfcec077883ad897c8136027762/content/browser/browser_plugin/browser_plugin_guest.cc

Project Member

Comment 75 by bugdroid1@chromium.org, Oct 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e

commit a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e
Author: fsamuel <fsamuel@chromium.org>
Date: Thu Oct 02 00:51:33 2014

GuestView: Move lifetime management out of content

This CL introduces an internal destroyGuest API, and enables preservation of
guests when display:none is set.

This patch is also a big step towards guest teleportation.

BUG=419020, 330264
TBR=kenrb@chromium.org for browser_plugin_messages.h IPC removal, asvitkine@chromium.org for histograms.xml

Review URL: https://codereview.chromium.org/618823002

Cr-Commit-Position: refs/heads/master@{#297751}

[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/chrome/browser/apps/web_view_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/chrome/renderer/resources/extensions/app_view.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/chrome/renderer/resources/extensions/extension_options.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/chrome/test/data/extensions/platform_apps/app_view/shim/main.js
[delete] https://chromium.googlesource.com/chromium/src.git/+/7f79ce28848eb40d4ec6d2d335e2996ff02362e5/chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.html
[delete] https://chromium.googlesource.com/chromium/src.git/+/7f79ce28848eb40d4ec6d2d335e2996ff02362e5/chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/main.js
[delete] https://chromium.googlesource.com/chromium/src.git/+/7f79ce28848eb40d4ec6d2d335e2996ff02362e5/chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/manifest.json
[delete] https://chromium.googlesource.com/chromium/src.git/+/7f79ce28848eb40d4ec6d2d335e2996ff02362e5/chrome/test/data/extensions/platform_apps/web_view/display_none_and_back/test.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/browser/web_contents/web_contents_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/browser/web_contents/web_contents_view_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/public/browser/browser_plugin_guest_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/content/renderer/browser_plugin/browser_plugin_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/api/guest_view/guest_view_internal_api.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/api/guest_view/guest_view_internal_api.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/api/web_view/web_view_internal_api.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/extension_function_histogram_value.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/extension_options/extension_options_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/extension_options/extension_options_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/guest_view_base.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/guest_view_base.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/web_view/web_view_constants.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/web_view/web_view_constants.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/browser/guest_view/web_view/web_view_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/common/api/guest_view_internal.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/renderer/resources/web_view.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/extensions/renderer/resources/web_view_events.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/a8484dd476ef402fc235a3e9c19b1d52ac0d0f6e/tools/metrics/histograms/histograms.xml

Project Member

Comment 76 by bugdroid1@chromium.org, Oct 2 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd

commit f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd
Author: fsamuel <fsamuel@chromium.org>
Date: Thu Oct 02 19:06:54 2014

Remove BrowserPlugin tests (only one test remaining with existing coverage)

This test coverage already exists in chrome and extensions now.

BUG=330264

Review URL: https://codereview.chromium.org/617123005

Cr-Commit-Position: refs/heads/master@{#297874}

[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/content_renderer.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/content_tests.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/renderer/browser_plugin/browser_plugin.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/browser_plugin_browsertest.cc
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/browser_plugin_browsertest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/renderer/browser_plugin/browser_plugin_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/renderer/browser_plugin/browser_plugin_manager.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/browser_plugin_manager_factory.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/browser_plugin_manager_impl.cc
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/browser_plugin_manager_impl.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/mock_browser_plugin.cc
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/mock_browser_plugin.h
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
[delete] https://chromium.googlesource.com/chromium/src.git/+/32115e57190cc45b4914e70797189243f53fffe9/content/renderer/browser_plugin/mock_browser_plugin_manager.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/renderer/render_view_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/f32d1c4cf0ed2d34784c60342bd4ca13a53fd2cd/content/renderer/renderer_main.cc

Project Member

Comment 77 by bugdroid1@chromium.org, Oct 4 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a

commit e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a
Author: fsamuel <fsamuel@chromium.org>
Date: Sat Oct 04 00:30:37 2014

<webview>: resizing with display:none set should resize on attachment

BUG=330264, 419020
TEST=WebViewTest.Shim_TestResizeWebviewWithDisplayNoneResizesContent
TBR=creis@chromium.org for minor browser_plugin_delegate.h change.

Review URL: https://codereview.chromium.org/624063002

Cr-Commit-Position: refs/heads/master@{#298133}

[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/chrome/browser/apps/web_view_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/content/public/renderer/browser_plugin_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/content/renderer/browser_plugin/browser_plugin.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/extensions/renderer/guest_view/guest_view_container.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/extensions/renderer/guest_view/guest_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Project Member

Comment 78 by bugdroid1@chromium.org, Feb 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1

commit 2e9413d8e27666cdd7961b5d17e7cb270bc48fc1
Author: fsamuel <fsamuel@chromium.org>
Date: Wed Feb 25 01:25:44 2015

Decouple BrowserPlugin from RenderView

With the move to out-of-process iframes, RenderFrames and away from RenderViews, this CL removes routing via RenderView Routing ID from BrowserPlugin.

Aside from BrowserPluginHostMsg_Attach, which creates a new BrowserPluginEmbedder in the associated WebContents on first call, all other IPCs are now CONTROL because they do not rely on routing IDs.

BUG=436339, 330264
TBR=kenrb@chromium.org for mechanical change to make all BrowserPluginHostMsg IPCs except ATTACH CONTROL instead of ROUTED.

Review URL: https://codereview.chromium.org/929243003

Cr-Commit-Position: refs/heads/master@{#317940}

[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/browser/browser_plugin/browser_plugin_embedder.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/browser/web_contents/web_contents_impl.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/common/browser_plugin/browser_plugin_messages.h
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/browser_plugin/browser_plugin.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/browser_plugin/browser_plugin.h
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/browser_plugin/browser_plugin_manager.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/browser_plugin/browser_plugin_manager.h
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/child_frame_compositing_helper.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/render_frame_impl.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/render_view_impl.cc
[modify] http://crrev.com/2e9413d8e27666cdd7961b5d17e7cb270bc48fc1/content/renderer/render_widget.cc

Owner: lazyboy@chromium.org
Status: Assigned
Reassigning this to Istiaque since he's been working on this.
Project Member

Comment 80 by bugdroid1@chromium.org, May 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d983c9d55e2f93b5b370a403cb1ff36c22cef0

commit 02d983c9d55e2f93b5b370a403cb1ff36c22cef0
Author: lazyboy <lazyboy@chromium.org>
Date: Fri May 22 03:56:10 2015

Add a basic postMessage test for <webview> in a new test suite.

The plan is to run this test in site isolation bots as well when
  <webview> using OOPIF CL lands.

BUG=330264
Test=None

Review URL: https://codereview.chromium.org/1148903003

Cr-Commit-Position: refs/heads/master@{#331061}

[modify] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/chrome/browser/apps/guest_view/web_view_browsertest.cc
[add] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.html
[add] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/embedder.js
[add] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/guest.html
[add] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/manifest.json
[add] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/chrome/test/data/extensions/platform_apps/web_view/post_message/basic/test.js
[modify] http://crrev.com/02d983c9d55e2f93b5b370a403cb1ff36c22cef0/testing/buildbot/chromium.fyi.json

Project Member

Comment 81 by bugdroid1@chromium.org, Jun 2 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba

commit 7a4f1ceb18ffe6777d6a8b10b2db06e957187eba
Author: lazyboy <lazyboy@chromium.org>
Date: Tue Jun 02 17:47:29 2015

Move guest view container message routing out of content/.

GuestViews used to receive messages through BrowserPlugin, this CL makes
GuestView message routing possible without BrowserPlugin. This is a
prerequisite for making <webview> pluginless.

BUG=330264
Test=None, internal change only.

Review URL: https://codereview.chromium.org/1161483004

Cr-Commit-Position: refs/heads/master@{#332430}

[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/chrome/renderer/chrome_content_renderer_client.cc
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/chrome/renderer/chrome_content_renderer_client.h
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/components/guest_view.gypi
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/components/guest_view/renderer/BUILD.gn
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/components/guest_view/renderer/guest_view_container.h
[add] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/components/guest_view/renderer/guest_view_container_dispatcher.cc
[add] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/components/guest_view/renderer/guest_view_container_dispatcher.h
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/content/public/renderer/browser_plugin_delegate.cc
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/content/public/renderer/browser_plugin_delegate.h
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/content/public/renderer/content_renderer_client.cc
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/content/public/renderer/content_renderer_client.h
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/content/renderer/browser_plugin/browser_plugin.cc
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/content/renderer/browser_plugin/browser_plugin_manager.cc
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/extensions/extensions.gypi
[add] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.cc
[add] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/extensions/renderer/guest_view/extensions_guest_view_container_dispatcher.h
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/extensions/shell/renderer/shell_content_renderer_client.cc
[modify] http://crrev.com/7a4f1ceb18ffe6777d6a8b10b2db06e957187eba/extensions/shell/renderer/shell_content_renderer_client.h

Project Member

Comment 82 by bugdroid1@chromium.org, Jun 9 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3

commit cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3
Author: lazyboy <lazyboy@chromium.org>
Date: Tue Jun 09 19:34:59 2015

Move BrowserPluginDelegate's lifetime mgmt out of content/

This CL makes BrowserPlugin not own BPDelegate (GuestViewContainer)
  anymore.
BrowserPluginDelegate's lifetime has been tied to garbage collection
  of the shadow root HTML element that contains the plugin. For
  example, for <webview>, this is the <webview> element.
Before registering BPDelegate to GC, there's a brief period while
  BPDelegate is not owned by anyone directly, this case is covered
  with the static PostTask that deletes the delegate if we did not
  tie it to GC (UpdateInternalInstanceIdAndBindDelegateToGC()).

To make <webview> run without BrowserPlugin, we need to manage
  GuestViewContainer's (which is a BPDelegate) lifetime out of
  content/.

BUG=330264
Test=None, internal change only.

Review URL: https://codereview.chromium.org/1162053003

Cr-Commit-Position: refs/heads/master@{#333552}

[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/components/guest_view/renderer/guest_view_container.cc
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/components/guest_view/renderer/guest_view_container.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/content/public/renderer/browser_plugin_delegate.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/content/renderer/browser_plugin/browser_plugin.cc
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/content/renderer/browser_plugin/browser_plugin.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/content/renderer/browser_plugin/browser_plugin_manager.cc
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/content/renderer/browser_plugin/browser_plugin_manager.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/content/renderer/render_frame_impl.cc
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/extensions/renderer/guest_view/extensions_guest_view_container.cc
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/extensions/renderer/guest_view/extensions_guest_view_container.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h
[modify] http://crrev.com/cb6ba5c2ad69bf9daf896e5d3cd0c252c0ce6da3/extensions/renderer/resources/guest_view/guest_view_container.js

Project Member

Comment 83 by bugdroid1@chromium.org, Jun 9 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df345d7ae7e0a524eaab0466573f7aad68c86a88

commit df345d7ae7e0a524eaab0466573f7aad68c86a88
Author: lazyboy <lazyboy@chromium.org>
Date: Tue Jun 09 22:18:18 2015

Extract the element implementation logic to function mods in <webview>.
  function mods end with "$".

"element" inside <webview> is currently the plugin <object> element, i.e.
  the browser plugin. This CL makes it possible to provide a different
  implementation for the element. This CL also provides a stub
  using <iframe>. This will be used by the <webview> using OOPIF
  architecture CL: https://chromiumcodereview.appspot.com/972313002/

BUG=330264
Test=None, no visible changes.

Review URL: https://codereview.chromium.org/1165773004

Cr-Commit-Position: refs/heads/master@{#333592}

[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/extensions.gypi
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/dispatcher.cc
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/app_view/app_view.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/extension_options/extension_options.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/extension_view/extension_view.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/guest_view.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/guest_view_container.js
[add] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/guest_view_iframe.js
[add] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/guest_view_iframe_container.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/surface_view/surface_view.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/web_view/web_view.js
[modify] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js
[add] http://crrev.com/df345d7ae7e0a524eaab0466573f7aad68c86a88/extensions/renderer/resources/guest_view/web_view/web_view_iframe.js

Blockedon: chromium:500957
Project Member

Comment 85 by bugdroid1@chromium.org, Jun 23 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7fd358fc121acce20e55ee20a81ce0597c2ca0b

commit b7fd358fc121acce20e55ee20a81ce0597c2ca0b
Author: lazyboy <lazyboy@chromium.org>
Date: Tue Jun 23 06:20:14 2015

Make WebViewGuest::LoadURLWithParams also take a GlobalRequestID param.

This param can be used to construct "transferred_global_request_id"
field of NavigationController::LoadURLParams.
Currently this is no-op but this is a requirement for OOPIF based
<webview> implementation.

BUG=330264
Test=None, internal change.

Review URL: https://codereview.chromium.org/1202523004

Cr-Commit-Position: refs/heads/master@{#335638}

[modify] http://crrev.com/b7fd358fc121acce20e55ee20a81ce0597c2ca0b/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] http://crrev.com/b7fd358fc121acce20e55ee20a81ce0597c2ca0b/extensions/browser/guest_view/web_view/web_view_guest.h

Project Member

Comment 86 by bugdroid1@chromium.org, Jun 24 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5283a46c07caacd5ba874e08fba1c2b5d596cec

commit f5283a46c07caacd5ba874e08fba1c2b5d596cec
Author: lazyboy <lazyboy@chromium.org>
Date: Wed Jun 24 21:53:35 2015

Exclude <webview> process from locking to chrome-guest:// site.

We need to fix this properly later on, but this should be fine for now.

Before the change, the issue here is:
  <webview> loads http://www.google.com/
  The SiteInstance of the <webview> looks like:
    chrome-guest://appid, so it locks the guest process to that
    site url.
  When <webview> wants to read cookies from http://www.google.com,
    ChildProcessSecurityPolicyImpl::SecurityState::CanAccessCookiesForOrigin()
    return false and we kill the <webview> process b/c we think it's not
    allowed to access the cookie.

This CL removes the origin lock for guest processes.

BUG=330264
Test=There's no way to check this @tott, patch in http://crrev.com/972313002,
  Load a <webview> that accesses cookies, e.g. load http://www.google.com.
  This should not result in killing renderer process anymore.

Review URL: https://codereview.chromium.org/1205983002

Cr-Commit-Position: refs/heads/master@{#336009}

[modify] http://crrev.com/f5283a46c07caacd5ba874e08fba1c2b5d596cec/content/browser/site_instance_impl.cc

Project Member

Comment 87 by bugdroid1@chromium.org, Jun 25 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8db99d435fbc0c2c0a0b3c6aac8d03913c85daa1

commit 8db99d435fbc0c2c0a0b3c6aac8d03913c85daa1
Author: lazyboy <lazyboy@chromium.org>
Date: Thu Jun 25 00:22:13 2015

Extract some WebViewTest to separate test suites.

Each of these test suites represents a feature that currently to not
  work with OOPIF based <webview>. So these will be disabled initially
  in site isolation FYI bots.
The plan is to gradually fix these features and turn them on in site
  isolation bots.

TBR=jam@chromium.org for  testing/buildbot/chromium.fyi.json
BUG=330264

Review URL: https://codereview.chromium.org/1207113002

Cr-Commit-Position: refs/heads/master@{#336052}

[modify] http://crrev.com/8db99d435fbc0c2c0a0b3c6aac8d03913c85daa1/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] http://crrev.com/8db99d435fbc0c2c0a0b3c6aac8d03913c85daa1/testing/buildbot/chromium.fyi.json

Project Member

Comment 88 by bugdroid1@chromium.org, Jun 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec48b2a6529b753f28340fd6741908086224bee

commit 6ec48b2a6529b753f28340fd6741908086224bee
Author: lazyboy <lazyboy@chromium.org>
Date: Mon Jun 29 15:18:14 2015

Make <webview> use out-of-process iframe architecture.

This is behind --site-per-process flag.

This is the first step to make <webview> --site-per-process
compatible, only basic features work: rendering, input,
navigation, executeScript and postMessage.

This CL makes <webview> BrowserPlugin free, so <webview>
is not a plugin to blink anymore, rather it's similar to iframe.
Therefore, this CL makes <webview> work without BrowserPlugin
or BrowserPluginGuest/BrowserPluginEmbedder.
We still need to use the old browser/ counterparts (BPG and BPE)
because we use it for 1) Guest related decision making
in WebContents, so WebContentsImpl::browser_plugin_guest() is
still used and useful, 2) Initializing and attaching logic
inside content/, e.g. BPG::InitInternal(), BPG::OnWillAttachComplete.
In subsequent CLs, these dependencies will be either removed if not
required, or extracted to a separate class.

TBR=jochen@chromium.org for testing/buildbot/chromium.fyi.json
BUG=330264

Review URL: https://codereview.chromium.org/972313002

Cr-Commit-Position: refs/heads/master@{#336565}

[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view.gypi
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/browser/guest_view_base.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/browser/guest_view_message_filter.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/browser/guest_view_message_filter.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/common/guest_view_messages.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/BUILD.gn
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/DEPS
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/guest_view_container.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/guest_view_container.h
[add] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/iframe_guest_view_container.cc
[add] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/iframe_guest_view_container.h
[add] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/iframe_guest_view_request.cc
[add] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/components/guest_view/renderer/iframe_guest_view_request.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/browser_plugin/browser_plugin_guest.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/frame_host/cross_process_frame_connector.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/frame_host/frame_tree_node.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/frame_host/render_frame_host_manager.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/frame_host/render_frame_host_manager.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/frame_host/render_frame_proxy_host.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/web_contents/web_contents_impl.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/browser/web_contents/web_contents_impl.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/content/public/browser/web_contents.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/extensions/renderer/guest_view/extensions_guest_view_container.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/extensions/renderer/guest_view/extensions_guest_view_container.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/extensions/renderer/guest_view/guest_view_internal_custom_bindings.h
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/extensions/renderer/resources/guest_view/guest_view_iframe.js
[modify] http://crrev.com/6ec48b2a6529b753f28340fd6741908086224bee/testing/buildbot/chromium.fyi.json

Project Member

Comment 89 by bugdroid1@chromium.org, Jul 27 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fbf63023255c931d2903316dc5b645575015f36

commit 9fbf63023255c931d2903316dc5b645575015f36
Author: lfg <lfg@chromium.org>
Date: Mon Jul 27 15:41:40 2015

Prevent GuestView from swapping process on cross-site navigations in --site-per-process.

BUG=330264

Review URL: https://codereview.chromium.org/1259573006

Cr-Commit-Position: refs/heads/master@{#340470}

[modify] http://crrev.com/9fbf63023255c931d2903316dc5b645575015f36/content/browser/loader/cross_site_resource_handler.cc

Blockedon: chromium:517291
Project Member

Comment 91 by bugdroid1@chromium.org, Aug 18 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51da06d54ae07a7ca1f9432fa72e6d4b515b392f

commit 51da06d54ae07a7ca1f9432fa72e6d4b515b392f
Author: lfg <lfg@chromium.org>
Date: Tue Aug 18 16:19:58 2015

Move GuestView code from WebView-specific web_view_iframe.js into
guest_view_iframe_container.js.

BUG=330264

Review URL: https://codereview.chromium.org/1288063006

Cr-Commit-Position: refs/heads/master@{#343933}

[modify] http://crrev.com/51da06d54ae07a7ca1f9432fa72e6d4b515b392f/extensions/renderer/resources/guest_view/guest_view_iframe_container.js
[modify] http://crrev.com/51da06d54ae07a7ca1f9432fa72e6d4b515b392f/extensions/renderer/resources/guest_view/web_view/web_view_iframe.js

Blocking: chromium:533069
Blockedon: chromium:533647
Blockedon: chromium:543179
Project Member

Comment 95 by bugdroid1@chromium.org, Apr 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c740d4b229de011378f5211d662011ef4c38f98f

commit c740d4b229de011378f5211d662011ef4c38f98f
Author: lfg <lfg@chromium.org>
Date: Fri Apr 15 16:45:33 2016

Introduce WebContentsViewChildFrame.

This new WebContentsView is used when the top-level view of the
WebContents is a RenderWidgetHostViewChildFrame, used to implement
GuestViews based on the out-of-process iframes architecture.

BUG=330264

Review URL: https://codereview.chromium.org/1882653002

Cr-Commit-Position: refs/heads/master@{#387620}

[modify] https://crrev.com/c740d4b229de011378f5211d662011ef4c38f98f/content/browser/web_contents/web_contents_impl.cc
[add] https://crrev.com/c740d4b229de011378f5211d662011ef4c38f98f/content/browser/web_contents/web_contents_view_child_frame.cc
[add] https://crrev.com/c740d4b229de011378f5211d662011ef4c38f98f/content/browser/web_contents/web_contents_view_child_frame.h
[modify] https://crrev.com/c740d4b229de011378f5211d662011ef4c38f98f/content/content_browser.gypi

Comment 96 by lfg@chromium.org, Oct 13 2016

Owner: lfg@chromium.org

Comment 97 by lfg@chromium.org, Oct 13 2016

Blocking: 655753
Blockedon: 671843

Comment 99 by lfg@chromium.org, Jun 8 2017

Cc: lfg@chromium.org
Owner: ekaramad@chromium.org
I think the only missing part now is finishing up MimeHandlerView and PDF support.

Assigning to ekaramad@.
Blocking: -655753
Blockedon: 784590
Project Member

Comment 102 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5053971dd2543d576a84eb883b8edf92fbf57517

commit 5053971dd2543d576a84eb883b8edf92fbf57517
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Fri Jul 27 07:07:46 2018

Introduce API for external handling of plugins

When the contents of a plugin element (<embed> and <object>) are to be
handeld externally inside an extension (most notably PDF) we currently
use browser plugin. BrowserPlugin is used to render GuestView contents
in another process.

However, BrowserPlugin-based guest views have been deprecated and all
guest views except for MimeHandlerViewGuest are not implemented on top
of cross-process frames.

This CL introduces the first steps in fully replacing BrowserPlugin with
corss-process frames.

Different mechanisms for this project have already been discussed in the
design doc:
https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.ue5a8s290yhk

Bug: 659750, 330264
Change-Id: If273fbbab3e9f4a4591c61b19d54e4cca73c3464
Reviewed-on: https://chromium-review.googlesource.com/1101161
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578554}
[modify] https://crrev.com/5053971dd2543d576a84eb883b8edf92fbf57517/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/5053971dd2543d576a84eb883b8edf92fbf57517/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/5053971dd2543d576a84eb883b8edf92fbf57517/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/5053971dd2543d576a84eb883b8edf92fbf57517/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/5053971dd2543d576a84eb883b8edf92fbf57517/third_party/blink/renderer/core/html/html_plugin_element.cc
[modify] https://crrev.com/5053971dd2543d576a84eb883b8edf92fbf57517/third_party/blink/renderer/core/html/html_plugin_element.h

Project Member

Comment 103 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e411392c3633e4dbbf5fb059f79ca10bec976f9b

commit e411392c3633e4dbbf5fb059f79ca10bec976f9b
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Thu Aug 02 17:48:37 2018

Content feature for MimeHandlerView in OOPF

This CL introduces a bare content feature to allow landing experimental
work and future CLs on MimeHandlerView using cross process frames. The
feature will be disabled by default.

MimeHandlerViewContainer is currently the last remaining GuestView
which still relies on BrowserPlugin. Eventually and starting with this
CL, the new implementation of MimeHandlerView will be based on
cross-process frames that no longer requires a BrowserPlugin.

Bug: 659750, 330264
Change-Id: I52a8eba4e9f2446ae0d899cd3a639f418bc01d12
Reviewed-on: https://chromium-review.googlesource.com/1073923
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580240}
[modify] https://crrev.com/e411392c3633e4dbbf5fb059f79ca10bec976f9b/content/public/common/content_features.cc
[modify] https://crrev.com/e411392c3633e4dbbf5fb059f79ca10bec976f9b/content/public/common/content_features.h

Project Member

Comment 104 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378384acf5e76872e88c144e4ab8d154ce533f84

commit 378384acf5e76872e88c144e4ab8d154ce533f84
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Fri Aug 03 21:26:46 2018

Make a BrowserPluginSpecific test a MimeHandlerViewTest

All GuestViews except for MimeHandlerViewGuest are now implemented based on
cross-process frames. There is however a hadnful of browser tests which are not
MimeHandlerViewTest but still use BrowserPlugin.

This CL will
  1- Change the MimeHandlerViewTest from parameteric to normal test.
  Essentially, the UseCrossProcessFramesForGuest flag is unrelated to
  the MimeHandlerViewGuest. There is a separate flag for that matter
  which is "MimeHandlerViewInCrossProcessFrame" and will be added
  eventually when the a first version of MimeHandlerViewGuest based on
  cross-process frames is implemented on ToT.

  2- Move WebViewBrowserPluginSpecificTest.AcceptTouchEvents to
  MimeHandlerViewTest. This involves overhauling the test test is also
  modified to load MimeHandlerViewGuest instead of WebViewGuest.

The short-term plan is to change all such (BrowserPluginSpecific) tests
to become MimeHandlerViewBrowserPluginSpecificTest. The longer term goal
is to remove all such tests when MimeHandlerViewInCrossProcessFrames
is shipped.

Bug: 659750, 533069, 330264
Change-Id: Icad9ddd1f2d1e6851b20f6c0d923dd2192b7dcec
Reviewed-on: https://chromium-review.googlesource.com/1161745
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580655}
[modify] https://crrev.com/378384acf5e76872e88c144e4ab8d154ce533f84/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/378384acf5e76872e88c144e4ab8d154ce533f84/chrome/test/data/extensions/api_test/mime_handler_view/index.js
[modify] https://crrev.com/378384acf5e76872e88c144e4ab8d154ce533f84/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc

Project Member

Comment 105 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eb68052e037952a13565c5545ca3fdc9dbac2b9

commit 8eb68052e037952a13565c5545ca3fdc9dbac2b9
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Fri Aug 10 21:39:23 2018

Move BrowserPluginSpecific tests out of web_view_browsertest.cc

The WebViewBrowserPluginSpecificTest class includes tests which use a
BrowserPluign-based GuestView. Since all GuestViews except MimeHandlerViewGuest
are now based on cross-process frames, these tests should not be implemented as
WebViewGuest tests anymore.

This CL introduces a new chrome browser test target for such
BrowserPluginSpecific tests where the tests instantiate a MimeHandlerViewGuest
instead of a <webview>.

Ideally, the tests should have lived with the rest of MimeHandlerViewTests in
extension layer; however, due to chrome layer dependencies it is not possible.

Bug: 659750, 533069, 330264, 870604
Change-Id: Ica252a60e94bad47cabbff8b9275b8f9fb05d7ae
Reviewed-on: https://chromium-review.googlesource.com/1168734
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582345}
[modify] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/browser/apps/guest_view/web_view_browsertest.cc
[add] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
[modify] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/test/BUILD.gn
[modify] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/test/data/extensions/api_test/mime_handler_view/index.js

Project Member

Comment 106 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66593c81db2fd722ef0e016f1030d4d1e73e540f

commit 66593c81db2fd722ef0e016f1030d4d1e73e540f
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Tue Sep 11 17:28:28 2018

Make 'web_view_browsertest.cc' (almost) BrowserPlugin-free

The BrowserPlugin related tests in the file were to test features that
affect BP-based GuestViews; this only includes MimeHandlerViewGuest.

This CL moves one more such test to
'chrome_mime_handler_view_browsertest.cc'. This also involves adapting
the test such that it creates a MimeHandlerViewGuest instead of
WebViewGuest based on BrowserPlugin.

The last remaining test in 'web_view_browsertest.cc' will be removed and
adapted in a followup CL (to make sure the process is easily reversible
in case the new tests end up having issues on bots).

Bug: 553069, 330264
Change-Id: Iaa7ba33189ecb8b23e8489dab8e9b2b5e378a9be
Reviewed-on: https://chromium-review.googlesource.com/1217147
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590372}
[modify] https://crrev.com/66593c81db2fd722ef0e016f1030d4d1e73e540f/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/66593c81db2fd722ef0e016f1030d4d1e73e540f/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
[modify] https://crrev.com/66593c81db2fd722ef0e016f1030d4d1e73e540f/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
[modify] https://crrev.com/66593c81db2fd722ef0e016f1030d4d1e73e540f/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Project Member

Comment 107 by bugdroid1@chromium.org, Sep 13

Project Member

Comment 108 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b219ac43dfc572c386868eae614f957f7ee812b1

commit b219ac43dfc572c386868eae614f957f7ee812b1
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Thu Sep 13 23:13:05 2018

Revert "Make 'web_view_browsertest.cc' BrowserPlugin-free"

This reverts commit d3358a99e012a585ce80ff0f4416930fe96978ba.

Reason for revert: The test seems to be very flaky.

Bug: 883965

Original change's description:
> Make 'web_view_browsertest.cc' BrowserPlugin-free
> 
> This CL removes and converts the last remaining BrowserPlugin-based test
> to chrome_mime_handler_view_browsertest.cc (the new test uses a
> MimeHandlerViewGuest).
> 
> Bug: 553069, 330264
> Change-Id: I487fbd47ca0c989e746d087c72fe396f9e9ac867
> Reviewed-on: https://chromium-review.googlesource.com/1221693
> Reviewed-by: James MacLean <wjmaclean@chromium.org>
> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#591115}

TBR=ekaramad@chromium.org,wjmaclean@chromium.org

Change-Id: I60e4bc6872645cb1be4de70d19f41c1c4e6e51b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 553069, 330264
Reviewed-on: https://chromium-review.googlesource.com/1226202
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591198}
[modify] https://crrev.com/b219ac43dfc572c386868eae614f957f7ee812b1/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/b219ac43dfc572c386868eae614f957f7ee812b1/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
[modify] https://crrev.com/b219ac43dfc572c386868eae614f957f7ee812b1/chrome/test/data/extensions/api_test/mime_handler_view/test_embedded.html
[modify] https://crrev.com/b219ac43dfc572c386868eae614f957f7ee812b1/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
[modify] https://crrev.com/b219ac43dfc572c386868eae614f957f7ee812b1/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Cc: riajiang@chromium.org
Showing comments 10 - 109 of 109 Older

Sign in to add a comment