New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 12 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 154571



Sign in to add a comment
link

Issue 327256: Run SharedWorker in a renderer process rather than creating a new worker process for it

Reported by kinuko@chromium.org, Dec 10 2013 Project Member

Issue description

Currently when Chrome/Blink runs a SharedWorker it creates a new process (called worker process) for one SharedWorker, which means it always create N+1 processes when N tabs are sharing the same SharedWorker.

This adds some burden both in terms of process resource (especially critical on Android, related: issue 154571) and code complexity (for worker process).

Technically it should be able to run a SharedWorker in one of the renderer processes that share the worker, like we're trying to do for  issue 313530  for ServiceWorker.

Some design considerations:
* When one tab requests to create a new SharedWorker the worker can initially be created in the same process
* When more tabs are connecting to the same SharedWorker they're going to talk to the renderer process that has the in-renderer SharedWorker (note: they should be in the same origin per spec)
* When the renderer process that has the in-renderer SharedWorker gets shutdown, a new SharedWorker instance may be created in a new renderer process that shares the same SharedWorker
* All communication between renderer process and SharedWorker process will go through the browser process, at least initially (as in the current architecture)
 

Comment 1 by kinuko@chromium.org, Dec 10 2013

Cc: adamk@chromium.org

Comment 2 by atwilson@google.com, Dec 10 2013

Just to clarify your third point:

"* When the renderer process that has the in-renderer SharedWorker gets shutdown, a new SharedWorker instance may be created in a new renderer process that shares the same SharedWorker"

Let's say that renderer A creates a Shared worker, so this worker is put in renderer A's process. Now renderer B starts up and creates the same shared worker - renderer B should get a reference to the worker in renderer A.

Under what circumstances can renderer process A's SharedWorker get shutdown? I'm just concerned from your comment that you are considering shutting down the SharedWorker in process A and restarting it in process B while it already has connected clients, which I don't think is feasible. I'd say that you need to keep renderer A's process running as long as the SharedWorker is alive.

Comment 3 by kinuko@chromium.org, Jan 15 2014

#2 (sorry I have missed this comment)

> Under what circumstances can renderer process A's SharedWorker get shutdown?
...
> I'd say that you need to keep renderer A's process running as long as the SharedWorker is alive.

Yeah, probably that's the practical solution we should try first. It's also what jam suggested on blink thread-- I'd drop the third point from my initial post.  Thanks for the suggestion.

Comment 4 by bugdroid1@chromium.org, Jan 23 2014

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=165606

------------------------------------------------------------------------
r165606 | horo@chromium.org | 2014-01-23T03:59:50.431829Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/ChromeClientImpl.cpp?r1=165606&r2=165605&pathrev=165606

Add null check in ChromeClientImpl::postAccessibilityNotification().

Because AXObjectCache::accessibilityEnabled() always returns true in the shared worker process,
ChromeClientImpl::postAccessibilityNotification() is never called in the process.
So we don't need to check m_webView->client() now.

But we are planing to move SharedWorker to the renderer process.
 http://crbug.com/327256 
ChromeClientImpl::postAccessibilityNotification() will be called in the shared worker's WebFrame
when the accessibility feature is enabled.
But m_webView->client() is NULL in the shared worker's WebFrame.

So we have to check it.

BUG= 327256 

Review URL: https://codereview.chromium.org/134643019
------------------------------------------------------------------------

Comment 5 by kinuko@chromium.org, Jan 31 2014

Owner: horo@chromium.org
Status: Assigned
Horo's been looking into this and has a local prototype for this one, assigning to him

Comment 6 by horo@chromium.org, Feb 10 2014

Comment 7 by horo@chromium.org, Feb 10 2014

Status: Started

Comment 8 by bugdroid1@chromium.org, Feb 12 2014

Project Member
------------------------------------------------------------------------
r250698 | horo@chromium.org | 2014-02-12T11:43:32.541301Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/OWNERS?r1=250698&r2=250697&pathrev=250698
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker?r1=250698&r2=250697&pathrev=250698

Add content/browser/shared_worker/OWNERS.

In this directory, we will implement the browser side code for the SharedWorker in the renderer process.

BUG= 327256 

Review URL: https://codereview.chromium.org/159123005
------------------------------------------------------------------------

Comment 9 by bugdroid1@chromium.org, Feb 12 2014

Project Member
------------------------------------------------------------------------
r250701 | horo@chromium.org | 2014-02-12T11:51:51.923972Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_document_set.cc?r1=250701&r2=250700&pathrev=250701
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_document_set.h?r1=250701&r2=250700&pathrev=250701
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.h?r1=250701&r2=250700&pathrev=250701

Use BrowserMessageFilter instead of WorkerMessageFilter in WorkerDocumentSet.

We will use WorkerDocumentSet for other type of BrowserMessageFilter while moving SharedWorker to the renderer process.

BUG= 327256 

Review URL: https://codereview.chromium.org/159893008
------------------------------------------------------------------------

Comment 10 by bugdroid1@chromium.org, Feb 13 2014

Project Member
------------------------------------------------------------------------
r251012 | horo@chromium.org | 2014-02-13T15:10:01.810783Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=251012&r2=251011&pathrev=251012
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=251012&r2=251011&pathrev=251012
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=251012&r2=251011&pathrev=251012

Add an empty class for the embedded SharedWorker.
(SharedWorkerServiceImpl)

These class will be used when "enable-embedded-shared-worker" is set.

BUG= 327256 

Review URL: https://codereview.chromium.org/140333011
------------------------------------------------------------------------

Comment 12 by bugdroid1@chromium.org, Feb 14 2014

Project Member
------------------------------------------------------------------------
r251335 | horo@chromium.org | 2014-02-14T15:30:22.818143Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/shared_worker_devtools_agent.cc?r1=251335&r2=251334&pathrev=251335
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_worker.gypi?r1=251335&r2=251334&pathrev=251335
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/shared_worker_devtools_agent.h?r1=251335&r2=251334&pathrev=251335
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworkerclient_proxy.cc?r1=251335&r2=251334&pathrev=251335
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=251335&r2=251334&pathrev=251335
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.h?r1=251335&r2=251334&pathrev=251335
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/child/shared_worker_devtools_agent.cc?r1=251335&r2=251334&pathrev=251335
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_child.gypi?r1=251335&r2=251334&pathrev=251335
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/child/shared_worker_devtools_agent.h?r1=251335&r2=251334&pathrev=251335
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker?r1=251335&r2=251334&pathrev=251335
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=251335&r2=251334&pathrev=251335
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworker_stub.cc?r1=251335&r2=251334&pathrev=251335

Implementations of SharedWorker in the renderer process.

In this CL I introduce 2 classes (EmbeddedSharedWorkerDevToolsAgent, EmbeddedSharedWorkerStub).

EmbeddedSharedWorkerStub and EmbeddedSharedWorkerDevToolsAgent are almost same as WebSharedWorkerStub and SharedWorkerDevToolsAgent which are used in the worker process now.
These classes are not used yet.
EmbeddedSharedWorkerStub will be created when CreateWorker message is received by RenderThreadImpl.

In this CL I move shared_worker_devtools_agent.* from content/worker/ to content/child/ because I want use it from content/renderer/shared_worker.

BUG= 327256 

Review URL: https://codereview.chromium.org/158953008
------------------------------------------------------------------------

Comment 13 by bugdroid1@chromium.org, Feb 18 2014

Project Member
Labels: merge-merged-1845
------------------------------------------------------------------------
r251801 | dxie@chromium.org | 2014-02-18T19:02:16.816078Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1845/src/content/content_browser.gypi?r1=251801&r2=251800&pathrev=251801
   M http://src.chromium.org/viewvc/chrome/branches/1845/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=251801&r2=251800&pathrev=251801
   M http://src.chromium.org/viewvc/chrome/branches/1845/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=251801&r2=251800&pathrev=251801
   D http://src.chromium.org/viewvc/chrome/branches/1845/src/content/browser/shared_worker/shared_worker_message_filter.h?r1=251801&r2=251800&pathrev=251801

Revert 251334 "Add SharedWorkerMessageFilter for the embedded Sh..."

> Add SharedWorkerMessageFilter for the embedded SharedWorker.
> 
> It will be used instead of WorkerMessageFilter when "enable-embedded-shared-worker" is set.
> 
> BUG= 327256 
> 
> Review URL: https://codereview.chromium.org/166273002

TBR=horo@chromium.org

Review URL: https://codereview.chromium.org/166873008
------------------------------------------------------------------------

Comment 14 by bugdroid1@chromium.org, Feb 18 2014

Project Member
Labels: merge-merged-1846
------------------------------------------------------------------------
r251802 | dxie@chromium.org | 2014-02-18T19:04:58.893385Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1846/src/content/content_browser.gypi?r1=251802&r2=251801&pathrev=251802
   M http://src.chromium.org/viewvc/chrome/branches/1846/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=251802&r2=251801&pathrev=251802
   M http://src.chromium.org/viewvc/chrome/branches/1846/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=251802&r2=251801&pathrev=251802
   D http://src.chromium.org/viewvc/chrome/branches/1846/src/content/browser/shared_worker/shared_worker_message_filter.h?r1=251802&r2=251801&pathrev=251802

Revert 251334 "Add SharedWorkerMessageFilter for the embedded Sh..."

> Add SharedWorkerMessageFilter for the embedded SharedWorker.
> 
> It will be used instead of WorkerMessageFilter when "enable-embedded-shared-worker" is set.
> 
> BUG= 327256 
> 
> Review URL: https://codereview.chromium.org/166273002

TBR=horo@chromium.org

Review URL: https://codereview.chromium.org/171123002
------------------------------------------------------------------------

Comment 15 by bugdroid1@chromium.org, Feb 26 2014

Project Member
------------------------------------------------------------------------
r253620 | horo@chromium.org | 2014-02-26T23:13:50.953491Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_storage_partition.h?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance_unittest.cc?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.cc?r1=253620&r2=253619&pathrev=253620

Implement SharedWorkerServiceImpl::CreateWorker and SharedWorkerInstance and SharedWorkerHost.

SharedWorkerInstance is almost same as WorkerProcessHost::WorkerInstance in content/browser/worker_host/worker_process_host.h.

In the next CL, I will implement SharedWorkerHost::Init() which sends CreateWorker message to the renderer.

BUG= 327256 

Review URL: https://codereview.chromium.org/177043003
------------------------------------------------------------------------

Comment 16 by bugdroid1@chromium.org, Feb 26 2014

Project Member
------------------------------------------------------------------------
r253620 | horo@chromium.org | 2014-02-26T23:13:50.953491Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_storage_partition.h?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance_unittest.cc?r1=253620&r2=253619&pathrev=253620
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.cc?r1=253620&r2=253619&pathrev=253620
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=253620&r2=253619&pathrev=253620

Implement SharedWorkerServiceImpl::CreateWorker and SharedWorkerInstance and SharedWorkerHost.

SharedWorkerInstance is almost same as WorkerProcessHost::WorkerInstance in content/browser/worker_host/worker_process_host.h.

In the next CL, I will implement SharedWorkerHost::Init() which sends CreateWorker message to the renderer.

BUG= 327256 

Review URL: https://codereview.chromium.org/177043003
------------------------------------------------------------------------

Comment 18 by bugdroid1@chromium.org, Mar 5 2014

Project Member
------------------------------------------------------------------------
r254928 | horo@chromium.org | 2014-03-05T02:24:15.742467Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_document_set.cc?r1=254928&r2=254927&pathrev=254928
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_document_set.h?r1=254928&r2=254927&pathrev=254928

Add WorkerDocumentSet::ContainsExternalRenderer(int worker_process_id)

It will be called to checks to see if the document set contains any documents which is associated with other renderer process than worker_process_id.

BUG= 327256 

Review URL: https://codereview.chromium.org/178473016
------------------------------------------------------------------------

Comment 19 by bugdroid1@chromium.org, Mar 5 2014

Project Member
------------------------------------------------------------------------
r255009 | horo@chromium.org | 2014-03-05T11:00:24.507212Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=255009&r2=255008&pathrev=255009

Implement SharedWorkerServiceImpl::GetWorkers().

This will be called from DevTools to list up the workers.

BUG= 327256 

Review URL: https://codereview.chromium.org/185743004
------------------------------------------------------------------------

Comment 20 by bugdroid1@chromium.org, Mar 5 2014

Project Member
------------------------------------------------------------------------
r255018 | horo@chromium.org | 2014-03-05T12:06:09.969991Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=255018&r2=255017&pathrev=255018
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.h?r1=255018&r2=255017&pathrev=255018

Add IncrementWorkerRefCount() and DecrementWorkerRefCount() to RenderProcessHostImpl.

These methods will be called from SharedWorkerServiceImpl when the existence of the other renderer process which is connected to the SharedWorker in this renderer process has changed.
It is only called when "enable-embedded-shared-worker" flag is set.

When |worker_ref_count_| is not zero , RenderProcessHostImpl::FastShutdownIfPossible() and RenderProcessHostImpl::Cleanup() don't shutdown the renderer process.

BUG= 327256 

Review URL: https://codereview.chromium.org/176843004
------------------------------------------------------------------------

Comment 21 by bugdroid1@chromium.org, Mar 5 2014

Project Member
------------------------------------------------------------------------
r255017 | horo@chromium.org | 2014-03-05T12:05:10.762836Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=255017&r2=255016&pathrev=255017
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=255017&r2=255016&pathrev=255017
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=255017&r2=255016&pathrev=255017

Implement SharedWorkerServiceImpl::TerminateWorker().

This will be called when the user clicks "terminate" in chrome://inspect/#workers

BUG= 327256 

Review URL: https://codereview.chromium.org/183663025
------------------------------------------------------------------------

Comment 22 by bugdroid1@chromium.org, Mar 5 2014

Project Member
------------------------------------------------------------------------
r255068 | horo@chromium.org | 2014-03-05T17:18:58.813814Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=255068&r2=255067&pathrev=255068

Tells the crash of SharedWorker to RenderViewHosts.

BUG= 327256 

Review URL: https://codereview.chromium.org/187553002
------------------------------------------------------------------------

Comment 23 by bugdroid1@chromium.org, Mar 11 2014

Project Member
------------------------------------------------------------------------
r256205 | horo@chromium.org | 2014-03-11T11:39:38.792910Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=256205&r2=256204&pathrev=256205
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=256205&r2=256204&pathrev=256205

Implement AllowDatabase, AllowFileSystem, AllowIndexedDB in SharedWorkerHost.

Same implementation as in worker_host/worker_process_host.cc.

BUG= 327256 

Review URL: https://codereview.chromium.org/194183004
------------------------------------------------------------------------

Comment 24 by bugdroid1@chromium.org, Mar 11 2014

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 11 2014

Project Member
------------------------------------------------------------------------
r256323 | cpu@chromium.org | 2014-03-11T21:55:45.035392Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=256323&r2=256322&pathrev=256323
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=256323&r2=256322&pathrev=256323
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc?r1=256323&r2=256322&pathrev=256323
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=256323&r2=256322&pathrev=256323
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=256323&r2=256322&pathrev=256323
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/message_port_message_filter.h?r1=256323&r2=256322&pathrev=256323
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_message_filter.h?r1=256323&r2=256322&pathrev=256323

Revert 256305 "Add SharedWorkerServiceImpl::CheckWorkerDependenc..."

This fired the leak detector. See  bug 351492  for details.

> Add SharedWorkerServiceImpl::CheckWorkerDependency().
> 
> This method checks the worker dependency of renderer processes and calls IncrementWorkerRefCount and DecrementWorkerRefCount of RenderProcessHostImpl on UI thread if necessary.
> 
> BUG= 327256 
> 
> Review URL: https://codereview.chromium.org/187533002

TBR=horo@chromium.org

Review URL: https://codereview.chromium.org/195723003
------------------------------------------------------------------------

Comment 26 by bugdroid1@chromium.org, Mar 11 2014

Project Member
------------------------------------------------------------------------
r256355 | horo@chromium.org | 2014-03-11T23:19:39.567682Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/OWNERS?r1=256355&r2=256354&pathrev=256355

Add content/renderer/shared_worker/OWNERS.

In this directory, we will implement the renderer side code for the SharedWorker in the renderer process.

BUG= 327256 

Review URL: https://codereview.chromium.org/194063004
------------------------------------------------------------------------

Comment 28 by bugdroid1@chromium.org, Mar 12 2014

Project Member
------------------------------------------------------------------------
r256422 | horo@chromium.org | 2014-03-12T04:36:15.147155Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/swapped_out_messages.cc?r1=256422&r2=256421&pathrev=256422

Add ViewHostMsg_DocumentDetached to SwappedOutMessages::CanSendWhileSwappedOut.

ViewHostMsg_DocumentDetached must be sent from the renderer process when the user leaves the page which is running SharedWorker.
But it is not sent in the current code when the user is going to another domain page.
It is because ViewHostMsg_DocumentDetached is not handled in SwappedOutMessages::CanSendWhileSwappedOut.

BUG= 327256 

Review URL: https://codereview.chromium.org/194443002
------------------------------------------------------------------------

Comment 29 by bugdroid1@chromium.org, Mar 12 2014

Project Member
------------------------------------------------------------------------
r256432 | horo@chromium.org | 2014-03-12T05:06:18.978920Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.h?r1=256432&r2=256431&pathrev=256432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=256432&r2=256431&pathrev=256432

Send WorkerHostMsg_WorkerConnected in EmbeddedSharedWorkerStub::OnConnect.

WorkerHostMsg_WorkerConnected must be sent in EmbeddedSharedWorkerStub::OnConnect if the SharedWorker is already running.
In current code the memory leak of SharedWorkerConnector could occur because SharedWorkerConnector::connected() is not called.

BUG= 327256 

Review URL: https://codereview.chromium.org/189413014
------------------------------------------------------------------------

Comment 30 by bugdroid1@chromium.org, Mar 12 2014

Project Member
------------------------------------------------------------------------
r256552 | horo@chromium.org | 2014-03-12T16:28:19.358756Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=256552&r2=256551&pathrev=256552
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.h?r1=256552&r2=256551&pathrev=256552

Implement renderer process side handler of WorkerProcessMsg_CreateWorker message.

WorkerProcessMsg_CreateWorker will be sent from the browser process to a renderer process if "enable-embedded-shared-worker" flag is set after https://codereview.chromium.org/154263004/ is landed.

BUG= 327256 

Review URL: https://codereview.chromium.org/194393002
------------------------------------------------------------------------

Comment 31 by bugdroid1@chromium.org, Mar 13 2014

Project Member
------------------------------------------------------------------------
r256749 | horo@chromium.org | 2014-03-13T05:16:01.561781Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_message_filter.h?r1=256749&r2=256748&pathrev=256749
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=256749&r2=256748&pathrev=256749
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=256749&r2=256748&pathrev=256749
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc?r1=256749&r2=256748&pathrev=256749
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=256749&r2=256748&pathrev=256749
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=256749&r2=256748&pathrev=256749
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/message_port_message_filter.h?r1=256749&r2=256748&pathrev=256749

Add SharedWorkerServiceImpl::CheckWorkerDependency().

This method checks the worker dependency of renderer processes and calls IncrementWorkerRefCount and DecrementWorkerRefCount of RenderProcessHostImpl on UI thread if necessary.

The old cl (http://crrev.com/256305) was reverted (http://crrev.com/256323) because of the memory leak in MockMessagePortMessageFilter::Send and MockSharedWorkerMessageFilter::Send.
This cl has fixed it.

The difference between this cl and the old cl is the null value handling of message_queue_ in MockMessagePortMessageFilter::Send and MockSharedWorkerMessageFilter::Send. 


BUG= 327256 , 351492 
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/196483003
------------------------------------------------------------------------

Comment 33 by bugdroid1@chromium.org, Mar 20 2014

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=169641

------------------------------------------------------------------
r169641 | horo@chromium.org | 2014-03-20T10:50:27.418338Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/CookieJar.cpp?r1=169641&r2=169640&pathrev=169641

Stop calling blink::Platform::current()->cookieJar() in CookieJar.cpp

We no longer have DRT in Blink.

BUG= 327256 

Review URL: https://codereview.chromium.org/205323004
-----------------------------------------------------------------

Comment 34 by bugdroid1@chromium.org, Mar 27 2014

Project Member
------------------------------------------------------------------
r259790 | horo@chromium.org | 2014-03-27T05:26:48.569753Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=259790&r2=259789&pathrev=259790
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=259790&r2=259789&pathrev=259790

Add UMA stats for SharedWorker in SharedWorkerHost.

This cl adds three UMA stats.
 - SharedWorker.TimeToDeleted
 - SharedWorker.TimeToScriptLoaded
 - SharedWorker.TimeToScriptLoadFailed

BUG= 327256 

Review URL: https://codereview.chromium.org/212373002
-----------------------------------------------------------------

Comment 35 by bugdroid1@chromium.org, Mar 29 2014

Project Member
------------------------------------------------------------------
r260376 | horo@chromium.org | 2014-03-29T17:28:38.373440Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=260376&r2=260375&pathrev=260376
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.h?r1=260376&r2=260375&pathrev=260376

Add UMA stats for SharedWorker in RenderProcessHostImpl.

This cl adds one UMA stats.
- SharedWorker.RendererSurviveForWorkerTime

BUG= 327256 

Review URL: https://codereview.chromium.org/212403002
-----------------------------------------------------------------

Comment 36 by bugdroid1@chromium.org, Mar 31 2014

Project Member

Comment 37 by bugdroid1@chromium.org, Apr 3 2014

Project Member
------------------------------------------------------------------
r261314 | horo@chromium.org | 2014-04-03T07:55:19.167048Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.h?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=261314&r2=261313&pathrev=261314
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager_unittest.cc?r1=261314&r2=261313&pathrev=261314
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager.cc?r1=261314&r2=261313&pathrev=261314
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager.h?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.cc?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.h?r1=261314&r2=261313&pathrev=261314
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=261314&r2=261313&pathrev=261314

Make DevTools support for the embedded SharedWorker.

BUG= 327256 

Review URL: https://codereview.chromium.org/196503005
-----------------------------------------------------------------

Comment 38 by bugdroid1@chromium.org, Apr 3 2014

Project Member
------------------------------------------------------------------
r261327 | horo@chromium.org | 2014-04-03T08:54:02.814996Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=261327&r2=261326&pathrev=261327
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager_unittest.cc?r1=261327&r2=261326&pathrev=261327
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager.cc?r1=261327&r2=261326&pathrev=261327
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager.h?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.h?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=261327&r2=261326&pathrev=261327
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.h?r1=261327&r2=261326&pathrev=261327

Revert of Make DevTools support for the embedded SharedWorker. (https://codereview.chromium.org/196503005/)

Reason for revert:
buildbot failure in Chromium Memory on Linux ASan+LSan Tests

SharedWorkerDevToolsManagerTest.AttachTest test causes memory leaks.

Original issue's description:
> Make DevTools support for the embedded SharedWorker.
> 
> BUG= 327256 
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261314

TBR=kinuko@chromium.org,pfeldman@chromium.org,yurys@chromium.org,sergeyv@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 327256 

Review URL: https://codereview.chromium.org/223583002
-----------------------------------------------------------------

Comment 39 by bugdroid1@chromium.org, Apr 3 2014

Project Member
------------------------------------------------------------------
r261387 | horo@chromium.org | 2014-04-03T14:51:32.382036Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=261387&r2=261386&pathrev=261387
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=261387&r2=261386&pathrev=261387

Add enable-embedded-shared-worker in chrome://flags/

BUG= 327256 

Review URL: https://codereview.chromium.org/221613005
-----------------------------------------------------------------

Comment 40 by bugdroid1@chromium.org, Apr 3 2014

Project Member
------------------------------------------------------------------
r261432 | horo@chromium.org | 2014-04-03T16:06:48.449165Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.cc?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.cc?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.h?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.h?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=261432&r2=261431&pathrev=261432
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager_unittest.cc?r1=261432&r2=261431&pathrev=261432
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager.cc?r1=261432&r2=261431&pathrev=261432
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager.h?r1=261432&r2=261431&pathrev=261432
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/render_thread_impl.cc?r1=261432&r2=261431&pathrev=261432

Make DevTools support for the embedded SharedWorker.

Original patch is https://codereview.chromium.org/196503005/.
But it was reverted because of memory leaks.
https://codereview.chromium.org/223583002/

This is the fixed version.

BUG= 327256 

Review URL: https://codereview.chromium.org/223123003
-----------------------------------------------------------------

Comment 41 by bugdroid1@chromium.org, Apr 3 2014

Project Member
------------------------------------------------------------------
r261435 | horo@chromium.org | 2014-04-03T16:13:08.552327Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=261435&r2=261434&pathrev=261435
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.h?r1=261435&r2=261434&pathrev=261435

Make AppCache support for SharedWorker in a renderer process.

BUG= 327256 

Review URL: https://codereview.chromium.org/223163005
-----------------------------------------------------------------

Comment 42 by p...@chromium.org, Apr 14 2014

Blocking: chromium:154571

Comment 43 by bugdroid1@chromium.org, Apr 22 2014

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=172115

------------------------------------------------------------------
r172115 | horo@chromium.org | 2014-04-22T05:03:59.778260Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=172115&r2=172114&pathrev=172115
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/workers/shared-worker-lifecycle-expected.txt?r1=172115&r2=172114&pathrev=172115

Changes the expectations of shared-worker-lifecycle.html layout test.

Expectations changes due to switiching to In-renderer Shared Worker.
After https://codereview.chromium.org/240843002/ is landed, I will remove the added line in TestExpectations.

BUG= 327256 

Review URL: https://codereview.chromium.org/245973004
-----------------------------------------------------------------

Comment 45 by bugdroid1@chromium.org, Apr 24 2014

Project Member
Labels: merge-merged-git-svn
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41834881d87ff12221f866b45a877b0ee5a981e1

commit 41834881d87ff12221f866b45a877b0ee5a981e1
Author: horo@chromium.org <horo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu Apr 24 16:20:11 2014 +0000

Introduce WorkerStoragePartitionId and use it in SharedWorkerInstance.

WorkerStoragePartitionId can be used to identify each WorkerStoragePartitions.
We can hold WorkerStoragePartitionId without extending the lifetime of all objects in the WorkerStoragePartition.

BUG= 366182 , 327256 

Review URL: https://codereview.chromium.org/258513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265930 0039d316-1c4b-4281-b951-d872f2087c98

Comment 46 by bugdroid1@chromium.org, Apr 24 2014

Project Member
------------------------------------------------------------------
r265930 | horo@chromium.org | 2014-04-24T16:20:11.361919Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance_unittest.cc?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.h?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.cc?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/shared_worker_devtools_manager_unittest.cc?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_message_filter.cc?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_storage_partition.cc?r1=265930&r2=265929&pathrev=265930
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_storage_partition.h?r1=265930&r2=265929&pathrev=265930

Introduce WorkerStoragePartitionId and use it in SharedWorkerInstance.

WorkerStoragePartitionId can be used to identify each WorkerStoragePartitions.
We can hold WorkerStoragePartitionId without extending the lifetime of all objects in the WorkerStoragePartition.

BUG= 366182 , 327256 

Review URL: https://codereview.chromium.org/258513002
-----------------------------------------------------------------

Comment 47 by bugdroid1@chromium.org, Apr 26 2014

Project Member
------------------------------------------------------------------
r266389 | horo@chromium.org | 2014-04-26T22:34:39.730883Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=266389&r2=266388&pathrev=266389

Adds SharedWorker related UMAs to histograms.xml.

I add the followings to histograms.xml.
  SharedWorker.RendererSurviveForWorkerTime
  SharedWorker.TimeToDeleted
  SharedWorker.TimeToScriptLoaded
  SharedWorker.TimeToScriptLoadFailed

They were introduced in http://crrev.com/259790 and http://crrev.com/260376.

BUG= 327256 

Review URL: https://codereview.chromium.org/245963004
-----------------------------------------------------------------

Comment 48 by bugdroid1@chromium.org, Apr 26 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e96139b946f532c1393cf358df051a774c52f2

commit f4e96139b946f532c1393cf358df051a774c52f2
Author: horo@chromium.org <horo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat Apr 26 22:34:39 2014 +0000

Adds SharedWorker related UMAs to histograms.xml.

I add the followings to histograms.xml.
  SharedWorker.RendererSurviveForWorkerTime
  SharedWorker.TimeToDeleted
  SharedWorker.TimeToScriptLoaded
  SharedWorker.TimeToScriptLoadFailed

They were introduced in http://crrev.com/259790 and http://crrev.com/260376.

BUG= 327256 

Review URL: https://codereview.chromium.org/245963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266389 0039d316-1c4b-4281-b951-d872f2087c98

Comment 49 by bugdroid1@chromium.org, Jun 9 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdd3d42ccd900945c04726469bb4ce30b07129e7

commit bdd3d42ccd900945c04726469bb4ce30b07129e7
Author: horo@chromium.org <horo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Jun 09 05:00:59 2014

Implement EmbeddedSharedWorkerPermissionClientProxy.

embedded_shared_worker_permission_client_proxy.* are copied from shared_worker_permission_client_proxy.* in content/worker/.
I will delete the directory when we will stop using worker process.

BUG= 327256 

Review URL: https://codereview.chromium.org/318013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275768 0039d316-1c4b-4281-b951-d872f2087c98

Comment 50 by bugdroid1@chromium.org, Jun 9 2014

Project Member
------------------------------------------------------------------
r275768 | horo@chromium.org | 2014-06-09T05:00:59.861697Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_renderer.gypi?r1=275768&r2=275767&pathrev=275768
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_permission_client_proxy.cc?r1=275768&r2=275767&pathrev=275768
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_permission_client_proxy.h?r1=275768&r2=275767&pathrev=275768
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/shared_worker/embedded_shared_worker_stub.cc?r1=275768&r2=275767&pathrev=275768

Implement EmbeddedSharedWorkerPermissionClientProxy.

embedded_shared_worker_permission_client_proxy.* are copied from shared_worker_permission_client_proxy.* in content/worker/.
I will delete the directory when we will stop using worker process.

BUG= 327256 

Review URL: https://codereview.chromium.org/318013002
-----------------------------------------------------------------

Comment 51 by bugdroid1@chromium.org, Jul 25 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f17a7bb8f2c9e1a93cb37cd7efbe811f2504127f

commit f17a7bb8f2c9e1a93cb37cd7efbe811f2504127f
Author: horo@chromium.org <horo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Jul 25 07:37:46 2014

Remove disable-embedded-shared-worker flag and shared worker process related codes.

BUG= 327256 

Review URL: https://codereview.chromium.org/411283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285521 0039d316-1c4b-4281-b951-d872f2087c98

Comment 52 by bugdroid1@chromium.org, Jul 25 2014

Project Member
------------------------------------------------------------------
r285521 | horo@chromium.org | 2014-07-25T07:37:46.423700Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_message_filter.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=285521&r2=285520&pathrev=285521
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/worker_browsertest.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/test/OWNERS?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/OWNERS?r1=285521&r2=285520&pathrev=285521
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/worker_document_set.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/loader/resource_dispatcher_host_impl.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworker_stub.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/resource_request_details.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/process_type.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_thread.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/devtools/devtools_targets_ui.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_webkitplatformsupport_impl.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/about_flags.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/shell/app_shell.gyp?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/shared_worker_permission_client_proxy.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_tests.gypi?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/shared_worker_permission_client_proxy.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/loader/resource_dispatcher_host_unittest.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/OWNERS?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/performance_monitor/process_metrics_history.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main_runner.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_message_filter.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_instance_unittest.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_webapplicationcachehost_impl.cc?r1=285521&r2=285520&pathrev=285521
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/worker_storage_partition.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_message_filter.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/embedded_worker_devtools_manager_unittest.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_message_filter.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/worker_resource_provider.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/BUILD.gn?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/profiler_metrics_provider.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/DEPS?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_shell.gypi?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/child_process_resource_provider.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/loader/resource_request_info_impl.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/shell/BUILD.gn?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_main.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/process_type.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/BUILD.gn?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/worker_service.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/test/BUILD.gn?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_service_impl.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_service_impl.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworkerclient_proxy.cc?r1=285521&r2=285520&pathrev=285521
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/worker_storage_partition.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_webapplicationcachehost_impl.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworkerclient_proxy.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_document_set.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_thread.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/worker_resource_provider.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_document_set.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/embedded_worker_devtools_manager.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager/task_manager.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_host.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl_unittest.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/shared_worker_service_impl.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_message_filter.cc?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_message_filter.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/websharedworker_stub.h?r1=285521&r2=285520&pathrev=285521
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/shared_worker/worker_document_set.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/worker_devtools_manager.h?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/worker_webkitplatformsupport_impl.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_storage_partition.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_storage_partition.h?r1=285521&r2=285520&pathrev=285521
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content.gyp?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/test/worker_browsertest.cc?r1=285521&r2=285520&pathrev=285521
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/content_worker.gypi?r1=285521&r2=285520&pathrev=285521

Remove disable-embedded-shared-worker flag and shared worker process related codes.

BUG= 327256 

Review URL: https://codereview.chromium.org/411283002
-----------------------------------------------------------------

Comment 53 by bugdroid1@chromium.org, Aug 12 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf23ff1fad227d8d4606158f6829a728e566024

commit eaf23ff1fad227d8d4606158f6829a728e566024
Author: horo@chromium.org <horo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Tue Aug 12 00:13:08 2014

Remove shared worker process related codes.

This CL removes
- switches::kWorkerProcess
- SANDBOX_TYPE_WORKER
- IDR_WORKER_SANDBOX_PROFILE

BUG= 327256 

Review URL: https://codereview.chromium.org/449333002

Cr-Commit-Position: refs/heads/master@{#288836}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288836 0039d316-1c4b-4281-b951-d872f2087c98

Comment 54 by bugdroid1@chromium.org, Aug 12 2014

Project Member
------------------------------------------------------------------
r288836 | horo@chromium.org | 2014-08-12T00:13:08.189392Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_linux/sandbox_linux.cc?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/sandbox_type_mac.h?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_init_mac.cc?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.cc?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/sandbox_mac.mm?r1=288836&r2=288835&pathrev=288836
   D http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker.sb?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_resources.grd?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/common/content_switches.h?r1=288836&r2=288835&pathrev=288836
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_main_delegate.cc?r1=288836&r2=288835&pathrev=288836

Remove shared worker process related codes.

This CL removes
- switches::kWorkerProcess
- SANDBOX_TYPE_WORKER
- IDR_WORKER_SANDBOX_PROFILE

BUG= 327256 

Review URL: https://codereview.chromium.org/449333002
-----------------------------------------------------------------

Comment 55 by horo@chromium.org, Aug 12 2014

Status: Fixed

Comment 56 by bugdroid1@chromium.org, Aug 16 2014

Project Member
------------------------------------------------------------------
r290139 | horo@chromium.org | 2014-08-16T08:33:51.886154Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/url_request_util.cc?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.cc?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.cc?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/content_browser_client.h?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client.h?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/info_map.cc?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/extensions/browser/info_map.h?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_content_browser_client.cc?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/chrome_content_browser_client_extensions_part.h?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/android_webview/browser/aw_content_browser_client.h?r1=290139&r2=290138&pathrev=290139
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_content_browser_client_parts.h?r1=290139&r2=290138&pathrev=290139

Remove worker process related codes from ContentBrowserClient.

BUG= 327256 

Review URL: https://codereview.chromium.org/468033002
-----------------------------------------------------------------

Comment 57 by bugdroid1@chromium.org, Aug 16 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23935931099331549af21fdb4d3cb942d473537c

commit 23935931099331549af21fdb4d3cb942d473537c
Author: horo@chromium.org <horo@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat Aug 16 08:33:51 2014

Remove worker process related codes from ContentBrowserClient.

BUG= 327256 

Review URL: https://codereview.chromium.org/468033002

Cr-Commit-Position: refs/heads/master@{#290139}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290139 0039d316-1c4b-4281-b951-d872f2087c98

Comment 58 by bugdroid1@chromium.org, Jun 29 2015

Project Member
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=197956

------------------------------------------------------------------
r197956 | wangxianzhu@google.com | 2015-06-29T02:44:33.688425Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=197956&r2=197955&pathrev=197956

Cleanup test expectations pointing to Fixed bugs

BUG= 237270 , 321787 , 335710 , 392626 , 327256 , 371654 , 361729 , 392762 , 460335 
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1217543003.
-----------------------------------------------------------------

Sign in to add a comment