New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2010
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 0
Type: Bug
M-5

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 32627: Chrome crash: CookiesTreeModel::DeleteCookieNode(CookieTreeNode*) + 0x0 (cookies_tree_model.cc:279)

Reported by rohi...@chromium.org, Jan 19 2010 Project Member

Issue description

Platform:
  Hostname: macintosh-0016cba58019.local
  Mac OS X Version 10.6.3 (Build 10D522)
  Processor: 1 Intel 1.50 GHz
  RAM: 1024 MB

Chrome:
  Chrome version: 4.0.302.0 r36504  <<<Release>>>
  QuickTime Player: 7.6.3
  QuickTime PlayerX: 103
  Flash Player: 10.0.32.18


What steps will reproduce the problem?
1. Go Chrome-->Preferences-->Under the hood->"Show cookies and website permissions"
2. Expand any cookie site entry.
3. Delete all cookie one by one. When there is no cookie left, click on 'Remove' button.

Expected result:
3.1 'Remove' button is disabled when there are no cookie sub-elements.

Actual result:
3.2 'Remove' button is enabled, clicking it, Chrome crashes.

Thread 0 (crashed)
 0 Google Chrome Framew0.302.0.0            0x00195971 CookiesTreeModel::DeleteCookieNode(CookieTreeNode*) + 0x0 (cookies_tree_model.cc:279)
 1 Google Chrome Framew0.302.0.0            0x00144e4c -[CookiesWindowController deleteCookie:] + 0xe (cookies_window_controller.mm:195)
 2 AppKit              0.1038.27.0          0x97780591 -[NSApplication sendAction:to:from:] + 0x6f
 3 Google Chrome Framew0.302.0.0            0x00112d33 -[BrowserCrApplication sendAction:to:from:] + 0x3b (chrome_browser_application_mac.mm:261)
 4 AppKit              0.1038.27.0          0x9785fd20 -[NSControl sendAction:to:] + 0x6b
 5 AppKit              0.1038.27.0          0x9785b7d1 -[NSCell _sendActionFrom:] + 0xa8
 6 AppKit              0.1038.27.0          0x9785aac8 -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 0x70f
 7 AppKit              0.1038.27.0          0x978b00fc -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] + 0x20b
 8 AppKit              0.1038.27.0          0x9785951e -[NSControl mouseDown:] + 0x32b
 9 AppKit              0.1038.27.0          0x97857527 -[NSWindow sendEvent:] + 0x15ac
10 AppKit              0.1038.27.0          0x97770176 -[NSApplication sendEvent:] + 0x191e
11 Google Chrome Framew0.302.0.0            0x0055948b -[CrApplication sendEvent:] + 0x2d (chrome_application_mac.mm:33)
12 AppKit              0.1038.27.0          0x97703c42 -[NSApplication run] + 0x394
13 Google Chrome Framew0.302.0.0            0x0054935c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 0x19 
(message_pump_mac.mm:677)
14 Google Chrome Framew0.302.0.0            0x00548ae5 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 0xb 
(message_pump_mac.mm:213)
15 Google Chrome Framew0.302.0.0            0x0056d1e3 MessageLoop::Run() + 0xb (message_loop.cc:205)
16 Google Chrome Framew0.302.0.0            0x000f35c2 BrowserMain(MainFunctionParams const&) + 0x7 (browser_main.cc:163)
17 Google Chrome Framew0.302.0.0            0x00009dda ChromeMain + 0xd (chrome_dll_main.cc:748)
18 Google Chrome                            0x00001fc5 
19
 
crash_report.txt
32.8 KB View Download

Comment 1 by mikesmith@chromium.org, Jan 20 2010

Labels: Mstone-5 ReleaseBlock-Beta
Status: Assigned

Comment 2 by mark@chromium.org, Jan 20 2010

Labels: Pri-0
This is an M5-targeted crasher.  We'd like a near-term fix for this for the 
immediate-future beta (meaning P0 meaning "now.")  Please let us know if you 
think that a fix is at risk.

Comment 3 by mikesmith@chromium.org, Jan 20 2010

Marking as Pri 0 as crashing and should hit current beta.

Comment 4 by mikesmith@chromium.org, Jan 20 2010

Labels: ForMerge

Comment 5 by rsesek@chromium.org, Jan 21 2010

Status: Started

Comment 6 by rsesek@chromium.org, Jan 21 2010

Status: Fixed
Committed to trunk http://src.chromium.org/viewvc/chrome?
view=rev&revision=36796.

Comment 7 by rsesek@chromium.org, Jan 21 2010

Note that this will not merge cleanly to the branch. The localization patch for  issue 32338  went in before this at r36766, which made significant XIB changes. Normally it'd 
be fine to merge that too, but that CL also had to roll GTM.

Comment 9 by bugdro...@gmail.com, Jan 22 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36796 

------------------------------------------------------------------------
r36796 | rsesek@chromium.org | 2010-01-21 14:04:23 -0800 (Thu, 21 Jan 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Cookies.xib?r1=36796&r2=36795
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller.h?r1=36796&r2=36795
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller.mm?r1=36796&r2=36795
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm?r1=36796&r2=36795

[Mac] Fix a crash in the cookies manager that was caused by an invalid selection.

XIB change: Change the "Remove" button's |enabled| binding from just looking at
the count of the selection to FilesOwner.removeButtonEnabled.

BUG= 32627 
TEST=Covered by unit tests.
TEST=Open cookies manager. Select one item, make sure "Remove" is enabled.
TEST=Open cookies manager. Try to select two items. You shouldn't be able to.

Review URL: http://codereview.chromium.org/546102
------------------------------------------------------------------------

Comment 10 by bugdro...@gmail.com, Jan 22 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36823 

------------------------------------------------------------------------
r36823 | rsesek@chromium.org | 2010-01-21 16:57:53 -0800 (Thu, 21 Jan 2010) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/302/src/chrome/app/nibs/Cookies.xib?r1=36823&r2=36822
   M http://src.chromium.org/viewvc/chrome/branches/302/src/chrome/browser/cocoa/cookies_window_controller.h?r1=36823&r2=36822
   M http://src.chromium.org/viewvc/chrome/branches/302/src/chrome/browser/cocoa/cookies_window_controller.mm?r1=36823&r2=36822
   M http://src.chromium.org/viewvc/chrome/branches/302/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm?r1=36823&r2=36822

Merge 36796 - [Mac] Fix a crash in the cookies manager that was caused by an invalid selection.

XIB change: Change the "Remove" button's |enabled| binding from just looking at
the count of the selection to FilesOwner.removeButtonEnabled.

BUG= 32627 
TEST=Covered by unit tests.
TEST=Open cookies manager. Select one item, make sure "Remove" is enabled.
TEST=Open cookies manager. Try to select two items. You shouldn't be able to.

Review URL: http://codereview.chromium.org/546102

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/543163
------------------------------------------------------------------------

Comment 11 by ismail@chromium.org, Jan 25 2010

Status: Verified
Platform:
  Hostname: testings-macbook-pro-15.local
  Mac OS X Version 10.6.2 (Build 10C540)
  Processor: 2 Intel 2.33 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 4.0.302.3 r36935  <<<Release>>>
  QuickTime Player: <unknown>
  QuickTime PlayerX: 90.3.1
  Flash Player: 10.0.42.34

Comment 12 by mal.chro...@gmail.com, Feb 15 2010

Labels: -formerge
removing formerge label from verified bugs.

Comment 13 by lafo...@chromium.org, Mar 19 2011

Labels: -Crash bulkmove Stability-Crash
Platform:
  Hostname: macintosh-0016cba58019.local
  Mac OS X Version 10.6.3 (Build 10D522)
  Processor: 1 Intel 1.50 GHz
  RAM: 1024 MB

Chrome:
  Chrome version: 4.0.302.0 r36504  &lt;&lt;&lt;Release&gt;&gt;&gt;
  QuickTime Player: 7.6.3
  QuickTime PlayerX: 103
  Flash Player: 10.0.32.18


What steps will reproduce the problem?
1. Go Chrome--&gt;Preferences--&gt;Under the hood-&gt;&quot;Show cookies and website permissions&quot;
2. Expand any cookie site entry.
3. Delete all cookie one by one. When there is no cookie left, click on 'Remove' button.

Expected result:
3.1 'Remove' button is disabled when there are no cookie sub-elements.

Actual result:
3.2 'Remove' button is enabled, clicking it, Chrome crashes.

Thread 0 (crashed)
 0 Google Chrome Framew0.302.0.0            0x00195971 CookiesTreeModel::DeleteCookieNode(CookieTreeNode*) + 0x0 (cookies_tree_model.cc:279)
 1 Google Chrome Framew0.302.0.0            0x00144e4c -[CookiesWindowController deleteCookie:] + 0xe (cookies_window_controller.mm:195)
 2 AppKit              0.1038.27.0          0x97780591 -[NSApplication sendAction:to:from:] + 0x6f
 3 Google Chrome Framew0.302.0.0            0x00112d33 -[BrowserCrApplication sendAction:to:from:] + 0x3b (chrome_browser_application_mac.mm:261)
 4 AppKit              0.1038.27.0          0x9785fd20 -[NSControl sendAction:to:] + 0x6b
 5 AppKit              0.1038.27.0          0x9785b7d1 -[NSCell _sendActionFrom:] + 0xa8
 6 AppKit              0.1038.27.0          0x9785aac8 -[NSCell trackMouse:inRect:ofView:untilMouseUp:] + 0x70f
 7 AppKit              0.1038.27.0          0x978b00fc -[NSButtonCell trackMouse:inRect:ofView:untilMouseUp:] + 0x20b
 8 AppKit              0.1038.27.0          0x9785951e -[NSControl mouseDown:] + 0x32b
 9 AppKit              0.1038.27.0          0x97857527 -[NSWindow sendEvent:] + 0x15ac
10 AppKit              0.1038.27.0          0x97770176 -[NSApplication sendEvent:] + 0x191e
11 Google Chrome Framew0.302.0.0            0x0055948b -[CrApplication sendEvent:] + 0x2d (chrome_application_mac.mm:33)
12 AppKit              0.1038.27.0          0x97703c42 -[NSApplication run] + 0x394
13 Google Chrome Framew0.302.0.0            0x0054935c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 0x19 
(message_pump_mac.mm:677)
14 Google Chrome Framew0.302.0.0            0x00548ae5 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 0xb 
(message_pump_mac.mm:213)
15 Google Chrome Framew0.302.0.0            0x0056d1e3 MessageLoop::Run() + 0xb (message_loop.cc:205)
16 Google Chrome Framew0.302.0.0            0x000f35c2 BrowserMain(MainFunctionParams const&amp;) + 0x7 (browser_main.cc:163)
17 Google Chrome Framew0.302.0.0            0x00009dda ChromeMain + 0xd (chrome_dll_main.cc:748)
18 Google Chrome                            0x00001fc5 
19

Comment 14 by bugdroid1@chromium.org, Oct 13 2012

Project Member
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Comment 15 by bugdroid1@chromium.org, Mar 10 2013

Project Member
Labels: -Mstone-5 M-5

Comment 16 by bugdroid1@chromium.org, Mar 11 2013

Project Member
Labels: -Area-Undefined

Comment 17 by bugdroid1@chromium.org, Mar 13 2013

Project Member
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment