New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Expose whether the input is a search, url, tel, etc.

Project Member Reported by faulkner...@gmail.com, Nov 25 2013

Issue description

Version: 31
OS: windows 8

What steps will reproduce the problem?
1. go to http://www.html5accessibility.com/tests/form-test.html
2. check the email/url/tel etc inputs
3. input type info not exposed in IA2

What is the expected output? 
see Mozilla implementation bug https://bugzilla.mozilla.org/show_bug.cgi?id=924896

Please use labels and text to provide additional information.

 
@dominic: Is anyone looking into this issue?
No, please feel free to implement this.

We should expose the input type in Blink, add it as a new string attribute in ax_enums.idl and then map it to the IA2 attribute on Windows.

Please also refactor BrowserAccessibilityAndroid::AndroidInputType() to implement this the correct way. We shouldn't have done it by checking the html attribute directly in content/browser code; that check should be abstracted away in Blink.

Thanks.

I'm looking on this from 2 weeks ago.
Here is WIP.
https://codereview.chromium.org/559343002/
And I'll update it today.
Sorry about that. I should have commented here.
Status: Assigned
ok. Sure. You can continue.

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4

commit 91d4e092d3a07e46ad55062dc0883071b3fe47e4
Author: je_julie.kim <je_julie.kim@samsung.com>
Date: Fri Oct 03 07:13:59 2014

Add AX attribute conversion for input type

Exposed input type for tel, search, url and email on mac and windows.
The Related CL:
https://codereview.chromium.org/596393004/

BUG= 323161 

Review URL: https://codereview.chromium.org/559343002

Cr-Commit-Position: refs/heads/master@{#298008}

[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/browser/accessibility/browser_accessibility_win.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/renderer/accessibility/blink_ax_tree_source.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/test/data/accessibility/input-types-expected-android.txt
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/test/data/accessibility/input-types-expected-mac.txt
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/test/data/accessibility/input-types-expected-win.txt
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/content/test/data/accessibility/input-types.html
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/ui/accessibility/ax_enums.idl
[modify] https://chromium.googlesource.com/chromium/src.git/+/91d4e092d3a07e46ad55062dc0883071b3fe47e4/ui/accessibility/ax_node_data.cc

Is this fixed or is more work needed?

It's done with two patches above. If there is any problem, please let me know.
Thanks,
Status: Fixed

Sign in to add a comment