Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 314678 asan: directly report asan errors in system daemons
Starred by 2 users Project Member Reported by quiche@chromium.org, Nov 4 2013 Back to list
Status: Verified
Owner: yunlian@chromium.org
Closed: Mar 2014
Cc: dkrahn@chromium.org, vapier@chromium.org
OS: Chrome
Pri: 2
Type: Bug


Sign in to add a comment
In crosreview.com/38024, glotov@ directed chrome asan logs to a location in /var/log, and updated cbuildbot_commands to look for asan errors there. This provided the benefit of reporting asan errors even if they didn't cause an autotest to fail.

We should generalize this for system daemons (e.g. shill, debugd). That's because system daemons are designed to restart and recover automatically. So it's possible for autotests to pass even if asan finds a bug in a system daemon.
 
Labels: Gardening
Cc: dkrahn@chromium.org
@dkrahn: this is somewhat related to one of your requests.
Comment 3 by vapier@chromium.org, Nov 11 2013
Cc: vapier@chromium.org
Owner: yunlian@chromium.org
yunlian was investigating this already.  the last e-mail he sent stated:
This is a work around at clang side. We can patch clang to set the default log_path to some other location.

Comment 4 by vapier@chromium.org, Nov 11 2013
Blocking: chromium:317919
Comment 5 by dkrahn@chromium.org, Nov 14 2013
Blocking: chromium:314293
Project Member Comment 6 by bugdroid1@chromium.org, Dec 14 2013
Project: chromiumos/overlays/chromiumos-overlay
Branch : master
Author : Yunlian Jiang <yunlian@google.com>
Commit : 619c4b14821488bc4c5106303b92c2d18ba35c8c

Code-Review  0 : Ahmad Sharif, Bhaskar Janakiraman, Caroline Tice, Han Shen, Luis Lozano, Simon Que, Yunlian Jiang, chrome-internal-fetch
Code-Review  +2: Mike Frysinger
Commit-Queue 0 : Ahmad Sharif, Bhaskar Janakiraman, Caroline Tice, Han Shen, Luis Lozano, Mike Frysinger, Simon Que, chrome-internal-fetch
Commit-Queue +1: Yunlian Jiang
Verified     0 : Ahmad Sharif, Bhaskar Janakiraman, Caroline Tice, Han Shen, Luis Lozano, Mike Frysinger, Simon Que, chrome-internal-fetch
Verified     +1: Yunlian Jiang
Change-Id      : I7541202b1c2266e9d510709c718b0197f2f73d34
Reviewed-at    : https://chromium-review.googlesource.com/177947

clang: change asan default output path.

BUG=chromium:314678
TEST=the asan output now goes to /var/log/asan*.log

sys-devel/clang/clang-3.4_pre188423-r1.ebuild
sys-devel/clang/files/clang-3.4-asan-default-path.patch
Status: Fixed
I think this bug was fixed by the CL in #c6.
Comment 8 by krisr@chromium.org, Mar 4 2014
Status: Verified
Sign in to add a comment