New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2013
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment
Use TextTrackMode and TextTrackKind enums in TextTrack IDL
Reported by phil...@opera.com, Oct 31 2013 Back to list
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#texttrackmode

This will make the IDL align better with the spec and allows some checking to be done by the IDL code generator instead.
 
Comment 1 by gl...@skynav.com, Oct 31 2013
Keep in mind that an attempt to set an enum typed member to an undefined value is ignored per the WebIDL spec, and the generator implements that policy without invoking the binding side setter. So if anything, there is less checking performed when going to enums.
Comment 2 by phil...@opera.com, Oct 31 2013
Status: Fixed
Fixed by https://codereview.chromium.org/52593009/

I compared the generated code before and after and adjusted the handling of invalid input to match.
Project Member Comment 3 by bugdroid1@chromium.org, Oct 31 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=161055

------------------------------------------------------------------------
r161055 | philipj@opera.com | 2013-10-31T12:58:55.034843Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.cpp?r1=161055&r2=161054&pathrev=161055
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.idl?r1=161055&r2=161054&pathrev=161055

Use TextTrackMode and TextTrackKind enums in TextTrack IDL

The generated code (modeAttributeSetter in V8TextTrack.cpp) now
checks that the string is one of the three allowed values, so we
can just assert it internally.

Also fiddle a bit with the IDL to make it match the spec order.

BUG= 313602 

Review URL: https://codereview.chromium.org/52593009
------------------------------------------------------------------------
Comment 4 by phil...@opera.com, Oct 31 2013
Labels: Cr-Blink-Text-Track
Comment 5 by sshru...@google.com, May 23 2016
Components: -Blink>Text>Track Blink>Media>Track
Renamed Blink>Text>Track to Blink>Media>Track. Moving these bugs to the new component.
Sign in to add a comment