New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 31043 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2010
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Blacklist certain destinations for accidental search infobar

Project Member Reported by pkasting@chromium.org, Dec 23 2009

Issue description

Per evan's email.  Comcast is apparently returning a 302 to a valid page at 
*.comcast.com on every one-word query.
 
Verizon also does does for Fios customers.
 Issue 18942  has been merged into this issue.
verizon.net too.  Argh
Status: Started
Summary: Blacklist certain destinations for accidental search infobar
And opendns.com
Status: Fixed
Fixed in r35493.  Will file a bug for the longer-term fix.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35493 

------------------------------------------------------------------------
r35493 | pkasting@chromium.org | 2010-01-04 15:36:11 -0800 (Mon, 04 Jan 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=35493&r2=35492

Blacklist particular TLD+1s for accidental search infobars, to avoid showing the user an infobar on all kinds of searches.

BUG= 31043 
TEST=Legit intranet sites should still produce infobars.  Search terms which previously generated infobars on Comcast/Verizon should not.
Review URL: http://codereview.chromium.org/523043
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35540 

------------------------------------------------------------------------
r35540 | pkasting@chromium.org | 2010-01-05 10:50:15 -0800 (Tue, 05 Jan 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=35540&r2=35539

I forgot that GURL doesn't do fixup.

BUG= 31043 
TEST=none
Review URL: http://codereview.chromium.org/521026
------------------------------------------------------------------------

Comment 9 by bugdro...@gmail.com, Jan 11 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35920 

------------------------------------------------------------------------
r35920 | pkasting@chromium.org | 2010-01-11 10:54:55 -0800 (Mon, 11 Jan 2010) | 24 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/alternate_nav_url_fetcher.cc?r1=35920&r2=35919

Merge the intranet redirect blacklist to 249.  Contains the following two changes:

===

Blacklist particular TLD+1s for accidental search infobars, to avoid showing the user an infobar on all kinds of searches.

BUG= 31043 
TEST=Legit intranet sites should still produce infobars.  Search terms which previously generated infobars on Comcast/Verizon should not.
Review URL: http://codereview.chromium.org/523043

===

I forgot that GURL doesn't do fixup.

BUG= 31043 
TEST=none
Review URL: http://codereview.chromium.org/521026

===

TBR=laforge
BUG= 31043 
Test=See above
Review URL: http://codereview.chromium.org/545012
------------------------------------------------------------------------

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-Omnibox -Mstone-4 Cr-UI-Browser-Omnibox M-4
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment