Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 309197 Switch to VS2013
Starred by 30 users Project Member Reported by scot...@chromium.org, Oct 18 2013 Back to list
VS2013 offers:
- Better C99 support (avoids slow c99->c89 conversion step for ffmpeg)
- Better C++11 support
- Faster IDE
- amd64_x86 toolchain (should alleviate memory limitations during official links)
- security enhancements (VTGuard)

We should investigate switching to it.

Potential gotchas:
- chrome doesn't compile yet
- misc bot/infrastructure work
- codegen bugs (PGO is known to crash on chrome in the RTM release)
- complexity in targeting XP


 
Blockedon: chromium:309200
Blockedon: chromium:297971
Blockedon: chromium:309854
Blockedon: -chromium:309854 chromium:309845
Blockedon: chromium:309849
Blockedon: chromium:317004
Cc: jsc...@chromium.org
Project Member Comment 7 by bugdroid1@chromium.org, Nov 11 2013
------------------------------------------------------------------------
r234244 | scottmg@chromium.org | 2013-11-11T18:33:11.683171Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/tools/win/toolchain/toolchain2013.py?r1=234244&r2=234243&pathrev=234244

First pass at automated vs2013 toolchain script

d:\src>python cr\src\tools\win\toolchain\toolchain2013.py
...
d:\src>d:\src\win_toolchain_2013\env
...
d:\src>cd cr\src
d:\src\cr\src>gclient runhooks
...
d:\src\cr\src>ninja -C out\Debug chrome

Can also pass --express to toolchain2013.py for Express toolchain.

BUG= 309197 
R=zturner@chromium.org

Review URL: https://codereview.chromium.org/66263002
------------------------------------------------------------------------
Project Member Comment 8 by bugdroid1@chromium.org, Nov 11 2013
------------------------------------------------------------------------
r234313 | scottmg@chromium.org | 2013-11-11T23:28:17.325205Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=234313&r2=234312&pathrev=234313

roll ffmpeg to 234251/0889dce

TBR=dalecurtis@chromium.org
BUG= 315109 , 309197 

Review URL: https://codereview.chromium.org/66303008
------------------------------------------------------------------------
Project Member Comment 9 by bugdroid1@chromium.org, Nov 12 2013
------------------------------------------------------------------------
r234417 | scottmg@chromium.org | 2013-11-12T05:26:48.786814Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/win/toolchain/toolchain2013.py?r1=234417&r2=234416&pathrev=234417

don't use VS subdir for 2013 toolchain builder

Was causing some problems with $(VCInstallDir) in gyp files, just put
it in the root of the toolchain, the same as the 2010 script.

R=cpu@chromium.org
TBR=cpu@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/69383003
------------------------------------------------------------------------
Blockedon: chromium:318016
Project Member Comment 11 by bugdroid1@chromium.org, Nov 12 2013
------------------------------------------------------------------------
r234439 | scottmg@chromium.org | 2013-11-12T06:47:10.518238Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_tab.cc?r1=234439&r2=234438&pathrev=234439

Don't use UpdateRegistryFromResourceS as it's not in 2013

ATL version that ships with 2013 doesn't have a suffix. 
UpdateRegistryFromResource used to select either an S or
a D suffix based on the value of _ATL_STATIC_REGISTRY,
however in ATL 12 (vs2013), UpdateRegistryFromResource
now just means UpdateRegistryFromResourceS, and
UpdateRegistryFromResourceD is separate.

We want to keep building with 2010 and 2013, so #if based
on _ATL_VER.

R=ananta@chromium.org, robertshield@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/66583008
------------------------------------------------------------------------
Project Member Comment 12 by bugdroid1@chromium.org, Nov 12 2013
------------------------------------------------------------------------
r234656 | scottmg@chromium.org | 2013-11-12T22:44:39.949084Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?r1=234656&r2=234655&pathrev=234656

Set TargetMachine for libs too

In VS2013, remoting_host_event_logger.lib fails with:

FAILED: E:\b\depot_tools\python_bin\python.exe gyp-win-tool link-wrapper environment.x86 lib.exe /nologo /ignore:4221 /OUT:obj\remoting\remoting_host_event_logger.lib @obj\remoting\remoting_host_event_logger.lib.rsp
LINK : warning LNK4068: /MACHINE not specified; defaulting to X64

obj\remoting\host\remoting_host_event_logger.host_event_logger_win.obj : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64'

This is because if unspecified, lib.exe chooses the target architecture
based on the first input file. In this lib, the first file (there's only
2) happens to be a .res compiled from a .rc, which doesn't have an
architecture. Because we use the amd64 toolchain, lib decides to guess
that it should use x64. This fails to lib because the other .cc input is
x86.

After adding support for setting the architecture for libs in gyp here
https://codereview.chromium.org/68133006/ this sets it explicitly on our
libs too.

R=cpu@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/61893020
------------------------------------------------------------------------
Blockedon: chromium:318952
Blockedon: chromium:303291
Project Member Comment 15 by bugdroid1@chromium.org, Nov 14 2013
------------------------------------------------------------------------
r234981 | scottmg@chromium.org | 2013-11-14T00:35:23.273453Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/chrome_tab.cc?r1=234981&r2=234980&pathrev=234981

Fix compilation on 2013 debug due to ATL changes

Fixes http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20VS2013%20%28dbg%29/builds/101/steps/compile/logs/stdio

R=robertshield@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/71963002
------------------------------------------------------------------------
Blockedon: chromium:320371
Blockedon: chromium:321187
Blockedon: chromium:323300
I just confirmed that linking chrome.dll (in chrome_multiple_dll=0) and interactive_ui_tests.exe both work fine in Debug with the cross x64 toolchain, which is nice to know.

The private bytes are up in the 6G range, I shudder to think how LTCG would look.

The pdbs is also 1.6G which could eventually be problematic as the IDE, etc. are still x86. Hopefully the internal limit for those is at least 4G, not 2G.
Cc: sebmarchand@chromium.org
Blockedon: chromium:324350
Labels: vs2013
Cc: dpranke@chromium.org
Blocking: chromium:328981
Blockedon: chromium:330051
Blockedon: chromium:330435
Out of curiosity, are we planning to convert back to a single chrome.dll after this switch, or leave as two DLLs?  (I don't know what the overall impact of the DLL split is at this point.)
Comment 28 by cpu@chromium.org, Dec 30 2013
pkasting, we are not sure. Darin has stated that the division enforces architectural boundaries and certainly the work done splitting drove some nice cleaning up of the code. Also the two dlls mode allows to optimize one for speed and the other for size for example.

On the other hand the single dll fully optimized might be superior at least in terms of overall performance.

Question is who is going to spend cycles doing all the legwork.
Comment 29 by cmp@chromium.org, Jan 2 2014
Cc: cmp@chromium.org
Labels: Infra
The DLL split also allowed SyzyASAN to be shipped to Canary, as it was too slow when the renderer code was ASAN'd, but usable when it was only on the browser code.

I plan to test PGO once VS2013 Update 1 comes out to get some data on how the split affects both compile time and runtime performance.
Blocking: chromium:330432
Project Member Comment 32 by bugdroid1@chromium.org, Jan 7 2014
------------------------------------------------------------------------
r243271 | scottmg@chromium.org | 2014-01-07T12:10:50.588128Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=243271&r2=243270&pathrev=243271

roll gyp 1806:1828

r1807 win msvs: make ordering match .gyp order
r1808 Fix gyptest-app for Xcode 5.0.2
r1809 Fix gyptest-xcode-gcc.py when using Xcode 5.0.2
r1810 Fix gyptest-sdkroot when oldest SDK is >= 10.8
r1811 Fix gyptest-xcode-env-order for Xcode 5.0.0
r1812 win msvs: Make ordering of sources in subdirs match gyp order
r1813 win ninja: Refactor manifest generate and embed to be 1-pass
r1814 win ninja: default to embedding manifest to match msvs
r1815 Use gyp.common.EnsureDirExists() in more places.
r1816 Add backported OrderedDict
r1817 Fix OrderedDict path import for 2.6
r1818 Add license header to ordered_dict
r1819 xcode_emulation: work in the absence of xcodebuild OS X systems
r1820 win msvs: make mixed source/dir match gyp order
r1821 Restrict multiple codesign assert.
r1822 win ninja: add support for ForceSymbolReferences
r1823 Revert r1819 for now, it broke the mac bots.
r1824 make: Let CC_host, CXX_host env vars win over make_global_settings keys.
r1825 xcode_emulation: fix on CLT-only systems redux
r1826 _XcodeVersion: return CLT version as appropriate
r1827 Write the make_global_settings to the error message.
r1828 Silence a pylint warning.

BUG= 331082 , 309197 
TBR=thakis@chromium.org
R=thakis@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/110893009
------------------------------------------------------------------------
Project Member Comment 33 by bugdroid1@chromium.org, Jan 17 2014
------------------------------------------------------------------------
r245543 | scottmg@chromium.org | 2014-01-17T17:19:50.812430Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/all.gyp?r1=245543&r2=245542&pathrev=245543

Remove browser_tests from official builder list

interactive_ui_tests and browser_tests both now. :/

TBR=dxie@chromium.org
BUG= 330432 ,  309197 

Review URL: https://codereview.chromium.org/130433011
------------------------------------------------------------------------
Should we raise the priority of this one (and its blockers) ? We're really starting to hit the limit of the 32 bits linker (e.g. https://codereview.chromium.org/130433011)... 
Project Member Comment 35 by bugdroid1@chromium.org, Jan 17 2014
Labels: merge-merged-1791
------------------------------------------------------------------------
r245551 | dxie@chromium.org | 2014-01-17T18:02:44.575977Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1791/src/build/all.gyp?r1=245551&r2=245550&pathrev=245551

Merge 245543 "Remove browser_tests from official builder list"

> Remove browser_tests from official builder list
> 
> interactive_ui_tests and browser_tests both now. :/
> 
> TBR=dxie@chromium.org
> BUG= 330432 ,  309197 
> 
> Review URL: https://codereview.chromium.org/130433011

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/141563003
------------------------------------------------------------------------
Sure! It's not going to get done much faster though. :)

I think chrome is _relatively_ safe since the DLL split, but it is pretty bad that we can't build any of the test binaries on Official any longer.

The blockers are the failing tests are due to 318952 (which has been tracked down and is actively being worked on), and then doing the work to test and roll out. I'm going to try forcing a couple bots over to 2013 today to see what breaks.
Labels: -Pri-2 Pri-1
Cc: dxie@chromium.org
Project Member Comment 39 by bugdroid1@chromium.org, Jan 18 2014
------------------------------------------------------------------------
r245713 | scottmg@chromium.org | 2014-01-18T02:03:57.968731Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/get_landmines.py?r1=245713&r2=245712&pathrev=245713

Add landmine for 2013 switch

R=iannucci@chromium.org
BUG= 309197 ,  323300 

Review URL: https://codereview.chromium.org/141583006
------------------------------------------------------------------------
Blockedon: chromium:336542
Blockedon: chromium:336620
Blockedon: chromium:338962
I'm sadly discovering the amd64_x86 doesn't lift many of the toolchain restrictions on file formats that we've hit. In particular, .pdb and .ilk still have the same 1G/2G/4G limits (presumably for interop with the x86 IDE/tools/etc.).

Blockedon: chromium:339215
Newly blocking issue 339215 might be serious. jam@ reporting PDB errors. I suspect AV/bit9, but unproven. If we can't fix/workaround/avoid, we might not be able to upgrade to 2013 safely.
Blockedon: chromium:308740
Labels: -merge-merged-1791
Blockedon: chromium:340358
Project Member Comment 48 by bugdroid1@chromium.org, Feb 5 2014
------------------------------------------------------------------------
r249074 | scottmg@chromium.org | 2014-02-05T19:24:43.326903Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.swarm/master.cfg?r1=249074&r2=249073&pathrev=249074

Test VS2013 rollout on master.chromium.swarm.

BUG= 309197 
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/152133008
------------------------------------------------------------------------
Blockedon: chromium:341182
Project Member Comment 50 by bugdroid1@chromium.org, Feb 6 2014
------------------------------------------------------------------------
r249242 | scottmg@chromium.org | 2014-02-06T02:44:55.890647Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/get_landmines.py?r1=249242&r2=249241&pathrev=249242
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=249242&r2=249241&pathrev=249242
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=249242&r2=249241&pathrev=249242

Move landmines into gyp_chromium

This ensures that the environment that's passed to gyp is the one that
landmines.py uses to determine when to set landmines.

Also, fix '2013e' not being detected as a 2013 switch.

BUG= 309197 ,  323300 
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/153073004
------------------------------------------------------------------------
Blockedon: chromium:342064
Blockedon: chromium:342105
Blockedon: chromium:344980
Project Member Comment 54 by bugdroid1@chromium.org, Feb 22 2014
------------------------------------------------------------------------
r252733 | scottmg@chromium.org | 2014-02-22T02:41:37.443183Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=252733&r2=252732&pathrev=252733
   A http://src.chromium.org/viewvc/chrome/trunk/src/build/toolchain_vs2013.hash?r1=252733&r2=252732&pathrev=252733

Move control of updating toolchain into src/

Moved out of depot_tools here: https://codereview.chromium.org/168603004/

The control is in src/ now, but logic for de-duplication is still in depot_tools.

This changes the default, so that VS2013 will be the default toolchain.

R=iannucci@chromium.org
BUG= 323300 , 309197 

Review URL: https://codereview.chromium.org/175573004
------------------------------------------------------------------------
Project Member Comment 55 by bugdroid1@chromium.org, Feb 22 2014
Labels: merge-merged-1849
------------------------------------------------------------------------
r252734 | scottmg@chromium.org | 2014-02-22T02:49:03.513489Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1849/src/build/gyp_chromium?r1=252734&r2=252733&pathrev=252734
   A http://src.chromium.org/viewvc/chrome/branches/1849/src/build/toolchain_vs2013.hash?r1=252734&r2=252733&pathrev=252734

Merge 252733 "Move control of updating toolchain into src/"

> Move control of updating toolchain into src/
> 
> Moved out of depot_tools here: https://codereview.chromium.org/168603004/
> 
> The control is in src/ now, but logic for de-duplication is still in depot_tools.
> 
> This changes the default, so that VS2013 will be the default toolchain.
> 
> R=iannucci@chromium.org
> BUG= 323300 , 309197 
> 
> Review URL: https://codereview.chromium.org/175573004

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/175053009
------------------------------------------------------------------------
Project Member Comment 56 by bugdroid1@chromium.org, Feb 22 2014
------------------------------------------------------------------------
r252738 | scottmg@chromium.org | 2014-02-22T03:24:51.836984Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/toolchain_vs2013.hash?r1=252738&r2=252737&pathrev=252738
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=252738&r2=252737&pathrev=252738

Re-enable 2013 with corrected hashes

TBR=iannucci@chromium.org
BUG= 323300 , 309197 

Review URL: https://codereview.chromium.org/176143002
------------------------------------------------------------------------
Project Member Comment 57 by bugdroid1@chromium.org, Feb 22 2014
------------------------------------------------------------------------
r252739 | scottmg@chromium.org | 2014-02-22T03:50:02.046663Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1849/src/build/toolchain_vs2013.hash?r1=252739&r2=252738&pathrev=252739

Merge 252738 "Re-enable 2013 with corrected hashes"

> Re-enable 2013 with corrected hashes
> 
> TBR=iannucci@chromium.org
> BUG= 323300 , 309197 
> 
> Review URL: https://codereview.chromium.org/176143002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/175173007
------------------------------------------------------------------------
Blockedon: chromium:345993
Blockedon: chromium:345998
Blockedon: chromium:346034
Project Member Comment 61 by bugdroid1@chromium.org, Feb 23 2014
------------------------------------------------------------------------
r252842 | scottmg@chromium.org | 2014-02-23T05:25:21.128908Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/compile.py?r1=252842&r2=252841&pathrev=252842

Don't clobber VS runtime DLLs

These are put there during generation; seems like clobber
should happen before that.

TBR=thakis@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/176523003
------------------------------------------------------------------------
Cc: a deleted user
Blockedon: chromium:346472
Cc: -a deleted user
Blocking: chromium:346988
Blockedon: chromium:347459
Project Member Comment 66 by bugdroid1@chromium.org, Feb 28 2014
------------------------------------------------------------------------
r253993 | scottmg@chromium.org | 2014-02-28T01:23:24.443179Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=253993&r2=253992&pathrev=253993

Default to VS2013 on Windows

This switches the default toolchain on Windows to VS2013.

TBR=cpu@chromium.org
BUG= 323300 , 309197 

Review URL: https://codereview.chromium.org/178263005
------------------------------------------------------------------------
Comment 67 by cmp@chromium.org, Feb 28 2014
Cc: -cmp@chromium.org
Project Member Comment 68 by bugdroid1@chromium.org, Feb 28 2014
------------------------------------------------------------------------
r254026 | scottmg@chromium.org | 2014-02-28T02:24:32.232432Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/hpack_input_stream.cc?r1=254026&r2=254025&pathrev=254026

Add missing #include of <algorithm> for std::min

(Required on VS2013)

TBR=mattm@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/180153007
------------------------------------------------------------------------
Reverted r253993 to check whether it caused several hundred layout test failures on http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7 .
Project Member Comment 70 by bugdroid1@chromium.org, Feb 28 2014
------------------------------------------------------------------------
r254038 | pkasting@chromium.org | 2014-02-28T04:19:57.740259Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=254038&r2=254037&pathrev=254038

Revert 253993 "Default to VS2013 on Windows"

Checking whether this caused several hundred Win 7 layout test image diffs.

> Default to VS2013 on Windows
> 
> This switches the default toolchain on Windows to VS2013.
> 
> TBR=cpu@chromium.org
> BUG= 323300 , 309197 
> 
> Review URL: https://codereview.chromium.org/178263005

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/183993005
------------------------------------------------------------------------
Blockedon: chromium:347870
Confirmed that reverting fixed all the image failures.
Project Member Comment 73 by bugdroid1@chromium.org, Mar 1 2014
------------------------------------------------------------------------
r254340 | scottmg@chromium.org | 2014-03-01T03:57:52.383072Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/gyp_chromium?r1=254340&r2=254339&pathrev=254340

Default to VS2013

Switch the default toolchain to VS2013, attempt N.

There will be WebKit image diffs on Windows, but they appear to be all
rebaseline-able minor changes.

TBR=cpu@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/185203002
------------------------------------------------------------------------
Project Member Comment 74 by bugdroid1@chromium.org, Mar 1 2014
------------------------------------------------------------------------
r254348 | scottmg@chromium.org | 2014-03-01T04:32:07.343417Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/apps/size_constraints.cc?r1=254348&r2=254347&pathrev=254348

Add <algorithm> include needed on VS2013

TBR=tmdiep@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/185173003
------------------------------------------------------------------------
Project Member Comment 75 by bugdroid1@chromium.org, Mar 1 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168239

------------------------------------------------------------------------
r168239 | scottmg@chromium.org | 2014-03-01T06:38:42.482644Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/image-pattern-rotate-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/geometry/fixed-position-transform-composited-page-scale-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-transformed-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/canvas-ellipse-circumference-fill-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/images/webp-color-profile-lossy-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/backface-visibility-transformed-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/canvas-text-alignment-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/reflections/animation-inside-reflection-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/clip/overflow-border-radius-composited-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/overflow/table-overflow-float-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/flat-with-transformed-child-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-path-01-b-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/hixie/perf/004-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-repeating-linear-gradient-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-zoom-controls-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-rotation-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/as-background-image/svg-as-background-4-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/backgrounds/size/contain-and-cover-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-radius-with-box-shadow-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/mixed-border-styles-radius-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/non-scaling-stroke-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-colorspace-yuv422-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/canvas/fillrect_gradient-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/css3-repeating-linear-gradients-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/zoom/page/zoom-background-images-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/hidpi/gradient-with-scaled-ancestor-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-omit-right-slice-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-2-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/filters/subRegion-one-effect-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/quadraticCurveTo-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug1296-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-radius-huge-assert-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/perpendicular-layer-sorting-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/filters/subRegion-two-effects-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/geometry/layer-due-to-layer-children-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-05-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/pattern-with-transformation-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/replaced/selection-rect-transform-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/hixie/perf/006-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/transforms/animated-path-inside-transformed-html-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/background-clipped-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-repeating-radial-gradients-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/direct-image-compositing-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug4427-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/carto.net/scrollbar-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-radial-gradients2-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/reflections/transform-inside-reflection-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/video-frame-size-change-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/images/color-jpeg-with-color-profile-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/lots-of-img-layers-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/gradient-stroke-width-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-border-radius-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/geometry/vertical-scroll-composited-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/radial-centered-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/css3-linear-angle-gradients-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-outset-in-shorthand-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-outset-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/as-background-image/svg-as-background-3-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/text/small-fonts-3-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-scrambled-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/perpendicular-layer-sorting-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/self-painting-layers-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/unprefixed-radial-gradients-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/marker-orient-auto-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-rotate-transform-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/css3-radial-gradients-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/backgrounds/gradient-background-leakage-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/lots-of-img-layers-with-opacity-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/as-background-image/svg-as-background-with-relative-size-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/filters/feImage-late-indirect-update-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/filters/filterRes-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-01-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/batik/filters/feTile-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/3d-corners-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-slices-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/ruby/select-ruby-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/ietestcenter/css3/bordersbackgrounds/border-radius-style-001-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-02-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/render-elems-07-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/layers-inside-overflow-scroll-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/repaint/block-selection-gap-in-composited-layer-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/hixie/perf/005-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug1430-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-zoom-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-frame-size-change-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css3/filters/effect-combined-hw-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/recursive-gradient-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/as-background-image/svg-as-background-5-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/speech/input-appearance-searchandspeech-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/softwarecompositing/direct-image-compositing-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-longhand-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/compositedscrolling/overflow/nested-render-surfaces-with-rotation-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-scale-transform-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/custom/radialGradient-focal-radius-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/render-elems-06-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/replaced/selection-rect-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-layer-crash-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/css3/filters/effect-reference-zoom-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-repeat-round-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/paths-data-09-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/general/perspective-units-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/compositing/reflections/nested-reflection-transition-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/transforms/3d/point-mapping/3d-point-mapping-3-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/gradients/css3-repeating-radial-gradients-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-scaled-gradient-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/borders/border-image-massive-scale-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/svg/transforms/text-with-pattern-with-svg-transform-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/media/video-colorspace-yuv420-expected.png?r1=168239&r2=168238&pathrev=168239
   M http://src.chromium.org/viewvc/blink/
Project Member Comment 76 by bugdroid1@chromium.org, Mar 2 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168250

------------------------------------------------------------------------
r168250 | dpranke@chromium.org | 2014-03-02T00:22:47.427823Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=168250&r2=168249&pathrev=168250

Add NeedsManualRebaseline suppressions for vs2013 switchover

This change suppresses the remaining failures resulting from the
switch to Visual Studio 2013 until scottmg or I can go through
and rebaseline them. There's probably a couple local failures from
my machine that shouldn't be rebaselined, and a couple of legit bugs
as well, which is why I don't want to use 'NeedsRebaseline' for the
bot to automatically deal with this.

TBR=scottmg@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/183973012
------------------------------------------------------------------------
Project Member Comment 77 by bugdroid1@chromium.org, Mar 2 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168251

------------------------------------------------------------------------
r168251 | dpranke@chromium.org | 2014-03-02T00:51:30.202332Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py?r1=168251&r2=168250&pathrev=168251
   M http://src.chromium.org/viewvc/blink/trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py?r1=168251&r2=168250&pathrev=168251

check the range of exit codes returned from run-webkit-tests.

Normally if run-webkit-tests detects regressions, it returns the number
of regressions in the exit code (i.e., if 5 tests fail, the exit code is 5).
We also use a few magic values to indicate other errors (like 130 for
interrupted, -1/254 for internal error, etc.). This means that if we get
a lot of errors, we can overlap and produce confusing results.

This change adds a range check on the number of errors; if we get more than
101 failures, we limit the exit code to 101. This should prevent overlap
while preserving behavior in all but very abnormal circumstances.

Arguably a better change would just be to use 1 for the error and ignore
the number of failures altogether, but that might break scripts so I'm
not going to do this now.

TBR=scottmg@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/185503002
------------------------------------------------------------------------
Project Member Comment 78 by bugdroid1@chromium.org, Mar 2 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168255

------------------------------------------------------------------------
r168255 | dpranke@chromium.org | 2014-03-02T05:20:40.286533Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=168255&r2=168254&pathrev=168255

Suppress a couple of XP-only failures after the vs2013 switch.

These will need baselines too, most likely.

TBR=scottmg@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/185303004
------------------------------------------------------------------------
Blockedon: chromium:348397
Blockedon: chromium:348800
Project Member Comment 81 by bugdroid1@chromium.org, Mar 4 2014
Labels: merge-merged-1870
------------------------------------------------------------------------
r254649 | karen@chromium.org | 2014-03-04T04:06:30.557873Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1870/src/build/gyp_chromium?r1=254649&r2=254648&pathrev=254649

Revert 254340 "Default to VS2013"

> Default to VS2013
> 
> Switch the default toolchain to VS2013, attempt N.
> 
> There will be WebKit image diffs on Windows, but they appear to be all
> rebaseline-able minor changes.
> 
> TBR=cpu@chromium.org
> BUG= 309197 
> 
> Review URL: https://codereview.chromium.org/185203002

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/178463014
------------------------------------------------------------------------
Blockedon: chromium:350018
Blockedon: chromium:349964
Blocking: chromium:350526
Blockedon: chromium:350639
Blocking: chromium:350659
Project Member Comment 87 by bugdroid1@chromium.org, Mar 11 2014
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=168942

------------------------------------------------------------------------
r168942 | rtoy@google.com | 2014-03-11T19:40:09.167822Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/audiobuffersource-loop-points.html?r1=168942&r2=168941&pathrev=168942
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=168942&r2=168941&pathrev=168942
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/audiobuffersource-loop-points-expected.wav?r1=168942&r2=168941&pathrev=168942
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/audiobuffersource-loop-points-expected.wav?r1=168942&r2=168941&pathrev=168942
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/webaudio/audiobuffersource-loop-points-expected.wav?r1=168942&r2=168941&pathrev=168942
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/webaudio/audiobuffersource-loop-points-expected.wav?r1=168942&r2=168941&pathrev=168942

Shorten duration of audio in audiobuffersource-loop-points WebAudio test

This test generates 7+ sec of audio, which takes a long time on debug
builds.  Reduce the length to 1.8 sec by making the notes much shorter and only
generating 60 notes (5 octaves) instead of 72. This shouldn't affect
the quality of the test.

Running local tests for linux, mac, win, and android shows that all of the platform tests are identical and can be removed in favor of just the one reference.

BUG= 312910 , 309197 
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/191653002
------------------------------------------------------------------------
Project Member Comment 88 by bugdroid1@chromium.org, Mar 12 2014
------------------------------------------------------------------------
r256675 | scottmg@chromium.org | 2014-03-12T22:29:14.281390Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/tools/win/toolchain?r1=256675&r2=256674&pathrev=256675

Remove old VS2010 toolchain script

VS2010 no longer supported, and the 2013 toolchain code was rolled into
depot_tools. Remove this outdated script.

TBR=cpu@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/195873007
------------------------------------------------------------------------
Status: Fixed
There's still work to do here, but we've switched as far along as Dev.
Is it possible to check things in which require VS2013? If I enable things like AVX2 support for libvpx, it will no longer build with older versions of VS.
It's fine to rely on vs2013 now on trunk.
Project Member Comment 92 by bugdroid1@chromium.org, Apr 1 2014
------------------------------------------------------------------
r260738 | scottmg@chromium.org | 2014-04-01T01:47:35.940494Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process/launch_win.cc?r1=260738&r2=260737&pathrev=260738

Fix --enable-logging after VS2013 switch

After https://src.chromium.org/viewvc/chrome?view=rev&revision=178656
a valid fileno of stdout or stderr abort connection of the console to
stdio on Windows.

Looking at the VS CRT between 2010 and 2013, it seems the behavior
that r178656 was relying on changed:

(in __initstdio)

C:\Program Files (x86)>diff "Microsoft Visual Studio 10.0\vc\crt\src\_file.c" "Microsoft Visual Studio 12.0\vc\crt\src\_file.c"
144,157d143
<         for ( i = 0 ; i < 3 ; i++ ) {
<             if ( (_osfhnd(i) == (intptr_t)INVALID_HANDLE_VALUE) ||
<                  (_osfhnd(i) == _NO_CONSOLE_FILENO) ||
<                  (_osfhnd(i) == 0) )
<             {
<             /*
<              * For stdin, stdout & stderr, we use _NO_CONSOLE_FILENO (a value
<              * different from _INVALID_HANDLE_VALUE to distinguish between
<              * a failure in opening a file & a program run without a console.
<              */
<                 _iob[i]._file = _NO_CONSOLE_FILENO;
<             }
<         }
<
194a181
>         __piob = NULL;


There's an open bug

http://connect.microsoft.com/VisualStudio/feedback/details/785119/

but as it was broken in 2012 and not fixed in 2013, it doesn't look like it's
going to be fixed. (The documentation still suggests that r178656 is correct:
http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.100).aspx vs
http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.120).aspx ) but that's
little consolation.

So, confirm that the underlying HANDLE is valid before aborting.

TBR=brettw@chromium.org
R=mseaborn@chromium.org
BUG= 169941 ,  309197 , 358267

Review URL: https://codereview.chromium.org/219813003
-----------------------------------------------------------------
Project Member Comment 93 by bugdroid1@chromium.org, Apr 1 2014
------------------------------------------------------------------
r260786 | tkent@chromium.org | 2014-04-01T07:24:43.274262Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process/launch_win.cc?r1=260786&r2=260785&pathrev=260786

Revert of Fix --enable-logging after VS2013 switch (https://codereview.chromium.org/219813003/)

Reason for revert:
Speculative revert for massive failures of XP browser_tests.

http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/30725


Original issue's description:
> Fix --enable-logging after VS2013 switch
> 
> After https://src.chromium.org/viewvc/chrome?view=rev&revision=178656
> a valid fileno of stdout or stderr abort connection of the console to
> stdio on Windows.
> 
> Looking at the VS CRT between 2010 and 2013, it seems the behavior
> that r178656 was relying on changed:
> 
> (in __initstdio)
> 
> C:\Program Files (x86)>diff "Microsoft Visual Studio 10.0\vc\crt\src\_file.c" "Microsoft Visual Studio 12.0\vc\crt\src\_file.c"
> 144,157d143
> <         for ( i = 0 ; i < 3 ; i++ ) {
> <             if ( (_osfhnd(i) == (intptr_t)INVALID_HANDLE_VALUE) ||
> <                  (_osfhnd(i) == _NO_CONSOLE_FILENO) ||
> <                  (_osfhnd(i) == 0) )
> <             {
> <             /*
> <              * For stdin, stdout & stderr, we use _NO_CONSOLE_FILENO (a value
> <              * different from _INVALID_HANDLE_VALUE to distinguish between
> <              * a failure in opening a file & a program run without a console.
> <              */
> <                 _iob[i]._file = _NO_CONSOLE_FILENO;
> <             }
> <         }
> <
> 194a181
> >         __piob = NULL;
> 
> 
> There's an open bug
> 
> http://connect.microsoft.com/VisualStudio/feedback/details/785119/
> 
> but as it was broken in 2012 and not fixed in 2013, it doesn't look like it's
> going to be fixed. (The documentation still suggests that r178656 is correct:
> http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.100).aspx vs
> http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.120).aspx ) but that's
> little consolation.
> 
> So, confirm that the underlying HANDLE is valid before aborting.
> 
> TBR=brettw@chromium.org
> R=mseaborn@chromium.org
> BUG= 169941 ,  309197 , 358267
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260738

TBR=mseaborn@chromium.org,brettw@chromium.org,scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 169941 ,  309197 , 358267

Review URL: https://codereview.chromium.org/220653002
-----------------------------------------------------------------
Project Member Comment 94 by bugdroid1@chromium.org, Apr 3 2014
------------------------------------------------------------------
r261253 | scottmg@chromium.org | 2014-04-03T01:34:36.168727Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process/launch_win.cc?r1=261253&r2=261252&pathrev=261253

Fix --enable-logging after VS2013 switch

After https://src.chromium.org/viewvc/chrome?view=rev&revision=178656
a valid fileno of stdout or stderr abort connection of the console to
stdio on Windows.

Looking at the VS CRT between 2010 and 2013, it seems the behavior
that r178656 was relying on changed:

(in __initstdio)

C:\Program Files (x86)>diff "Microsoft Visual Studio 10.0\vc\crt\src\_file.c" "Microsoft Visual Studio 12.0\vc\crt\src\_file.c"
144,157d143
<         for ( i = 0 ; i < 3 ; i++ ) {
<             if ( (_osfhnd(i) == (intptr_t)INVALID_HANDLE_VALUE) ||
<                  (_osfhnd(i) == _NO_CONSOLE_FILENO) ||
<                  (_osfhnd(i) == 0) )
<             {
<             /*
<              * For stdin, stdout & stderr, we use _NO_CONSOLE_FILENO (a value
<              * different from _INVALID_HANDLE_VALUE to distinguish between
<              * a failure in opening a file & a program run without a console.
<              */
<                 _iob[i]._file = _NO_CONSOLE_FILENO;
<             }
<         }
<
194a181
>         __piob = NULL;


There's an open bug

http://connect.microsoft.com/VisualStudio/feedback/details/785119/

but as it was broken in 2012 and not fixed in 2013, it doesn't look like it's
going to be fixed. (The documentation still suggests that r178656 is correct:
http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.100).aspx vs
http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.120).aspx ) but that's
little consolation.

So, confirm that the underlying HANDLE is valid before aborting.

TBR=brettw@chromium.org
R=mseaborn@chromium.org
BUG= 169941 ,  309197 , 358267

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260738

Review URL: https://codereview.chromium.org/219813003
-----------------------------------------------------------------
Project Member Comment 95 by bugdroid1@chromium.org, Apr 3 2014
------------------------------------------------------------------
r261286 | scottmg@chromium.org | 2014-04-03T06:31:04.494705Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/process/launch_win.cc?r1=261286&r2=261285&pathrev=261286

Revert of Fix --enable-logging after VS2013 switch (https://codereview.chromium.org/219813003/)

Reason for revert:
Possibly causing failures on nacl_integration x86-64

http://build.chromium.org/p/chromium.win/builders/NaCl%20Tests%20%28x86-64%29/builds/11185/steps/nacl_integration/logs/stdio#failure1

Original issue's description:
> Fix --enable-logging after VS2013 switch
> 
> After https://src.chromium.org/viewvc/chrome?view=rev&revision=178656
> a valid fileno of stdout or stderr abort connection of the console to
> stdio on Windows.
> 
> Looking at the VS CRT between 2010 and 2013, it seems the behavior
> that r178656 was relying on changed:
> 
> (in __initstdio)
> 
> C:\Program Files (x86)>diff "Microsoft Visual Studio 10.0\vc\crt\src\_file.c" "Microsoft Visual Studio 12.0\vc\crt\src\_file.c"
> 144,157d143
> <         for ( i = 0 ; i < 3 ; i++ ) {
> <             if ( (_osfhnd(i) == (intptr_t)INVALID_HANDLE_VALUE) ||
> <                  (_osfhnd(i) == _NO_CONSOLE_FILENO) ||
> <                  (_osfhnd(i) == 0) )
> <             {
> <             /*
> <              * For stdin, stdout & stderr, we use _NO_CONSOLE_FILENO (a value
> <              * different from _INVALID_HANDLE_VALUE to distinguish between
> <              * a failure in opening a file & a program run without a console.
> <              */
> <                 _iob[i]._file = _NO_CONSOLE_FILENO;
> <             }
> <         }
> <
> 194a181
> >         __piob = NULL;
> 
> 
> There's an open bug
> 
> http://connect.microsoft.com/VisualStudio/feedback/details/785119/
> 
> but as it was broken in 2012 and not fixed in 2013, it doesn't look like it's
> going to be fixed. (The documentation still suggests that r178656 is correct:
> http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.100).aspx vs
> http://msdn.microsoft.com/en-us/library/zs6wbdhx(v=vs.120).aspx ) but that's
> little consolation.
> 
> So, confirm that the underlying HANDLE is valid before aborting.
> 
> TBR=brettw@chromium.org
> R=mseaborn@chromium.org
> BUG= 169941 ,  309197 , 358267
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260738
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261253

TBR=mseaborn@chromium.org,brettw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 169941 ,  309197 , 358267

Review URL: https://codereview.chromium.org/223353002
-----------------------------------------------------------------
Project Member Comment 96 by bugdroid1@chromium.org, Apr 10 2014
------------------------------------------------------------------
r263122 | scottmg@chromium.org | 2014-04-10T23:16:46.514897Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_test.expected/win_debug.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/oilpan.expected/basic_win.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/master/factory/chromium_factory.py?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___2.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_compile_dbg.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/try_compile_failure.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_rel_pass.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug___3.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/dart/dartium.expected/basic_win_64_MirrorTrue.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_rel_fail.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.win/master_win_cfg.py?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_dbg_pass.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.lkgr/master_lkgr_cfg.py?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_upload.expected/win_release_tot_angle.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks_failure.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_dbg_fail.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_upload.expected/win_release.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_rel_pass.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/master/factory/syzygy_factory.py?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_upload.expected/win_debug.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_git_WinGitXP.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_rel_fail.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure_win.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_test.expected/win_release_blink.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_compile.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_test.expected/win_release.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/dart/dartium.expected/basic_win_64_MirrorFalse.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.webkit/master_win_webkit_latest_cfg.py?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.perf/master.cfg?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_git_WinGit.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_blink_win_blink_compile_rel.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_pass.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_fail.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.tryserver.chromium/master.cfg?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/compile_failure.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Win.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug___1.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/full_tryserver_chromium_win_blink_compile_rel.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_test.expected/win_debug_tryserver.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.client.nacl.sdk/master.cfg?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/gclient_revert_failure.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/masters/master.chromium.swarm/master.cfg?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/blink_trybot.expected/compile_failure_win.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/win_release.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___1.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/chromium_trybot.expected/win_debug.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug___2.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/gpu/build_and_test.expected/win_debug_blink.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___nosnap___shared.json?r1=263122&r2=263121&pathrev=263122
   M http://src.chromium.org/viewvc/chrome/trunk/tools/build/scripts/slave/recipe_modules/chromium/config.py?r1=263122&r2=263121&pathrev=263122

Remove obsolete GYP_MSVS_VERSION settings from buildbot configs

The msvs version is controlled by hashes in the src/ tree now.

R=iannucci@chromium.org
BUG= 309197 

Review URL: https://codereview.chromium.org/230473007
-----------------------------------------------------------------
Project Member Comment 97 by bugdroid1@chromium.org, Apr 21 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=172090

------------------------------------------------------------------
r172090 | eae@chromium.org | 2014-04-21T23:35:07.653431Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=172090&r2=172089&pathrev=172090

Update VS2013 test expectations

Remove stale NeedsManualRebaseline expecations since VS2013 migration
and skip audio tests on win debug.

BUG= 309197 
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/245913002
-----------------------------------------------------------------
Project Member Comment 98 by bugdroid1@chromium.org, Jul 10 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=177859

------------------------------------------------------------------
r177859 | rtoy@google.com | 2014-07-10T17:32:43.321340Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-sine-expected.wav?r1=177859&r2=177858&pathrev=177859
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-square-expected.wav?r1=177859&r2=177858&pathrev=177859
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=177859&r2=177858&pathrev=177859
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-triangle-expected.wav?r1=177859&r2=177858&pathrev=177859
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-custom-expected.wav?r1=177859&r2=177858&pathrev=177859

Rebase oscillator tests for Windows

The expected sine result was way off for some reason. I compared this
new result with the linux version and they now differ by at most 1 ulp

The other tests just differ by at most 1 ulp too. I think these differences are due to the switch to SSE2 on windows.

BUG= 309197 , 320099 
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/380903002
-----------------------------------------------------------------
Comment 99 by junov@chromium.org, Jul 10 2014
Rebased tests are failing on win7
Reverted manually: r177869
Project Member Comment 100 by bugdroid1@chromium.org, Nov 12 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185249

------------------------------------------------------------------
r185249 | rtoy@chromium.org | 2014-11-12T22:16:31.830881Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/FlakyTests?r1=185249&r2=185248&pathrev=185249
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-sine.html?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/resources/oscillator-testing.js?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-square.html?r1=185249&r2=185248&pathrev=185249
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-sine-sweep-snr-expected.txt?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-triangle.html?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-sine-expected.wav?r1=185249&r2=185248&pathrev=185249
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-sine-sweep-snr.html?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-sawtooth.html?r1=185249&r2=185248&pathrev=185249
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/webaudio/oscillator-sine-expected.wav?r1=185249&r2=185248&pathrev=185249
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/webaudio/oscillator-sine-expected.wav?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-custom.html?r1=185249&r2=185248&pathrev=185249
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185249&r2=185248&pathrev=185249
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/webaudio/oscillator-sine-expected.wav?r1=185249&r2=185248&pathrev=185249

Rebase oscillator sine test result.

Manually compared this new result against the linux result and they
differ by about 2 units, which is expected. The old result appears
to have a completely incorrect frequency sweep.

Also added a new test for oscillator that uses SNR and max difference to compare the expected and actual result. This is a bit more robust with different numerical results and makes it easier to tell if something is totally wrong or just slightly wrong for the oscillator-sine test.

Removed oscillator-sine; it seems very sensitive to numerics of the platform, and I think the new osc-sine-sweep-snr test is robust enough to catch errors

The other oscillator tests are just updated to match the change in api in oscillator-testing.js to support passing in the context so different check routines can be used for the test.

BUG= 425744 ,  431688 ,  309197 
TESTS=osc-sine-sweep-snr.html

Review URL: https://codereview.chromium.org/670863002
-----------------------------------------------------------------
Project Member Comment 101 by bugdroid1@chromium.org, Nov 18 2014
The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=185543

------------------------------------------------------------------
r185543 | rtoy@chromium.org | 2014-11-18T19:17:35.312068Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-custom-sweep-snr.html?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-square-sweep-snr-expected.txt?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-triangle.html?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-sawtooth.html?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/webaudio/oscillator-custom-expected.wav?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-triangle-sweep-snr-expected.txt?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-sawtooth-sweep-snr-expected.txt?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-custom-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/webaudio/oscillator-custom-expected.wav?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-sine-sweep-snr.html?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-square-sweep-snr.html?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/webaudio/oscillator-square-expected.wav?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-triangle-sweep-snr.html?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/resources/oscillator-testing.js?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-sawtooth-sweep-snr.html?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-custom-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/webaudio/oscillator-triangle-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/webaudio/oscillator-custom-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux-x86/webaudio/oscillator-sawtooth-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-sine-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-square-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-custom.html?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/webaudio/oscillator-square-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-triangle-expected.wav?r1=185543&r2=185542&pathrev=185543
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-custom-sweep-snr-expected.txt?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/webaudio/oscillator-triangle-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/webaudio/oscillator-sawtooth-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/webaudio/oscillator-sawtooth-expected.wav?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-square-expected.wav?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/webaudio/oscillator-square-expected.wav?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-triangle-expected.wav?r1=185543&r2=185542&pathrev=185543
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-square.html?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/oscillator-sawtooth-expected.wav?r1=185543&r2=185542&pathrev=185543
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webaudio/osc-sine-sweep-snr-expected.txt?r1=185543&r2=185542&pathrev=185543

Replace oscillator tests with a more robust testing method that is less sensitive to small differences caused by floating-point operations.

Instead of requiring exact results, we compare the actual result against a reference.  Three criteria are used to pass the test:

1. The SNR between the actual and expected results must be large enough.
2. The maximum absolute difference must be less than a small threshold
3. The actual number of differences must be less than some number.

If any of these fail, the test fails.

oscillator-testing.js is updated to include a comment on how to generate new reference files in case they need to be generated again.

This is a follow-up to https://codereview.chromium.org/720293002/ that does the same thing for the remaining oscillator tests.

BUG= 320099 ,  309197 

Review URL: https://codereview.chromium.org/720293002
-----------------------------------------------------------------
Blocking: -chromium:350659
Sign in to add a comment