New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 308466 link

Starred by 108 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

After allowing plugins,"QuickTime Plug-in 7.7.1 has crashed " error message seen in www.apple.com/itunes/

Reported by adha...@etouch.net, Oct 17 2013

Issue description

Chrome Version       :  32.0.1673.3 (Official Build 229054) canary
OS : Mac
Url : https://itunes.apple.com/us/itunes-u/global-warming-climate-change/id391599862

What steps will reproduce the problem?
1.Launch chrome and navigate to chrome://settings
2.Click on Content settings and select "Block all" radio button under Plugins section.
3.Open the above link and click on blocked plugins icon in the omni box and check the option "Always allow plug-ins on itunes.apple.com".
4.reload the page.

After reloading the page "QuickTime Plug-in 7.7.1 has crashed " error message pop up seen.

Webpage should get open without any error message.

This is a Mac specific regression issue and broken in  M-32.

Below is the narrow bisect info :
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=225965%3A226041

 
Quick_time plugins.mp4
1.6 MB View Download
Status: Untriaged

Comment 2 by meh...@chromium.org, Oct 17 2013

Maybe related: issue 304694

Comment 3 by dxie@google.com, Oct 17 2013

Labels: Cr-Internals-Plugins
Owner: jam@chromium.org
Status: Assigned
Is this related to http://src.chromium.org/viewvc/chrome?revision=226031&view=revision?  Can you take a look?
Issue 334739 has been merged into this issue.
 Issue 334653  has been merged into this issue.
It looks like this issue might also be occurring on the windows platform. The crash seems to be triggered when an HTML embed tag is present on a webpage. 

This issue did not surface in the stable channel version 31.0.1650.63. It surfaced only when 32.0.1700.72 and 32.0.1700.76 were released to the stable channel.
Yes, it occurred both on OSX 10.6.8/QT 7.6.6 (32.0.1700.77) and Windows 7/QT 7.7.4 (32.0.1700.76 m) setups here, and with the <object> tag instead of <embed> (I'm assuming the <html> video tag would ultimately trigger the same problems with the plugin, but I'm going to try it).  I've seen various mentions of this problem from people using v32 in beta, and I'm surprised this was released to stable.  Certainly the main bug report shouldn't be limited to "OS-Mac".

Can anyone report successfully playing any Quicktime movie using the Quicktime plugin under V32?  Using the plugin for other media such as MP3 audio or whatever?  If calling the plugin from v32 is completely broken I'm surprised there isn't more chatter on the internet, but if it is working in some or many setups I'd really want to find out how to work around this problem (aside from reverting to V31).

Comment 8 by jam@chromium.org, Jan 16 2014

Status: Started
I can repro this on Windows. Looks like it's related to changing how plugin network requests are processed. Investigating.

Comment 9 by sly...@gmail.com, Jan 16 2014

There is a lot of chatter about this on the internet (re: #7 davidobe...@gmail.com's comment).  This has become a major issue. It is affecting both Windows and Mac users who were upgraded to the Chrome 32+ version of the browser.  This was not happening in any 31 version.

Affected Versions
MAC: 	32.0.1700.77+
PC:	32.0.1700.76+

Comment 10 by jam@chromium.org, Jan 17 2014

Cc: lafo...@chromium.org karen@chromium.org
Labels: -M-32 M-33 Merge-Requested
Karen & Anthony: the fix is simple and I'll send it out soon. I'm guessing we wouldn't push this in M32 update but M33 really needs this I think.

Comment 11 by sly...@gmail.com, Jan 17 2014

Thanks jam@chromium.org, Karen and Anthony.  I would strongly consider this be released in a ver. 32 update if possible.  I am not sure if you are following the forums and boards, but there are a lot of production companies who depend on Quicktime to playback their files and they have to abandon Chrome completely to do so.  We are one of them.  If there is any information I can provide, please let me know as we have done extensive testing of video playback with this plugin and the video tag on Chrome on both PC and MAC.

Comment 12 Deleted

 Issue 335113  has been merged into this issue.

Comment 14 by Deleted ...@, Jan 17 2014

We spent a long time converting all our clients from Internet Explorer to Chrome. Now we have to convert all of them over to Firefox again as our product makes use of the Quicktime plugin and its causing a lot complaints. Urgent v32 update is needed please
Still able to reproduce on 34.0.1790.0 (Official Build 245382) canary on MAC 10.9.1
Definitely another vote for issuing a v32 update with this fix as soon as available - we're another of those video production companies that view Quicktime work product via the plugin.  Apparently reverting everyone to v31 is unsupported by Chrome and would be a pain.

Incidentally, the HTML5 <video> tag does still work with Quicktime - Chrome seems to be playing it natively, not via the plugin.  But at least for us this isn't a viable option, as I'd have to tweak our internal code, the player (at least in Chrome) seems to have inferior controls (no single-frame scrub, for instance) and since Mozilla doesn't support H.264 we'd have to have two code paths or drop Firefox support.


I agree the fix should be released ASAP, rather than delayed until v33. There are websites that are used daily at our company by most of the staff who are affected by this bug. Until this is fixed, everyone had to switch to using a different browser, which folks are unhappy with.
Labels: -Merge-Requested Merge-Approved
Approved for 33 (1750)
Please stop me-too-ing this bug, or we'll need to lock it to comments. The process for deciding what to put in a stable channel update is not vote-by-bug-comments. If you want to indicate your interest in seeing this fixed, just star the bug.

Comment 20 Deleted

Labels: Restrict-AddIssueComment-EditIssue

Comment 22 by jam@chromium.org, Jan 17 2014

Labels: OS-Windows
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 17 2014

------------------------------------------------------------------------
r245600 | jam@chromium.org | 2014-01-17T20:32:38.045511Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/npapi/plugin_url_fetcher.cc?r1=245600&r2=245599&pathrev=245600
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/npapi/plugin_url_fetcher.h?r1=245600&r2=245599&pathrev=245600
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/npapi/webplugin_delegate_impl.cc?r1=245600&r2=245599&pathrev=245600
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/npapi/webplugin_delegate_impl.h?r1=245600&r2=245599&pathrev=245600

Give QuickTime the plugin stream data in writeable memory as it modifies it.

This broke after switching the fetching of plugin stream data to the plugin process because now the data from ResourceDispatcher is passed directly to the plugin and it's read-only.

BUG= 308466 
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/141333005
------------------------------------------------------------------------
Project Member

Comment 24 by bugdroid1@chromium.org, Jan 17 2014

Labels: -Merge-Approved merge-merged-1750
------------------------------------------------------------------------
r245617 | jam@chromium.org | 2014-01-17T21:05:16.116888Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/content/child/npapi/plugin_url_fetcher.h?r1=245617&r2=245616&pathrev=245617
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/content/child/npapi/webplugin_delegate_impl.cc?r1=245617&r2=245616&pathrev=245617
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/content/child/npapi/webplugin_delegate_impl.h?r1=245617&r2=245616&pathrev=245617
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/content/child/npapi/plugin_url_fetcher.cc?r1=245617&r2=245616&pathrev=245617

Merge 245600 "Give QuickTime the plugin stream data in writeable..."

> Give QuickTime the plugin stream data in writeable memory as it modifies it.
> 
> This broke after switching the fetching of plugin stream data to the plugin process because now the data from ResourceDispatcher is passed directly to the plugin and it's read-only.
> 
> BUG= 308466 
> R=ananta@chromium.org
> 
> Review URL: https://codereview.chromium.org/141333005

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/139303020
------------------------------------------------------------------------

Comment 25 by kareng@google.com, Jan 21 2014

Labels: -M-33 M-32 Merge-Approved
approved for m32.
Labels: TE-Verified-34.0.1796.2 TE-Verified-M34 TE-Verified-33.0.1750.42 TE-Verified-M33
Tested this fix on Latest Canary#34.0.1796.2 (Official Build 245951) & Latest M33#33.0.1750.42 (Official Build 245916) on Mac OS X 10.9.1 - Working as intended.

Thank you.
Project Member

Comment 27 by bugdroid1@chromium.org, Jan 21 2014

Labels: -Merge-Approved merge-merged-1700
------------------------------------------------------------------------
r245990 | jam@chromium.org | 2014-01-21T06:20:00.891248Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1700/src/content/child/npapi/plugin_url_fetcher.cc?r1=245990&r2=245989&pathrev=245990
   M http://src.chromium.org/viewvc/chrome/branches/1700/src/content/child/npapi/plugin_url_fetcher.h?r1=245990&r2=245989&pathrev=245990
   M http://src.chromium.org/viewvc/chrome/branches/1700/src/content/child/npapi/webplugin_delegate_impl.cc?r1=245990&r2=245989&pathrev=245990
   M http://src.chromium.org/viewvc/chrome/branches/1700/src/content/child/npapi/webplugin_delegate_impl.h?r1=245990&r2=245989&pathrev=245990

Merge 245600 "Give QuickTime the plugin stream data in writeable..."

> Give QuickTime the plugin stream data in writeable memory as it modifies it.
> 
> This broke after switching the fetching of plugin stream data to the plugin process because now the data from ResourceDispatcher is passed directly to the plugin and it's read-only.
> 
> BUG= 308466 
> R=ananta@chromium.org
> 
> Review URL: https://codereview.chromium.org/141333005

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/138903006
------------------------------------------------------------------------

Comment 28 by jam@chromium.org, Jan 21 2014

For anyone who's starred this, Karen approved the merge to M32 and it's now merged. So it should go out in the next M32 build.

Comment 29 by jam@chromium.org, Jan 21 2014

Status: Fixed
Cc: srsridhar@chromium.org
Labels: TE-Verified-M32 TE-Verified-32.0.1700.102
Tested the issue on MacBook pro 10.9 OS -chrome version 32.0.1700.102 (Official Build 246481). Fix is working as intended. No crash error message pop-up is seen upon reloading the page after allowing the plugins.

Comment 31 by jam@chromium.org, Jan 30 2014

I got a repro from a user with http://jsfiddle.net/dgerton/2DcwT/. Looks like it was a different mime type (audio in this case). 
Project Member

Comment 32 by bugdroid1@chromium.org, Jan 30 2014

------------------------------------------------------------------------
r248007 | jam@chromium.org | 2014-01-30T19:11:04.864662Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/npapi/webplugin_delegate_impl.cc?r1=248007&r2=248006&pathrev=248007

Expand the QuickTime quirk to handle all mime types used by that plugin.

BUG= 308466 
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/150153002
------------------------------------------------------------------------

Comment 33 by jam@chromium.org, Jan 31 2014

Labels: Merge-Requested
Labels: -Merge-Requested Merge-Approved
Project Member

Comment 35 by bugdroid1@chromium.org, Feb 4 2014

Labels: -Merge-Approved
------------------------------------------------------------------------
r248564 | jam@chromium.org | 2014-02-03T20:27:38.585960Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1700/src/content/child/npapi/webplugin_delegate_impl.cc?r1=248564&r2=248563&pathrev=248564

Merge 248007 "Expand the QuickTime quirk to handle all mime type..."

> Expand the QuickTime quirk to handle all mime types used by that plugin.
> 
> BUG= 308466 
> R=ananta@chromium.org
> 
> Review URL: https://codereview.chromium.org/150153002

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/145483008
------------------------------------------------------------------------
Project Member

Comment 36 by bugdroid1@chromium.org, Feb 4 2014

------------------------------------------------------------------------
r248565 | jam@chromium.org | 2014-02-03T20:29:09.378678Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1750/src/content/child/npapi/webplugin_delegate_impl.cc?r1=248565&r2=248564&pathrev=248565

Merge 248007 "Expand the QuickTime quirk to handle all mime type..."

> Expand the QuickTime quirk to handle all mime types used by that plugin.
> 
> BUG= 308466 
> R=ananta@chromium.org
> 
> Review URL: https://codereview.chromium.org/150153002

TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/138003016
------------------------------------------------------------------------

Sign in to add a comment