New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible

Reported by phil...@opera.com, Oct 9 2013

Issue description

These IDL attributes were added to WebKit in 2009 <http://trac.webkit.org/changeset/51191>, as part of a non-standard way of supporting captions. This predates the first signs of HTMLTrackElement <http://trac.webkit.org/changeset/83220>.

The implementations of these properties show that they are now only exposing information which can already be found by using the TextTrack API, so there's no point in trying to standardize the properties.

I had never heard of these properties before I saw then in HTMLMediaElement.idl. Searching for them overwhelmingly finds things related to WebKit/Blink development and not people trying to use it.

There's a non-zero compat risk in removing these, but they look relatively obscure and it's worth trying to remove.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=159317

------------------------------------------------------------------------
r159317 | philipj@opera.com | 2013-10-10T08:58:49.846940Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-in-band-legacy-api.html?r1=159317&r2=159316&pathrev=159317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderMediaControls.cpp?r1=159317&r2=159316&pathrev=159317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.cpp?r1=159317&r2=159316&pathrev=159317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.h?r1=159317&r2=159316&pathrev=159317
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.idl?r1=159317&r2=159316&pathrev=159317
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-in-band-legacy-api-expected.txt?r1=159317&r2=159316&pathrev=159317
   M http://src.chromium.org/viewvc/blink/trunk/ManualTests/media-controls.html?r1=159317&r2=159316&pathrev=159317
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=159317&r2=159316&pathrev=159317

Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible

See the bug for why it is (probably) best to remove these.

Move some things in HTMLMediaElement.idl to match the spec order and
to leave all WebKit extensions in a group at the end.

Drop duplicate TreatNullAs=NullString introduced in r159260.

BUG= 305753 

Review URL: https://codereview.chromium.org/26759003
------------------------------------------------------------------------

Comment 2 by phil...@opera.com, Oct 10 2013

Status: Fixed

Comment 3 by sshru...@google.com, Mar 21 2016

Components: -Blink>Video Blink>Media>Video
Renaming Blink>Video to Blink>Media>Video for better characterization

Sign in to add a comment