New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment
link

Issue 305526: Blank videos, but audio intact

Reported by tint...@gmail.com, Oct 9 2013

Issue description

Device name: Asus Transformer, Samsung Galaxy Tab

From "Settings > About Chrome"
Application version: Chrome 30 and 31 (beta)
OS: Android 4.3

URLs (if applicable):

Behavior in Android Browser (if applicable):



Steps to reproduce:
1. youtube.com
2. vimeo.com
3. any embedded video

Expected result:
watch video with audio

Actual result:
video is blank, only audio is working. however video shows if you maximize to full screen. this problem did not exist in chrome 29.
 

Comment 1 by candr...@chromium.org, Oct 11 2013

Cc: qin...@chromium.org
Labels: -Pri-2 Pri-1 M-31 ReleaseBlock-Stable Type-Bug-Regression
Status: Untriaged
Thanks for the report!

I'm able to repro this on ASUS Transformer TF101 with IML74K.

* Doesn't repro on 29.0.1543.2
* Repros on 30.0.1599.82 and 31.0.1650.16

Logs at http://go/chrome-androidlogs/305526

Comment 2 by qin...@chromium.org, Oct 11 2013

Cc: siev...@chromium.org

Comment 3 by kamakshi@chromium.org, Oct 11 2013

Cc: -qin...@chromium.org
Labels: Cr-Internals-Media-Video
Owner: qin...@chromium.org
Status: Assigned

Comment 4 by candr...@chromium.org, Oct 11 2013

More reports of this in  issue 283053 .

Comment 5 by qin...@chromium.org, Oct 17 2013

Cc: qin...@chromium.org
 Issue 283053  has been merged into this issue.

Comment 6 by qin...@chromium.org, Oct 17 2013

glGetIntegerv(GL_TEXTURE_BINDING_EXTERNAL_OES, &texture_id) in StreamTextureManagerAndroid::StreamTextureAndroid::Update() is causing a GL error.

GL_TEXTURE_BINDING_EXTERNAL_OES is probably not implemented on old NVidia GPUs.
Assigning it to sievers@ as he have a fix.

Comment 7 by qin...@chromium.org, Oct 17 2013

Owner: siev...@chromium.org

Comment 9 by bugdroid1@chromium.org, Oct 17 2013

Project Member
------------------------------------------------------------------------
r229254 | sievers@chromium.org | 2013-10-17T23:28:29.886858Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/gpu/stream_texture_manager_android.cc?r1=229254&r2=229253&pathrev=229254
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc?r1=229254&r2=229253&pathrev=229254
   M http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?r1=229254&r2=229253&pathrev=229254

Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES query

glGetIntegerv(GL_TEXTURE_BINDING_EXTERNAL_OES, &texture_id) returns
GL_INVALID_ENUM on older Android NVIDIA drivers.

The reason for the query is to restore correct texture bindings,
since SurfaceTexture.updateTexImage() implies a call to glBindTexture().
Since we now only call this before drawing, we can just set the correct
active texture unit (which gets restored after draw).

BUG= 305526 , 283053 

Review URL: https://codereview.chromium.org/26921004
------------------------------------------------------------------------

Comment 10 by qin...@chromium.org, Oct 17 2013

verified that this change fixes the issue.

Comment 11 by siev...@chromium.org, Oct 23 2013

Labels: Merge-Requested
Status: Fixed
Requesting merge for r229254, since no issues were raised in latest dev build. Also, the patch affects Android only.

Comment 12 by candr...@chromium.org, Oct 23 2013

Status: Started
Changing to "Started" since it's not merged yet.

Comment 13 by laforge@google.com, Oct 24 2013

Labels: -Merge-Requested Merge-Approved

Comment 14 by bugdroid1@chromium.org, Oct 24 2013

Project Member
Labels: -Merge-Approved merge-merged-1650
------------------------------------------------------------------------
r230734 | sievers@chromium.org | 2013-10-24T16:12:31.429158Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1650/src/content/common/gpu/stream_texture_manager_android.cc?r1=230734&r2=230733&pathrev=230734
   M http://src.chromium.org/viewvc/chrome/branches/1650/src/gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc?r1=230734&r2=230733&pathrev=230734
   M http://src.chromium.org/viewvc/chrome/branches/1650/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?r1=230734&r2=230733&pathrev=230734

Merge 229254 "Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES..."

> Work around broken GL_TEXTURE_BINDING_EXTERNAL_OES query
> 
> glGetIntegerv(GL_TEXTURE_BINDING_EXTERNAL_OES, &texture_id) returns
> GL_INVALID_ENUM on older Android NVIDIA drivers.
> 
> The reason for the query is to restore correct texture bindings,
> since SurfaceTexture.updateTexImage() implies a call to glBindTexture().
> Since we now only call this before drawing, we can just set the correct
> active texture unit (which gets restored after draw).
> 
> BUG= 305526 , 283053 
> 
> Review URL: https://codereview.chromium.org/26921004

TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/39263004
------------------------------------------------------------------------

Comment 15 by vinodkr@chromium.org, Oct 24 2013

Status: Fixed

Comment 16 by candr...@chromium.org, Oct 24 2013

 Issue 310995  has been merged into this issue.

Comment 17 by bluetoot...@gmail.com, Dec 1 2013

I'm still seeing this issue with Android Chrome version 31. Pretty much I have the mp4 video stored in the SD card and the web page is written to use the local video file instead of downloading from the Internet.

Sign in to add a comment