New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment
link

Issue 305216: Borders for CSS tables don't display when border-radius is used

Reported by cont...@benfrain.com, Oct 8 2013

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1659.2 Safari/537.36

Example URL:
http://codepen.io/benfrain/pen/wxDdq

Steps to reproduce the problem:
1. Create an element and set it via CSS as display: table;
2. Add border with width and colour
3. Add a border-radius and watch the border colour disappear

What is the expected behavior?
The element should retain border colour but also have rounded corners

What went wrong?
Chrome seems to loose the colour of the border (makes the border transparent instead)

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? Yes Not sure, about 3-4 versions back I think

Does this work in other browsers? Yes Firefox 23, Safari 6.0.5 (8536.30.1), Opera 12.16

Chrome version: 32.0.1659.2  Channel: dev
OS Version: OS X 10.8.5
Flash Version: Shockwave Flash 11.9 r900
 

Comment 1 by cont...@benfrain.com, Oct 8 2013

Just tested in Chrome Stable: Version 30.0.1599.69 and the problem isn't there. Looks like a regression bug.

Comment 2 by tkent@chromium.org, Oct 8 2013

Labels: -Cr-Content Cr-Blink-Rendering Needs-Bisect

Comment 3 by rponnada@chromium.org, Oct 9 2013

Cc: ligim...@chromium.org rponnada@chromium.org
Labels: -Pri-2 -Type-Bug -OS-Mac -Needs-Bisect Pri-1 Type-Bug-Regression OS-All M-32
Status: Untriaged
Able to repro this issue on window7 using 32.0.1664.3 (Official Build 227606) canary Aura

This is Regression issue:: Below is tool results

CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=225168%3A225184

BLINK CHANGELOG URL:
  http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?ur
l=/trunk&range=158300%3A158286

Suspect:158297??

Comment 4 by ligim...@chromium.org, Oct 9 2013

Cc: gyuyoung...@samsung.com
Owner: japhet@chromium.org
Status: Assigned

Comment 5 by japhet@chromium.org, Oct 9 2013

Owner: tasak@chromium.org
I'm guessing this is related to http://src.chromium.org/viewvc/blink?revision=158295&view=revision

tasak, would you mind taking a look?

Comment 6 by tasak@google.com, Oct 11 2013

Sure. I will investigate this issue.

Comment 7 by tasak@google.com, Oct 11 2013

Status: Started

Comment 8 by lebc...@gmail.com, Oct 11 2013

I have a very similar issue in the newest dev version (32.0.1664.3 dev). on Mac OS X 10.8.4. The minimum code to reproduce the bug is here:

http://jsfiddle.net/lebbe/RB3vh/ 

I hope this can be of any help. I reply because the code in the first post does not reproduce the bug in my current dev version, but the code I link to in jsfiddle does. If not I would just have voted on the issue.

Comment 9 by tasak@google.com, Oct 11 2013

The regression is caused by my patch. So I should not add bleedAvoidance check. i.e.

-    if (bleedAvoidance != BackgroundBleedBackgroundOverBorder && !style()->hasAppearance() && style()->hasBorder() && !collapseBorders())
+    if (style()->hasBorder() && !collapseBorders())
         paintBorder(paintInfo, rect, style());

Thank you, lebchen

I'm now trying to create a layout test.
So I would like to use your repro.

Comment 10 by lebc...@gmail.com, Oct 11 2013

Use it as you please.

Comment 11 by tasak@google.com, Oct 11 2013

I've just uploaded a fixing patch:
https://codereview.chromium.org/26997002/

Comment 12 Deleted

Comment 13 by paol.mar...@gmail.com, Oct 16 2013

problem still present in Version 32.0.1671.3 canary Aura (win7 64bit)

maybe there is also a problem with div positioning.

go here, fill the form and press trhe green button to see the problem.

http://tariffe.segugio.it/costo-gas-metano/confronto-tariffe-gas-metano.aspx

Comment 14 by cont...@benfrain.com, Oct 16 2013

Pretty sure a patch hasn't been integrated yet. If you click the link above you can follow the patch progress.

Comment 15 by cont...@benfrain.com, Nov 13 2013

Could anyone confirm - if this isn't patched, is the bug likely to make it to stable in 6 weeks or so?

Comment 16 by bugdroid1@chromium.org, Dec 5 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=163220

------------------------------------------------------------------------
r163220 | tasak@google.com | 2013-12-05T08:08:06.421153Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/table/table-with-border-radius-expected.png?r1=163220&r2=163219&pathrev=163220
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTable.cpp?r1=163220&r2=163219&pathrev=163220
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderBox.cpp?r1=163220&r2=163219&pathrev=163220
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/table/table-with-border-radius-expected.txt?r1=163220&r2=163219&pathrev=163220
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTable.h?r1=163220&r2=163219&pathrev=163220
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=163220&r2=163219&pathrev=163220
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/table/table-with-border-radius.html?r1=163220&r2=163219&pathrev=163220

Should paint border before background when bleedAvoidance is  BackgroundBleedBackgroundOverBorder.

This is a fixing patch for a regression caused by r158295:
http://src.chromium.org/viewvc/blink?revision=158295&view=revision

BUG= 305216 
TEST=fast/table/table-with-border-radius.html

Review URL: https://codereview.chromium.org/26997002
------------------------------------------------------------------------

Comment 17 by tasak@google.com, Dec 6 2013

Status: Fixed

Comment 18 by bugdroid1@chromium.org, Dec 10 2013

Project Member
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=163475

------------------------------------------------------------------------
r163475 | ojan@chromium.org | 2013-12-10T00:20:31.114760Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/table/table-with-border-radius-expected.png?r1=163475&r2=163474&pathrev=163475
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/fast/table/table-with-border-radius-expected.png?r1=163475&r2=163474&pathrev=163475
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/table/table-with-border-radius-expected.png?r1=163475&r2=163474&pathrev=163475
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/table/table-with-border-radius-expected.txt?r1=163475&r2=163474&pathrev=163475
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/table/border-radius-with-image-expected.png?r1=163475&r2=163474&pathrev=163475
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/linux/fast/table/border-radius-with-image-expected.png?r1=163475&r2=163474&pathrev=163475
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/fast/table/border-radius-with-image-expected.png?r1=163475&r2=163474&pathrev=163475
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/android/fast/table/table-with-border-radius-expected.txt?r1=163475&r2=163474&pathrev=163475
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/mac/fast/table/border-radius-with-image-expected.png?r1=163475&r2=163474&pathrev=163475
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=163475&r2=163474&pathrev=163475
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/platform/win/fast/table/table-with-border-radius-expected.png?r1=163475&r2=163474&pathrev=163475

Auto-rebaseline for r163220

http://src.chromium.org/viewvc/blink?view=revision&revision=163220

BUG= 305216 
TBR=tasak@google.com

Review URL: https://codereview.chromium.org/99003004
------------------------------------------------------------------------

Comment 19 by bugdroid1@chromium.org, Dec 10 2013

Project Member
Labels: merge-merged-1700
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=163487

------------------------------------------------------------------------
r163487 | tasak@google.com | 2013-12-10T03:21:57.952731Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/branches/chromium/1700/Source/core/rendering/RenderTable.cpp?r1=163487&r2=163486&pathrev=163487
   M http://src.chromium.org/viewvc/blink/branches/chromium/1700/Source/core/rendering/RenderBox.cpp?r1=163487&r2=163486&pathrev=163487
   A http://src.chromium.org/viewvc/blink/branches/chromium/1700/LayoutTests/fast/table/table-with-border-radius-expected.txt?r1=163487&r2=163486&pathrev=163487
   M http://src.chromium.org/viewvc/blink/branches/chromium/1700/Source/core/rendering/RenderTable.h?r1=163487&r2=163486&pathrev=163487
   M http://src.chromium.org/viewvc/blink/branches/chromium/1700/LayoutTests/TestExpectations?r1=163487&r2=163486&pathrev=163487
   A http://src.chromium.org/viewvc/blink/branches/chromium/1700/LayoutTests/fast/table/table-with-border-radius.html?r1=163487&r2=163486&pathrev=163487
   A http://src.chromium.org/viewvc/blink/branches/chromium/1700/LayoutTests/platform/linux/fast/table/table-with-border-radius-expected.png?r1=163487&r2=163486&pathrev=163487

Merge 163220 "Should paint border before background when bleedAv..."

> Should paint border before background when bleedAvoidance is  BackgroundBleedBackgroundOverBorder.
> 
> This is a fixing patch for a regression caused by r158295:
> http://src.chromium.org/viewvc/blink?revision=158295&view=revision
> 
> BUG= 305216 
> TEST=fast/table/table-with-border-radius.html
> 
> Review URL: https://codereview.chromium.org/26997002

TBR=tasak@google.com

Review URL: https://codereview.chromium.org/111263002
------------------------------------------------------------------------

Comment 20 by laforge@google.com, Jan 9 2015

Labels: -Cr-Blink-Rendering Cr-Blink-Layout
Migrate from Cr-Blink-Rendering to Cr-Blink-Layout

Sign in to add a comment