New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 131 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2011
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocked on:
issue 59242
issue 59672

Blocking:
issue chromium-os:906
issue chromium-os:908
issue 62745
issue 67068
issue 68758
issue 70699
issue 182655
issue 182657

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Implement tab sync

Reported by skrul@chromium.org, Dec 15 2009

Issue description

A user should be able to see the list of open tabs they have on all of their synchronized browsers.

 

Comment 1 by tim@chromium.org, Jan 15 2010

Just to clarify because I'm not totally sure, I think "tab sync" V1 is syncing the 
sessions stuff you currently see on the NTP when (for example) you close a tab or a 
window with a bunch of tabs;  or there extra UI &&|| code to sample your current 
session more frequently than what already exists? 
http://code.google.com/p/chromium-os/issues/detail?id=908 seems to suggest that.  Do we 
have different requirements for chromium-os v chromium?
Labels: Area-Feature

Comment 3 by karen@chromium.org, Feb 2 2010

Labels: m5-priority
Labels: -Area-Feature Area-UI
Recommendations based on labels Feature-Sync and os-all from activity in the last 60 days
	skrul@chromium.org(Recommended)
	chron@chromium.org
	tim@chromium.org
	albertb@chromium.org
	zork@chromium.org
	akalin@chromium.org
Labels: MrBotRecommends
This an automated note...
Recommendations based on labels Feature-Sync and os-all from activity in the last 60 days
	skrul@chromium.org(Recommended)
	chron@chromium.org
	tim@chromium.org
	albertb@chromium.org
	zork@chromium.org
	akalin@chromium.org
It would be really nice to not even have to click a link on the NTP to open the saved 
window. Ideally, I could leave computer A with Chrome open, login to computer B, and 
have all my tabs from A load up on B when I open Chrome. One difficult with this would 
be determining what to do with A's open window as I browse on B. When a new tab is 
opened on B, is a new tab also opened on A, or would I need to click some kind of Sync 
button on A to activate that?

Comment 8 by tim@chromium.org, Mar 25 2010

Labels: -Mstone-5 Mstone-6

Comment 9 by tim@chromium.org, Jun 14 2010

Labels: -Mstone-6 -m5-priority Mstone-7
Is this different from session sync?  It  seems the same.  Are you passing
me the whole project with this one, or are we still working together?

-jerr
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50119 

------------------------------------------------------------------------
r50119 | jerrica@google.com | 2010-06-17 10:16:56 -0700 (Thu, 17 Jun 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=50119&r2=50118
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service_unittest.cc?r1=50119&r2=50118
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=50119&r2=50118

Created notification for when a session is saved.

Created a notification for when a session is saved,
so that later we can observe this notification and 
sync a session.
BUG= 30519 
TEST=session_service_unittest.cc
Review URL: http://codereview.chromium.org/2858005
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52252 

------------------------------------------------------------------------
r52252 | jerrica@google.com | 2010-07-13 18:29:05 -0700 (Tue, 13 Jul 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=52252&r2=52251
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.h?r1=52252&r2=52251

Created method to save histogram data for future
syncing of sessions.

Created a method to track certain session modifications
in order to determine what we want to track when
syncing sessions
BUG= 30519 
TEST=NONE
Review URL: http://codereview.chromium.org/2930002
------------------------------------------------------------------------

Comment 13 by n...@chromium.org, Aug 10 2010

 Issue 51539  has been merged into this issue.

Comment 14 by arane...@gmail.com, Aug 10 2010

No, it does nor exist.
Select "Options", popup window "Chromium Options" comes up.
Select tab "Personal Stuff", section  "Sync" button "Customize...".
Popup window "Configire Sync":
1 - "Keep everything synced"
2 - "Choose what to sync:"
2.1 - AutoFill
2.2 - Bookmarks
2.3 - Extensions
2.4 - Preferences
2.5 - Themes

Where are the "Tabs"?
Sorry, I do not see.

It is not yet available. this is only the bug tracker for that request. Tab sync might be available in Chrome 7 (see sidebar Mstone-7)

Comment 16 by jda...@gmail.com, Aug 10 2010

@aranenko be patience, this is not implemented yet, is targeted for Chrome 7.

Comment 17 by arane...@gmail.com, Aug 10 2010

Version 7? Thank you people, waiting for it with great exceptions.
google has changed its roadmap and they will release updates more often. Every six weeks or so. Chrome 6 should come in early September, chrome 7 maybe in middle of october.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55973 

------------------------------------------------------------------------
r55973 | jerrica@google.com | 2010-08-12 18:01:53 -0700 (Thu, 12 Aug 2010) | 4 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/protocol/session_specifics.proto
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/protocol/sync_proto.gyp?r1=55973&r2=55972
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/testserver/chromiumsync.py?r1=55973&r2=55972

sync: Add sessions to protocol and chromiumsync python test server.

BUG= 30519 
Review URL: http://codereview.chromium.org/3107008
------------------------------------------------------------------------

Comment 20 by tim@chromium.org, Aug 16 2010

Labels: -Mstone-7 Mstone-8
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56423 

------------------------------------------------------------------------
r56423 | tim@chromium.org | 2010-08-17 14:10:21 -0700 (Tue, 17 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=56423&r2=56422
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/new_tab_ui.cc?r1=56423&r2=56422
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/value_helper.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/value_helper.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc?r1=56423&r2=56422
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_data_type_controller.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_data_type_controller.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_mock.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc?r1=56423&r2=56422
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_flow.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/model_type.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/model_type.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/browser_with_test_window_test.cc?r1=56423&r2=56422
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/browser_with_test_window_test.h?r1=56423&r2=56422

Added classes to enable session sync functionality.

TEST=ProfileSyncServiceSessionTest
BUG= 30519 

Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009

Review URL: http://codereview.chromium.org/3184004
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56426 

------------------------------------------------------------------------
r56426 | tim@chromium.org | 2010-08-17 14:30:23 -0700 (Tue, 17 Aug 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=56426&r2=56425
   D /trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   D /trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/new_tab_ui.cc?r1=56426&r2=56425
   D /trunk/src/chrome/browser/dom_ui/value_helper.cc
   D /trunk/src/chrome/browser/dom_ui/value_helper.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc?r1=56426&r2=56425
   D /trunk/src/chrome/browser/sync/glue/session_change_processor.cc
   D /trunk/src/chrome/browser/sync/glue/session_change_processor.h
   D /trunk/src/chrome/browser/sync/glue/session_data_type_controller.cc
   D /trunk/src/chrome/browser/sync/glue/session_data_type_controller.h
   D /trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   D /trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_mock.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc?r1=56426&r2=56425
   D /trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_flow.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/model_type.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/model_type.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/browser_with_test_window_test.cc?r1=56426&r2=56425
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/browser_with_test_window_test.h?r1=56426&r2=56425

Revert 56423 - Added classes to enable session sync functionality.

TEST=ProfileSyncServiceSessionTest
BUG= 30519 

Original patch by jerrica@chromium.org
Original review: http://codereview.chromium.org/3168009

Review URL: http://codereview.chromium.org/3184004

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/3127017
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56462 

------------------------------------------------------------------------
r56462 | tim@chromium.org | 2010-08-17 17:23:29 -0700 (Tue, 17 Aug 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_commands_unittest.cc?r1=56462&r2=56461
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/new_tab_ui.cc?r1=56462&r2=56461
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/value_helper.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/value_helper.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/abstract_profile_sync_service_test.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/data_type_manager_impl.cc?r1=56462&r2=56461
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_data_type_controller.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_data_type_controller.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_impl_unittest.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_factory_mock.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_password_unittest.cc?r1=56462&r2=56461
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_typed_url_unittest.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_flow.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_wizard_unittest.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/model_type.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/syncable/model_type.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view_unittest.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/browser_with_test_window_test.cc?r1=56462&r2=56461
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/browser_with_test_window_test.h?r1=56462&r2=56461

sync: take two for:

Added classes to enable session sync functionality.

TEST=ProfileSyncServiceSessionTest
BUG= 30519 
Original patch by : jerrica@chromium.org
Original review http://codereview.chromium.org/3168009

Review URL: http://codereview.chromium.org/3133022
------------------------------------------------------------------------

Comment 24 by n...@chromium.org, Aug 18 2010

 Issue 52523  has been merged into this issue.

Comment 25 by n...@chromium.org, Aug 21 2010

 Issue 39201  has been merged into this issue.

Comment 26 by n...@chromium.org, Aug 21 2010

Labels: -syncV2 -MrBotRecommends
A first pass of this is implemented.  Tim, should we break this down into smaller items for what remains?
Labels: SyncEverything

Comment 28 by zea@chromium.org, Sep 24 2010

Comment 29 by tim@chromium.org, Oct 1 2010

Labels: -Mstone-8 Mstone-10

Comment 30 by zea@chromium.org, Oct 18 2010

Status: Started

Comment 31 by zea@chromium.org, Oct 18 2010

Blockedon: 59672
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=63266

------------------------------------------------------------------------
r63266 | zea@chromium.org | Wed Oct 20 14:36:20 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_wizard.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/autofill_change_processor.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/options/sync_options_handler.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/sync_setup_flow.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.h?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.h?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/ntp_resource_cache.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.h?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=63266&r2=63265&pathrev=63266
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=63266&r2=63265&pathrev=63266

Fix syncing of sessions. Numerous changes have been made. Currently, the model associator does not have a local model to associate with, but instead contains a buffer of protobuf specifics for foreign sessions which gets completely overwritten everytime an update occurs. This buffer is then used to create a vector of foreign sessions for each foreign session handler. As a result, The model associator is slightly different from other datatypes.

The creation of a persistent unique machine tag needs to be resolved still. Something understandable by the user would be good (home, work, etc.), but for now we use the directory kernel's cache_guid. Unfortunately, this gets reset each time sync is enabled/disabled, resulting in stale client session info that remains visible.

BUG= 30519 
TEST=unit_test

Review URL: http://codereview.chromium.org/3825005
------------------------------------------------------------------------

Comment 34 by zea@chromium.org, Oct 22 2010

For those interested in playing around, I'm attaching a script that will launch the python test server for you (only works on mac/linux). Run it, and it will give you the command line switches needed to run chromium with sessions on.

Comment 35 by till...@gmail.com, Oct 26 2010

Hey Zea, where will we find the options to play around with this feature (I.E. a "Save Session" or "Load Session" function) once we've downloaded and run the script?

Comment 36 by zea@chromium.org, Oct 26 2010

Once you have two machines syncing (or two chrome processes running on one machine), and start browsing on them, you'll see a foreign sessions section whenever you make a new tab containing the session info of whatever other clients are being synced with. Click one of them to restore it (it will open new window(s)). 

Make sure you run each chromium process with the command line switches the script tells you to. 

Note that the real sync server does not support sessions right now, this is just to play around with it on the client side. You'll only be syncing the data to a local python script. One of the command line switches I mentioned tells your chromium process not to use the real server but your local one instead.

I'm attaching a more recent script (although I'm not really supporting it, it's just to help people out).
launch_test_server.py
1.9 KB View Download
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=65051

------------------------------------------------------------------------
r65051 | zea@chromium.org | Thu Nov 04 07:41:38 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.cc?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.h?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc?r1=65051&r2=65050&pathrev=65051
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/single_client_live_sessions_sync_test.cc?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service_test_helper.h?r1=65051&r2=65050&pathrev=65051
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/live_sessions_sync_test.h?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.h?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.cc?r1=65051&r2=65050&pathrev=65051
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/two_client_live_sessions_sync_test.cc?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.h?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=65051&r2=65050&pathrev=65051
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/multiple_client_live_sessions_sync_test.cc?r1=65051&r2=65050&pathrev=65051
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/live_sync_test.cc?r1=65051&r2=65050&pathrev=65051

Session sync integration tests. Left out many client for now, since even
without doing anything in the test it was timing out.

BUG= 30519 
TEST=self

Review URL: http://codereview.chromium.org/4158009
------------------------------------------------------------------------

Comment 38 by zea@chromium.org, Nov 17 2010

still targeted for M10, although we're blocked on UI guys.

Comment 40 by zea@chromium.org, Dec 17 2010

 Issue 67104  has been merged into this issue.

Comment 41 by tim@chromium.org, Jan 3 2011

Labels: -Mstone-10 Mstone-14

Comment 42 by tim@chromium.org, Jan 3 2011

Labels: -SyncEverything
@zea - We should set up a Type=Meta bug for this feature (targeted ~ m12+) and split up the work into other bugs. 
Project Member

Comment 43 by bugdroid1@chromium.org, Jan 6 2011

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=70645

------------------------------------------------------------------------
r70645 | zea@chromium.org | Thu Jan 06 13:17:49 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/single_client_live_sessions_sync_test.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/live_sessions_sync_test.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/profile_sync_service_session_unittest.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/protocol/session_specifics.proto?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_id.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/two_client_live_sessions_sync_test.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.cc?r1=70645&r2=70644&pathrev=70645
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator_unittest.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/new_new_tab.js?r1=70645&r2=70644&pathrev=70645
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/foreign_session_tracker.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_restore.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_change_processor.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=70645&r2=70644&pathrev=70645
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/foreign_session_tracker.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/session_model_associator.cc?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncapi.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/foreign_session_handler.h?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=70645&r2=70644&pathrev=70645
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_types.h?r1=70645&r2=70644&pathrev=70645

[SYNC] Sessions datatype refactor. Most things related to sessions under-the-hood have changed. More tests on the way.

BUG= 30519 , 62753 
TEST=unit_tests,sync_integration_tests

Review URL: http://codereview.chromium.org/5705004
------------------------------------------------------------------------

Comment 44 by zea@chromium.org, Jan 19 2011

Blockedon: 59242
 Issue 66503  has been merged into this issue.
 Issue 85149  has been merged into this issue.
 Issue 85508  has been merged into this issue.

Comment 48 by tim@chromium.org, Jun 29 2011

Labels: -Mstone-14 Mstone-15

Comment 49 by nmb...@gmail.com, Jul 4 2011

For those interested in an immediate solution to this problem, I've developed an extension that will push a window of tabs from one computer to another.
It may be installed from here: https://chrome.google.com/webstore/detail/aifeiagmjiaflfnimgdioknejnpfkbpa

Comment 50 by zea@chromium.org, Sep 7 2011

Status: Fixed

Comment 51 by jru...@gmail.com, Sep 7 2011

Status: Fixed!!! So excited to try this out!!!
@jru...@gmail.com:
Thanks for spamming about 128 people who have started the bug to get news about the development!
Project Member

Comment 53 by bugdroid1@chromium.org, Oct 13 2012

Blockedon: -chromium:59242 -chromium:59672 chromium:59242 chromium:59672
Blocking: -chromium-os:906 -chromium-os:908 -chromium:68758 -chromium:70699 -chromium:62745 -chromium:67068 chromium-os:906 chromium-os:908 chromium:68758 chromium:70699 chromium:62745 chromium:67068
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 54 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-Sync -Mstone-15 -Area-UI Cr-Services-Sync Cr-UI M-15
Project Member

Comment 55 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment