New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 303957 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2013
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Make Chrome support only SPDY/3 and above

Project Member Reported by akalin@chromium.org, Oct 4 2013

Issue description

As sent to spdy-dev@:

...Chrome has supported SPDY/3.1 since M28 and we are confident that it will work as the stable SPDY version. Therefore, we (Chrome) are planning to retire SPDY/2 also.

The tentative plan is to:

1) Stop advertising SPDY/2 in the next stable version of Chrome (M32), but still keep around a flag to turn it on for diagnostic purposes.

2) Remove all SPDY/2-specific code in the following stable version of Chrome (M33).
 
M31 branch point has already passed so I can go ahead with part 1 on trunk.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4 2013

------------------------------------------------------------------------
r227043 | akalin@chromium.org | 2013-10-04T18:39:21.770606Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_server_properties_manager_unittest.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_server_properties_manager.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_stream.h?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties_impl_unittest.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_info.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_pool.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/next_proto.h?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/buffered_spdy_framer.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_test_util_common.cc?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.h?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.h?r1=227043&r2=227042&pathrev=227043
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session.h?r1=227043&r2=227042&pathrev=227043

[SPDY] Remove references to obsolete SPDY versions SPDY/1 and SPDY/2.1

Remove them from NextProto and AlternateProtocol enums.

Add constants for minimum/maximum/number of valid AlternateProtocol
enum values and use that consistently.

Take care of TODOs to use kProtoSPDYMinimumVersion instead of
kProtoSPDY2 (since they're now one and the same).

BUG= 303957 
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/25956002
------------------------------------------------------------------------
r227229 is also for this bug (not sure why this bug wasn't updated).
Labels: M-32
Status: Fixed
Split off #2 into 304955, repurposing this one for #1 and closing (since it's fixed by r227229).
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8 2013

------------------------------------------------------------------------
r227229 | akalin@chromium.org | 2013-10-06T05:26:02.568219Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_net_benchmarking_message_filter.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/quic/quic_network_transaction_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_info.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket_pool_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl_request_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_pool.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/next_proto.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/buffered_spdy_framer_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler_spdy_test.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_layer.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_proxy_client_socket_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_http_stream_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_stream_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/http_server_properties_manager_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_network_transaction_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_websocket_stream_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_server_properties_impl_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_stream_factory_impl_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_job_test.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_pool_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_info.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/buffered_spdy_framer.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_proxy_client_socket_pool_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/ssl_client_socket.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_impl_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_layer.h?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_pipelined_host_forced_unittest.cc?r1=227229&r2=227228&pathrev=227229
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=227229&r2=227228&pathrev=227229

[SPDY] Do not advertise SPDY/2 by default

Add a switch to re-enable advertising SPDY/2.

Use SPDY/3 instead of SPDY/2 for cases where SPDY is forced on. Also use SPDY/3 instead of SPDY/2 in tests.

Add "deprecated" to all enum constants involving SPDY/2.

Remove unused --enable-npn switch.

BUG= 303957 
R=darin@chromium.org, rtenneti@chromium.org

Review URL: https://codereview.chromium.org/25977005
------------------------------------------------------------------------
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2014

------------------------------------------------------------------------
r254316 | willchan@chromium.org | 2014-03-01T01:42:01.200810Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.cc?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/io_thread.h?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_session.cc?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_pool.cc?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_session.h?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/spdy/spdy_session_pool.h?r1=254316&r2=254315&pathrev=254316
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_browser_main.cc?r1=254316&r2=254315&pathrev=254316

Remove a bunch of unused network flags.

--enable-sdch (renamed to --enable-sdch-over-https)
--enable-spdy2
--max-spdy-concurrent-streams (kept the ability in the networking library to expose this for configuration purposes, but chromium will not configure it)
--enable-ip-pooling
--disable-ip-pooling

BUG= 344673 , 303957 , 344684 , 344698 , 344793 

Review URL: https://codereview.chromium.org/169053004
------------------------------------------------------------------------

Comment 7 by laforge@google.com, Mar 4 2015

Labels: -Cr-Internals-Network-SPDY Cr-Internals-Network-HTTP2
Migrate from Cr-Internals-Network-SPDY to Cr-Internals-Network-HTTP2

Sign in to add a comment