New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2013
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 295895



Sign in to add a comment
link

Issue 303848: Limit max memory for decoded images on all devices

Reported by wangxianzhu@chromium.org, Oct 3 2013 Project Member

Issue description

Bug 295895  #16  klobag said:

2. As we already have the support for the cap of decoded image, we can add the cap for the none low end devices. e.g. we can limit the cap to be 1/10 of the physicalAvailMemory and round it to the closest MB. Xianzhu, can you add this for M31?
 

Comment 1 by wangxianzhu@chromium.org, Oct 3 2013

Blocking: chromium:295895

Comment 2 by bugdroid1@chromium.org, Oct 4 2013

Project Member
------------------------------------------------------------------------
r227063 | wangxianzhu@chromium.org | 2013-10-04T19:58:39.360703Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/child/webkitplatformsupport_impl.cc?r1=227063&r2=227062&pathrev=227063

Android: limit image decoded size based on amount of physical memory

The previous change (https://codereview.chromium.org/23600067/) added
limit for low end devices (memory <= 512MB). Now limit on all devices
to display huge images without crash or displaying as corrupted images.

This CL is still Android. The method might be also useful on other
platforms but the best parameters may differ (may be affected by the
swap memory).

BUG= 303848 

Review URL: https://codereview.chromium.org/25938002
------------------------------------------------------------------------

Comment 3 by klo...@chromium.org, Oct 4 2013

Labels: Merge-Requested

Comment 4 by laforge@google.com, Oct 7 2013

Labels: -Merge-Requested Merge-Approved

Comment 5 by wangxianzhu@chromium.org, Oct 7 2013

Labels: -Merge-Approved Merge-Merged-1650
Merge 227063 "Android: limit image decoded size based on amount ..."

> Android: limit image decoded size based on amount of physical memory
> 
> The previous change (https://codereview.chromium.org/23600067/) added
> limit for low end devices (memory <= 512MB). Now limit on all devices
> to display huge images without crash or displaying as corrupted images.
> 
> This CL is still Android. The method might be also useful on other
> platforms but the best parameters may differ (may be affected by the
> swap memory).
> 
> BUG= 303848 
> 
> Review URL: https://codereview.chromium.org/25938002

TBR=wangxianzhu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227291

Comment 6 by wangxianzhu@chromium.org, Oct 7 2013

Status: Fixed

Comment 7 by bugdroid1@chromium.org, Oct 8 2013

Project Member
------------------------------------------------------------------------
r227291 | wangxianzhu@chromium.org | 2013-10-07T16:32:58.722242Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1650/src/webkit/child/webkitplatformsupport_impl.cc?r1=227291&r2=227290&pathrev=227291

Merge 227063 "Android: limit image decoded size based on amount ..."

> Android: limit image decoded size based on amount of physical memory
> 
> The previous change (https://codereview.chromium.org/23600067/) added
> limit for low end devices (memory <= 512MB). Now limit on all devices
> to display huge images without crash or displaying as corrupted images.
> 
> This CL is still Android. The method might be also useful on other
> platforms but the best parameters may differ (may be affected by the
> swap memory).
> 
> BUG= 303848 
> 
> Review URL: https://codereview.chromium.org/25938002

TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/26282002
------------------------------------------------------------------------

Comment 9 by wangxianzhu@chromium.org, Oct 14 2013

Status: Fixed
This bug is only for limiting decoded image size. Now the decoded image size is limited. The crash itself is tracked in bug 295895.

Comment 10 by piman@chromium.org, Apr 2 2014

Labels: -Restrict-View-Google

Sign in to add a comment