New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Refactor the PDF plugin to be an extension

Project Member Reported by raymes@chromium.org, Oct 3 2013

Issue description

Refactor the PDF plugin to be an extension with a nested plugin.
 
Showing comments 130 - 229 of 229 Older
Project Member

Comment 130 by bugdroid1@chromium.org, Aug 22 2014

------------------------------------------------------------------
r291387 | n.bansal@samsung.com | 2014-08-22T12:18:59.863415Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/pdf/viewport.js?r1=291387&r2=291386&pathrev=291387

OOP PDF - Update zoom factor to fall within range

Currently setZoom() doesn't check whether zoom factor provided
falls within range or not. It is possible to pass big zoom level
through 'zoom' open pdf parameter which can make browser unresponsive.

This patch updates the zoom factor provided in setZoom() to fall
within range.

BUG= 303491 

Review URL: https://codereview.chromium.org/475933004
-----------------------------------------------------------------
Project Member

Comment 131 by bugdroid1@chromium.org, Aug 22 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4271e16b743b649e0d584dcfb90c5ae976864ce2

commit 4271e16b743b649e0d584dcfb90c5ae976864ce2
Author: n.bansal@samsung.com <n.bansal@samsung.com@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri Aug 22 12:18:59 2014

OOP PDF - Update zoom factor to fall within range

Currently setZoom() doesn't check whether zoom factor provided
falls within range or not. It is possible to pass big zoom level
through 'zoom' open pdf parameter which can make browser unresponsive.

This patch updates the zoom factor provided in setZoom() to fall
within range.

BUG= 303491 

Review URL: https://codereview.chromium.org/475933004

Cr-Commit-Position: refs/heads/master@{#291387}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291387 0039d316-1c4b-4281-b951-d872f2087c98


Project Member

Comment 132 by bugdroid1@chromium.org, Aug 28 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53b6e7a7c94dfdd0b2b5b8632776d5978bf46b91

commit 53b6e7a7c94dfdd0b2b5b8632776d5978bf46b91
Author: n.bansal <n.bansal@samsung.com>
Date: Thu Aug 28 10:59:37 2014

OOP PDF - Add OpenPDFParamsParser class

This patch introduces OpenPDFParamsParser class which is responsible
to parse open pdf parameters and set them in a dictionary. This
dictionary will be used to set initial viewport settings when opening
pdf document.

BUG= 303491 

Review URL: https://codereview.chromium.org/477933003

Cr-Commit-Position: refs/heads/master@{#292360}

[add] https://chromium.googlesource.com/chromium/src.git/+/53b6e7a7c94dfdd0b2b5b8632776d5978bf46b91/chrome/browser/resources/pdf/open_pdf_params_parser.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/53b6e7a7c94dfdd0b2b5b8632776d5978bf46b91/chrome/browser/resources/pdf/pdf.js

Project Member

Comment 133 by bugdroid1@chromium.org, Sep 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d

commit abce781d9bc37e60d95ed9504407169f845e056d
Author: lazyboy <lazyboy@chromium.org>
Date: Sat Sep 06 13:22:51 2014

Adding MimeHandlerView.

This GuestView type would be used to render out of process pdf through extension.
This introduces BrowserPluginDelegate in content/renderer,
because we need a way to create a MimeHandlerView guest (extensions/ concept)
from BrowserPlugin (content/ concept).

MimeHandlerView is behind --enable-mime-handler-view flag.

BUG= 303491 
Test=Apply http://crrev.com/392813003/ on top of this CL,
Launch chrome with --out-of-process-pdf flag and --enable-mime-handler-view flag
Navigate to a PDF
Check PDF is served using BrowserPlugin, probably easier to see process associated with the BrowserPlugin from Chrome's task manager.

Review URL: https://codereview.chromium.org/376033002

Cr-Commit-Position: refs/heads/master@{#293613}

[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/browser/apps/web_view_interactive_browsertest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/chrome_renderer.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/common/extensions/api/_api_features.json
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/renderer/browser_plugin/chrome_browser_plugin_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/renderer/chrome_content_renderer_client.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/chrome/test/data/extensions/platform_apps/web_view/focus/inject_input_method.js
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/content_renderer.gypi
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/public/renderer/browser_plugin_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/public/renderer/content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/public/renderer/content_renderer_client.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/browser_plugin.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/browser_plugin_manager.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/browser_plugin_manager_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/browser_plugin_manager_impl.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/mock_browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/mock_browser_plugin.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/mock_browser_plugin_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/browser_plugin/mock_browser_plugin_manager.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/content/renderer/render_frame_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/BUILD.gn
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/extension_message_filter.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/extension_message_filter.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/guest_view/guest_view_base.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/guest_view/mime_handler_view/mime_handler_view_constants.h
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
[add] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/api/mime_handler_view_guest_internal.json
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/api/schemas.gypi
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/extension_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/feature_switch.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/feature_switch.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/switches.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/common/switches.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/extensions.gyp
[modify] https://chromium.googlesource.com/chromium/src.git/+/abce781d9bc37e60d95ed9504407169f845e056d/extensions/extensions_strings.grd

Blockedon: chromium:411753
Blockedon: chromium:411765
Project Member

Comment 136 by bugdroid1@chromium.org, Sep 8 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/114290f6ba077e3d434cbe61cfdccbb70d6b5f08

commit 114290f6ba077e3d434cbe61cfdccbb70d6b5f08
Author: raymes <raymes@chromium.org>
Date: Mon Sep 08 17:44:11 2014

Take useful code out of DCHECKS in mime_handler_view_guest.cc

A mistake I've made in the past! Not sure if it's possible to test this code
in release builds.

BUG= 303491 

Review URL: https://codereview.chromium.org/547283002

Cr-Commit-Position: refs/heads/master@{#293751}

[modify] https://chromium.googlesource.com/chromium/src.git/+/114290f6ba077e3d434cbe61cfdccbb70d6b5f08/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Project Member

Comment 137 by bugdroid1@chromium.org, Sep 10 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36ba52d60b693dfe4980b2b73169988f13251324

commit 36ba52d60b693dfe4980b2b73169988f13251324
Author: raymes <raymes@chromium.org>
Date: Wed Sep 10 00:11:37 2014

Remove NOTREACHED verifying no previous exceptions are set in PepperTryCatch

When setting an exception we check that no other exceptions have been set.
However, sometimes it is preferable not to bail out of the
codepath immediately because the code becomes messier. In particular, if
the context is destroyed, an exception will be set which can happen upon
construction of the try/catch. Keeping this NOTREACHED means that we have to check
for an exception after the construction of every try/catch. I can't see a
problem with not checking the exception immediately - other operations will
fail and the result of the try-catch will eventually be set.

BUG= 303491 

Review URL: https://codereview.chromium.org/554173002

Cr-Commit-Position: refs/heads/master@{#294046}

[modify] https://chromium.googlesource.com/chromium/src.git/+/36ba52d60b693dfe4980b2b73169988f13251324/content/renderer/pepper/pepper_try_catch.cc

Blockedon: chromium:416310
Blockedon: chromium:415858
Blockedon: chromium:416328
Blockedon: chromium:416329
Blockedon: chromium:416332
Blockedon: chromium:416333
Blockedon: chromium:416334
Blockedon: chromium:416337
Blockedon: chromium:416339
Blockedon: chromium:418818
Project Member

Comment 149 by bugdroid1@chromium.org, Oct 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e7acfa2273ba3c88b988db4e85beb1014ea35f

commit b3e7acfa2273ba3c88b988db4e85beb1014ea35f
Author: lazyboy <lazyboy@chromium.org>
Date: Tue Oct 07 21:11:46 2014

Fix mime-handler-view crash upon creation:
We don't do create/attach steps through JavaScript API.

This broke after https://crrev.com/e7c9f7781cbc6db099dacbefdc19ac2fd9bfc19a
landed.

BUG= 303491 
Test=Open chrome with --out-of-process-pdf and --enable-mime-handler-view,
  Navigate to a PDF, renderer process shouldn't crash.

Review URL: https://codereview.chromium.org/638703004

Cr-Commit-Position: refs/heads/master@{#298572}

[modify] https://chromium.googlesource.com/chromium/src.git/+/b3e7acfa2273ba3c88b988db4e85beb1014ea35f/extensions/renderer/guest_view/guest_view_container.cc

Sorry for asking, but is this work the reason I can't open PDFs on chrome anymore?
Currently whenever I try to open a PDF I get a blank screen and this on stdout:
Out 07 19:40:52 mateus-arch google-chrome-unstable.desktop[7592]: [7592:7592:1007/194052:ERROR:navigation_entry_screenshot_manager.cc(152)] Invalid entry with unique id: 136

That unique ID seems to be unique (totally truth) between every try.
I am currently running 39.0.2171.7 dev (64-bit) on Arch Linux.
No, it sounds like you're hitting another bug. Please file a separate issue.
Thanks, filled  Issue 421527  .
Just pointing that some versions ago I was getting crashes. And I am using that out-of-process-pdf flag.
Well, the bug I filed is probably related to the work being done here:

Running chrome with --out-of-process-pdf triggers it.
Running with --out-of-process-pdf and enable-mime-handler-view (as #149 says in the description) I can read the PDF without any problem.
Project Member

Comment 154 by bugdroid1@chromium.org, Oct 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dc6e4f0eead4a98a7fcc876d14eb1a46b565641

commit 2dc6e4f0eead4a98a7fcc876d14eb1a46b565641
Author: raymes <raymes@chromium.org>
Date: Mon Oct 13 18:09:13 2014

Always enable the mime-handler-view feature for OOP PDF

This always enables the --enable-mime-handler-view FeatureSwitch when
--out-of-process-pdf is specified.

BUG= 303491 

Review URL: https://codereview.chromium.org/623813003

Cr-Commit-Position: refs/heads/master@{#299320}

[modify] https://chromium.googlesource.com/chromium/src.git/+/2dc6e4f0eead4a98a7fcc876d14eb1a46b565641/chrome/common/chrome_content_client.cc

Project Member

Comment 155 by bugdroid1@chromium.org, Oct 13 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629

commit 0fa0be50a2ca75472c27113b43bd5b3bc42d7629
Author: raymes <raymes@chromium.org>
Date: Mon Oct 13 20:38:09 2014

Implement find in page support for top level BrowserPlugins.

Right now BrowserPlugins don't handle find in page. This CL adds support for find in page in MIMEHandlerView BrowserPlugin instances.

Find in page is only handled for "full page" plugins, that is when the BrowserPlugin as loaded at the top level. The reason is because supporting find in embedded BrowserPlugins would require recursively searching which is far more complicated to implement and we (jam@, fsamuel@) have decided to defer implementing for the time being.

Detecting whether the BrowserPlugin is loaded at the top level requires detecting whether the main frame is a "plugin document" in blink, which needs to be sent to the browser from the renderer. It isn't sufficient to determine whether the BrowserPlugin is merely loaded in the main frame, because it may be <embed>ed inside a html document in the main frame. In that case we don't want find in page to search the document.

BUG= 303491 

Review URL: https://codereview.chromium.org/597753003

Cr-Commit-Position: refs/heads/master@{#299358}

[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/browser/browser_plugin/browser_plugin_embedder.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/browser/browser_plugin/browser_plugin_embedder.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/browser/browser_plugin/browser_plugin_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/browser/browser_plugin/browser_plugin_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/browser/web_contents/web_contents_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/common/browser_plugin/browser_plugin_messages.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/public/browser/browser_plugin_guest_delegate.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/public/browser/browser_plugin_guest_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/content/renderer/browser_plugin/browser_plugin.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/extensions/browser/api/web_view/web_view_internal_api.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/0fa0be50a2ca75472c27113b43bd5b3bc42d7629/extensions/browser/guest_view/web_view/web_view_guest.h

Blocking: chromium:423184
Blocking: -chromium:423184
Blockedon: chromium:423184
Project Member

Comment 159 by bugdroid1@chromium.org, Oct 29 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3edd4d5d972d3820ec22cebd011ecbd9d4841143

commit 3edd4d5d972d3820ec22cebd011ecbd9d4841143
Author: raymes <raymes@chromium.org>
Date: Wed Oct 29 01:29:54 2014

Support non-integer scroll offsets being passed to the PDF plugin.

This broke as a result of non-integer scroll offsets being introduced into blink.

BUG= 303491 

Review URL: https://codereview.chromium.org/685923002

Cr-Commit-Position: refs/heads/master@{#301765}

[modify] https://chromium.googlesource.com/chromium/src.git/+/3edd4d5d972d3820ec22cebd011ecbd9d4841143/pdf/out_of_process_instance.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/3edd4d5d972d3820ec22cebd011ecbd9d4841143/pdf/out_of_process_instance.h

Project Member

Comment 160 by bugdroid1@chromium.org, Nov 6 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656

commit 78e3d60d83366c66e82ec147a061be200088a656
Author: raymes <raymes@chromium.org>
Date: Thu Nov 06 23:25:17 2014

Refactor GuestViewContainer to split out WebView related logic and MimeHandlerView related logic.

This refactors GuestViewContainer to separate WebView related logic and MimeHandlerView
related logic. Two subclasses are created to contain the logic related to each. The
content API has to be modified to allow creating each of the two types of container.

BUG= 303491 

Review URL: https://codereview.chromium.org/702433002

Cr-Commit-Position: refs/heads/master@{#303118}

[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/content/public/renderer/browser_plugin_delegate.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/content/renderer/render_frame_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/extensions.gyp
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/BUILD.gn
[add] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/extensions_guest_view_container.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/extensions_guest_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/guest_view_container.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/guest_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/mime_handler_view_container.cc
[add] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/renderer/guest_view/mime_handler_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/78e3d60d83366c66e82ec147a061be200088a656/extensions/shell/renderer/shell_content_renderer_client.cc

Project Member

Comment 161 by bugdroid1@chromium.org, Nov 7 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292

commit 9765493708d63e233b77a1849c0aa399407be292
Author: raymes <raymes@chromium.org>
Date: Fri Nov 07 01:26:22 2014

Support embedded plugins with MimeHandlerView.

This change adds support for embedded plugins getting loaded via MimeHandlerView.
Changes:
-Changes MimeHandlerViewContainer to kick off a URL request when the content
is embedded. This is done because in that case, a URL request isn't started
automatically by the browser.
-Plumb through the original URL that is used to instantiate the plugin so that it can be loaded (as above).
-Change the extensions PluginManager to allow extensions that are associated
with a MIME type to be handlers for the file extensions which correspond with
that MIME type. This is needed because <embed>ed documents don't typically
specify a MIME type.

Currently the URL request made won't correctly be intercepted as an http stream. This change will be made in a followup CL.

BUG= 303491 

Review URL: https://codereview.chromium.org/701713003

Cr-Commit-Position: refs/heads/master@{#303152}

[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/chrome/browser/extensions/plugin_manager.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/chrome/renderer/chrome_content_renderer_client.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/content/public/renderer/content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/content/public/renderer/content_renderer_client.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/content/renderer/render_frame_impl.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/extensions/renderer/guest_view/mime_handler_view_container.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/extensions/renderer/guest_view/mime_handler_view_container.h
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/extensions/shell/renderer/shell_content_renderer_client.cc
[modify] https://chromium.googlesource.com/chromium/src.git/+/9765493708d63e233b77a1849c0aa399407be292/extensions/shell/renderer/shell_content_renderer_client.h

Blockedon: chromium:431181
Blockedon: chromium:431185
Blockedon: chromium:432453
Blockedon: chromium:432811
Blockedon: chromium:432809
Blockedon: chromium:433713
Blockedon: chromium:434223
Blockedon: chromium:434982
Blockedon: chromium:435420
Blockedon: chromium:435478
Blockedon: -chromium:304966
Blockedon: chromium:436339
Blockedon: chromium:436345
Blockedon: chromium:436444
Project Member

Comment 176 by bugdroid1@chromium.org, Nov 26 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35a4ea650df5c2a1863707104cc93cf0736a7f97

commit 35a4ea650df5c2a1863707104cc93cf0736a7f97
Author: raymes <raymes@chromium.org>
Date: Wed Nov 26 00:49:14 2014

Change the flag which enables OOP PDF to an enable/disable flag

This leaves the default as disabled.

BUG= 303491 

Review URL: https://codereview.chromium.org/756653005

Cr-Commit-Position: refs/heads/master@{#305738}

[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/browser/about_flags.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/browser/chrome_browser_main_win.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/browser/chrome_content_browser_client.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/browser/extensions/component_loader.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/browser/resources/pdf/pdf_extension_test.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/common/chrome_content_client.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/common/chrome_switches.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/common/chrome_switches.h
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/chrome/renderer/printing/print_web_view_helper.cc
[modify] http://crrev.com/35a4ea650df5c2a1863707104cc93cf0736a7f97/tools/metrics/histograms/histograms.xml

Blockedon: chromium:439867
Blockedon: chromium:440657
Blockedon: chromium:441132
Blockedon: -chromium:436345

Comment 181 by wfh@chromium.org, Dec 15 2014

Blockedon: chromium:442493
Project Member

Comment 182 by bugdroid1@chromium.org, Dec 15 2014

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81c98ba5f74cbe9e6f1a12a0b96371b65dd4374e

commit 81c98ba5f74cbe9e6f1a12a0b96371b65dd4374e
Author: sammc <sammc@chromium.org>
Date: Mon Dec 15 23:20:02 2014

OOP PDF: Fix PrintWebViewHelper test issues with OOP PDF enabled.

OOP PDF causes that the print-preview page to contain an iframe of the
PDF extension instead of directly including a plugin element. However,
the tests for PrintWebViewHelper use a fake print-preview page that
cannot contain an iframe of the extension because the necessary
infrastructure is not available in the test. This relaxes the
expectations so that in tests where the pdf element isn't an iframe,
that element is used instead.

BUG= 303491 

Review URL: https://codereview.chromium.org/800343004

Cr-Commit-Position: refs/heads/master@{#308450}

[modify] http://crrev.com/81c98ba5f74cbe9e6f1a12a0b96371b65dd4374e/chrome/renderer/printing/print_web_view_helper.cc

Blockedon: chromium:443811
Blockedon: chromium:444752
Blockedon: chromium:446390
Blockedon: -chromium:442493
Labels: M-42
Project Member

Comment 188 by bugdroid1@chromium.org, Jan 11 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff54748f98853a5fedb2010c0c0f6748ded9cf2e

commit ff54748f98853a5fedb2010c0c0f6748ded9cf2e
Author: raymes <raymes@chromium.org>
Date: Sun Jan 11 23:52:50 2015

Enable the OOP PDF viewer as the default

BUG= 303491 

Review URL: https://codereview.chromium.org/748553003

Cr-Commit-Position: refs/heads/master@{#311010}

[modify] http://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e/chrome/common/chrome_switches.cc

Project Member

Comment 189 by bugdroid1@chromium.org, Jan 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c998ca372838d0b700c87dd8eda905ab2d1260df

commit c998ca372838d0b700c87dd8eda905ab2d1260df
Author: raymes <raymes@chromium.org>
Date: Tue Jan 13 04:40:02 2015

Revert of Enable the OOP PDF viewer as the default (patchset #1 id:1 of https://codereview.chromium.org/748553003/)

Reason for revert:
This got merged badly and flipped the wrong flag.

Original issue's description:
> Enable the OOP PDF viewer as the default
>
> BUG= 303491 
>
> Committed: https://crrev.com/ff54748f98853a5fedb2010c0c0f6748ded9cf2e
> Cr-Commit-Position: refs/heads/master@{#311010}

TBR=thestig@chromium.org,sammc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 303491 

Review URL: https://codereview.chromium.org/835273005

Cr-Commit-Position: refs/heads/master@{#311214}

[modify] http://crrev.com/c998ca372838d0b700c87dd8eda905ab2d1260df/chrome/common/chrome_switches.cc

Project Member

Comment 190 by bugdroid1@chromium.org, Jan 13 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ab2c77414eac62cd067a91f7b9b17af3770ae8

commit 68ab2c77414eac62cd067a91f7b9b17af3770ae8
Author: raymes <raymes@chromium.org>
Date: Tue Jan 13 06:21:33 2015

Enable the OOP PDF viewer as the default

This relands https://codereview.chromium.org/748553003/ which got incorrectly
merged by the commit bot :(

TBR=sammc@chromium.org
BUG= 303491 

Review URL: https://codereview.chromium.org/850633002

Cr-Commit-Position: refs/heads/master@{#311225}

[modify] http://crrev.com/68ab2c77414eac62cd067a91f7b9b17af3770ae8/chrome/common/chrome_switches.cc

Project Member

Comment 191 by bugdroid1@chromium.org, Jan 14 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61578df45fc7a7d7d6a25bde8865769f05a0de5e

commit 61578df45fc7a7d7d6a25bde8865769f05a0de5e
Author: raymes <raymes@chromium.org>
Date: Wed Jan 14 03:18:11 2015

Merge html-office-public repo into src

This was originally intended to be shared code with another project but that
will no longer be the case.

BUG= 303491 

Review URL: https://codereview.chromium.org/853603002

Cr-Commit-Position: refs/heads/master@{#311400}

[modify] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/DEPS
[modify] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/component_extension_resources.grd
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_fit_page.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_fit_width.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_play.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_print.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_save.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_zoom_in.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/hiDPI/button_zoom_out.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_fit_page.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_fit_width.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_play.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_print.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_save.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_zoom_in.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/img/lowDPI/button_zoom_out.png
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/viewer-button.css
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/viewer-button.html
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-button/viewer-button.js
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.css
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.js
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.css
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.html
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.css
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.js
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.css
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.html
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-progress-bar/viewer-progress-bar.js
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.css
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.html
[add] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/elements/viewer-toolbar/viewer-toolbar.js
[modify] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/index-material.html
[modify] http://crrev.com/61578df45fc7a7d7d6a25bde8865769f05a0de5e/chrome/browser/resources/pdf/index.html

Blockedon: chromium:448473 chromium:448561
Blockedon: chromium:374673
Blockedon: chromium:450029
Blockedon: chromium:449919

Comment 198 by wfh@chromium.org, Jan 20 2015

Blocking: chromium:365160

Comment 199 by wfh@chromium.org, Jan 20 2015

Hi, is this still on track for M42?  Let me know if you need any help, as we'd like to turn the win32k renderer sandbox lockdown, and it depends on having OOP PDF.  Thanks!
We're still on track! It is enabled on canary by default. We're in the
process of fixing some regressions that have come up.

Cheers!
Raymes
Project Member

Comment 201 by bugdroid1@chromium.org, Jan 22 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59ab7ac8433652b921f2a93289c6d13b862e5a0

commit b59ab7ac8433652b921f2a93289c6d13b862e5a0
Author: raymes <raymes@chromium.org>
Date: Thu Jan 22 02:07:49 2015

Delay printing OOP PDF until loading is complete

This delays the print command in OOP PDF. This simplifies the use of the OOP PDF scripting API so print can be called immediately before the document is loaded.

BUG= 303491 

Review URL: https://codereview.chromium.org/865023002

Cr-Commit-Position: refs/heads/master@{#312524}

[modify] http://crrev.com/b59ab7ac8433652b921f2a93289c6d13b862e5a0/pdf/out_of_process_instance.cc
[modify] http://crrev.com/b59ab7ac8433652b921f2a93289c6d13b862e5a0/pdf/out_of_process_instance.h

Blockedon: chromium:449923 chromium:450530
Blockedon: chromium:449903
Blockedon: chromium:452319
Blockedon: chromium:451342
Blockedon: -chromium:450530
Blockedon: chromium:453184
Blockedon: -chromium:444752
Blockedon: chromium:453729
Blockedon: chromium:455439
Blockedon: chromium:457457
Blockedon: -chromium:455439
Blockedon: chromium:405305
Blockedon: chromium:458457
Blockedon: chromium:458050
Blockedon: chromium:458927
Blockedon: chromium:459383
Blockedon: chromium:459998
Blockedon: chromium:458047
Blockedon: chromium:461587
Status: Fixed
Project Member

Comment 223 by bugdroid1@chromium.org, May 6 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119

commit a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119
Author: raymes <raymes@chromium.org>
Date: Wed May 06 07:07:33 2015

Remove the in-process PDF viewer from pdf/

BUG= 303491 

Review URL: https://codereview.chromium.org/1125103002

Cr-Commit-Position: refs/heads/master@{#328498}

[modify] http://crrev.com/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119/pdf/BUILD.gn
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/button.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/button.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/control.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/control.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/fading_control.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/fading_control.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/fading_controls.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/fading_controls.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/instance.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/instance.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/number_image_generator.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/number_image_generator.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/page_indicator.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/page_indicator.h
[modify] http://crrev.com/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119/pdf/pdf.cc
[modify] http://crrev.com/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119/pdf/pdf.gyp
[modify] http://crrev.com/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119/pdf/preview_mode_client.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/progress_control.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/progress_control.h
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/thumbnail_control.cc
[delete] http://crrev.com/ecb571288a8df7de01468b2609f1c27f3c91ad3e/pdf/thumbnail_control.h

Project Member

Comment 224 by bugdroid1@chromium.org, May 7 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a

commit ec40c91c3f90649a4e7a29a459839d1fb5a46e1a
Author: raymes <raymes@chromium.org>
Date: Thu May 07 03:44:37 2015

Remove the unused parts of PPB_PDF

These parts were only used by the in-process viewer.

BUG= 303491 
TBR=jam@chromium.org for components/resources/

Review URL: https://codereview.chromium.org/1125113002

Cr-Commit-Position: refs/heads/master@{#328695}

[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/chrome/browser/ui/cocoa/pdf_password_dialog_cocoa.mm
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/chrome/browser/ui/views/pdf_password_dialog.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/chrome/chrome_browser_ui.gypi
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/chrome/renderer/chrome_content_renderer_client.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/chrome/renderer/pepper/chrome_pdf_print_client.h
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/chrome/renderer/pepper/pepper_flash_renderer_host.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf.gypi
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/browser/pdf_web_contents_helper.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/browser/pdf_web_contents_helper.h
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/browser/pdf_web_contents_helper_client.h
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/common/pdf_messages.h
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/renderer/BUILD.gn
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/renderer/pdf_resource_util.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/renderer/pdf_resource_util.h
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/renderer/pepper_pdf_host.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/pdf/renderer/pepper_pdf_host.h
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/pdf/renderer/ppb_pdf_impl.cc
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/pdf/renderer/ppb_pdf_impl.h
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/components/resources/components_scaled_resources.grd
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pan_icon.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_ftp.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_ftp_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_ftp_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_ftw.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_ftw_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_ftw_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_print.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_print_disabled.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_print_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_print_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_save.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_save_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_save_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomin.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomin_end.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomin_end_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomin_end_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomin_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomin_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomout.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomout_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_button_zoomout_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_dropshadow.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_page_indicator_background.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_0.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_1.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_2.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_3.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_4.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_5.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_6.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_7.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_8.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_progress_background.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_0.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_1.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_2.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_3.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_4.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_5.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_6.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_7.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_8.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_9.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_100_percent/pdf/pdf_thumbnail_num_background.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pan_icon.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_ftp.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_ftp_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_ftp_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_ftw.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_ftw_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_ftw_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_print.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_print_disabled.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_print_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_print_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_save.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_save_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_save_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomin.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomin_end.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomin_end_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomin_end_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomin_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomin_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomout.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomout_hover.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_button_zoomout_pressed.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_dropshadow.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_page_indicator_background.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_0.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_1.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_2.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_3.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_4.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_5.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_6.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_7.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_8.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_progress_background.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_0.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_1.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_2.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_3.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_4.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_5.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_6.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_7.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_8.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_9.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/default_200_percent/pdf/pdf_thumbnail_num_background.png
[delete] http://crrev.com/cfae748cda0ab6830022fd99159c6e494e271e0f/components/resources/pdf_scaled_resources.grdp
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/ppapi/tests/test_pdf.cc
[modify] http://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a/ppapi/tests/test_pdf.h

Project Member

Comment 226 by bugdroid1@chromium.org, May 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf

commit b40097fbb3bc496b9dd94caf5a50866e6f8c62bf
Author: raymes <raymes@chromium.org>
Date: Fri May 29 00:49:38 2015

Removed unused functions in PPB_PDF

There are a bunch of PPB_PDF functions that are now unused. Delete them.

BUG= 303491 

Review URL: https://codereview.chromium.org/1154313002

Cr-Commit-Position: refs/heads/master@{#331899}

[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/components/pdf.gypi
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/components/pdf/renderer/BUILD.gn
[delete] http://crrev.com/a9fa362dd87e988768d0aab5c6ea0601d882a57e/components/pdf/renderer/pdf_resource_util.cc
[delete] http://crrev.com/a9fa362dd87e988768d0aab5c6ea0601d882a57e/components/pdf/renderer/pdf_resource_util.h
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/components/pdf/renderer/pepper_pdf_host.cc
[delete] http://crrev.com/a9fa362dd87e988768d0aab5c6ea0601d882a57e/ppapi/api/private/finish_writing_these/ppb_pdf.idl
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/c/private/ppb_pdf.h
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/cpp/private/pdf.cc
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/cpp/private/pdf.h
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/proxy/pdf_resource.cc
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/proxy/pdf_resource.h
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/proxy/pdf_resource_unittest.cc
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/proxy/ppapi_messages.h
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/thunk/ppb_pdf_api.h
[modify] http://crrev.com/b40097fbb3bc496b9dd94caf5a50866e6f8c62bf/ppapi/thunk/ppb_pdf_thunk.cc

Project Member

Comment 227 by bugdroid1@chromium.org, May 29 2015

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/994380bfb0056cd5744ead4e7d5018bc17542235

commit 994380bfb0056cd5744ead4e7d5018bc17542235
Author: raymes <raymes@chromium.org>
Date: Fri May 29 01:31:53 2015

Remove unused in-process pepper APIs

Several APIs are now unused after turning on OOP PDF. This removes:
Selection_Dev
Widget_Dev
Scrollbar_Dev
Zoom_Dev

These APIs only work in-process so we can be sure they aren't used by existing plugins (except possibly the NaCl plugin but they aren't used by that either).

BUG= 303491 

Review URL: https://codereview.chromium.org/1161563002

Cr-Commit-Position: refs/heads/master@{#331904}

[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/chrome/common/ppapi_utils.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/content_renderer.gypi
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/pepper_webplugin_impl.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/pepper_webplugin_impl.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/plugin_module.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/content/renderer/pepper/ppb_scrollbar_impl.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/content/renderer/pepper/ppb_scrollbar_impl.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/content/renderer/pepper/ppb_widget_impl.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/content/renderer/pepper/ppb_widget_impl.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/resource_creation_impl.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/content/renderer/pepper/resource_creation_impl.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/native_client_sdk/src/libraries/ppapi/library.dsc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/native_client_sdk/src/libraries/ppapi_cpp/library.dsc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/pdf/out_of_process_instance.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/pdf/out_of_process_instance.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppb_scrollbar_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppb_widget_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppb_zoom_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppp_scrollbar_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppp_selection_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppp_widget_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/api/dev/ppp_zoom_dev.idl
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppb_scrollbar_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppb_widget_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppb_zoom_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppp_scrollbar_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppp_selection_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppp_widget_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/c/dev/ppp_zoom_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/scrollbar_dev.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/scrollbar_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/selection_dev.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/selection_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/widget_client_dev.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/widget_client_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/widget_dev.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/widget_dev.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/zoom_dev.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/cpp/dev/zoom_dev.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/ppapi_shared.gypi
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/ppapi_sources.gypi
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/proxy/interface_list.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/proxy/ppb_instance_proxy.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/proxy/ppb_instance_proxy.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/proxy/resource_creation_proxy.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/proxy/resource_creation_proxy.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/tests/all_c_includes.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/tests/all_cpp_includes.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/tests/test_case.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/tests/test_scrollbar.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/tests/test_scrollbar.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/thunk/BUILD.gn
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/thunk/interfaces_ppb_public_dev.h
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/thunk/ppb_instance_api.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/thunk/ppb_scrollbar_api.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/thunk/ppb_scrollbar_thunk.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/thunk/ppb_video_encoder_thunk.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/thunk/ppb_widget_api.h
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/thunk/ppb_widget_dev_thunk.cc
[delete] http://crrev.com/351d6b2c5d234c814e3d40c0fafebc8ed1f6ea7e/ppapi/thunk/ppb_zoom_dev_thunk.cc
[modify] http://crrev.com/994380bfb0056cd5744ead4e7d5018bc17542235/ppapi/thunk/resource_creation_api.h

Project Member

Comment 229 by bugdroid1@chromium.org, May 29 2015

The following revision refers to this bug:
  http://src.chromium.org/viewvc/blink?view=rev&rev=196119

------------------------------------------------------------------
r196119 | raymes@chromium.org | 2015-05-29T04:11:36.235808Z

Changed paths:
   D http://src.chromium.org/viewvc/blink/trunk/Source/web/ScrollbarGroup.cpp?r1=196119&r2=196118&pathrev=196119
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.cpp?r1=196119&r2=196118&pathrev=196119
   D http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginScrollbarImpl.cpp?r1=196119&r2=196118&pathrev=196119
   D http://src.chromium.org/viewvc/blink/trunk/public/web/WebPluginScrollbarClient.h?r1=196119&r2=196118&pathrev=196119
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/web.gypi?r1=196119&r2=196118&pathrev=196119
   D http://src.chromium.org/viewvc/blink/trunk/public/web/WebPluginScrollbar.h?r1=196119&r2=196118&pathrev=196119
   D http://src.chromium.org/viewvc/blink/trunk/Source/web/ScrollbarGroup.h?r1=196119&r2=196118&pathrev=196119
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginContainerImpl.h?r1=196119&r2=196118&pathrev=196119
   D http://src.chromium.org/viewvc/blink/trunk/Source/web/WebPluginScrollbarImpl.h?r1=196119&r2=196118&pathrev=196119
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebViewImpl.cpp?r1=196119&r2=196118&pathrev=196119
   M http://src.chromium.org/viewvc/blink/trunk/Source/web/WebFrameWidgetImpl.cpp?r1=196119&r2=196118&pathrev=196119

Delete WebPluginScrollbar and friends

This removes WebPluginScrollbar which is no longer used in chromium after
https://codereview.chromium.org/1161563002/

BUG= 303491 

Review URL: https://codereview.chromium.org/1156243002
-----------------------------------------------------------------
Showing comments 130 - 229 of 229 Older

Sign in to add a comment