Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user
Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 252217



Sign in to add a comment
Correct and simplify the cookie events browser test
Reported by phil...@opera.com, Oct 2 2013 Back to list
As discussed in mail and IRC, the cookie events browser test is incorrect, causing flakiness when  issue 252217  was fixed.
 
Comment 1 by phil...@opera.com, Oct 2 2013
Blocking: chromium:252217
Project Member Comment 3 by bugdroid1@chromium.org, Oct 2 2013
------------------------------------------------------------------------
r226456 | philipj@opera.com | 2013-10-02T12:19:28.196357Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/cookies/events/test.js?r1=226456&r2=226455&pathrev=226456

Correct and simplify the cookie events browser test

The listeners were being removed in the completion callback to
chrome.cookies.set instead of in the chrome.cookiesonChanged
listener. Nothing guaranteed the order of these two, so the test
begun failing when delete started waiting for flush in
<https://chromiumcodereview.appspot.com/18032002>.

Simplify the tests by using listenOnce/listenForever.

BUG= 302914 

Review URL: https://codereview.chromium.org/25677004
------------------------------------------------------------------------
Comment 4 by phil...@opera.com, Oct 2 2013
Status: Fixed
Project Member Comment 5 by bugdroid1@chromium.org, Oct 3 2013
------------------------------------------------------------------------
r226720 | philipj@opera.com | 2013-10-03T10:13:16.288381Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/cookies/cookie_monster_unittest.cc?r1=226720&r2=226719&pathrev=226720
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/cookies/cookie_monster.cc?r1=226720&r2=226719&pathrev=226720
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/cookies/cookie_monster.h?r1=226720&r2=226719&pathrev=226720

Wait for store flush in CookieMonster::Delete*Task

Second attempt to commit this, after fixing a flaky test:
http://code.google.com/p/chromium/issues/detail?id=302914

BUG= 252217 

Review URL: https://codereview.chromium.org/18032002
------------------------------------------------------------------------
Sign in to add a comment