New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2015
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----


Sign in to add a comment
link

Issue 302553: Redesign and implement a new Page Info bubble on Android

Reported by clamy@chromium.org, Oct 1 2013 Project Member

Issue description

The goal is three-fold:
1) Bring the page info bubble on Android to the same level of functionality than the desktop.
2) Simplify the display of security information.
3) Add relevant mobile specific information.
 

Comment 1 by clamy@chromium.org, Oct 1 2013

Blockedon: chromium:302555

Comment 3 by srikanth@chromium.org, Oct 2 2013

Maybe best to merge this in with crbug.com/147768 (which links in this work with other parts that depend on this) as well as make that the Type-Launch bug?

Comment 4 by roma@chromium.org, Oct 9 2013

Blockedon: chromium:305700
I've created a design spec bug here:  crbug.com/305700  and blocked this bug and the bug that Srikanth mentions on it. I agree that we should merge this with crbug.com/147768 and make that the launch bug.

The mocks, specs and first iterations will all be tracked in 305700.

Thanks!

Comment 5 by sashab@chromium.org, Oct 8 2014

Blockedon: chromium:365528
Cc: f...@chromium.org egm@chromium.org
Owner: sashab@chromium.org
I'm working on implementing this now. All relevant UI specs are on issue 365528 in the last comment.

Attached some screenshots so you can see the WIP.
pageinfo_short_list.png
61.4 KB View Download
pageinfo_medium_list.png
68.0 KB View Download
pageinfo_long_list.png
70.1 KB View Download
pageinfo_empty_list.png
72.9 KB View Download
pageinfo_medium_list_dropdown_selected.png
67.4 KB View Download
pageinfo_medium_list_dropdown.png
67.4 KB View Download

Comment 6 by sashab@chromium.org, Oct 15 2014

Cc: rolfe@chromium.org
Summary: Redesign and implement a new Page Info bubble on Android (was: Android: meta bug tracking the redesign of the page info bubble)

Comment 7 by sashab@chromium.org, Oct 15 2014

Blockedon: chromium:423617

Comment 8 by sashab@chromium.org, Oct 15 2014

Blockedon: chromium:423619

Comment 9 by sashab@chromium.org, Oct 15 2014

Blockedon: chromium:408406

Comment 10 by sashab@chromium.org, Oct 15 2014

Cc: finnur@chromium.org
Ordering of permissions agreed with rolfe, felt and egm to be:
Cookies
Location
Media (Camera/Mic)
Notifications
Images
Javascript
Popups
Fullscreen
Downloads
Plugins
Google translate (currently in content settings)
Protected content (currently in content settings)

So, for PageInfo, there are only 6 displayed permissions (in this order):
Location
Media (Camera/Mic)
Notifications
Images
Javascript
Popups

Comment 11 by sashab@chromium.org, Oct 16 2014

Blockedon: chromium:424030

Comment 12 by sashab@chromium.org, Oct 16 2014

Clarifications from rolfe: the dialog should appear slightly differently on tablets (rough sketch attached). The max width is 800px at Nexus 7 resolution (400px at 1x resolution).
0 (1).jpg
31.2 KB View Download

Comment 13 by sashab@chromium.org, Oct 21 2014

Screenshots of the dialog for various webpages to show how it should display.
pageinfo_https_long_url.png
157 KB View Download
pageinfo_http_with_port.png
53.8 KB View Download
pageinfo_internal.png
49.8 KB View Download
pageinfo_http.png
190 KB View Download
pageinfo_https_broken.png
110 KB View Download
pageinfo_https_mixed.png
112 KB View Download
pageinfo_https.png
75.4 KB View Download
pageinfo_internal_2.png
42.5 KB View Download

Comment 14 by bugdroid1@chromium.org, Oct 22 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cee6105930e94ad2abf2c004efb1d65c0759a0f

commit 9cee6105930e94ad2abf2c004efb1d65c0759a0f
Author: sashab <sashab@chromium.org>
Date: Wed Oct 22 23:04:03 2014

Enabled the new PageInfo dialog on Android by default

Changed the flag '--enable-new-website-settings' to
'--disable-new-website-settings', which enables the new PageInfo dialog
on Android by default. The dialog can be launched by selecting the lock
icon on non-HTTP pages, or long-pressing on the URL bar on HTTP pages.

BUG= 302553 

Review URL: https://codereview.chromium.org/661803004

Cr-Commit-Position: refs/heads/master@{#300789}

[modify] https://chromium.googlesource.com/chromium/src.git/+/9cee6105930e94ad2abf2c004efb1d65c0759a0f/chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java
[modify] https://chromium.googlesource.com/chromium/src.git/+/9cee6105930e94ad2abf2c004efb1d65c0759a0f/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

Comment 15 by sashab@chromium.org, Nov 5 2014

Blockedon: chromium:430345

Comment 16 by sashab@chromium.org, Nov 6 2014

Blockedon: chromium:425158

Comment 17 by sashab@chromium.org, Nov 6 2014

Blockedon: chromium:430771

Comment 18 by sashab@chromium.org, Nov 6 2014

Blockedon: chromium:431104

Comment 19 by sashab@chromium.org, Nov 23 2014

Blockedon: chromium:435925

Comment 20 by sashab@chromium.org, Nov 27 2014

Blockedon: chromium:437364

Comment 21 by sashab@chromium.org, Dec 1 2014

Blockedon: chromium:437958

Comment 22 by sashab@chromium.org, Dec 30 2014

Blockedon: chromium:432007

Comment 23 by sashab@chromium.org, Feb 5 2015

Labels: Priority-
(No comment was entered for this change.)

Comment 24 by sashab@chromium.org, Feb 5 2015

(No comment was entered for this change.)

Comment 25 by sashab@chromium.org, Feb 5 2015

(No comment was entered for this change.)

Comment 26 by sashab@chromium.org, Apr 15 2015

Owner: benwells@chromium.org

Comment 27 by benwells@chromium.org, Apr 23 2015

Cc: tsergeant@chromium.org
Status: Fixed
I think this is done now. There is still ongoing work but it is well tracked elsewhere.

Reopen if I'm mistaken.

Sign in to add a comment