New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove npr.org quirk in HTMLMediaElement

Reported by phil...@opera.com, Oct 1 2013

Issue description

<http://trac.webkit.org/changeset/58586> added a site-specific quirk in HTMLMediaElement which is unlikely to still be needed. We should try to remove it to find out, and if it is needed put our developer relations resources to work on fixing the problem.
 

Comment 1 by phil...@opera.com, Oct 1 2013

It doesn't look like needsSiteSpecificQuirks is actually enabled on any platform, so if you want I can try to rip all of it out, but in any case I'll start with HTMLMediaElement.

Comment 3 by phil...@opera.com, Oct 1 2013

Owner: phil...@opera.com

Comment 4 by phil...@opera.com, Oct 1 2013

I grepped poorly, site specific quirks are enabled unless --disable-site-specific-quirks is given, but I still think we should remove them where possible.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 2 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=158703

------------------------------------------------------------------------
r158703 | philipj@opera.com | 2013-10-02T09:04:25.494234Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.cpp?r1=158703&r2=158702&pathrev=158703
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.h?r1=158703&r2=158702&pathrev=158703

Remove npr.org quirk in HTMLMediaElement

This quirk was added in <http://trac.webkit.org/changeset/58586> with
reference to <rdar://problem/7902467>. Unfortunately, the details are
unavailable. It's likely that npr.org has changed since this was added,
so try removing the quirk to see if anything breaks.

BUG= 302409 

Review URL: https://codereview.chromium.org/25516002
------------------------------------------------------------------------

Comment 6 by phil...@opera.com, Oct 9 2013

Status: Fixed

Sign in to add a comment