New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 17 users

Issue metadata

Status: Verified
Owner:
User never visited
Closed: Jan 2010
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Content scripts not injected in extension processes

Reported by jackson@chromium.org, Dec 7 2009

Issue description

What steps will reproduce the problem?
1. Install the attached extension
2. Inspect the background page

What is the expected output? 

Console has a message "Content script ran in ..."

What do you see instead?

Content script did not run in the iframe. No message appears.

Builds I've tried:
4.0.249.25 (Official Build 33676) FAIL
4.0.266.0 (33987): FAIL

I will try to find the most recent revision that doesn't fail.
 
Testcase.crx
987 bytes Download
Testcase.zip
735 bytes Download
It appears to have been introduced in r33541

Comment 3 by aa@chromium.org, Dec 7 2009

Labels: -Pri-2 Pri-1 Regression Mstone-4 ReleaseBlock-Stable
Status: Assigned

Comment 4 by evan@chromium.org, Dec 9 2009

Labels: -area-extensions Feature-Extensions
Mass migrating Area-Extensions to Feature-Extensions.
(I also got Area-Extensions removed from the label drop-down so we hopefully 
won't see more bugs with that label.)
I've also noticed an issue with Framesets using Userscripts in ChromePlus 1.3.2.0, 
4.0.258.0. The userscript only runs for the top level document, previously it would 
also run for each frame. I assume this is the same bug?
Is ChromePlus using the all_frames manifest declaration for the user script?

http://code.google.com/chrome/extensions/content_scripts.html
I'm not that familiar with the insides of ChromePlus, but I've been able to do the 
following:
- download Chromium 4.0.258.0 (33210), so the same that ChromePlus 1.3.2.0 is built 
on. 
- Installed my user script, but as an extension rather than sourcing from a user 
script folder since that is now the method used, and it worked correctly on framesets
- Checked in ChromePlus again, where I had been using my user scripts the old way, 
i.e. not installed as an extenstion, but rather in a user script folder. This still 
showed the issue
- Removed my user script folder in ChromePlus and installed in ChromePlus as an 
extension: And it worked.

So, since installing user scripts as extensions is the preferred way, it would appear 
this is a non-issue, relating to ChromePlus still providing an option to have a User 
Script folder. Sorry.

I'll try an pass this info onto the ChromePlus guys, since they should remove the 
user script folder option.

Comment 8 by aa@chromium.org, Dec 12 2009

Summary: Content scripts not injected in extension processes

Comment 9 by Deleted ...@, Dec 15 2009

Content-script is also not injected when page is loaded on an window opened from the
extension.


Comment 10 by aa@chromium.org, Dec 15 2009

Status: Started
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=34668 

------------------------------------------------------------------------
r34668 | aa@chromium.org | 2009-12-15 23:47:39 -0800 (Tue, 15 Dec 2009) | 6 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/content_script_extension_process_apitest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging.h?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging_linux.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging_mac.mm?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/child_process_logging_win.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.h?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_thread.h?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/user_script_slave.cc?r1=34668&r2=34667
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/user_script_slave.h?r1=34668&r2=34667
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/injectionator.js
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/content_script_extension_process/manifest.json

Fix regression where we stopped running content scripts in
extension processes.

BUG= 29621 

Review URL: http://codereview.chromium.org/505012
------------------------------------------------------------------------

Labels: Area-Internals Internals-Install
Labels: -Area-Internals -Internals-Install
Fixing a bulk edit. Looks like the search query was not correct.

Comment 14 by mega...@gmail.com, Jan 5 2010

You can see this issue in my extension One Number 1.0/1.1, where I was opening new tabs 
incorrectly with window.open, which caused the new tabs to be opened in the extension's 
process (hmm maybe this should be filed as a separate bug.).  Users reported extensions 
not working in these tabs.  I figured it was "by design" and not a bug since extensions 
shouldn't really be able to mess with other extensions I think?

Anyways don't bother checking it out in 1.2 since I use the proper chrome.tabs.create 
APIs now.  Not sure if the gallery keeps copies of old versions?

Comment 15 by aa@chromium.org, Jan 6 2010

Status: Fixed

Comment 16 by aa@chromium.org, Jan 6 2010

Merged at r35664
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35664 

------------------------------------------------------------------------
r35664 | aa@chromium.org | 2010-01-06 15:32:21 -0800 (Wed, 06 Jan 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extensions_service.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/renderer_host/browser_render_process_host.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/chrome.gyp?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/child_process_logging.h?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/child_process_logging_linux.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/child_process_logging_mac.mm?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/child_process_logging_win.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/renderer/extensions/extension_process_bindings.h?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/renderer/render_thread.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/renderer/render_thread.h?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/renderer/user_script_slave.cc?r1=35664&r2=35663
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/renderer/user_script_slave.h?r1=35664&r2=35663

Merge 34668: Fix regression where we stopped running content scripts in
extension processes.

BUG= 29621 

------------------------------------------------------------------------

Comment 19 by *mdu@chromium.org, Jan 9 2010

Status: Verified
Verified in build 4.0.249.64 (Official Build 35722), it works fine now.
Does not work in Chrome 5.0331
Labels: -Regression bulkmove Type-Regression
What steps will reproduce the problem?
1. Install the attached extension
2. Inspect the background page

What is the expected output? 

Console has a message "Content script ran in ..."

What do you see instead?

Content script did not run in the iframe. No message appears.

Builds I've tried:
4.0.249.25 (Official Build 33676) FAIL
4.0.266.0 (33987): FAIL

I will try to find the most recent revision that doesn't fail.
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 13 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Mstone-4 -Feature-Extensions -Type-Regression Cr-Platform-Extensions M-4 Type-Bug-Regression
Project Member

Comment 24 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment