New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 29538 link

Starred by 26 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

should be able to uninstall extensions by right-clicking on them

Reported by linus%ch...@gtempaccount.com, Dec 6 2009

Issue description

Not all extensions have UI, but for the ones that do I should be able to 
uninstall them by right-clicking on them and selecting Uninstall.
 

Comment 1 Deleted

Comment 2 by aa@chromium.org, Dec 6 2009

See also  bug 28948 

Comment 3 by aa@chromium.org, Dec 6 2009

Labels: -Area-Misc Feature-Extensions ReleaseBlock-Stable
Status: Started
I'll dup the other bug since this contains more meta info, even though it is newer.
 Issue 28948  has been merged into this issue.

Comment 6 by finnur@chromium.org, Dec 10 2009

Changelist is up for review:
http://codereview.chromium.org/486022

Menu includes:

Disable
Options
Uninstall

How about Check for update?

Comment 8 by finnur@chromium.org, Dec 10 2009

Not sure it is needed, but it would be beyond the scope of this bug... and would 
require some UI to indicate an extension has been updated, which we don't have yet.
Mind if I open up a new issue for it? I think it'd be convenient to update there 
instead of manually Clicking the wrench, then Extensions, then going into Developer 
mode. I realize they auto-update, but sometimes you want to force update (like clicking 
About Google Chrome and selecting "Update now"). The balloon window that shows when a 
new extension has been installed could probably be re-used when an extension has been 
manually updated, couldn't it?
Go right ahead.
Checked in to r34812. Keeping open as per aa to track what needs to be merged.

Comment 12 by evan@chromium.org, Dec 17 2009

Please file PlatformParity-tagged bugs if you didn't implement this for all platforms.
FYI, just submitted  issue 30654  for "update" menu option.
Thanks Evan.
Filed  issue 30655  (Mac) and 30656 (Linux). I might look at implementing the Linux one 
later this week but anyone is free to take it.

Comment 15 by dhw@chromium.org, Dec 17 2009

 Issue 28335  has been merged into this issue.

Comment 16 by dhw@chromium.org, Dec 17 2009

Blockedon: 30655 30656
 Issue 30621  might be a duplicate.
No,  issue 30621  is a separate issue.
Also,  issue 29717  is pretty similar.

Comment 20 by aa@chromium.org, Dec 17 2009

 Issue 29717  has been merged into this issue.
Blockedon: -30655 -30656
Status: Fixed
Merged into 249 branch at r34858. Closing this one since we have two other bugs keeping 
track of the platform parity.
Will someone please "unmerge"  Issue 28335  from this?

It's a separate issue which states this:
"developers of extensions should have enough control where they can add tiered context 
menu items, set/show hot-keys (hot-keys meaning both combination keys like Ctrl+L and 
accessibility letters), and set limited styles (strong, emphasize, etc)."
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=34812 

------------------------------------------------------------------------
r34812 | finnur@chromium.org | 2009-12-16 21:55:32 -0800 (Wed, 16 Dec 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.cc?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/crx_installer.h?r1=34812&r2=34811
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_ui.cc?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=34812&r2=34811
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.h?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=34812&r2=34811
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=34812&r2=34811

Add the right-click context menu for Browser actions and Page Actions.

BUG= 29538 
TEST=Right-click an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=34858 

------------------------------------------------------------------------
r34858 | finnur@chromium.org | 2009-12-17 11:19:12 -0800 (Thu, 17 Dec 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/app/generated_resources.grd?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/crx_installer.cc?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/crx_installer.h?r1=34858&r2=34857
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extensions_ui.cc?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.cc?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.h?r1=34858&r2=34857
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/location_bar_view.cc?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/location_bar_view.h?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/chrome.gyp?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.cc?r1=34858&r2=34857
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.h?r1=34858&r2=34857

Merge 34812 - Add the rightclick context menu for Browser actions and Page Actions.

BUG= 29538 
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/501085
------------------------------------------------------------------------

nathanbrauer: I don't know if issues can be "unmerged", maybe re-create it stating why you think it is 
different.

I created  issue 29717 .  It also contains one separate feature request that is not repeated here: the ability to 
rate extensions directly in the browser.  I'll file a separate request for this.
Yeah, I guess  issue 29717  should have been morphed into that instead of dup'ed, since 
only half of it is a duplicate of this bug.

But, no worries. Just go ahead and file a separate request like you mentioned.
Created  issue 30781  for rating extensions directly in the browser.  Thanks.
Haha,  Issue 28335  has been re-merged into an issue that is actually a duplicate of 
mine.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35007 

------------------------------------------------------------------------
r35007 | laforge@chromium.org | 2009-12-18 15:41:01 -0800 (Fri, 18 Dec 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/app/generated_resources.grd?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/crx_installer.cc?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/crx_installer.h?r1=35007&r2=35006
   D /branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   D /branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extensions_ui.cc?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.cc?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.h?r1=35007&r2=35006
   D /branches/249/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   D /branches/249/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/location_bar_view.cc?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/location_bar_view.h?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/chrome.gyp?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.cc?r1=35007&r2=35006
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.h?r1=35007&r2=35006

Revert 34858 - Merge 34812  Add the rightclick context menu for Browser actions and Page Actions.

BUG= 29538 
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).
Review URL: http://codereview.chromium.org/486022

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/501085

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/501130
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35039 

------------------------------------------------------------------------
r35039 | finnur@chromium.org | 2009-12-18 20:10:00 -0800 (Fri, 18 Dec 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/app/generated_resources.grd?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/crx_installer.cc?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/crx_installer.h?r1=35039&r2=35038
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.cc
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.h
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_disabled_infobar_delegate.cc?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extensions_ui.cc?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.cc?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/browser_actions_container.h?r1=35039&r2=35038
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_action_context_menu.cc
   A http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/extensions/extension_action_context_menu.h
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/location_bar_view.cc?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/views/location_bar_view.h?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/chrome.gyp?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.cc?r1=35039&r2=35038
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/common/extensions/extension.h?r1=35039&r2=35038

Merge 34812 - Add the rightclick context menu for Browser actions and Page
Actions.

BUG= 29538 
TEST=Rightclick an extension icon and make sure all the options work for both
Page and Browser actions (Options should be grayed out when there is no Options
page specified in the manifest).

TBR=laforge@chromium.org

Review URL: http://codereview.chromium.org/501136
------------------------------------------------------------------------

I think UTF8ToUTF16() should be used instead of ASCIIToUTF16()
at Line 30 of extension_action_context_menu_model.cc.
Otherwise multi-byte characters will not be displayed correctly.
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35197 

------------------------------------------------------------------------
r35197 | finnur@chromium.org | 2009-12-22 16:50:53 -0800 (Tue, 22 Dec 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_action_context_menu_model.cc?r1=35197&r2=35196

Fix utf8 issue in extension action context menu.

BUG= 29538 
TEST=Extensions with utf8 encoded names should appear correctly named in the context menu.

Review URL: http://codereview.chromium.org/520001
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=35242 

------------------------------------------------------------------------
r35242 | finnur@chromium.org | 2009-12-23 15:46:44 -0800 (Wed, 23 Dec 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_action_context_menu_model.cc?r1=35242&r2=35241

Merge 35197 - Fix utf8 issue in extension action context menu.

BUG= 29538 
TEST=Extensions with utf8 encoded names should appear correctly named in the context menu.

Review URL: http://codereview.chromium.org/520001

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/515020
------------------------------------------------------------------------

Comment 34 by *mdu@chromium.org, Jan 8 2010

Status: Verified
Verified in build 4.0.249.64 (Official Build 35722), context menu items of extension
UI buttons work.
Project Member

Comment 35 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 36 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Feature-Extensions -Mstone-4 M-4 Cr-Platform-Extensions
Project Member

Comment 37 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment