Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 21 users
Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature

Blocking:
issue 653917



Sign in to add a comment
make chrome build with use_ozone==1 chromeos==0
Reported by tiago.vi...@intel.com, Sep 19 2013 Back to list
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.62 Safari/537.36

Steps to reproduce the problem:
We need a couple of changes in the code mainly related with the isolation of X11 code on Linux to make Ozone platform work with Chrome target.

What is the expected behavior?

What went wrong?
This has never supported before.

Did this work before? No 

Chrome version: 29.0.1547.62  Channel: dev
OS Version: 
Flash Version: Shockwave Flash 11.8 r800
 
Labels: -Via-Wizard -Type-Bug Proj-Ozone Type-Feature
Owner: rjkroege@chromium.org
Project Member Comment 2 by bugdroid1@chromium.org, Sep 23 2013
------------------------------------------------------------------------
r224727 | tiago.vignatti@intel.com | 2013-09-23T16:31:58.566545Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/idle_linux.cc?r1=224727&r2=224726&pathrev=224727

chrome: Check idle state for Ozone platform

X11 screen savers are special ones but we hope that most of the Ozone
implementations won't need these special treatment as in here. Therefore just
return false.

BUG= 295089 

Review URL: https://chromiumcodereview.appspot.com/24114007
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Sep 24 2013
------------------------------------------------------------------------
r224996 | tiago.vignatti@intel.com | 2013-09-24T15:57:29.298132Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/themes/theme_service_factory.cc?r1=224996&r2=224995&pathrev=224996

chrome: Wrap correctly what is X11 theming code

So other Aura platforms can use also this file, in particular for the Chrome
target under Ozone.

BUG= 295089 

Review URL: https://chromiumcodereview.appspot.com/24037004
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Oct 23 2013
------------------------------------------------------------------------
r230526 | tiago.vignatti@intel.com | 2013-10-23T22:35:17.992003Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_utils_x11.cc?r1=230526&r2=230525&pathrev=230526
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser_ui.gypi?r1=230526&r2=230525&pathrev=230526
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/options/advanced_options_utils_linux.cc?r1=230526&r2=230525&pathrev=230526

Convert X11 AdvancedOptionsUtilities to generic Linux platforms

The files being changed on this CL don't touch any X11 specific code, so they can used by other Linux platforms, in particular for Chrome target works under Ozone.
    
BUG= 295089 

Review URL: https://codereview.chromium.org/34583002
------------------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Oct 24 2013
------------------------------------------------------------------------
r230803 | tiago.vignatti@intel.com | 2013-10-24T20:43:28.288795Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/webview/unhandled_keyboard_event_handler_linux.cc?r1=230803&r2=230802&pathrev=230803
   D http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/webview/unhandled_keyboard_event_handler_aurax11.cc?r1=230803&r2=230802&pathrev=230803
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/views/controls/webview/webview.gyp?r1=230803&r2=230802&pathrev=230803

Convert views X11 UnhandledKeyboardEventHandler to other Linux platforms

We have two Linux platforms supported under Aura: Ozone and X11. The files
being changed on this CL don't touch any X11 specific code, so they can used by Ozone as well.

Linux GTK+ takes another path, not using views, so this change doesn't affect that.

BUG= 295089 

Review URL: https://codereview.chromium.org/34573002
------------------------------------------------------------------------
Project Member Comment 6 by bugdroid1@chromium.org, Oct 30 2013
------------------------------------------------------------------------
r231842 | tiago.vignatti@intel.com | 2013-10-30T15:51:11.895541Z

Changed paths:
   D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/aura/tabs/dock_info_aurax11.cc?r1=231842&r2=231841&pathrev=231842
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser_ui.gypi?r1=231842&r2=231841&pathrev=231842
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/aura/tabs/dock_info_auralinux.cc?r1=231842&r2=231841&pathrev=231842

browser: Enable DockInfo for Aura Linux besides X11
    
Currently DockInfo is supporting ChromeOS and Aura X11, but we want to enable
it for Aura Ozone as well.
    
This CL stubs DockInfo::GetLocalProcessWindowAtPoint for non-X11 based
platforms and, in particular, this brings back support for Chrome browser in
Ozone-Wayland.
    
BUG= 295089 

Review URL: https://codereview.chromium.org/29493004
------------------------------------------------------------------------
Labels: Cr-Ozone
Labels: -Cr-Ozone
Labels: M-35
Status: Started
Comment 11 by kareng@google.com, Apr 7 2014
Labels: -M-35 MovedFrom-35 M-36
Moving all non essential bugs to the next Milestone.
Cc: dnicoara@chromium.org
Owner: spang@chromium.org
spang@ you said that you were working on this. 

My assumption: this bug encompasses all necessary !display support code for Chrome to build/run on ozone.
Labels: -M-36 MovedFrom-36
This issue has already been moved once and is lower than Priority 1,therefore removing mstone.
Owner: ----
Status: Available
Summary: make chrome build with use_ozone==1 chromeos==0 (was: Chrome Browser should work in Ozone platform)
Renaming this bug to cover desktop build only and disowning.
Owner: tiago.vi...@intel.com
Labels: Hotlist-Recharge Hotlist-Recharge-Stale
This issue likely requires triage.  The current issue owner may be inactive (i.e. hasn't fixed an issue in the last 30 days or commented in this particular issue in the last 90 days).  It has also not been modified in a year (prior to this update).  Thanks for helping out!

-Anthony
Cc: spang@chromium.org
Cc: j.iso...@samsung.com
Comment 19 by mfor...@gmail.com, Apr 11 2016
Labels: -Hotlist-Recharge hotlist-recharge
 While trying to build Chromium 49.0.2623.112 on desktop Linux with use_ozone==1 chromeos==0

I got the following error:

obj/chrome/browser/notifications/browser.fullscreen_notification_blocker.o: In function `FullscreenNotificationBlocker::CheckState()':
../../chrome/browser/notifications/fullscreen_notification_blocker.cc:(.text._ZN29FullscreenNotificationBlocker10CheckStateEv+0x3c): undefined reference to `IsFullScreenMode()'
obj/chrome/browser/ui/browser_ui.browser_view_prefs.o: In function `chrome::RegisterBrowserViewProfilePrefs(user_prefs::PrefRegistrySyncable*)':
../../chrome/browser/ui/browser_view_prefs.cc:(.text._ZN6chrome31RegisterBrowserViewProfilePrefsEPN10user_prefs20PrefRegistrySyncableE+0x1e): undefined reference to `ui::GetCustomFramePrefDefault()'
obj/chrome/browser/ui/ash/launcher/browser_ui.launcher_context_menu.o: In function `LauncherContextMenu::Init()':
../../chrome/browser/ui/ash/launcher/launcher_context_menu.cc:(.text._ZN19LauncherContextMenu4InitEv+0x526): undefined reference to `IsFullScreenMode()'
obj/chrome/browser/ui/views/tabs/browser_ui.tab_drag_controller.o: In function `TabDragController::GetLocalProcessWindow(gfx::Point const&, bool)':
../../chrome/browser/ui/views/tabs/tab_drag_controller.cc:(.text._ZN17TabDragController21GetLocalProcessWindowERKN3gfx5PointEb+0xdf): undefined reference to `GetLocalProcessWindowAtPoint(chrome::HostDesktopType, gfx::Point const&, std::set<aura::Window*, std::less<aura::Window*>, std::allocator<aura::Window*> > const&)'
obj/chrome/browser/ui/panels/browser_ui.display_settings_provider.o: In function `DisplaySettingsProvider::IsFullScreen()':
../../chrome/browser/ui/panels/display_settings_provider.cc:(.text._ZN23DisplaySettingsProvider12IsFullScreenEv+0x1): undefined reference to `IsFullScreenMode()'
obj/chrome/browser/ui/views/frame/browser_ui.desktop_browser_frame_aura.o: In function `DesktopBrowserFrameAura::InitNativeWidget(views::Widget::InitParams const&)':
../../chrome/browser/ui/views/frame/desktop_browser_frame_aura.cc:(.text._ZN23DesktopBrowserFrameAura16InitNativeWidgetERKN5views6Widget10InitParamsE+0x38): undefined reference to `BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost(views::internal::NativeWidgetDelegate*, views::DesktopNativeWidgetAura*, BrowserView*, BrowserFrame*)'
clang-3.8: error: linker command failed with exit
Comment 20 by spang@chromium.org, Apr 14 2016
Cc: rjkroege@chromium.org
 Issue 602230  has been merged into this issue.
Owner: spang@chromium.org
Similar to comment 19 above, I'm currently getting linker errors when compiling 52.0.2743.6 due to:

* BrowserDesktopWindowTreeHostX11 depending on DesktopWindowTreeHostX11, but the latter not being compiled for Ozone (the former probably needs a new class for Ozone)
* GlobalMenuBarX11 being compiled, but some dependencies not being compiled (same case as before)
* Undefined references to ui::DeviceDataManager::GetInstance() and ui::DeviceDataManager::RemoveObserver(ui::InputDeviceEventOb
server*)
* A few other undefined references to GTK/X11 calls

(Ozone-related arguments set: use_ozone=true ozone_auto_platforms=false ozone_platform_x11=true ozone_platform_wayland=true)
Comment 23 by mfor...@gmail.com, May 27 2016
 I've since found out that this is a feature which is being worked on using  issue #361137    ( https://bugs.chromium.org/p/chromium/issues/detail?id=361137 ) 
 I suppose once that issue is closed it should work. Hopefully the work will be completed.
Comment 24 by fw...@igalia.com, Sep 2 2016
For the record, there is some related work here: https://codereview.chromium.org/2024953007/
Project Member Comment 25 by bugdroid1@chromium.org, Oct 14 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec1f1a08d336158429f96c8e09d590066696b41b

commit ec1f1a08d336158429f96c8e09d590066696b41b
Author: thomasanderson <thomasanderson@google.com>
Date: Fri Oct 14 19:20:05 2016

Add Wayland dev packages to sysroots

BUG= 295089 
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2415933004
Cr-Commit-Position: refs/heads/master@{#425422}

[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.jessie.amd64
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.jessie.arm
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.jessie.arm64
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.jessie.i386
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.jessie.mipsel
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.precise.amd64
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.wheezy.amd64
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.wheezy.arm
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.wheezy.i386
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/packagelist.wheezy.mipsel
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/sysroot-creator-jessie.sh
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/sysroot-creator-precise.sh
[modify] https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b/build/linux/sysroot_scripts/sysroot-creator-wheezy.sh

Project Member Comment 26 by bugdroid1@chromium.org, Oct 19 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/deaf7dd14f748d97edb27edf1eb9e8b0f5bf45bd

commit deaf7dd14f748d97edb27edf1eb9e8b0f5bf45bd
Author: tonikitoo <tonikitoo@igalia.com>
Date: Wed Oct 19 17:42:03 2016

Set ozone_platform_wayland to true for ozone/ChromeOS builds

After [1], sysroots have the required dependencies installed
to get ozone/wayland builds going as part of the ozone/chromeos
buildbot - namely chromium_chromeos_ozone_rel_ng.

[1] https://codereview.chromium.org/2415933004/

BUG= 295089 

Review-Url: https://chromiumcodereview.appspot.com/2423833002
Cr-Commit-Position: refs/heads/master@{#426238}

[modify] https://crrev.com/deaf7dd14f748d97edb27edf1eb9e8b0f5bf45bd/ui/ozone/ozone.gni

Cc: thomasanderson@chromium.org
Project Member Comment 28 by bugdroid1@chromium.org, Oct 26 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1ce090fb362ed48b243cf3c5a926238abac36b5

commit c1ce090fb362ed48b243cf3c5a926238abac36b5
Author: tonikitoo <tonikitoo@igalia.com>
Date: Wed Oct 26 21:22:34 2016

Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate
variable to check for libsecret inclusion. A more accurate
check is 'use_glib', since GLib is the hard dependency
libsecret relies on.

Today use_ozone happens to work because it forcibly disables
use_glib.

BUG= 295089 

Review-Url: https://codereview.chromium.org/2452063002
Cr-Commit-Position: refs/heads/master@{#427801}

[modify] https://crrev.com/c1ce090fb362ed48b243cf3c5a926238abac36b5/chrome/browser/BUILD.gn

Project Member Comment 29 by bugdroid1@chromium.org, Oct 26 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2f307b06528f971698a6e729a89bd74d6a06b23

commit f2f307b06528f971698a6e729a89bd74d6a06b23
Author: tonikitoo <tonikitoo@igalia.com>
Date: Wed Oct 26 21:53:51 2016

Only call X11DesktopHandler for USE_X11 builds

... and the same applies to calling ui::GetCustomFramePrefDefault,
implemented in ui/base/x/x11_util.cc

BUG= 295089 

Review-Url: https://codereview.chromium.org/2454743002
Cr-Commit-Position: refs/heads/master@{#427830}

[modify] https://crrev.com/f2f307b06528f971698a6e729a89bd74d6a06b23/chrome/browser/ui/browser_view_prefs.cc
[modify] https://crrev.com/f2f307b06528f971698a6e729a89bd74d6a06b23/chrome/browser/ui/views/frame/browser_frame.cc

Project Member Comment 30 by bugdroid1@chromium.org, Oct 27 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e861c0932dc392508ab64284ce160d1a58c700e

commit 8e861c0932dc392508ab64284ce160d1a58c700e
Author: tonikitoo <tonikitoo@igalia.com>
Date: Thu Oct 27 22:48:41 2016

Build some x11 dependent files only if 'use_x11'

This will make it easier to make desktop linux chrome
builds, through Ozone.

BUG= 295089 

Review-Url: https://codereview.chromium.org/2457443004
Cr-Commit-Position: refs/heads/master@{#428174}

[modify] https://crrev.com/8e861c0932dc392508ab64284ce160d1a58c700e/chrome/browser/BUILD.gn

Project Member Comment 31 by bugdroid1@chromium.org, Nov 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4772dcd8400da7137c37e9590acdadba1306783

commit a4772dcd8400da7137c37e9590acdadba1306783
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Nov 01 02:04:21 2016

Add Linux Ozone fyi compile-only bot (src-side changes)

BUG= 295089 
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2470453002
Cr-Commit-Position: refs/heads/master@{#428912}

[modify] https://crrev.com/a4772dcd8400da7137c37e9590acdadba1306783/tools/mb/mb_config.pyl

Project Member Comment 32 by bugdroid1@chromium.org, Nov 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad9ff3ca51c167a4473909bb68588b7ede0da52

commit dad9ff3ca51c167a4473909bb68588b7ede0da52
Author: tonikitoo <tonikitoo@igalia.com>
Date: Tue Nov 01 15:54:29 2016

Refactor WindowFinder definition

CL reworks the WindowFinder implementation as follows:

(Before):

- There was a WindowFinder base class, with empty ctor
and  dtor definitions, and one method GetLocalProcessWindowAtPoint,
with platform specific implementations living in
window_finder_{x11,mac,chromeos,win}.

- There used to be a derived class WindowFinderMus, overriding
GetLocalProcessWindowAtPoint.

- TabDragController instantiated either WindowFinder or
WindowFinderMus depending whether the "Mus" code path is
being executed.

(After)

- The Mac platform does not support Mus. So only
 window_finder_mac.mm and window_finder.h are built.

- Other platforms (linux_desktop, chromeos, win) build
window_finder.cc, window_finder_mus.cc as well a platform
specific file; e.g. window_finder_chromeos.cc in case of
ChromeOS.

- CL also moves the logic that checks whether chrome is
running with the Mus path to within  GetLocalProcessWindowAtPointMus.

This CL is a preparation to CL [1], where chrome --mash
capabilities are extended to run through Ozone.

[1] https://codereview.chromium.org/2408803002/

BUG= 295089 

Review-Url: https://codereview.chromium.org/2449103004
Cr-Commit-Position: refs/heads/master@{#429010}

[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/window_finder.h
[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/window_finder_mus.cc
[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/window_finder_mus.h
[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/window_finder_win.cc
[modify] https://crrev.com/dad9ff3ca51c167a4473909bb68588b7ede0da52/chrome/browser/ui/views/tabs/window_finder_x11.cc

Project Member Comment 33 by bugdroid1@chromium.org, Nov 1 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/766b0221447f87540de95ec06836143a6e73f087

commit 766b0221447f87540de95ec06836143a6e73f087
Author: thomasanderson <thomasanderson@google.com>
Date: Tue Nov 01 22:44:48 2016

Add Linux Ozone fyi compile-only bot

BUG= 295089 
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2463523002

[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/masters/master.chromium.fyi/slaves.cfg
[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/masters/master.tryserver.chromium.linux/master.cfg
[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/masters/master.tryserver.chromium.linux/slaves.cfg
[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/scripts/slave/gatekeeper.json
[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/scripts/slave/recipe_modules/chromium_tests/trybots.py
[add] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Ozone_Linux.json
[add] https://crrev.com/766b0221447f87540de95ec06836143a6e73f087/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_ozone_compile_only_ng.json

Project Member Comment 34 by bugdroid1@chromium.org, Nov 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29469b3fd3cc2e74424444a20ef12714710b0509

commit 29469b3fd3cc2e74424444a20ef12714710b0509
Author: thomasanderson <thomasanderson@google.com>
Date: Wed Nov 02 05:36:42 2016

Use ozone config on Linux Ozone bot

CL https://codereview.chromium.org/2470453002/ added the Linux Ozone
bot but did not actually set use_ozone = true.  This CL makes it so
that I stop getting emails about this failure :S

BUG= 295089 
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2466383003
Cr-Commit-Position: refs/heads/master@{#429215}

[modify] https://crrev.com/29469b3fd3cc2e74424444a20ef12714710b0509/tools/mb/mb_config.pyl

Project Member Comment 35 by bugdroid1@chromium.org, Nov 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da97a9ff8dbe3c463ff7d64fd765483401e2feb2

commit da97a9ff8dbe3c463ff7d64fd765483401e2feb2
Author: tonikitoo <tonikitoo@igalia.com>
Date: Wed Nov 02 20:43:39 2016

Condition the use of ChromeBrowserMainExtraPartsViewsLinux to !use_ozone

In order to bring up a Chrome/Chromium Ozone/Wayland build,
it is needed to opt out the instantiation/inclusion of
chrome_browser_main_extra_parts_views_linux.cc/h in Ozone builds.

It should still possible to opt-in the use of CBMEPVL for Ozone builds
in the future, but it would be safer to condition it to an extra GN variable,
where one could explicitly specify that the Gtk wayland backend is to be used.
E.g.:

  if (!use_ozone || use_gtk_wayland_backend) {
    sources += [
      "views/chrome_browser_main_extra_parts_views_linux.cc",
      "views/chrome_browser_main_extra_parts_views_linux.h"
    ]
  } else # regular ozone case {
    sources += [
      "views/chrome_browser_main_extra_parts_views.cc",
      "views/chrome_browser_main_extra_parts_views.h"
    ]
  }

CL also moves the PreProfileInit override from CBMEPVL to CBMEPV,
if-def'ing it out for CHROMEOS, in order to keep the behavior to
desktop linux builds (x11/ozone).

BUG= 295089 

Review-Url: https://codereview.chromium.org/2462423002
Cr-Commit-Position: refs/heads/master@{#429391}

[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.h

Project Member Comment 36 by bugdroid1@chromium.org, Nov 2 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da97a9ff8dbe3c463ff7d64fd765483401e2feb2

commit da97a9ff8dbe3c463ff7d64fd765483401e2feb2
Author: tonikitoo <tonikitoo@igalia.com>
Date: Wed Nov 02 20:43:39 2016

Condition the use of ChromeBrowserMainExtraPartsViewsLinux to !use_ozone

In order to bring up a Chrome/Chromium Ozone/Wayland build,
it is needed to opt out the instantiation/inclusion of
chrome_browser_main_extra_parts_views_linux.cc/h in Ozone builds.

It should still possible to opt-in the use of CBMEPVL for Ozone builds
in the future, but it would be safer to condition it to an extra GN variable,
where one could explicitly specify that the Gtk wayland backend is to be used.
E.g.:

  if (!use_ozone || use_gtk_wayland_backend) {
    sources += [
      "views/chrome_browser_main_extra_parts_views_linux.cc",
      "views/chrome_browser_main_extra_parts_views_linux.h"
    ]
  } else # regular ozone case {
    sources += [
      "views/chrome_browser_main_extra_parts_views.cc",
      "views/chrome_browser_main_extra_parts_views.h"
    ]
  }

CL also moves the PreProfileInit override from CBMEPVL to CBMEPV,
if-def'ing it out for CHROMEOS, in order to keep the behavior to
desktop linux builds (x11/ozone).

BUG= 295089 

Review-Url: https://codereview.chromium.org/2462423002
Cr-Commit-Position: refs/heads/master@{#429391}

[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.h
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/da97a9ff8dbe3c463ff7d64fd765483401e2feb2/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.h

Project Member Comment 37 by bugdroid1@chromium.org, Nov 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03d13e3e9a1f45f3a9b09c54e4c7c26faebfbfcc

commit 03d13e3e9a1f45f3a9b09c54e4c7c26faebfbfcc
Author: thomasanderson <thomasanderson@google.com>
Date: Thu Nov 03 01:34:21 2016

Ozone Linux: Fix linker error in browser_tests

BUG= 295089 
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2477473002
Cr-Commit-Position: refs/heads/master@{#429502}

[modify] https://crrev.com/03d13e3e9a1f45f3a9b09c54e4c7c26faebfbfcc/chrome/test/base/in_process_browser_test.cc

Project Member Comment 38 by bugdroid1@chromium.org, Nov 3 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8468a79ce654fd5594c4ab2b5b40e7b45a71e3d

commit b8468a79ce654fd5594c4ab2b5b40e7b45a71e3d
Author: thomasanderson <thomasanderson@google.com>
Date: Thu Nov 03 12:49:55 2016

Ozone Linux: Fix linker errors in headless_unittests

BUG= 295089 
R=skyostil@chromium.org

Review-Url: https://codereview.chromium.org/2476473002
Cr-Commit-Position: refs/heads/master@{#429548}

[modify] https://crrev.com/b8468a79ce654fd5594c4ab2b5b40e7b45a71e3d/headless/public/util/error_reporter.h

Project Member Comment 40 by bugdroid1@chromium.org, Nov 5 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f84e575ea00a183afd878022f6d481e6057c2354

commit f84e575ea00a183afd878022f6d481e6057c2354
Author: thomasanderson <thomasanderson@google.com>
Date: Sat Nov 05 03:39:17 2016

Add ozone_platform_gbm=true to Ozone Linux bot

BUG= 295089 
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2480573003
Cr-Commit-Position: refs/heads/master@{#430144}

[modify] https://crrev.com/f84e575ea00a183afd878022f6d481e6057c2354/tools/mb/mb_config.pyl

Project Member Comment 41 by bugdroid1@chromium.org, Nov 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b10ea66fcc43a0eed828eb62ffb2bd141b825fce

commit b10ea66fcc43a0eed828eb62ffb2bd141b825fce
Author: tonikitoo <tonikitoo@igalia.com>
Date: Mon Nov 07 23:52:01 2016

Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0

As of now, chrome --mash is possible to get launched on regular
chrome desktop Linux builds (with enable_package_mash_services = true)
and on chromeos builds.

CL provides a first step for running with chrome --mash
natively on both Wayland and X11, through Ozone.
It includes 3 stub'ed methods for now, to be implemented follow up CLs.

GN args:
  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = true
  ozone_auto_platforms = false
  enable_package_mash_services = true

Additionally, CL also makes it possible to turn green the FYI
linux/ozone bot, worked out by thomasanderson@ et al.

TEST= <out>/chrome --mash --ozone-platform=wayland|x11 --user-data-dir=~/tmp

BUG= 295089 

Review-Url: https://codereview.chromium.org/2408803002
Cr-Commit-Position: refs/heads/master@{#430424}

[modify] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/BUILD.gn
[add] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/fullscreen_ozone.cc
[add] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/media/webrtc/window_icon_util_ozone.cc
[modify] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc
[add] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/ui/views/frame/native_browser_frame_factory_ozone.cc
[add] https://crrev.com/b10ea66fcc43a0eed828eb62ffb2bd141b825fce/chrome/browser/ui/views/tabs/window_finder_ozone.cc

Project Member Comment 42 by bugdroid1@chromium.org, Nov 8 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15744c760b64d09988003601596ed16bad40df6f

commit 15744c760b64d09988003601596ed16bad40df6f
Author: fwang <fwang@igalia.com>
Date: Tue Nov 08 13:58:33 2016

Ozone documentation: Take into account recent changes in Linux Desktop

BUG= 295089 

Review-Url: https://codereview.chromium.org/2490533002
Cr-Commit-Position: refs/heads/master@{#430599}

[modify] https://crrev.com/15744c760b64d09988003601596ed16bad40df6f/docs/ozone_overview.md

Status: Fixed
Blocking: 653917
Project Member Comment 46 by bugdroid1@chromium.org, Jan 9 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af9db6743eb97d139fc3e7460a51830cc942d1f

commit 7af9db6743eb97d139fc3e7460a51830cc942d1f
Author: fwang <fwang@igalia.com>
Date: Mon Jan 09 14:52:22 2017

Ash should only build on Chrome OS [1], so to run Ozone on Linux Desktop
the command line option --window-manager=simple_wm is now recommended.
The patch [2] is no longer recommended for Linux Desktop and the fact
that the support is unstable is highlighted. Finally, the mentions of
working/non-working targets is simplified a bit.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=666773
[2] https://codereview.chromium.org/2485673002/

BUG= 295089 

Review-Url: https://codereview.chromium.org/2621563003
Cr-Commit-Position: refs/heads/master@{#442248}

[modify] https://crrev.com/7af9db6743eb97d139fc3e7460a51830cc942d1f/docs/ozone_overview.md

Project Member Comment 47 by bugdroid1@chromium.org, Apr 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/150a0a9177dc26b6ebbe66f909c0860a49bfb6e1

commit 150a0a9177dc26b6ebbe66f909c0860a49bfb6e1
Author: tonikitoo <tonikitoo@igalia.com>
Date: Sat Apr 22 19:13:14 2017

Obsolete the ozone code path in ui/views/

Ozone works today as a windowing abstract layer underneath Mus
(UI service). The classes being removed were part of an earlier
attempt to upstream 01.org's Ozone/Wayland "port" of Chromium,
which is not under active development anymore [1].

[1] https://01.org/ozone-wayland

CL obsoletes the unused ScreenOzone and DesktopWindowTreeHostOzone
implementations, since for Mus/Ozone ScreenMus and
DesktopWindowTreeHostMus are used, respectively.

BUG= 295089 

Review-Url: https://codereview.chromium.org/2830933006
Cr-Commit-Position: refs/heads/master@{#466540}

[modify] https://crrev.com/150a0a9177dc26b6ebbe66f909c0860a49bfb6e1/ui/views/BUILD.gn
[delete] https://crrev.com/6e4da46b88046efacaf1850aa3b716aa11a51652/ui/views/widget/desktop_aura/desktop_factory_ozone.cc
[delete] https://crrev.com/6e4da46b88046efacaf1850aa3b716aa11a51652/ui/views/widget/desktop_aura/desktop_factory_ozone.h
[delete] https://crrev.com/6e4da46b88046efacaf1850aa3b716aa11a51652/ui/views/widget/desktop_aura/desktop_screen_ozone.cc
[modify] https://crrev.com/150a0a9177dc26b6ebbe66f909c0860a49bfb6e1/ui/views/widget/desktop_aura/desktop_window_tree_host_ozone.cc

Project Member Comment 48 by bugdroid1@chromium.org, May 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8de6a53455b05558640d3a658fd0b874dfe8e6e

commit c8de6a53455b05558640d3a658fd0b874dfe8e6e
Author: tonikitoo <tonikitoo@igalia.com>
Date: Mon May 22 22:01:30 2017

Do not include x11 files in case of Ozone builds

This only fails when no X11 headers are present on the system and

  use_ozone = true
  ozone_platform_wayland = true
  ozone_platform_x11 = false
  use_sysroot = false

BUG= 295089 

Review-Url: https://codereview.chromium.org/2892343002
Cr-Commit-Position: refs/heads/master@{#473718}

[modify] https://crrev.com/c8de6a53455b05558640d3a658fd0b874dfe8e6e/chrome/browser/ui/views/frame/browser_frame.cc

Sign in to add a comment