New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 2929 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2008
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

"Encoding" menu disabled when visit a page at the first time

Reported by xlyuan@chromium.org, Sep 29 2008

Issue description

Build: 0.2.153.1 (Official Build 2519)
 
[Steps]
1 Launch Chrome
2 Navigate to any web page, say google.com
3 Select "Control the current page" drop down menu 
4 Observe

[Results]
The "Encoding" menu is disabled

[Expected]
The "Encoding" menu should be always enabled

[Notes]
Not reproduce after reload the current page


 
Encoding menu.jpg
114 KB View Download
Labels: Area-BrowserUI I18N are
Labels: -are -area-i18n
Labels: I18N-jp

Comment 4 by js...@chromium.org, Oct 17 2008

Labels: Mstone-1.0
Status: Assigned
This is for sure Mstone-1.0. I've begun to take a look along with  issue 3315 


Comment 5 by xlyuan@chromium.org, Oct 17 2008

I just want to mention that: 

When open js or css file, the "Encoding" menu is always disabled, so if "Auto detect"
is off or "Default encoding" is not the right one, there is no way to get non-ASCII
characters show correctly in js or css file.

Test:
1. Launch English Chrome
2. Go to http://login.sina.com.cn/
3. View source of this page
4. Open the corresponding css or js link in a new tab
5. Observe the non-ASCII characters

Comment 6 by js...@chromium.org, Oct 18 2008

JS/CSS issue was filed as  issue 3565 

Comment 8 by js...@chromium.org, Oct 22 2008

Status: Started
Labels: -Mstone-1.0 Mstone-X
Moving this out of the 1.0 list as per https://spreadsheets.google.com/a/google.com/ccc?key=pv1RidUkOQETG1XcAcFyRYA
Labels: -Pri-2 -Mstone-X Pri-1 Mstone-1.0 Regression dev-release-block

Comment 11 by js...@chromium.org, Oct 23 2008

Status: Fixed
fixed in r3844 on trunk (also merged to 1.0 branch by Mark). 


Comment 12 by js...@chromium.org, Oct 24 2008

Xiaolu, can you verify the fix? 

Glen said he still saw the encoding menu disabled occasionally? 
To Glen, can you reproduce failure reliably? Specific web pages, file types, a
sequence of pages?  Or is it just sporadic?  


Status: Assigned
Hmm, three cases:

1. Fixed for part of web pages, like:

http://www.chinamobile.com/
http://www.icbc.com.cn/icbc/

2. Still reproduce on some web pages, what those pages have in common:

When "Save page as", "Save As" dialog shows:
File name: download
Save as type: Chrome HTML

Instead of:
File name: The title of the page
Save as type: Web Page, Complete

URLs:
http://www.autohome.com.cn/
http://fund.eastmoney.com/

3. This web page is more weird, when open it at the first time, the "Encoding" menu
is enabled, then switch to a new tab, then switch back, the "Encoding" menu becomes
disabled.

URL:
http://www.zaobao.com/

Verified on build:
0.3.154.6 (Official Build 3810)
0.3.155.0 (Developer Build 3908)



Comment 14 by js...@chromium.org, Oct 24 2008

The condition for enabling the encoding menu is |IsSavableType && IsSavableURL|.  So, 
the 2nd case makes sense. Now, I wonder why those web pages are regarded as 'not 
savable'.  I'll debug it. 

Hmm, the 3rd case is indeed strange. I'll also look into it. 



Comment 15 by js...@chromium.org, Oct 27 2008

This time, it should be really fixed (r4001 , 
http://codereview.chromium.org/8206/show )




Fixed on trunk build 0.3.155.0 (Developer Build 4200).

I will close this bug when the fix landed to the branch.
Status: Fixed
Xiaolu, please mark this as verified when you verify this on the release branch.

Comment 18 by prog...@gmail.com, Nov 6 2008

i notice it with 0.3.154.9
in this site
http://statcomp.ats.ucla.edu/WebTools/JavaTools/popup.htm
after i click the "here" link to open a popup (in the encoding menu of the chrome 
icon in the popup's top left corner)
Status: Verified
Verified in 0.3.154.12 (Official Build 4978).
RE: comment 18 
0.3.154.9 does not have the patch, yet. It'll be in next dev release. However, even 
in trunk build, the pop-up menu has the encoding menu disabled. Thanks for spotting 
it. Let's deal with it in  issue 3769 .


Comment 21 by prog...@gmail.com, Nov 7 2008

you mean  issue 3765  (i think)

i just love beta testing... thanks for giving me the platform to do it :) and for 
making a great piece of software of course


Project Member

Comment 22 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 9 2013

Labels: -Type-Bug -Regression Type-Bug-Regression

Sign in to add a comment