New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 29103 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-5

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Mac: Developer Tools window shouldn't display a location bar

Project Member Reported by viettrungluu@chromium.org, Dec 1 2009

Issue description

What steps will reproduce the problem?
1. Navigate to some normal page.
2. Cmd-Opt-I to open the Developer Tools window.
3. Open your eyes.

What is the expected output? What do you see instead?
No location bar should be displayed. I see a location bar (which is selectable, 
but not editable).
 
Labels: Mstone-5
Status: Available
Status: Assigned
It's 'cause we don't implement app-mode (application popup) windows, so I guess it's 
mine.

Comment 3 by jrg@chromium.org, Dec 11 2009

This is unrelated to app mode.
The problem is because we don't honor all the args to window.open for pop-ups.  E.g.
<script>
window.open('http://www.cnn.com', 'CNN', 'location=1')
</script>
You can have the bug if you like.
Pssst. In DevToolsWindow::CreateDevToolsBrowser(), there's a line which goes:

  browser_ = Browser::CreateForApp(L"DevToolsApp", profile_, false);

Status: Started
Status: Fixed

Comment 8 by bugdro...@gmail.com, Dec 18 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=34757 

------------------------------------------------------------------------
r34757 | viettrungluu@chromium.org | 2009-12-16 13:36:10 -0800 (Wed, 16 Dec 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_cell.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/chrome_browser_window.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/chrome_browser_window_unittest.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_item_cell.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.h?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_window_controller.h?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_window_controller.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=34757&r2=34756
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=34757&r2=34756

Mac: fix/implement app windows (not app mode), popups, drawing; refactor code.

1. Properly display app windows, including Developer Tools window (no location bar). Also check using --app=http://foobar.com/.
2. Lay out popup windows (in particular, location bar) better. Check using, e.g., <http://www.quirksmode.org/js/popup.html>; make sure it looks good (with a variety of themes).
3. Properly draw border to Omnibox -- so that its border matches the surrounding buttons. Check (looking very closely/zooming) using various themes (Google and artist, light and dark).
4. Re-organize/refactor code in the BrowserWindowController (esp. the layout code). Check that (in a normal window) it still displays the toolbar, bookmark bar (normal and NTP), infobar, and download shelf correctly.

BUG= 13148 , 20244 , 26757 , 29103 
TEST=See above.

Review URL: http://codereview.chromium.org/495010
------------------------------------------------------------------------

Status: Verified
4.0.277.0 (Official Build 35097) dev
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-5 M-5
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment