New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2010
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature

Blocking:
issue 28287

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Stable release source tarballs

Reported by spo...@gmail.com, Dec 1 2009

Issue description

When Chrome hits beta (or when it hits stable), versioned source tarballs
will ensure that distributions have a predictable, stable target for
generating builds. 

These versioned releases also provide a base for minor releases, such as
critical bug fixes or security patches. Major new features or API breaks
should not happen in minor releases.

These source tarballs should not contain prebuilt binaries, or at least, a
tarball should be generated that does not contain prebuilt binaries, and
should be clearly marked as "source-only".

This is an issue for the distro metabug, 28287.
 
Labels: -OS-All OS-Linux
Status: Available
Labels: -Type-Bug -Area-Misc Type-Feature Area-Infrastructure Mstone-X
 Issue 17586  has been merged into this issue.
Labels: -Area-Infrastructure Area-BuildTools
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38302 

------------------------------------------------------------------------
r38302 | phajdan.jr@chromium.org | 2010-02-06 01:46:57 -0800 (Sat, 06 Feb 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/export_tarball/export_tarball.py?r1=38302&r2=38301

Make export_tarball.py work with older Pythons.

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/578019
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38303 

------------------------------------------------------------------------
r38303 | phajdan.jr@chromium.org | 2010-02-06 02:45:55 -0800 (Sat, 06 Feb 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/307/src/tools/export_tarball/export_tarball.py?r1=38303&r2=38302

Merge 38302 - Make export_tarball.py work with older Pythons.

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/578019

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/574025
------------------------------------------------------------------------

Status: Started
Stealing the bug. Nicolas is helping me with testing this on the bots.

Comment 9 by bugdro...@gmail.com, Feb 11 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38756 

------------------------------------------------------------------------
r38756 | phajdan.jr@chromium.org | 2010-02-11 03:10:00 -0800 (Thu, 11 Feb 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/export_tarball/export_tarball.py?r1=38756&r2=38755

Workaround older python versions' less capable tarfile.

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/603008
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=39019 

------------------------------------------------------------------------
r39019 | phajdan.jr@chromium.org | 2010-02-13 10:24:56 -0800 (Sat, 13 Feb 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/307/src/tools/export_tarball/export_tarball.py?r1=39019&r2=39018

Merge 38756 - Workaround older python versions' less capable tarfile.

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/603008

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/600121
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=39238 

------------------------------------------------------------------------
r39238 | phajdan.jr@chromium.org | 2010-02-17 10:13:15 -0800 (Wed, 17 Feb 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/export_tarball/export_tarball.py?r1=39238&r2=39237

Fix removing unnecessary files in export_tarball.py

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/619007
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=40119 

------------------------------------------------------------------------
r40119 | phajdan.jr@chromium.org | 2010-02-26 06:32:52 -0800 (Fri, 26 Feb 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/307/src/tools/export_tarball/export_tarball.py?r1=40119&r2=40118

Merge 39238 - Fix removing unnecessary files in export_tarball.py

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/619007

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/661182
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=44458 

------------------------------------------------------------------------
r44458 | phajdan.jr@chromium.org | 2010-04-14 01:55:20 -0700 (Wed, 14 Apr 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/export_tarball/export_tarball.py?r1=44458&r2=44457

Add more directories to export_tarball.py's exclude list.

Recently the tarball got approx. 2x bigger because of that.

TBR=nsylvain

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/1545036
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=44459 

------------------------------------------------------------------------
r44459 | phajdan.jr@chromium.org | 2010-04-14 02:12:34 -0700 (Wed, 14 Apr 2010) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/375/src/tools/export_tarball/export_tarball.py?r1=44459&r2=44458

Merge 44458 - Add more directories to export_tarball.py's exclude list.

Recently the tarball got approx. 2x bigger because of that.

TBR=nsylvain

TEST=none
BUG= 29044 

Review URL: http://codereview.chromium.org/1545036

TBR=nsylvain
Review URL: http://codereview.chromium.org/1605030
------------------------------------------------------------------------

Status: Fixed
I consider it fixed. For now the Linux tarballs are available at http://build.chromium.org/buildbot/official/
HEAD's at 5.0.394 and those are at 5.0.387. Are they more stable or are they just 
old?

A xz-compressed tarball would be nice btw.

$ du -h chromium-5.0.387.0.tar.bz2 
161M    chromium-5.0.387.0.tar.bz2
$ bunzip2 chromium-5.0.387.0.tar.bz2 
$ du -h chromium-5.0.387.0.tar 
828M    chromium-5.0.387.0.tar
$ xz -9 -e chromium-5.0.387.0.tar 
$ du -h chromium-5.0.387.0.tar.xz 
115M    chromium-5.0.387.0.tar.xz
$ 
This HEAD vs tarballs lag looks like a bug. I generally monitor the tarballs (they are used for Gentoo packages), 
so you can expect such issues to get fixed shortly.

For xz tarballs, feel free to open a new bug (commenting in a closed bug makes the comment less noticeable). If 
you have a patch for export_tarball.py, that's even better.
> This HEAD vs tarballs lag looks like a bug. I generally monitor the tarballs (they 
are used for Gentoo packages), so you can expect such issues to get fixed shortly.

Appears to be fixed now.

> For xz tarballs, feel free to open a new bug (commenting in a closed bug makes the 
comment less noticeable). If you have a patch for export_tarball.py, that's even 
better.

Whatever tar writer for python probably doesn't support anything other than gzip, 
bzip and maybe zip. The latest tarballs are up to 485MB now, so I won't bother 
anymore. I don't expect xz to get it much below 400M, which is completely 
unacceptable given how often I upgrade. In my opinion the tarballs contain far too 
much. E.g. dll's. I'll stick with git/svn checkouts.

Comment 19 by spo...@gmail.com, May 25 2010

Something is going wrong with the tarball generation, the third_party/WebKit/WebCore
directory is not being included. Given that this code is a key part of the chromium
browser, it really should be included.
Status: Available
Reopening then. We probably need to fix export_tarball.py and make sure the generated tarball can actually build the chrome target.
So the situation is that anything 6.0.X with X > 408 can't be built because of missing files... (plus for some reason there aren't any tarballs with X > 424). This matters. This is important.
I concur. Distributions are having troubles keeping up with chromium dev channel releases right now because of this issue. As distributions are not providing 6.0.422.0 because of this, is this really only a priority 2 issue?
BTW, I have opened a thread on chromium-dev when I noticed this, and I was pointed to this issue, which might have gotten it some more exposure again.
Status: Fixed
I think this is now fixed semi-properly. Ideally we should have a buildbot to test the tarballs. Practically it's more difficult. But now we have the checkout logs available publicly, so debugging is easier.
Labels: -Area-BuildTools bulkmove Area-Build
When Chrome hits beta (or when it hits stable), versioned source tarballs
will ensure that distributions have a predictable, stable target for
generating builds. 

These versioned releases also provide a base for minor releases, such as
critical bug fixes or security patches. Major new features or API breaks
should not happen in minor releases.

These source tarballs should not contain prebuilt binaries, or at least, a
tarball should be generated that does not contain prebuilt binaries, and
should be clearly marked as "source-only".

This is an issue for the distro metabug, 28287.

Comment 25 by Deleted ...@, Dec 19 2011

Can we make sure these tarballs have hash files as well?

I would file a new bug for that.
Blocking: chromium:28287
Project Member

Comment 28 by bugdroid1@chromium.org, Oct 13 2012

Blocking: -chromium:28287
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Build Build

Sign in to add a comment