New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment
link

Issue 289354: Audio disabled when playbackRate is less than 0.5

Reported by lay...@gmail.com, Sep 11 2013

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/29.0.1547.65 Safari/537.36

Example URL:

Steps to reproduce the problem:
1. set the playbackRate as 0.4 ( any of less than 0.5)
2. play mp4/webm 

What is the expected behavior?
sound should be abled any playbackRate. 

What went wrong?
Sound is disabled 

Did this work before? N/A 

Is it a problem with Flash or HTML5? HTML5

Does this work in other browsers? Yes safari 6.0.5 (8536.30.1)

Chrome version: 29.0.1547.65  Channel: stable
OS Version: OS X 10.8.4
Flash Version: Shockwave Flash 11.8 r800
 

Comment 1 by ajnolley@chromium.org, Oct 7 2013

layer9, can you provide an example of this behavior in a code playground like jsfiddle? Thank you!

Comment 2 by dalecur...@chromium.org, Oct 7 2013

Cc: turajs@chromium.org
This is working as intended.  We have a new algorithm that may perform better for < 0.5 and > 8.0, I've cc'd the author for more information.

Comment 3 by kishor...@gmail.com, Nov 2 2013

I can confirm the same behavior on "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36".

When the playbackRate drops below 0.5, the audio just mutes. If this is indeed going to be fixed in a future version, when can we expect to see the new code in Chrome?

Comment 4 by turajs@google.com, Nov 4 2013

Sorry for the delay in response. The algorithm is technically capable of doing so, but the quality degrades. It is really difficult for me to speculate what percentage of our users would actually use that, given the degraded quality. But if you think it is useful, we can just increase the limit. There is nothing in the algorithm that can be tuned to make it work better at those playout rates. Some other algorithms do a better job, but perhaps more tricky got them work well (tunning).

Comment 5 by ajnolley@chromium.org, Nov 8 2013

Status: Untriaged

Comment 6 by kishor...@gmail.com, Feb 7 2014

I think it's worth increasing the limit - I do agree that the quality degrades for most audios, but there are cases where the audio consists of people talking rapidly and this really helps. I work on a few audio related apps, where this will be helpful.

Comment 7 by sh...@chromium.org, Feb 12 2014

Labels: -Cr-Internals-Media Cr-Internals-Media-Audio
Owner: turajs@chromium.org
Status: Assigned
turajs@: If there is an existing bug for this can you mark as duplicate? 

Or should we mark as WontFix for the time being?

Comment 8 by dalecur...@chromium.org, Feb 12 2014

Labels: -OS-Mac OS-All
Owner: ----
Status: Available
As Turaj mentioned this will probably work, but quality will be degraded.  If someone wants to change this and figure out how it sounds, here's where the change needs to be made:

https://code.google.com/p/chromium/codesearch#chromium/src/media/filters/audio_renderer_algorithm.cc&l=49

Comment 9 by scherkus@chromium.org, Feb 28 2014

Labels: -Pri-2 -Via-Wizard Pri-3 Hotlist-Fixit

Comment 10 by scherkus@chromium.org, Mar 19 2014

Owner: sande...@chromium.org
Status: Started

Comment 11 by bugdroid1@chromium.org, Mar 20 2014

Project Member
------------------------------------------------------------------
r258215 | sandersd@chromium.org | 2014-03-20T06:08:02.505451Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_algorithm_unittest.cc?r1=258215&r2=258214&pathrev=258215
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_algorithm.cc?r1=258215&r2=258214&pathrev=258215
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_algorithm.h?r1=258215&r2=258214&pathrev=258215

Remove muting for extreme playbackRates.

Audio was muted below 0.5x and above 4x as the quality degraded
significantly under the crossfade algorithm. The quality is now much
better under the WSLOA algorithm (r220343).

BUG= 289354 
R=scherkus@chromium.org
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/205093002
-----------------------------------------------------------------

Comment 12 by sande...@chromium.org, Apr 1 2014

Status: Fixed

Comment 13 by bugdroid1@chromium.org, Jun 4 2014

Project Member
Labels: merge-merged-1916
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1b2c8380f66b0447e83d122269b4001a42bd158

commit b1b2c8380f66b0447e83d122269b4001a42bd158
Author: karen@chromium.org <karen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 02:02:44 2014

Revert 258215 "Remove muting for extreme playbackRates."

> Remove muting for extreme playbackRates.
> 
> Audio was muted below 0.5x and above 4x as the quality degraded
> significantly under the crossfade algorithm. The quality is now much
> better under the WSLOA algorithm (r220343).
> 
> BUG= 289354 
> R=scherkus@chromium.org
> R=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/205093002

TBR=sandersd@chromium.org

Review URL: https://codereview.chromium.org/316733006

git-svn-id: svn://svn.chromium.org/chrome/branches/1916/src@274697 0039d316-1c4b-4281-b951-d872f2087c98

Comment 14 by bugdroid1@chromium.org, Jun 4 2014

Project Member
------------------------------------------------------------------
r274697 | karen@chromium.org | 2014-06-04T02:02:44.568938Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1916/src/media/filters/audio_renderer_algorithm_unittest.cc?r1=274697&r2=274696&pathrev=274697
   M http://src.chromium.org/viewvc/chrome/branches/1916/src/media/filters/audio_renderer_algorithm.cc?r1=274697&r2=274696&pathrev=274697
   M http://src.chromium.org/viewvc/chrome/branches/1916/src/media/filters/audio_renderer_algorithm.h?r1=274697&r2=274696&pathrev=274697

Revert 258215 "Remove muting for extreme playbackRates."

> Remove muting for extreme playbackRates.
> 
> Audio was muted below 0.5x and above 4x as the quality degraded
> significantly under the crossfade algorithm. The quality is now much
> better under the WSLOA algorithm (r220343).
> 
> BUG= 289354 
> R=scherkus@chromium.org
> R=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/205093002

TBR=sandersd@chromium.org

Review URL: https://codereview.chromium.org/316733006
-----------------------------------------------------------------

Comment 15 by bugdroid1@chromium.org, Jun 4 2014

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/915bb8a0897ed3f8a84400023267ed4aafb248e8

commit 915bb8a0897ed3f8a84400023267ed4aafb248e8
Author: scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 02:09:10 2014

Revert 258215 "Remove muting for extreme playbackRates."

It exposed a bug in the WSOLA algorithm that causes it to incorrectly
trigger underflows.

> Remove muting for extreme playbackRates.
> 
> Audio was muted below 0.5x and above 4x as the quality degraded
> significantly under the crossfade algorithm. The quality is now much
> better under the WSLOA algorithm (r220343).
> 
> BUG= 289354 
> R=scherkus@chromium.org
> R=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/205093002

BUG= 368083 
TBR=sandersd@chromium.org

Review URL: https://codereview.chromium.org/312963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274701 0039d316-1c4b-4281-b951-d872f2087c98

Comment 16 by bugdroid1@chromium.org, Jun 4 2014

Project Member
------------------------------------------------------------------
r274701 | scherkus@chromium.org | 2014-06-04T02:09:10.765733Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_algorithm_unittest.cc?r1=274701&r2=274700&pathrev=274701
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_algorithm.cc?r1=274701&r2=274700&pathrev=274701
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_algorithm.h?r1=274701&r2=274700&pathrev=274701

Revert 258215 "Remove muting for extreme playbackRates."

It exposed a bug in the WSOLA algorithm that causes it to incorrectly
trigger underflows.

> Remove muting for extreme playbackRates.
> 
> Audio was muted below 0.5x and above 4x as the quality degraded
> significantly under the crossfade algorithm. The quality is now much
> better under the WSLOA algorithm (r220343).
> 
> BUG= 289354 
> R=scherkus@chromium.org
> R=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/205093002

BUG= 368083 
TBR=sandersd@chromium.org

Review URL: https://codereview.chromium.org/312963003
-----------------------------------------------------------------

Comment 17 by bugdroid1@chromium.org, Jun 4 2014

Project Member
Labels: merge-merged-1985
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7922a4ba476cd64ba63770070f35ca2381bc3cc7

commit 7922a4ba476cd64ba63770070f35ca2381bc3cc7
Author: scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 21:05:50 2014

Revert 258215 "Remove muting for extreme playbackRates."

It exposed a bug in the WSOLA algorithm that causes it to incorrectly
trigger underflows.

> Remove muting for extreme playbackRates.
> 
> Audio was muted below 0.5x and above 4x as the quality degraded
> significantly under the crossfade algorithm. The quality is now much
> better under the WSLOA algorithm (r220343).
> 
> BUG= 289354 
> R=scherkus@chromium.org
> R=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/205093002

BUG= 368083 
TBR=sandersd@chromium.org

Review URL: https://codereview.chromium.org/313213002

git-svn-id: svn://svn.chromium.org/chrome/branches/1985/src@274903 0039d316-1c4b-4281-b951-d872f2087c98

Comment 18 by bugdroid1@chromium.org, Jun 4 2014

Project Member
------------------------------------------------------------------
r274903 | scherkus@chromium.org | 2014-06-04T21:05:50.663535Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1985/src/media/filters/audio_renderer_algorithm_unittest.cc?r1=274903&r2=274902&pathrev=274903
   M http://src.chromium.org/viewvc/chrome/branches/1985/src/media/filters/audio_renderer_algorithm.cc?r1=274903&r2=274902&pathrev=274903
   M http://src.chromium.org/viewvc/chrome/branches/1985/src/media/filters/audio_renderer_algorithm.h?r1=274903&r2=274902&pathrev=274903

Revert 258215 "Remove muting for extreme playbackRates."

It exposed a bug in the WSOLA algorithm that causes it to incorrectly
trigger underflows.

> Remove muting for extreme playbackRates.
> 
> Audio was muted below 0.5x and above 4x as the quality degraded
> significantly under the crossfade algorithm. The quality is now much
> better under the WSLOA algorithm (r220343).
> 
> BUG= 289354 
> R=scherkus@chromium.org
> R=dalecurtis@chromium.org
> 
> Review URL: https://codereview.chromium.org/205093002

BUG= 368083 
TBR=sandersd@chromium.org

Review URL: https://codereview.chromium.org/313213002
-----------------------------------------------------------------

Comment 19 by bugdroid1@chromium.org, Jun 5 2014

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/7922a4ba476cd64ba63770070f35ca2381bc3cc7

commit 7922a4ba476cd64ba63770070f35ca2381bc3cc7
Author: scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 21:05:50 2014

Comment 20 by bugdroid1@chromium.org, Jun 5 2014

Project Member
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/915bb8a0897ed3f8a84400023267ed4aafb248e8

commit 915bb8a0897ed3f8a84400023267ed4aafb248e8
Author: scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed Jun 04 02:09:10 2014

Comment 21 by sande...@chromium.org, Jun 24 2014

Status: Available
This fix was undone to work around  issue 368083 . The rendering algorithm will need to be debugged to re-apply the fix.

Comment 22 by sande...@chromium.org, Jun 24 2014

Cc: tkonch...@chromium.org
 Issue 384871  has been merged into this issue.

Comment 23 by yini...@chromium.org, Jul 28 2015

Labels: StaleAvailable

Comment 24 by prabhur@chromium.org, Oct 1 2015

Labels: -StaleAvailable StaleAssigned
Status: Assigned

Comment 25 by lafo...@chromium.org, Oct 2 2015

Labels: Hotlist-Recharge
This issue likely requires triage.  The current issue owner may be inactive (i.e. hasn't fixed an issue in the last 30 days or commented in this particular issue in the last 90 days).  Thanks for helping out!

-Anthony

Comment 26 by sande...@chromium.org, Oct 6 2015

Labels: -Hotlist-Fixit -merge-merged-1916 -merge-merged-1985 -StaleAssigned -Hotlist-Recharge
Status: Available
Returning this to available status. It's going to require a rewrite of the WSOLAS implementation.

Comment 27 by sande...@chromium.org, Apr 15 2016

Labels: Hotlist-CodeHealth

Comment 28 by sheriffbot@chromium.org, Apr 17 2017

Project Member
Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been available for more than 365 days, and should be re-evaluated. Please re-triage this issue.
The Hotlist-Recharge-Cold label is applied for tracking purposes, and should not be removed after re-triaging the issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 29 by sande...@chromium.org, Apr 17 2017

Cc: sande...@chromium.org
Labels: -Type-Bug -Hotlist-Recharge-Cold Type-Feature
Owner: ----
Status: Available (was: Untriaged)

Comment 30 by dalecur...@chromium.org, Sep 20 2017

Cc: johnpallett@chromium.org
Owner: dalecur...@chromium.org
Status: Assigned (was: Available)

Comment 31 by dalecur...@chromium.org, Sep 28 2017

Dan, are you able to find the bug for which we disabled this again for? It's not linked in your changes above.

Comment 32 by sande...@chromium.org, Sep 28 2017

Looks like it was  issue 368083 .

Comment 33 by dalecur...@chromium.org, Sep 28 2017

Durr, I'm blind :)

Comment 34 by bugdroid1@chromium.org, Oct 16 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c48caf1d643328b20af02368d56a9814b2da95

commit 14c48caf1d643328b20af02368d56a9814b2da95
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Oct 16 20:44:36 2017

Remove muting at < 0.5x and > 4x; helps accessibility use cases.

Lets try this again; last time we had to revert due to hangs during
transitions between low to high rates, but this does not reproduce
anymore. Seemingly the hangs could have happened at any rate and
have hopefully been subsequently fixed.

BUG= 289354 
TEST=unittests pass, no hangs could be reproduced.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9d40f55031185227a76831bbd594f0cb45510c44
Reviewed-on: https://chromium-review.googlesource.com/717177
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509159}
[modify] https://crrev.com/14c48caf1d643328b20af02368d56a9814b2da95/media/filters/audio_renderer_algorithm.cc
[modify] https://crrev.com/14c48caf1d643328b20af02368d56a9814b2da95/media/filters/audio_renderer_algorithm.h
[modify] https://crrev.com/14c48caf1d643328b20af02368d56a9814b2da95/media/filters/audio_renderer_algorithm_unittest.cc

Comment 35 by dalecur...@chromium.org, Oct 17 2017

Labels: M-64
Status: Fixed (was: Assigned)
So far so good for M64, but will keep an eye on it.

Comment 36 Deleted

Sign in to add a comment