Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 288019 WEBPImageDecoder.cpp uses unreleased libwebp features
Starred by 8 users Project Member Reported by phajdan.jr@chromium.org, Sep 9, 2013 Back to list
Status: Fixed
Owner: jzern@chromium.org
Closed: Jan 2014
Cc: urvang@chromium.org, fbarchard@chromium.org
Components:
OS: Linux
Pri: 2
Type: Bug


Sign in to add a comment
Here's what I get when trying to compile against libwebp-0.3.1:

../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp: In member function ‘bool WebCore::WEBPImageDecoder::updateDemuxer()’:
../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp:248:69: error: ‘WebPIterator’ has no member named ‘blend_method’
../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp:248:85: error: ‘WEBP_MUX_BLEND’ was not declared in this scope
../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp:256:109: error: ‘WebPIterator’ has no member named ‘has_alpha’

I think this was introduced in https://chromiumcodereview.appspot.com/22802020 as a cherry-pick from upstream git.

It's obviously fine to let this bake for a while in our repo, but ideally libwebp should make a release with this code before M31 hits stable.

It seems I can't assign it to Urvang, so trying Frank first - could you help route this to the right people?
 
Comment 1 by urvang@google.com, Sep 10, 2013
Yes, this is known, and due to the cherry-picked changes as Pawel mentioned.

We will release the next libwebp version before M31 hits stable (which seems to be 12th Nov) as suggested.

Feel free to mark this as M31 releaseblock-stable.
Comment 2 by urvang@chromium.org, Sep 13, 2013
Labels: ReleaseBlock-Stable
Cc: fbarchard@chromium.org
Owner: urvang@chromium.org
Comment 4 by urvang@google.com, Oct 14, 2013
Cc: urvang@chromium.org
Owner: jzern@chromium.org
Comment 5 by jzern@chromium.org, Oct 22, 2013
Labels: -M-31 -ReleaseBlock-Stable M-32
We'll make an attempt to make a release within the same time frame of the stable release, but this isn't a release blocker.
Comment 6 by kareng@google.com, Nov 8, 2013
Labels: -M-32 M-33 MovedFrom-32
Moving all non essential bugs to the next Milestone.
Comment 7 by spo...@gmail.com, Dec 3, 2013
Sure would be nice if this got made into a release. :/
Project Member Comment 8 by bugdroid1@chromium.org, Dec 17, 2013
Labels: -M-33 MovedFrom-33
This issue has already been moved once and is lower than Priority 1,therefore removing mstone.
Looks like this is fixed with libwebp-0.4.0. I've tested it and building with system libwebp seems to work with that version. Thanks!
Comment 10 by jzern@chromium.org, Jan 7, 2014
Status: Fixed
As noted the availability of libwebp-0.4.0 addresses this issue.
Sign in to add a comment