New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 285942 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
OOO till Dec 17th
Closed: Sep 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Feedback report is crashing with "Choose File" option.

Project Member Reported by sontis@chromium.org, Sep 5 2013

Issue description

chromeOS Version:  4647.0.0
Chrome Version :  31.0.1621.1

What steps will reproduce the problem?
1. Sign in to the device.
2. Open any webpage and trigger feedback report (Alt + shift + I).
3. click on "Choose File" button and attach file.
4. Click on "send feedback" report.


What is the expected output?
Feedback report should be submitted properly.

What do you see instead?
Feedback report is crashed.
Got message "Feedback has crashed. Click this balloon to restart the app".

Note:
I did not find any crash dumps on device.
 
Cc: joshwoodward@chromium.org
Owner: r...@chromium.org
Status: Assigned
Hey Rahul, can you take a look at this?
Will not block first dev for this issue, but we should fix by next week's dev release.
Cc: ligim...@chromium.org srsridhar@chromium.org
 Issue 286276  has been merged into this issue.

Comment 5 by krisr@chromium.org, Sep 6 2013

Labels: AdjustedPriority

Comment 6 by r...@chromium.org, Sep 6 2013

Labels: Iteration-89
Status: Started
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 7 2013

------------------------------------------------------------------------
r221866 | rkc@chromium.org | 2013-09-07T02:53:19.106043Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc?r1=221866&r2=221865&pathrev=221866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/feedback_private.idl?r1=221866&r2=221865&pathrev=221866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/feedback/feedback_data.cc?r1=221866&r2=221865&pathrev=221866
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/feedback/feedback_data.h?r1=221866&r2=221865&pathrev=221866

Fix feedback attach a file and system info code.
Attaching a file to feedback is crashing the app since we fail on the AttachedFile validate (since we don't actually send blobs over, the attachedFile.data field is always empty, which fails parameter validation on the Chrome side). The easiest way to fix it was to make the parameter optional, since we never read it anyway. It is only there to hold the data so that the feedback custom bindings can move it into attachedFileBlobUrl.

This CL also fixes the sys info, which wasn't being sent due to code that was ported over from the UI incorrectly. The new UI does not need to wait on system information collection, since that is now done via a separate call, making passing around the sys_info variable completely redundant, and in this case wrong.

R=asargent@chromium.org
BUG= 285942 , 285938 
TEST=We are able to attach a file and system information with a feedback report.

Review URL: https://chromiumcodereview.appspot.com/23458031
------------------------------------------------------------------------

Comment 8 by r...@chromium.org, Sep 7 2013

Status: Fixed
Status: Verified
Google Chrome	31.0.1626.0 (Official Build 222150) dev
Platform	4665.0.0 (Official Build) dev-channel link

Sign in to add a comment