Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 2822 Use MenuItemView instead of Menu for the Page menu button
Starred by 2 users Reported by xlyuan@chromium.org, Sep 26, 2008 Back to list
Status: Fixed
Owner: sky@chromium.org
Closed: Jun 2010
Components:
OS: All
Pri: 2
Type: Bug

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
See <b\1232732>

There is currently a hack in chrome\views\accelerator.cc which modifies the
shortcut string in certain cases for RTL locaes. For example, instead of
returning "Ctrl++" the hack returns "++Ctrl". This hack is required because
Windows does not support Unicode directionality marks for text inside
menus. Modifying the string in this manner is not very safe since it relies
on the fact that we always the strings that need adjustment always have the
suffix "+" and KEY (where KEY is the actual accelerator key).

One way to avoid using this hack is to not use Windows menus and instead
use the chrome specific menus (the same menus used by on the bookmark bar).

 
 
Comment 1 by niranjan@chromium.org, Sep 30, 2008
Labels: Mstone-X
Comment 2 by mal.chro...@gmail.com, Sep 30, 2008
Labels: Area-BrowserUI I18N are
Comment 3 by mal.chro...@gmail.com, Sep 30, 2008
Labels: -are -area-i18n
Comment 4 by oritm@chromium.org, Dec 18, 2009
Labels: -Area-BrowserUI Area-UI-Features
Area-UI-Features label replaces Area-BrowserUI label
Comment 5 by lafo...@chromium.org, Feb 17, 2010
Labels: Area-UI
Comment 6 by lafo...@chromium.org, Feb 17, 2010
Labels: -Area-UI-Features
Comment 7 by pkasting@chromium.org, Jun 28, 2010
Scott, I think your work obsoletes this?
Comment 8 by sky@chromium.org, Jun 28, 2010
Status: Fixed
Indeed. We're now using menuitemview for the wrench menu.
Comment 9 by lafo...@chromium.org, Mar 18, 2011
Labels: -I18N bulkmove Feature-I18N
See &lt;b\1232732&gt;

There is currently a hack in chrome\views\accelerator.cc which modifies the
shortcut string in certain cases for RTL locaes. For example, instead of
returning &quot;Ctrl++&quot; the hack returns &quot;++Ctrl&quot;. This hack is required because
Windows does not support Unicode directionality marks for text inside
menus. Modifying the string in this manner is not very safe since it relies
on the fact that we always the strings that need adjustment always have the
suffix &quot;+&quot; and KEY (where KEY is the actual accelerator key).

One way to avoid using this hack is to not use Windows menus and instead
use the chrome specific menus (the same menus used by on the bookmark bar).
Project Member Comment 10 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 11 by bugdroid1@chromium.org, Mar 11, 2013
Labels: -Area-UI -Feature-I18N Cr-UI-I18N Cr-UI
Project Member Comment 12 by bugdroid1@chromium.org, Mar 20, 2013
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment