New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 281507 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

DevTools: Jump between editing locations feature

Project Member Reported by lushnikov@chromium.org, Aug 29 2013

Issue description

Feature request: 

Consider I'm writing some javascript, and at some point I realize that
I need to enhance function "foo". I hit "Ctrl-Shift-O", type in "foo", hit enter and add some code to improve it. But how do I get back? 

I would be great to have Alt+/Alt- shortcuts to navigate between different editing locations. In this example, it would be enough to hit Alt- to get back to my previous editing location.

 
Labels: Cr-Platform-DevTools
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162570

------------------------------------------------------------------------
r162570 | lushnikov@chromium.org | 2013-11-23T12:18:59.976114Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/FilteredItemSelectionDialog.js?r1=162570&r2=162569&pathrev=162570
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/SourcesPanel.js?r1=162570&r2=162569&pathrev=162570
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/StyleSheetOutlineDialog.js?r1=162570&r2=162569&pathrev=162570

DevTools: refactor outline dialogs to run callback on item selection

This patch refactors outline dialogs to run specified callback on
item selection. This is a prework for the "jump to previous editing
location" feature.

BUG= 281507 

Review URL: https://codereview.chromium.org/77283005
------------------------------------------------------------------------
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 23 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162574

------------------------------------------------------------------------
r162574 | lushnikov@chromium.org | 2013-11-23T12:29:19.893063Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/TabbedPane.js?r1=162574&r2=162573&pathrev=162574

DevTools: tab selection after tabclose should not be a user gesture

This patch changes call to 'TabbedPane.selectTab' method to recieve
false as 'userGesture' argument if it's done as a part
of 'TabbedPane.closeTabs' method. This doesn't seem to change any
behavior as the 'TabbedEditorContainer._updateHistory()' will
be called anyway on the previous step of closing tabs, and
subsequent call to this method from 'selectTab' will result
in noop.

BUG= 281507 

Review URL: https://codereview.chromium.org/81983002
------------------------------------------------------------------------
 Issue 316575  has been merged into this issue.
Labels: -Type-Bug Type-Feature
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2014

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=165395

------------------------------------------------------------------------
r165395 | lushnikov@chromium.org | 2014-01-20T10:31:50.861830Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/SourceFrame.js?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/TabbedEditorContainer.js?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/TextEditor.js?r1=165395&r2=165394&pathrev=165395
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/jump-to-previous-editing-location.html?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/devtools.gypi?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/scripts/frontend_modules.json?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/CodeMirrorTextEditor.js?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/TextRange.js?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/SourcesPanelDescriptor.js?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/SourcesPanel.js?r1=165395&r2=165394&pathrev=165395
   M http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/UISourceCodeFrame.js?r1=165395&r2=165394&pathrev=165395
   A http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/SimpleHistoryManager.js?r1=165395&r2=165394&pathrev=165395
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/inspector/jump-to-previous-editing-location-expected.txt?r1=165395&r2=165394&pathrev=165395
   A http://src.chromium.org/viewvc/blink/trunk/Source/devtools/front_end/EditingLocationHistoryManager.js?r1=165395&r2=165394&pathrev=165395

DevTools: "Jump between editing locations" experiment

This patch introduces "Jump between editing locations" experiment. It
adds "Alt+" and "Alt-" shortcuts to the scripts panel to navigate between
editing locations. An editing location is considered to be switched if
one of the following happens:
- A user clicks with his mouse and changes cursor position
- Position in editor was highlighted and cursor was moved there (e.g.
due to "Goto function" outline dialog)
- A new file was opened

BUG= 281507 
R=vsevik@chromium.org

Review URL: https://codereview.chromium.org/23474010
------------------------------------------------------------------------
Status: Fixed

Sign in to add a comment