Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 27910 Find-bar should continue searching but fails after some point
Starred by 4 users Project Member Reported by venkataramana@chromium.org, Nov 16, 2009 Back to list
Status: WontFix
Owner: finnur@chromium.org
Closed: Apr 2010
Cc: lafo...@chromium.org, jcampan@chromium.org, finnur@chromium.org
Components:
OS: All
Pri: 1
Type: Bug-Regression

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
Build: 4.0.249.0 (Official Build 32041) and ToT (r 32056)

-Navigate to google.com home page and search for news
-Ctrl+f to find-in bar and type 'news' in the search box
-hit return key couple of times to continue the search.
-Esc to cancel the find-in bar

Now Repeat:
Ctrl+f + steps 3&4  for few times.

Issue: After some point, find-in bar fail to continue the search. It always
starts searching from the previous search  count( say 15), even though you
search for up to 20/25 ...search count

It repros on all platforms (win/linux/mac)

Finnur: Pls feel free to ping me, if it does not reproduce for you!

 
Comment 1 Deleted
Comment 2 by finnur@chromium.org, Dec 3, 2009
Status: Started
OK, here is how to repro:

1) Navigate to google.com home page and search for news
2) Ctrl+F and type 'news' in the search box (to search for 'news' within the Google 
results page for 'news').
3) Press Enter until the active match is on one of the links in the search results
4) Press Esc

From this point on, F3 after Esc will always start from the last link that was active 
at the time you pressed Esc.

Having figured this out, I found the revision where this started happening (r31000) and 
looking at the changelists that went into that build it seems that this regressed with 
r30999, which is the fix for some Focus issues (issue 21388). 

Basically, what is happening is that we are changing the selection when we set focus to 
the page (a hack to make content editable elements accept input along with getting 
focus), which makes Find think that the user changed selection after finding, which 
triggers Find to start from a new selection point.

Fortunately, it looks like I can augment this fix with a one-liner change to make it 
not break Find.
Labels: Area-Feature
Comment 4 by lafo...@chromium.org, Feb 17, 2010
Labels: -Area-Feature Area-UI
Comment 5 by prog...@gmail.com, Apr 1, 2010
is this still reproducible?
Comment 6 by finnur@chromium.org, Apr 1, 2010
Status: WontFix
Looks like this is working on trunk. I initially thought I had fixed this bug with my 
fix for issue 38700, but it turns out that even if I remove it, this bug doesn't repro 
anymore.
Comment 7 by lafo...@chromium.org, Mar 18, 2011
Labels: -Regression bulkmove Type-Regression
Build: 4.0.249.0 (Official Build 32041) and ToT (r 32056)

-Navigate to google.com home page and search for news
-Ctrl+f to find-in bar and type 'news' in the search box
-hit return key couple of times to continue the search.
-Esc to cancel the find-in bar

Now Repeat:
Ctrl+f + steps 3&4  for few times.

Issue: After some point, find-in bar fail to continue the search. It always
starts searching from the previous search  count( say 15), even though you
search for up to 20/25 ...search count

It repros on all platforms (win/linux/mac)

Finnur: Pls feel free to ping me, if it does not reproduce for you!
Project Member Comment 8 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 9 by bugdroid1@chromium.org, Mar 9, 2013
Labels: -Feature-FindInPage -Area-UI -Type-Regression Type-Bug-Regression Cr-UI-Browser-FindInPage Cr-UI
Sign in to add a comment