New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 277955 link

Starred by 10 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 279506



Sign in to add a comment

NullPointerException in the tab switcher

Project Member Reported by klo...@chromium.org, Aug 23 2013

Issue description

Chrome for Android 30.0.1599.17
Nexus 4

Open Chrome
Open the tab switcher
Swipe to close all the tabs
While the last tab is closing, hit tab switcher icon. 

08-22 22:00:07.528: E/AndroidRuntime(5380): FATAL EXCEPTION: main
08-22 22:00:07.528: E/AndroidRuntime(5380): java.lang.NullPointerException
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at org.chromium.content.browser.ContentViewCore.isDeviceAccessibilityScriptInjectionEnabled(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at org.chromium.content.browser.ContentViewCore.setAccessibilityState(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at org.chromium.content.browser.ContentView.setAccessibilityState(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at com.google.android.apps.chrome.Main.toggleOverview(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at com.google.android.apps.chrome.Main.access$4900(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at com.google.android.apps.chrome.Main$MainWithNative$6.onClick(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at com.google.android.apps.chrome.ToolbarPhone$ToolbarDelegatePhone.onClick(Unknown Source)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at android.view.View.performClick(View.java:4305)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at android.view.View$PerformClick.run(View.java:18048)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at android.os.Handler.handleCallback(Handler.java:733)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at android.os.Handler.dispatchMessage(Handler.java:95)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at android.os.Looper.loop(Looper.java:137)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at android.app.ActivityThread.main(ActivityThread.java:4947)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at java.lang.reflect.Method.invokeNative(Native Method)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at java.lang.reflect.Method.invoke(Method.java:517)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:774)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:590)
08-22 22:00:07.528: E/AndroidRuntime(5380): 	at dalvik.system.NativeStart.main(Native Method)

 
Status: Started

Comment 2 by candrada@google.com, Aug 26 2013

Labels: Stability-Crash
8 reports so far in Feedback.

Cluster:  https://feedback.corp.google.com/#/Product/282/Category/95068/Cluster/5282589
Carson - fix in hand? We are trying to cut a Beta RC later today and want to know if we should hold the build for  a fix here.  Thx !!
Blockedon: chromium:279506
I've got a CL in code review that is a bandaid while we wait for https://code.google.com/p/chromium/issues/detail?id=279506
Nevermind, I just realized that this is also an issue in the standard tab stack. I'll see what I can do about fixing both of them.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29 2013

Project: .../internal/apps
Branch : master
Author : Carson Holgate <clholgat@google.com>
Commit : 74f5fda209f8c972d59fa6294130e1a53d9e8f64

Code Review +2: David Trainor
Verified    +1: David Trainor
Change-Id     : I4416c1eb8e52234f3cc187203021edfe83752fb9
Reviewed-at   : https://gerrit-int.chromium.org/43423
Hi Carson.  Is this ready to get merged into M30?  We're planning to push to Beta tomorrow.  Thanks.
The CL in #6 was reverted due to some failing tests and the change was fairly extensive. dtrainor@ is trying to find a better, simpler, solution.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 3 2013

Project: .../internal/apps
Branch : master
Author : David Trainor <dtrainor@chromium.org>
Commit : 0259e8f401403e8eedda1b3af98660bdb7c12ab1

Code Review +2: Carson Holgate, David Trainor
Verified    +1: David Trainor
Change-Id     : Ifae7d955314dbc104a41d0358aa22da907c001aa
Reviewed-at   : https://gerrit-int.chromium.org/43792
The crash is fixed but we still have some odd animations.  I have an idea of why we're seeing this but I still need to investigate.
Labels: Merge-Requested
Status: Fixed
The quick fix for the NPE is in.  We should get that to M30 and worry about fixing the animations as a lower priority.

Comment 12 by kareng@google.com, Sep 5 2013

Labels: -Merge-Requested Merge-Approved
i assume u want https://gerrit-int.chromium.org/43792. https://gerrit-int.chromium.org/43792 approved
Just https://gerrit-int.chromium.org/#/c/43792/ at #9.  #6 was reverted.
Cc: -dtrainor@chromium.org clholgat@chromium.org
Owner: dtrainor@chromium.org
Status: Assigned
Tested with latest M30 build - 30.0.1599.38

Still getting error on Tabswitcher mode on N4/JWR build
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 11 2013

Project: .../internal/apps
Branch : 1599
Author : David Trainor <dtrainor@chromium.org>
Commit : 9ca268373451fadfa00faf64c30e135053ef12d6

Code Review +2: David Trainor
Verified    +1: David Trainor
Change-Id     : I33169c5e2a7e8596eff6a4c7c44df73d0363bdf6
Reviewed-at   : https://gerrit-int.chromium.org/44079
Labels: -Merge-Approved Merge-Merged
Status: Fixed
Status: Verified
Verified on M30(30.0.1599.48) /M31(31.0.1634.0)and issue got fixed.

Sign in to add a comment