New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 27483 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2009
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Restricted
  • Only users with Commit permission may comment.



Sign in to add a comment

Empty Chrome Frame directories aren't removed even after restart

Reported by sunandt@chromium.org, Nov 12 2009

Issue description

What steps will reproduce the problem?
1. Install CF 244
2. Navigate to any URL that uses CF like cf:about:
3. Uninstall CF
4. A dialog will appear whether to restart or not. Click on restart now.

Issue: Even after restart the Chrome Frame directories @ 
C:\Program Files\Google and 
C:\Documents and Settings\username\Local Settings\Application Data\Google
will not be removed

Installer log
-------------
[1111/172038:ERROR:uninstall.cc(116)] Failed to delete folder: C:\Documents 
and Settings\All Users\Start Menu\Programs\Google Chrome Frame
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\ChromeHTML
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Clients\StartMenuInternet\Google Chrome Frame
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Clients\StartMenuInternet\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\Applications\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Microsoft\Windows\CurrentVersion\App Paths\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\.htm\OpenWithList\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\.html\OpenWithList\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\.shtml\OpenWithList\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\.xht\OpenWithList\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Classes\.xhtml\OpenWithList\chrome.exe
[1111/172038:ERROR:uninstall.cc(252)] Failed to delete registry key: 
Software\Microsoft\MediaPlayer\ShimInclusionList\chrome.exe
[1111/172038:ERROR:uninstall.cc(207)] Failed to delete folder (1st try): 
C:\Program Files\Google\Chrome Frame\Application
[1111/172038:ERROR:uninstall.cc(227)] Failed to delete user profile dir: 
C:\Documents and Settings\testing\Local Settings\Application 
Data\Google\Chrome Frame\User Data

 

Comment 1 by bugdro...@gmail.com, Nov 12 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31853 

------------------------------------------------------------------------
r31853 | robertshield@chromium.org | 2009-11-12 15:31:35 -0800 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.cc?r1=31853&r2=31852
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_after_reboot_helper.cc?r1=31853&r2=31852
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_after_reboot_helper.h?r1=31853&r2=31852

Correctly schedule empty parent directories for deletion when Chrome Frame is uninstalled while in use.

BUG= 27483 ,23999
TEST=Uninstall Chrome Frame while it is in use. Verify that all Chrome Frame folders are removed.

Review URL: http://codereview.chromium.org/392013
------------------------------------------------------------------------

Status: Fixed
Fixed, mostly. At least as fixed as I can make it without much plumbing.

The correct directories are now all scheduled for deletion and I have not seen a case 
where the files in Program Files don't get removed.

For the user profile directory, this MAY still occasionally fail if CF is in use. 
Here's why: the mechanism we use to schedule files for deletion is to call out to 
MoveFileEx asking it to delete files on reboot. MoveFileEx will only cause files and 
_empty_ directories to be deleted on reboot, so we traverse the tree of the user 
profile depth-first and delete each individual file before it's parent directory. 

If new files are created in the user profile between the time we uninstall and the 
time Chrome Frame is shut down / the machine is rebooted then not all of the user 
profile directories will be empty (since the new file couldn't be scheduled to be 
deleted before it existed). The session manager will then stop deleting stuff and may 
leave some directories behind. Fixing this will take quite a bit of work.

So for now, I will mark this as fixed as the delete-on-reboot mechanism tries its 
best and will get rid of the profile directory at least some of the time.
Issue 23999 has been merged into this issue.

Comment 4 by bugdro...@gmail.com, Nov 19 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31853 

------------------------------------------------------------------------
r31853 | robertshield@chromium.org | 2009-11-12 15:31:35 -0800 (Thu, 12 Nov 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/uninstall.cc?r1=31853&r2=31852
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_after_reboot_helper.cc?r1=31853&r2=31852
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/delete_after_reboot_helper.h?r1=31853&r2=31852

Correctly schedule empty parent directories for deletion when Chrome Frame is uninstalled while in use.

BUG= 27483 ,23999
TEST=Uninstall Chrome Frame while it is in use. Verify that all Chrome Frame folders are removed.

Review URL: http://codereview.chromium.org/392013
------------------------------------------------------------------------

Labels: -Area-Installer Area-Internals Internals-Install

Comment 6 by *mdu@chromium.org, Jan 5 2010

Status: Verified
Verified in build 4.0.289.0 (Official Build 35449), it works fine now
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Area-Internals -Internals-Install Cr-Internals-Install Cr-Internals
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2013

Labels: -Cr-Internals-Install Cr-Internals-Installer

Sign in to add a comment