Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 247 users
Status: Fixed
Owner:
Closed: Sep 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 742457
issue 753945

Restricted
  • Only users with EditIssue permission may comment.


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment
Right click and rename USB & SD volumes in the left nav
Project Member Reported by joshwoodward@chromium.org, Aug 16 2013 Back to list
You should be able to rename any volume in the left nav that is insertable and has RW privileges - e.g. USB, SD, etc.

You should be able to right click and then there should be a "Rename" option at the top of the context menu. This should behave the same way as renaming a file.

@satorux - This could be a good feature for M-31 if there's time. WDYT? Marking Pri-2 and M-31 for now since our other features are set.
 
Cc: -satorux@chromium.org benchan@chromium.org
Labels: -M-31
Owner: kinaba@chromium.org
Status: Assigned
I think changing disk volume names is a very tricky thing to do. For FAT32 (most USB/SD volumes are formatted in this format), we seem to need to use "mlabel" command with a root privilege per https://help.ubuntu.com/community/RenameUSBDrive. That said, getting this done right would need a significant amount of work.
Cc: joshwoodward@chromium.org
Yes, it's quite tricky. I believe we've previously looked into this feature request and decided that it's one of the long tail issues that we will eventually address and prioritize according to user demands. But has the time come?

Feature-wise:
1. Do we want to support this feature for all supported filesystems: VFAT, exFAT, NTFS, HFS+, ext2/3/4?  I guess we need to support at least VFAT and exFAT. 

2. Do we allow ASCII-only labels? Otherwise, we may need to educate the user that there may be some compatible issue with other operating systems / media devices.

Implementation-wise:
1. I remember, for some filesystem, we may need to ensure the block device is not busy before modifying the label. That may imply unmounting the ilesystem first before relabeling it.

2. cros-disks currently derives the mount point based on filesystem label. If we keep the same implementation, we need to remount the filesystem to a different mount point after modifying the label. It becomes challenging to handle already open files. If the new label already exists on another mounted filesystem, we need to de-duplicate the mount point, which can be confusing to the user.

A cleaner solution is to force unmount the filesystem before relabeling it. But a much cleaner solution is to have cros-disks introduces another mapping of the label and the mount point. It's similar to how we handle the display name of a mounted archive in the GDrive cache.

3. We should sandbox third_party processes that requires root privilege, which involves profiling the system calls used by these processes and derives an appropriate seccomp filter.

Given the amount of work and decisions to get it right, both UX and implementation, I'd recommend some more planning on this feature.
Cc: kinaba@chromium.org
Owner: ----
Status: Available
Whoa, quite tricky indeed. Let's leave this one in the backlog for now. When/if we do it, I think we could do the renaming as a part of the "Format device" flow.

Marking "Available" for now...
Cc: -kinaba@chromium.org
Labels: -Type-Bug -Pri-2 Type-Feature Pri-3
Owner: kinaba@chromium.org
Status: Assigned
Comment 5 by Deleted ...@, Apr 10 2014
yes please fix this so i can rename my SD card and usb drive 
Kinaba, is there a reason this is still assigned to you? If not, I'd like to toss it back to Available.
Owner: ----
Status: Available
Please kill this feature and bring back ext4 support
Forgive me for not digging into this issue more deeply, but it seems to me that the problem might be solved by not using the filesystem label as the volume's mount point.

How about using the dev name instead?  The ui can dynamically query the label when required.

I apologize if this isn't a viable solution, it's just that I would love to be able to easily rename my volumes AND still be able to use all of my ext formatted drives.
Wait, THIS is the problem that you are going to drop ext4 support for? Maybe I am missing something, but this sounds like a purely cosmetic issue.
Cc: satorux@chromium.org
Labels: Restrict-AddIssueComment-EditIssue
Owner: bengold@chromium.org
Status: Untriaged
Saving this from the great bug bash as I'd like to see it implemented one day 
Cc: dhadd...@chromium.org sdantul...@chromium.org
 Issue 569656  has been merged into this issue.
Owner: fukino@chromium.org
s/bengold/fukino/ in Owner field
Labels: -Pri-3 Pri-2
Status: Assigned
fukino@ can you comment on the viability of #9?

It seems like using a less mutable ID as the mount point would be useful in general. It's not like the user cares over-much what the internal mount point is.

Based on earlier comments it seems like the following flow would work:
1: User enters a new name for the device.
2: Unmount the drive.
3: Do the rename.
4: Remount the drive.

If any of the steps fail we can just display an error and abort.

Is there complexity/difficulty here I'm missing?

This is a highly requested feature. I know we've held off due to difficulty, but we can't let it starve forever.
Blocking: 742457
Cc: yamaguchi@chromium.org
Owner: klemenko@google.com
Blocking: 753945
Project Member Comment 19 by bugdroid1@chromium.org, Aug 16
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/193cc4b7f06fcad518bc987d0d59b0128652a677

commit 193cc4b7f06fcad518bc987d0d59b0128652a677
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Aug 16 11:18:24 2017

system_api: Add cros_disks::kFileSystemType.

BUG= chromium:274041 
TEST=None

Change-Id: I6c5d9b324a1721dd63822b7dd4fdaaf2f6099c48
Reviewed-on: https://chromium-review.googlesource.com/608727
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>

[modify] https://crrev.com/193cc4b7f06fcad518bc987d0d59b0128652a677/dbus/cros-disks/dbus-constants.h

Project Member Comment 20 by bugdroid1@chromium.org, Aug 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/a8a13b91661a811162d2043ca211165ecdaa035f

commit a8a13b91661a811162d2043ca211165ecdaa035f
Author: Klemen Kozjek <klemenko@google.com>
Date: Thu Aug 17 14:31:37 2017

cros-disks: Add Rename method, RenameCompleted signal, and RenameErrorType.

This CL adds cros_disks::Rename method, cros_disks::RenameCompleted signal, and cros_disks::RenameErrorType.

BUG= chromium:274041 
TEST=None

Change-Id: Icb0fba5a894f9c958ed92a3918e7e338d7ba6f54
Reviewed-on: https://chromium-review.googlesource.com/609043
Commit-Ready: Klemen Kozjek <klemenko@google.com>
Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/a8a13b91661a811162d2043ca211165ecdaa035f/dbus/cros-disks/dbus-constants.h

Project Member Comment 21 by bugdroid1@chromium.org, Aug 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/15f8d636eada3869f897f8df9f15fc3a76d30b63

commit 15f8d636eada3869f897f8df9f15fc3a76d30b63
Author: Klemen Kozjek <klemenko@google.com>
Date: Thu Aug 17 16:26:15 2017

cros-disks: Add FileSystemType to DiskDevice struct.

This CL extends DiskDevice structure with file system type.

BUG= chromium:274041 
CQ-DEPEND=CL:608727
TEST=platform_CrosDisks*

Change-Id: I7ddabb989c0f64bacd40e5bb7f2575e70604cefc
Reviewed-on: https://chromium-review.googlesource.com/609565
Commit-Ready: Klemen Kozjek <klemenko@google.com>
Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/15f8d636eada3869f897f8df9f15fc3a76d30b63/cros-disks/dbus_bindings/org.chromium.CrosDisks.xml
[modify] https://crrev.com/15f8d636eada3869f897f8df9f15fc3a76d30b63/cros-disks/disk.cc

Project Member Comment 22 by bugdroid1@chromium.org, Aug 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5df84732755ec06855536e76d0b0631b77491329

commit 5df84732755ec06855536e76d0b0631b77491329
Author: Klemen Kozjek <klemenko@google.com>
Date: Fri Aug 18 05:41:13 2017

autotest platform_CrosDisksDBus: Check if property FileSystemType is present

BUG= chromium:274041 
CQ-DEPEND=CL:609565
TEST=platform_CrosDisksDBus

Change-Id: I58da91727b1def890eca5103db192eb1f7e5ba82
Reviewed-on: https://chromium-review.googlesource.com/612929
Commit-Ready: Klemen Kozjek <klemenko@google.com>
Tested-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/5df84732755ec06855536e76d0b0631b77491329/client/site_tests/platform_CrosDisksDBus/platform_CrosDisksDBus.py

Project Member Comment 23 by bugdroid1@chromium.org, Aug 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83d398593880bf7b73b4b8218ffc47c499b4a730

commit 83d398593880bf7b73b4b8218ffc47c499b4a730
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Aug 23 02:08:15 2017

Files App: Add notifications for renaming

This CL adds notification messages for renaming process for events:
PENDING, SUCCESS, and FAILURE. In addition to notification this CL also
adds strings required by notifications. As a result, when renaming is invoked
you ought to see notification that reports the current status of
renaming.

BUG= 274041 
TEST=browser_tests FileManagerJsTest.DeviceHandler*

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I000bdb58ca93c7f61c8bdf111397d495fc89316e
Reviewed-on: https://chromium-review.googlesource.com/615105
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496555}
[modify] https://crrev.com/83d398593880bf7b73b4b8218ffc47c499b4a730/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/83d398593880bf7b73b4b8218ffc47c499b4a730/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/83d398593880bf7b73b4b8218ffc47c499b4a730/ui/file_manager/file_manager/background/js/device_handler.js
[modify] https://crrev.com/83d398593880bf7b73b4b8218ffc47c499b4a730/ui/file_manager/file_manager/background/js/device_handler_unittest.js

Project Member Comment 24 by bugdroid1@chromium.org, Aug 23
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed2387b81702c4d43f04b17bd6d8518e687bc42e

commit ed2387b81702c4d43f04b17bd6d8518e687bc42e
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Aug 23 02:31:32 2017

Files App: Prepare UI for rename external USB/SD drive

This CL prepares UI for rename external USB/SD drive in Files App. Because backend for this issue has not been finished yet I have added command line argument '--enable-external-drive-rename' which is used to enable UI part of the feature.

Bug:  274041 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ida64372e68108d975cc8b17b3cab99bcf80fc850
Reviewed-on: https://chromium-review.googlesource.com/604611
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#496562}
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chromeos/chromeos_switches.cc
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/chromeos/chromeos_switches.h
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/third_party/closure_compiler/externs/file_manager_private.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/externs/volume_info.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/background/js/volume_info_impl.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/background/js/volume_manager_util.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/common/js/util.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/common/js/volume_manager_common.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/foreground/css/file_manager.css
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/foreground/js/directory_tree_naming_controller.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/ed2387b81702c4d43f04b17bd6d8518e687bc42e/ui/file_manager/file_manager/main.html

Status: Started
Project Member Comment 26 by bugdroid1@chromium.org, Aug 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f1c6195768222e092f363b1e2feb99d974bd24

commit 46f1c6195768222e092f363b1e2feb99d974bd24
Author: Klemen Kozjek <klemenko@google.com>
Date: Fri Aug 25 19:20:54 2017

Files App: Decouple mount point/volume name and add file system type

This CL decouples mount point name(volumeId) and external drive device's name, and extends volume info with disk file system type which is going to be used for external drive renaming process. OnFormatCompleted it will update mount point, volume name, and disk file system type.

As a result, you should see entries with the exact same name if you use two or more partitions/disks with the exact same name.

CQ-DEPEND=CL:608727, CL:609565, CL:604611

Bug:  274041 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7fb9ef2ac45100a31411d38bc2f54ba215b440f6
Reviewed-on: https://chromium-review.googlesource.com/605108
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#497488}
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/chromeos/file_manager/volume_manager.h
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_chromeos_unittest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/extensions/api/image_writer_private/test_utils.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/browser/extensions/api/image_writer_private/test_utils.h
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chrome/test/data/extensions/api_test/file_browser/mount_test/test.js
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/dbus/cros_disks_client.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/dbus/cros_disks_client.h
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/dbus/cros_disks_client_unittest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/disks/disk_mount_manager.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/disks/disk_mount_manager.h
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/disks/disk_mount_manager_unittest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/disks/mock_disk_mount_manager.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/disks/mock_disk_mount_manager.h
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/chromeos/disks/suspend_unmount_manager_unittest.cc
[modify] https://crrev.com/46f1c6195768222e092f363b1e2feb99d974bd24/components/storage_monitor/storage_monitor_chromeos_unittest.cc

Project Member Comment 27 by bugdroid1@chromium.org, Aug 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7

commit bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7
Author: Klemen Kozjek <klemenko@google.com>
Date: Fri Aug 25 20:20:09 2017

Files App: Add Rename to cros disks client.

This CL adds Rename method to the disk client implementation which
through dbus invokes cros disks disk renaming functionality. Before
renaming happens on the mounted disk, client will save its mount point
name for later when re-mounting will occur and try to re-mount the disk
to previous mount point name to preserve file paths.

BUG= 274041 
CQ-DEPEND=CL:605108

Change-Id: I40d0522cb5195940b0b949418a99e2eaca1e1041
Reviewed-on: https://chromium-review.googlesource.com/616510
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497518}
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/app_mode/kiosk_external_updater.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/app_mode/kiosk_external_updater.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/device_event_router.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/device_event_router.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/device_event_router_unittest.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/event_router.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/file_manager/volume_manager.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/file_manager/volume_manager_observer.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chrome/common/extensions/api/file_manager_private.idl
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/dbus/cros_disks_client.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/dbus/cros_disks_client.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/dbus/fake_cros_disks_client.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/dbus/fake_cros_disks_client.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/disks/disk_mount_manager.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/disks/disk_mount_manager.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/disks/disk_mount_manager_unittest.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/disks/mock_disk_mount_manager.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/chromeos/disks/mock_disk_mount_manager.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/components/arc/volume_mounter/arc_volume_mounter_bridge.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/components/arc/volume_mounter/arc_volume_mounter_bridge.h
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/components/storage_monitor/storage_monitor_chromeos.cc
[modify] https://crrev.com/bf5610fa7d17e67ce4970e5f6e3d4850f05e19d7/components/storage_monitor/storage_monitor_chromeos.h

Project Member Comment 28 by bugdroid1@chromium.org, Aug 25
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db1d04e328f308c14887b186a51313b8014f8dae

commit db1d04e328f308c14887b186a51313b8014f8dae
Author: Klemen Kozjek <klemenko@google.com>
Date: Fri Aug 25 22:01:50 2017

Files App: Add tests for volume name renaming

This CL adds automated tests for volume rename functionality inside of
cros disks client.

BUG= 274041 
CQ-DEPEND=CL:616510

Change-Id: Ibd4da890471c379c15c3b70a00730a63a5843eae
Reviewed-on: https://chromium-review.googlesource.com/628616
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497557}
[modify] https://crrev.com/db1d04e328f308c14887b186a51313b8014f8dae/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
[modify] https://crrev.com/db1d04e328f308c14887b186a51313b8014f8dae/chromeos/disks/disk_mount_manager_unittest.cc

Project Member Comment 29 by bugdroid1@chromium.org, Aug 28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe224986776e689b4767047d4ab37fca2baabfd4

commit fe224986776e689b4767047d4ab37fca2baabfd4
Author: Klemen Kozjek <klemenko@google.com>
Date: Mon Aug 28 07:50:01 2017

Files App: Display grayed out Rename action

This CL changes a condition when to show Rename action and when to gray
it out. As a result, Rename action is visible on every removable device
regardless of its file system type and read-only flag. If removable
device has an unsupported file type or read-only flag is set then Rename
action will be unclickable(grayed out) but visible.

Bug:  274041 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibb30ae43a8435e5b43757af227b7d7adb4adec61
Reviewed-on: https://chromium-review.googlesource.com/637293
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#497707}
[modify] https://crrev.com/fe224986776e689b4767047d4ab37fca2baabfd4/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Project Member Comment 30 by bugdroid1@chromium.org, Aug 30
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b065885040075209fbaf6e8c6c997f270a3a1dbe

commit b065885040075209fbaf6e8c6c997f270a3a1dbe
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Aug 30 20:04:23 2017

cros-disks: Add Rename manager

This CL adds external drive rename functionality to cros_disks service.
As a result, cros_disks supports rename of VFAT and EXFAT disks for
which it uses exfatlabel and dosfslabel tools within sandboxed process
to reduce security risks. Beside renaming implementations the CL also
contains unit tests related to the implementation.

BUG= chromium:274041 
CQ-DEPEND=CL:609565, CL:609043
TEST=platform_CrosDisks*, RenameManagerTest.*

Change-Id: I69c95c0d5fecc37ab993256abe060fd439ecfa2d
Reviewed-on: https://chromium-review.googlesource.com/616585
Commit-Ready: Klemen Kozjek <klemenko@google.com>
Tested-by: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/cros_disks_server.cc
[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/org.chromium.CrosDisks.conf
[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/daemon.h
[add] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/rename_manager.cc
[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/daemon.cc
[add] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/rename_manager_observer_interface.h
[add] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/rename_manager.h
[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/dbus_bindings/org.chromium.CrosDisks.xml
[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/cros-disks.gyp
[modify] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/cros_disks_server.h
[add] https://crrev.com/b065885040075209fbaf6e8c6c997f270a3a1dbe/cros-disks/rename_manager_unittest.cc

Project Member Comment 31 by bugdroid1@chromium.org, Aug 31
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494

commit 7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494
Author: Klemen Kozjek <klemenko@google.com>
Date: Thu Aug 31 07:24:10 2017

autotest: Add platform_CrosDisksRename test

This CL adds platform_CrossDisksRename test to test renaming feature
for VFAT, EXFAT, and NTFS (unsupported file system) file system type.

BUG= chromium:274041 
CQ-DEPEND=CL:616585
TEST=platform_CrosDisksRename

Change-Id: Ic2419873911fe0f8268ebbdf49662cfbf4509adf
Reviewed-on: https://chromium-review.googlesource.com/614822
Commit-Ready: Klemen Kozjek <klemenko@google.com>
Tested-by: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Ben Chan <benchan@chromium.org>

[add] https://crrev.com/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494/client/site_tests/platform_CrosDisksRename/platform_CrosDisksRename.py
[modify] https://crrev.com/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494/client/cros/cros_disks.py
[add] https://crrev.com/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494/client/site_tests/platform_CrosDisksRename/vfat_tests
[add] https://crrev.com/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494/client/site_tests/platform_CrosDisksRename/ntfs_tests
[add] https://crrev.com/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494/client/site_tests/platform_CrosDisksRename/exfat_tests
[add] https://crrev.com/7740bfdcbe7ca6fdfe5c5e86b1f3e1543b20b494/client/site_tests/platform_CrosDisksRename/control

Project Member Comment 32 by bugdroid1@chromium.org, Aug 31
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e3f3865f5c63645e002ed6986dad3f772b306434

commit e3f3865f5c63645e002ed6986dad3f772b306434
Author: Klemen Kozjek <klemenko@google.com>
Date: Thu Aug 31 09:37:08 2017

autotest: Add test platform_CrosDisksRename

BUG= chromium:274041 
CQ-DEPEND=CL:614822
TEST=Remote trybot builds.

Change-Id: I2595c40c2ca3ad6333c7f57d6c0a83e91132b7c2
Reviewed-on: https://chromium-review.googlesource.com/623547
Commit-Ready: Klemen Kozjek <klemenko@google.com>
Tested-by: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/e3f3865f5c63645e002ed6986dad3f772b306434/chromeos-base/autotest-tests-cros-disks/autotest-tests-cros-disks-9999.ebuild

Project Member Comment 33 by bugdroid1@chromium.org, Sep 1
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2b30e45756aac3dcdcef7ef13834c0601b4553a

commit f2b30e45756aac3dcdcef7ef13834c0601b4553a
Author: Klemen Kozjek <klemenko@google.com>
Date: Fri Sep 01 05:04:51 2017

Files App: Add a flag for rename feature to flag descriptions

This CL adds a flag that enables external drive rename action in the
context menu. The flag is added to flag descriptions and as a result, it
is visible under chrome://flags.

BUG= 274041 

Change-Id: Ia83b12daab124b0f664699b432d48c6138410678
Reviewed-on: https://chromium-review.googlesource.com/644667
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#499134}
[modify] https://crrev.com/f2b30e45756aac3dcdcef7ef13834c0601b4553a/chrome/browser/about_flags.cc
[modify] https://crrev.com/f2b30e45756aac3dcdcef7ef13834c0601b4553a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f2b30e45756aac3dcdcef7ef13834c0601b4553a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/f2b30e45756aac3dcdcef7ef13834c0601b4553a/tools/metrics/histograms/enums.xml

Status: Fixed
Labels: Merge-Request-62
Project Member Comment 36 by sheriffbot@chromium.org, Sep 2
Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 44 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I would like to CP commit f2b30e45756aac3dcdcef7ef13834c0601b4553a to M62.
Project Member Comment 38 by bugdroid1@chromium.org, Sep 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1f85b7c00511599dd6742f7d0e4a0492413d4c0

commit c1f85b7c00511599dd6742f7d0e4a0492413d4c0
Author: Klemen Kozjek <klemenko@google.com>
Date: Wed Sep 06 05:26:49 2017

Files App: Change a text of *_LONG_NAME

As a result, IDS_FILE_BROWSER_ERROR_EXTERNAL_DRIVE_LONG_NAME 
and IDS_FILE_BROWSER_ERROR_LONG_NAME follow UX writing style.

BUG= 274041 

Change-Id: I93222050e54717f19b17fe8fc86aaf9adefd514d
Reviewed-on: https://chromium-review.googlesource.com/651829
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499885}
[modify] https://crrev.com/c1f85b7c00511599dd6742f7d0e4a0492413d4c0/chrome/app/chromeos_strings.grdp

Labels: -Merge-Review-62 Merge-Rejected-62
Merge for 62 is rejected, we are past branch point and are no longer accept string changes.
Labels: -Merge-Rejected-62 Merge-Approved-62
Merge approved as we should not need string changes here per email.
Project Member Comment 41 by bugdroid1@chromium.org, Sep 12
Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b452163815081e0b113ad259e10b4ec0db579f5

commit 8b452163815081e0b113ad259e10b4ec0db579f5
Author: Klemen Kozjek <klemenko@google.com>
Date: Tue Sep 12 03:34:50 2017

Files App: Add a flag for rename feature to flag descriptions

This CL adds a flag that enables external drive rename action in the
context menu. The flag is added to flag descriptions and as a result, it
is visible under chrome://flags.

BUG= 274041 

Change-Id: Ia83b12daab124b0f664699b432d48c6138410678
Reviewed-on: https://chromium-review.googlesource.com/644667
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#499134}(cherry picked from commit f2b30e45756aac3dcdcef7ef13834c0601b4553a)
Reviewed-on: https://chromium-review.googlesource.com/662478
Cr-Commit-Position: refs/branch-heads/3202@{#154}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/8b452163815081e0b113ad259e10b4ec0db579f5/chrome/browser/about_flags.cc
[modify] https://crrev.com/8b452163815081e0b113ad259e10b4ec0db579f5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/8b452163815081e0b113ad259e10b4ec0db579f5/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/8b452163815081e0b113ad259e10b4ec0db579f5/tools/metrics/histograms/enums.xml

Sign in to add a comment