Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 272765 Files.app: Unable to create a new folder in "select a folder to open" window
Starred by 18 users Project Member Reported by tkonch...@chromium.org, Aug 14 2013 Back to list
Status: Verified
Owner:
Closed: Aug 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment
Chrome Version: 30.0.1599.1 (Official Build 217187) canary
Chrome OS Version: 
Chrome OS Platform: 4537.0.0 (Official Build) canary-channel daisy
Network info: wifi

Precondition : Have a few files in downloads.

Steps To Reproduce:
1. Launch chrome and navigate chrome://extensions and check the developer mode and click on "Load unpacked extension" button.
2. Observe that "Select a folder to open" window opens up with "New folder" button at the left bottom.
3. Click on "New folder" button and observe that nothing happens.

Expected Result: The new folder should be created.

Actual Result: Nothing happens.

This is a regression issue as it was working fine in M28 and M29.


 
Labels: Iteration-88
Owner: mtomasz@chromium.org
Status: Assigned
@mtomasz - It looks like your plate is a bit more open than @yoshiki's. Do you mind taking this?
Comment 2 by mtomasz@google.com, Aug 14 2013
No problem. I'll take a look tmr.
Labels: todo
It happens on "Save file as" as well.

Reproduce steps :
1.  right click on a page and select the "Save as..." option
2.  click on any folders to enable "New folder" button 
3.  click on "New folder" 
Status: Started
Project Member Comment 6 by bugdroid1@chromium.org, Aug 19 2013
------------------------------------------------------------------------
r218255 | mtomasz@chromium.org | 2013-08-19T10:34:15.576752Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/css/file_manager.css?r1=218255&r2=218254&pathrev=218255
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=218255&r2=218254&pathrev=218255
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/extensions/file_manager/file_manager_browsertest.cc?r1=218255&r2=218254&pathrev=218255
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/main.html?r1=218255&r2=218254&pathrev=218255

Fix creating a directory in the Save-as dialog.

This regression was caused since we were listening for commands on the dialog container only. In the save-as dialog, the new folder button is on the footer, which is not a child of the dialog container. This patch adds listening for the command on the footer.

TEST=Tested manually.
BUG= 272765 

Review URL: https://chromiumcodereview.appspot.com/22880017
------------------------------------------------------------------------
Labels: Merge-TBD
Status: Fixed
This may be in M-30. I have to double check.
This bug exists in

Google Chrome	30.0.1599.16 (Official Build 218868) dev
Platform	4537.16.0 (Official Build) dev-channel
Labels: Iteration-89
Status: Assigned
Please re-open if the bug still exists. I'll do it now.
Cc: hirono@chromium.org yoshiki@chromium.org
CC'ing in case @yoshiki or @hirono can take this on in Iteration-89.
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
 mtomasz@, is r218255 needed to be merged to M-30 to resolve this issue?
Can you merge-request if so?
This should have landed in M-30. If it still reproduces, then it means it is still broken. I am not able to check since I'm OOO.
Cc: mtomasz@chromium.org
Owner: hirono@chromium.org
Still broken on latest M-30:

Google Chrome	30.0.1599.20 (Official Build 219470) beta
Platform	4537.24.0 (Official Build) beta-channel link

Assigning to @hirono since @mtomasz is OOO.
Comment 14 by Deleted ...@, Aug 26 2013
ja ovo ništa ne razumijem

Comment 15 by Deleted ...@, Aug 26 2013
NÃO ESTA CONECTANDO E NÃO CONSIGO ATUALIZAR GOOGLE CHROME
@mtomasz - Is this really landed for M30? The branch is cut at the rev 217147 and the log shows this is not landed into 1599.

https://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/browser/resources/file_manager/js/?view=log

Labels: -Merge-TBD Merge-Requested
Comment 18 by kareng@google.com, Aug 27 2013
Labels: -Merge-Requested Merge-Approved
Project Member Comment 19 by bugdroid1@chromium.org, Aug 28 2013
Labels: -Merge-Approved merge-merged-1599
------------------------------------------------------------------------
r219915 | hirono@chromium.org | 2013-08-28T04:22:19.810188Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/browser/resources/file_manager/main.html?r1=219915&r2=219914&pathrev=219915
   M http://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/browser/resources/file_manager/css/file_manager.css?r1=219915&r2=219914&pathrev=219915
   M http://src.chromium.org/viewvc/chrome/branches/1599/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=219915&r2=219914&pathrev=219915

Merge 218255 "Fix creating a directory in the Save-as dialog."

> Fix creating a directory in the Save-as dialog.
> 
> This regression was caused since we were listening for commands on the dialog container only. In the save-as dialog, the new folder button is on the footer, which is not a child of the dialog container. This patch adds listening for the command on the footer.
> 
> TEST=Tested manually.
> BUG= 272765 
> 
> Review URL: https://chromiumcodereview.appspot.com/22880017

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/23624005
------------------------------------------------------------------------
Status: Fixed
Status: Verified

Google Chrome	30.0.1599.24 (Official Build 220122) dev
Platform	4537.30.0 (Official Build) dev-channel peach_pit
I had message to update +++++++++++++++++++++++++++++++++++++++++++++++Google Chrome,wont download

Sign in to add a comment