Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 270340 Need to subdivide TextTrackCue into VTTCue
Starred by 6 users Project Member Reported by gl...@skynav.com, Aug 9 2013 Back to list
Status: Fixed
Owner:
User never visited
Closed: Apr 2014
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment
The definition of TextTrackCue has changed from HTML5.0 CR [1] to HTML5.1 ED [2] (and the "HTML Living Standard" [3]) as follows:

(1) the following members have moved to a new interface VTTCue [4]:

* attribute DOMString vertical;
* attribute boolean snapToLines;
* attribute (long or AutoKeyword) line;
* attribute long position;
* attribute long size;
* attribute DOMString align;
* attribute DOMString text;
* DocumentFragment getCueAsHTML();

it has been proposed that the text attribute be restored to TextTrackCue to serve with generic instances of TextTrackCue, i.e., instances lacking a specialized sub-interface (sub-type);

(2) the following member, introduced by the earlier WebVTT regions extension appears to have been moved to VTTCue as well according to [4]:

* attribute DOMString regionId

However, the current version of the WebVTT Region Extension [5] is still showing this member on TextTrackCue. [This conflict needs to be resolved by the editor.]

(3) the earlier constructor defined on TextTrackCue has been removed in [2][3], and a new constructor defined on VTTCue [4]:

[Constructor(double startTime, double endTime, DOMString text)]
interface VTTCue : TextTrackCue { ... }

it has been proposed that the prior defined constructor on TextTrackCue should be restored, in order to construct generic cues;

(4) the following enumeration type definition was moved from the definition of TextTrackCue to the definition of VTTCue:

enum AutoKeyword { "auto" };

while the following new enumerations were introduced with the definition of VTTCue:

enum DirectionSetting { "" /* horizontal */, "rl", "lr" };
enum AlignSetting { "start", "middle", "end", "left", "right" };

with the vertical and align attributes now returning these enumeration types, respectively, rather than DOMString.

[1] http://www.w3.org/TR/2012/CR-html5-20121217/embedded-content-0.html#texttrackcue
[2] http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#texttrackcue
[3] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#texttrackcue
[4] https://dvcs.w3.org/hg/text-tracks/raw-file/default/webvtt/webvtt.html#vttcue-interface
[5] https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html#attributes-1
 
The region extension [5] is out of date and will be removed soon.
Comment 2 by gl...@skynav.com, Aug 9 2013
As of today, the editor of HTML5 and HTML5.1 has restored the TextTrackCue constructor and the text property to the TextTrackCue interface, while removing the text property from the VTTCue interface. See [1][2][3].

Note that both the prior elimination of the TextTrackCue constructor, and not its restoration for constructing generic (non-WebVTT) cues, constitute a substantive, technical change that is not backward compatible with existing early adopter use of the TextTrackCue constructor. More specifically, existing JS client code that used this constructor will need to be changed to use the VTTCue constructor instead. Otherwise, the result obtained from constructing TextTrackCue will be a generic cue not associated with WebVTT semantics.

[1] http://www.w3.org/html/wg/drafts/html/CR/embedded-content-0.html#texttrackcue
[2] http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#texttrackcue
[3] https://dvcs.w3.org/hg/text-tracks/raw-file/default/webvtt/webvtt.html#vttcue-interface
Comment 3 by gl...@skynav.com, Aug 9 2013

>Note that both the prior elimination of the TextTrackCue constructor, and not its restoration for constructing
>generic (non-WebVTT) cues...

s/not its restoration/now its restoration/
Comment 4 by gl...@skynav.com, Aug 9 2013
Labels: -Type-Bug Type-Feature OWP-Type-ChangeAPI
Comment 5 by gl...@skynav.com, Aug 12 2013
In the original description of this bug, the list of members to be moved from TextTrackCue to VTTCue erroneously included the following member:

* attribute DOMString text;

This member is slated to be retained on TextTrackCue as per [1].

[1] http://www.w3.org/html/wg/drafts/html/master/embedded-content-0.html#texttrackcue
Comment 6 by glenn@chromium.org, Aug 14 2013
Labels: -Cr-Internals-Media-Track Cr-Blink
Status: Started
Comment 7 by glenn@chromium.org, Aug 14 2013
Owner: glenn@chromium.org
Comment 8 by glenn@chromium.org, Aug 14 2013
Labels: -Cr-Blink Cr-Blink-Text-Track
Comment 9 by phil...@opera.com, Oct 26 2013
Is this in review now? I'm going to be working on <track> and WebVTT soon, and expect to make changes that would conflict with these changes.
Comment 10 by glenn@chromium.org, Oct 26 2013
The prior review was cancelled after I deleted its CLs. I will be submitting a new CL shortly once I deal with some custom V8 binding issues. So stay tuned.
I'm actively working on 23702007, but this is mostly on the demuxer end of the pipeline.  If the work you're doing is sufficiently downstream, it might not affect me too much.

https://chromiumcodereview.appspot.com/23702007/
Project Member Comment 12 by bugdroid1@chromium.org, Oct 28 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=160707

------------------------------------------------------------------------
r160707 | philipj@opera.com | 2013-10-28T09:31:38.186385Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/page/UseCounter.h?r1=160707&r2=160706&pathrev=160707
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=160707&r2=160706&pathrev=160707

Add UseCounter for TextTrackCue constructor

The plan in issue 270340 is to leave the TextTrackCue constructor until
it is known to be safe to deprecate and remove. Add a UseCounter so that
we can get stats from M32 stable, to be branched Nov 4th, 2013.

BUG= 270340 

Review URL: https://codereview.chromium.org/47453002
------------------------------------------------------------------------
Comment 13 by phil...@opera.com, Nov 11 2013
After private mail exchange with Glenn, I'll start working on the Web-facing interface split now.
Project Member Comment 14 by bugdroid1@chromium.org, Nov 14 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162015

------------------------------------------------------------------------
r162015 | philipj@opera.com | 2013-11-14T13:03:49.906807Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/custom/V8TextTrackCueCustom.cpp?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/InbandTextTrack.cpp?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/WebVTTParser.cpp?r1=162015&r2=162014&pathrev=162015
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/text-track-cue-constructor.html?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.idl?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/WebVTTParser.h?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/LoadableTextTrack.cpp?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/TextTrackLoader.cpp?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/constructor-length.html?r1=162015&r2=162014&pathrev=162015
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/VTTCue.idl?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cues-cuechange-expected.txt?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cues-enter-exit-expected.txt?r1=162015&r2=162014&pathrev=162015
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/text-track-cue-constructor-expected.txt?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/loader/TextTrackLoader.h?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.cpp?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/js/constructor-length-expected.txt?r1=162015&r2=162014&pathrev=162015
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/VTTCue.cpp?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/webexposed/global-constructors-listing-expected.txt?r1=162015&r2=162014&pathrev=162015
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/VTTCue.h?r1=162015&r2=162014&pathrev=162015
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/bindings.gypi?r1=162015&r2=162014&pathrev=162015

Split VTTCue from TextTrackCue

VTTCue has been split from TextTrackCue in the specs:
http://whatwg.org/html#texttrackcue
http://dev.w3.org/html5/webvtt/#vttcue-interface

The TextTrackCue constructor is left for legacy compat until it is
deemed safe to remove. To verify that it actually works, the tests still
use the TextTrackCue constructor, but will be updated to use VTTCue in a
later commit.

Internal refactoring has been kept to a minimum, future commits should
move more code from TextTrackCue to VTTCue.

Thanks to Glenn Adams for starting this work and providing feedback!

BUG= 270340 

Review URL: https://codereview.chromium.org/63173020
------------------------------------------------------------------------
Project Member Comment 15 by bugdroid1@chromium.org, Nov 14 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162026

------------------------------------------------------------------------
r162026 | philipj@opera.com | 2013-11-14T14:44:42.324887Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues-expected.txt?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/snapToLines-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-negative-timestamp.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTMLCrash-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-mutable-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-remove-active-cue-crash.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/video-controls-captions.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/text.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/endTime.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCueList/getter.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/line.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/vertical-expected.txt?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTML.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-rendering-first-line-box.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrack/removeCue.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/align.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-rendering-empty-cue-crash.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML-expected.txt?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/text-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/regions-webvtt/text-track-cue-region-attribute.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrack/cues.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/snapToLines.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/pauseOnExit.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/align-expected.txt?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/line-expected.txt?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTMLCrash.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-mutable.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-empty-crash.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onenter.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-add-remove-cue-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/startTime.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCueList/length.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/vertical.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/track/track-element/src-clear-cues.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCueList/getCueById.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/video-controls-captions-multiple-clicks.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/track/webvtt/rendering/reftest/repaint.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical-expected.txt?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTMLCrash-expected.txt?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/text.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrack/addCue.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-negative-timestamp-expected.txt?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/align.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/line.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/id.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-disabled-addcue.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/text-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-inline-assertion-crash.html?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/snapToLines.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-add-remove-cue.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/line-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/track-cue-rendering-mode-changed.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTML-expected.txt?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/track.html?r1=162026&r2=162025&pathrev=162026
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/onexit.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/align-expected.txt?r1=162026&r2=162025&pathrev=162026
   D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/TextTrackCue/vertical.html?r1=162026&r2=162025&pathrev=162026
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/media/track/opera/interfaces/VTTCue/getCueAsHTMLCrash.html?r1=162026&r2=162025&pathrev=162026

Update TextTrackCue tests to use VTTCue where appropriate

The Opera tests were fixed upstream and re-imported:
https://github.com/w3c/web-platform-tests/commit/8c08468d5494c9026c2a857f366c631651c413fd
https://github.com/w3c/web-platform-tests/commit/da34397c2c16170da60e5c7638e00c0edadcf0be

A new test in cues.html requres a more recent testharness.js
than we have and was disabled.

BUG= 270340 

Review URL: https://codereview.chromium.org/72543003
------------------------------------------------------------------------
Project Member Comment 16 by bugdroid1@chromium.org, Nov 18 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162245

------------------------------------------------------------------------
r162245 | philipj@opera.com | 2013-11-18T23:18:47.003456Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/InbandTextTrack.cpp?r1=162245&r2=162244&pathrev=162245
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.cpp?r1=162245&r2=162244&pathrev=162245
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTParser.cpp?r1=162245&r2=162244&pathrev=162245
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.cpp?r1=162245&r2=162244&pathrev=162245
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=162245&r2=162244&pathrev=162245
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrack.h?r1=162245&r2=162244&pathrev=162245

Remove the logic for de-duplicating in-band text track cues

To de-duplicate cues by comparing their properties cannot work, since
scripts can modify cues in small or big ways at any time. For example,
the de-duplication will fail if the id has changed or if the timings
have been slightly shifted.

It must be the demuxer's responsibility to do this, e.g. by keeping
track of the offsets for which cues have already been sourced. This need
not consume a lot of memory, since it could record ranges of offsets.

BUG= 270340 

Review URL: https://codereview.chromium.org/74623002
------------------------------------------------------------------------
Project Member Comment 17 by bugdroid1@chromium.org, Nov 22 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=162550

------------------------------------------------------------------------
r162550 | glenn@chromium.org | 2013-11-22T16:50:41.401805Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=162550&r2=162549&pathrev=162550
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTextTrackCue.cpp?r1=162550&r2=162549&pathrev=162550
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTCue.h?r1=162550&r2=162549&pathrev=162550
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/shadow/MediaControlElements.cpp?r1=162550&r2=162549&pathrev=162550
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/HTMLMediaElement.h?r1=162550&r2=162549&pathrev=162550
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVTTCue.cpp?r1=162550&r2=162549&pathrev=162550
   D http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderTextTrackCue.h?r1=162550&r2=162549&pathrev=162550
   A http://src.chromium.org/viewvc/blink/trunk/Source/core/rendering/RenderVTTCue.h?r1=162550&r2=162549&pathrev=162550
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/core.gypi?r1=162550&r2=162549&pathrev=162550
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.cpp?r1=162550&r2=162549&pathrev=162550
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTCue.cpp?r1=162550&r2=162549&pathrev=162550

Move VTT functionality from TextTrackCue.* to VTTCue.*

BUG= 270340 

Review URL: https://codereview.chromium.org/77853002
------------------------------------------------------------------------
Project Member Comment 18 by bugdroid1@chromium.org, Dec 3 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=163113

------------------------------------------------------------------------
r163113 | philipj@opera.com | 2013-12-03T21:31:06.545975Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=163113&r2=163112&pathrev=163113
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTCue.h?r1=163113&r2=163112&pathrev=163113

Remove TextTrackCue::isVTTCue

It is unused, as virtual functions are used instead of casting.

BUG= 270340 

Review URL: https://codereview.chromium.org/102003002
------------------------------------------------------------------------
Project Member Comment 20 by bugdroid1@chromium.org, Dec 4 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=163184

------------------------------------------------------------------------
r163184 | philipj@opera.com | 2013-12-04T17:59:24.671787Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.cpp?r1=163184&r2=163183&pathrev=163184
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTCue.cpp?r1=163184&r2=163183&pathrev=163184
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/TextTrackCue.h?r1=163184&r2=163183&pathrev=163184
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/track/vtt/VTTCue.h?r1=163184&r2=163183&pathrev=163184

Tweak TextTrackCue/VTTCue virtual functions

Remove unreachable implementations and remove toString from release.

BUG= 270340 

Review URL: https://codereview.chromium.org/104473002
------------------------------------------------------------------------
Comment 21 by phil...@opera.com, Apr 27 2014
Status: Fixed
Closing this as I've filed a separate bug for the main remaining issue: https://code.google.com/p/chromium/issues/detail?id=367555
Components: -Blink>Text>Track Blink>Media>Track
Renamed Blink>Text>Track to Blink>Media>Track. Moving these bugs to the new component.
Sign in to add a comment