New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 264197 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jul 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add 'colno' attribute to ErrorEvent interface.

Project Member Reported by mkwst@chromium.org, Jul 25 2013

Issue description

We've avoided doing this, as IE11 is currently running with 'col', which is annoying. We should decide what to name this parameter, and add it to the interface.
 
Cc: l.gom...@samsung.com
Summary: Add 'column' attribute to ErrorEvent interface. (was: Add 'column' parameter to ErrorEvent interface.)
Renaming 'parameter' to 'attribute' as this is what you probably meant.

Also, are you sure IE11 is using 'col'? I checked IE10 a couple of days ago and it was using 'colno' which is consistent with 'lineno' at least.

Comment 2 by mkwst@google.com, Jul 25 2013

I haven't checked myself, so it's quite possible I'm wrong. :)

http://samples.msdn.microsoft.com/ietestcenter/WebWorkers/WorkerGlobalScope_ErrorEvent_colno.htm is looking for 'col', and they claim it passes.
I think you may be confused, this test is for checking the 4th column argument, not the column attribute on the TestEvent.

If you look at http://samples.msdn.microsoft.com/ietestcenter/WebWorkers/support/ErrorEvent.js (worker script called by the test you mentioned), it creates a javascript Object for the onerror arguments. They just happen to call the property 'col' which is why they check for 'col' in the test.
Arguably the test name is confusing as it mentions ErrorEvent and colno :) However, the description is correct: "WorkerGlobalScope onerror event handler 4th argument: col".

Comment 5 by mkwst@chromium.org, Jul 25 2013

Oh, alright. I think the general point still stands, however: IE and the spec disagree. :)
True. I thought it was worth mentioning because I personally prefer the naming used by IE10 as it is more consistent IMHO (lineno / colno) than the specification (lineno / column).

Comment 7 by mkwst@google.com, Jul 25 2013

Yes, I'd agree with that assessment.
Summary: Add 'colno' attribute to ErrorEvent interface. (was: Add 'column' attribute to ErrorEvent interface.)
Good news, the attribute was just renamed to 'colno' in the specification to match IE10:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#errorevent

This should make things easier.

Do you mind if I assign this bug to me?

Comment 10 by mkwst@chromium.org, Jul 26 2013

Cc: -ch.du...@samsung.com
Owner: ch.du...@samsung.com
Please grab it!
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 30 2013

The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=155148

------------------------------------------------------------------------
r155148 | ch.dumez@sisa.samsung.com | 2013-07-30T08:28:51.873690Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/window-onerror-08.html?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/constructors/error-event-constructor.html?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/workers/worker-script-error-expected.txt?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ErrorEvent.h?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ErrorEvent.idl?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/window-onerror-08-expected.txt?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/workers/worker-script-error.html?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/V8ErrorHandler.cpp?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/events/constructors/error-event-constructor-expected.txt?r1=155148&r2=155147&pathrev=155148
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/dom/ErrorEvent.cpp?r1=155148&r2=155147&pathrev=155148

Add 'colno' attribute to ErrorEvent interface

Add 'colno' attribute to ErrorEvent interface to match the latest
specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#errorevent

The 'colno' attribute is already supported by IE10.

BUG= 264197 

Review URL: https://chromiumcodereview.appspot.com/20679002
------------------------------------------------------------------------
Status: Fixed

Sign in to add a comment