New issue
Advanced search Search tips
Starred by 16 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2014
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 8606



Sign in to add a comment
link

Issue 262193: Make Win64 packaging official builds work

Reported by jsc...@chromium.org, Jul 19 2013 Project Member

Issue description

Files, paths, and staging needs to be updated for Win64.
 

Comment 1 by jsc...@chromium.org, Jul 19 2013

Blocking: chromium:8606

Comment 2 by bugdroid1@chromium.org, Jul 19 2013

Project Member
------------------------------------------------------------------------
r212673 | jschuh@chromium.org | 2013-07-19T22:24:01.755558Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=212673&r2=212672&pathrev=212673

Exclude 32-bit specific files from Win64 build

R=gab@chromium.org, kerz@chromium.org
BUG= 262193 

Review URL: https://codereview.chromium.org/19616005
------------------------------------------------------------------------

Comment 3 by bugdroid1@chromium.org, Jul 20 2013

Project Member
------------------------------------------------------------------------
r212719 | jschuh@chromium.org | 2013-07-20T01:56:27.312658Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer.gyp?r1=212719&r2=212718&pathrev=212719
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=212719&r2=212718&pathrev=212719

Copy mini_installer_exe_version.rc to PRODUCT_DIR

This is needed to fix hardcoded paths in FILES.CFG that
prevent using ninja for official builds.

BUG= 262193 
R=grt@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/19845002
------------------------------------------------------------------------

Comment 4 by bugdroid1@chromium.org, Jul 20 2013

Project Member
------------------------------------------------------------------------
r212759 | jschuh@chromium.org | 2013-07-20T06:07:50.904294Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/all.gyp?r1=212759&r2=212758&pathrev=212759

Remove test binaries from Win64 official build to improve cycle times

BUG= 262193 

Review URL: https://chromiumcodereview.appspot.com/19541011
------------------------------------------------------------------------

Comment 5 by bugdroid1@chromium.org, Jul 21 2013

Project Member
Labels: merge-merged-1571
------------------------------------------------------------------------
r212819 | karen@chromium.org | 2013-07-21T07:51:18.443882Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1571/src/chrome/tools/build/win/FILES.cfg?r1=212819&r2=212818&pathrev=212819
   M http://src.chromium.org/viewvc/chrome/branches/1571/src/chrome/installer/mini_installer.gyp?r1=212819&r2=212818&pathrev=212819

Revert 212719 "Copy mini_installer_exe_version.rc to PRODUCT_DIR"

> Copy mini_installer_exe_version.rc to PRODUCT_DIR
> 
> This is needed to fix hardcoded paths in FILES.CFG that
> prevent using ninja for official builds.
> 
> BUG= 262193 
> R=grt@chromium.org, mmoss@chromium.org
> 
> Review URL: https://codereview.chromium.org/19845002

TBR=jschuh@chromium.org

Review URL: https://codereview.chromium.org/19909002
------------------------------------------------------------------------

Comment 6 by bugdroid1@chromium.org, Jul 21 2013

Project Member
------------------------------------------------------------------------
r212826 | karen@chromium.org | 2013-07-21T21:04:46.520338Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=212826&r2=212825&pathrev=212826
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer.gyp?r1=212826&r2=212825&pathrev=212826

Revert 212719 "Copy mini_installer_exe_version.rc to PRODUCT_DIR"

> Copy mini_installer_exe_version.rc to PRODUCT_DIR
> 
> This is needed to fix hardcoded paths in FILES.CFG that
> prevent using ninja for official builds.
> 
> BUG= 262193 
> R=grt@chromium.org, mmoss@chromium.org
> 
> Review URL: https://codereview.chromium.org/19845002

TBR=jschuh@chromium.org

Review URL: https://codereview.chromium.org/19825003
------------------------------------------------------------------------

Comment 7 by bugdroid1@chromium.org, Jul 22 2013

Project Member
------------------------------------------------------------------------
r212954 | jschuh@chromium.org | 2013-07-22T20:16:34.621424Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/mini_installer.gyp?r1=212954&r2=212953&pathrev=212954
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES.cfg?r1=212954&r2=212953&pathrev=212954

Output mini_installer_exe_version.rc to PRODUCT_DIR

This is needed to fix hardcoded paths in FILES.CFG that
prevent using ninja for official builds.

BUG= 262193 
TBR=grt@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/19800003
------------------------------------------------------------------------

Comment 8 by bugdroid1@chromium.org, Jul 22 2013

Project Member
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=39693

------------------------------------------------------------------------
r39693 | jschuh@google.com | 2013-07-22T22:18:14.352008Z

------------------------------------------------------------------------

Comment 9 by bugdroid1@chromium.org, Jul 23 2013

Project Member
------------------------------------------------------------------------
r213007 | jschuh@chromium.org | 2013-07-23T00:26:29.923463Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/all.gyp?r1=213007&r2=213006&pathrev=213007

Remove chromedriver from Win64 official to improve cycle times

Also cleaned up a bit, since the exclusion list was getting long.

BUG= 262193 
R=iannucci@google.com

Review URL: https://codereview.chromium.org/19923004
------------------------------------------------------------------------

Comment 10 by bugdroid1@chromium.org, Jul 23 2013

Project Member
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=39754

------------------------------------------------------------------------
r39754 | jschuh@google.com | 2013-07-23T22:12:03.651094Z

------------------------------------------------------------------------

Comment 11 by bugdroid1@chromium.org, Aug 1 2013

Project Member
The following revision refers to this bug:
    http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=40085

------------------------------------------------------------------------
r40085 | jschuh@google.com | 2013-08-01T00:27:43.603894Z

------------------------------------------------------------------------

Comment 12 by jsc...@chromium.org, Jan 29 2014

Status: Fixed
Fixed a while ago.

Sign in to add a comment