Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Starred by 8 users
Status: Fixed
Owner:
Closed: Aug 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug
Team-Accessibility

Blocking:
issue 281529



Sign in to add a comment
Implement canvas drawSystemFocusRing and drawCustomFocusRing
Project Member Reported by dmazz...@chromium.org, Jul 19 2013 Back to list
Comment 1 by junov@chromium.org, Jul 19 2013
Cc: junov@chromium.org
Project Member Comment 2 by bugdroid1@chromium.org, Jul 30 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=155185

------------------------------------------------------------------------
r155185 | dmazzoni@chromium.org | 2013-07-30T22:29:33.515115Z

Changed paths:
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/accessibility/draw-custom-focus-ring.html?r1=155185&r2=155184&pathrev=155185
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/draw-custom-focus-ring.html?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.cpp?r1=155185&r2=155184&pathrev=155185
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/draw-system-focus-ring-expected.txt?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityRenderObject.cpp?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.h?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.idl?r1=155185&r2=155184&pathrev=155185
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/accessibility/draw-custom-focus-ring-expected.txt?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityObject.h?r1=155185&r2=155184&pathrev=155185
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/draw-custom-focus-ring-expected.txt?r1=155185&r2=155184&pathrev=155185
   A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/fast/canvas/draw-system-focus-ring.html?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/accessibility/AccessibilityNodeObject.cpp?r1=155185&r2=155184&pathrev=155185
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/TestExpectations?r1=155185&r2=155184&pathrev=155185

Implement canvas focus ring methods.

BUG= 261998 

Review URL: https://chromiumcodereview.appspot.com/19786002
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Aug 5 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=155532

------------------------------------------------------------------------
r155532 | dmazzoni@chromium.org | 2013-08-05T18:19:38.049329Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.cpp?r1=155532&r2=155531&pathrev=155532
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.h?r1=155532&r2=155531&pathrev=155532

Canvas focus outline should match style in html.css.

The default style of an element isn't quite right. The style that
most elements get by default when focused is defined in html.css.
There's no easy way to access this, so this change hardcodes
the values and adds a comment.

BUG= 261998 

Review URL: https://chromiumcodereview.appspot.com/21643002
------------------------------------------------------------------------
Project Member Comment 5 by bugdroid1@chromium.org, Aug 20 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/blink?view=rev&rev=156371

------------------------------------------------------------------------
r156371 | dmazzoni@chromium.org | 2013-08-20T07:34:51.905137Z

Changed paths:
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/accessibility/draw-custom-focus-ring-expected.txt?r1=156371&r2=156370&pathrev=156371
   M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/accessibility/draw-custom-focus-ring.html?r1=156371&r2=156370&pathrev=156371
   M http://src.chromium.org/viewvc/blink/trunk/Source/core/html/canvas/CanvasRenderingContext2D.cpp?r1=156371&r2=156370&pathrev=156371

drawSystemFocusRing should take canvas transformations into account.

In addition, the accessible rect needs to be applied to ancesetor elements
within the canvas, otherwise their bounding boxes may be clipped.

BUG= 261998 

Review URL: https://chromiumcodereview.appspot.com/23314002
------------------------------------------------------------------------
Blocking: chromium:281529
Status: Fixed
This should be done now. Let's file new issues if any bugs are found.

Sign in to add a comment