| Issue 25454 | Mac: need to find way to measure memory sharing | ||||||||||||||||||||||||||||||||
| Starred by 201 users | Project Member Reported by viettrungluu@chromium.org, Oct 21 2009 | Back to list | |||||||||||||||||||||||||||||||
Sign in to add a comment
|
This is needed for decent stats (about our own processes!) in about:memory and in the task manager.
,
Dec 17 2009
Replacing labels: Area-BrowserBackend by Area-Internals
,
Dec 18 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34994
------------------------------------------------------------------------
r34994 | thakis@chromium.org | 2009-12-18 14:48:19 -0800 (Fri, 18 Dec 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util.h?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_posix.cc?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/base/trace_event.cc?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager.cc?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/mach_ipc_mac.h?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/mach_ipc_mac.mm?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/chrome_process_util.h?r1=34994&r2=34993
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkitclient_impl.cc?r1=34994&r2=34993
Fix cpu/memory measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG= 13156 ,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
------------------------------------------------------------------------
,
Dec 19 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35025
------------------------------------------------------------------------
r35025 | thakis@chromium.org | 2009-12-18 17:31:03 -0800 (Fri, 18 Dec 2009) | 11 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util.h?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_posix.cc?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/base/trace_event.cc?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager.cc?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/mach_ipc_mac.h?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/mach_ipc_mac.mm?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/chrome_process_util.h?r1=35025&r2=35024
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkitclient_impl.cc?r1=35025&r2=35024
Revert 34994, maybe it regressed startup perf - Fix cpu/memory measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG= 13156 ,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
------------------------------------------------------------------------
,
Dec 19 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35043
------------------------------------------------------------------------
r35043 | viettrungluu@chromium.org | 2009-12-18 20:50:04 -0800 (Fri, 18 Dec 2009) | 14 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util.h?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_posix.cc?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/base/trace_event.cc?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/safe_browsing_database_unittest.cc?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager.cc?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/mach_ipc_mac.h?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/mach_ipc_mac.mm?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/chrome_process_util.h?r1=35043&r2=35042
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkitclient_impl.cc?r1=35043&r2=35042
Revert 35025 - Revert 34994, maybe it regressed startup perf Fix cpu/memory measurements on OS X.
Right now, this only works for the current process; support for child processes will be added in a later CL.
BUG= 13156 ,25454
TEST=Hook up task manager (connect menu item to commandDispatch:, give it the right tag). Stats for the browser process should now be right, and %cpu should be 0 (for now) for all other processes.
Review URL: http://codereview.chromium.org/500118
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/504068
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/505056
------------------------------------------------------------------------
,
Dec 23 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35092
------------------------------------------------------------------------
r35092 | thakis@chromium.org | 2009-12-21 09:44:20 -0800 (Mon, 21 Dec 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util.h?r1=35092&r2=35091
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=35092&r2=35091
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mach_broker_mac.cc
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mach_broker_mac.h
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/mach_broker_mac_unittest.cc
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/task_manager.cc?r1=35092&r2=35091
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=35092&r2=35091
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=35092&r2=35091
Mac: Create a pid->task_t mapping in the browser process.
Since nothing writes to this map in the browser atm, this does not have any visible effect.
BUG= 13156 ,25454
TEST=unittest
Review URL: http://codereview.chromium.org/501138
------------------------------------------------------------------------
,
Jan 21 2010
Memory measurement works by now. We still need to figure out how to measure sharing.
,
Mar 9 2010
,
Jun 28 2010
So... Chrome is using 5 gigs of virtual memory and 310 megs of ram with only 7 tabs, no flash and no Java? Sounds insane to me :-/
,
Oct 7 2010
Measuring shared vs private memory on Mac will be useful for the "processes" extension API, since that's the only way to report memory usage to extensions in a cross-platform way. See http://www.chromium.org/developers/design-documents/extensions/processes-api for details.
,
Nov 10 2010
More than just over-counting your own, it over-counts Safari's as well. Mine's listed as 9.8 gb virtual (unless it's counting Safari and WebKit as the same, despite separate processes, though then it's still 600k high). And under-counts Firefox (reports ~680k, Activity Monitor reports just over 1Gb).
,
Nov 10 2010
@IMGroxx: is that 1G vs 680K, rather than 680M, for Firefox? Moreover, is it about virtual or resident memory? The "Virtual Memory" column in Activity Monitor can be considered a misnomer, even though it is more useful. Use "Inspect Process" to discover that it reports in that column "Virtual Private Memory", i.e. writable areas (allocated with malloc() and such, or mapped from libraries), while "Virtual Memory Size" by itself also includes library text for the whole library you link to; even if you actually just use a function of that library, the whole library must be _mapped_ in virtual memory - which just increases this number, not memory usage, so this number is of rather little use. All this verified on Mac OS X 10.6 (I've no clue about older Macs, this is the first Mac I use).
,
Dec 9 2010
no activity in a year? wheres the fix?
,
Dec 21 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=69863
------------------------------------------------------------------------
r69863 | sail@chromium.org | Tue Dec 21 12:04:56 PST 2010
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=69863&r2=69862&pathrev=69863
Mac: Shared and Private memory for Task Manager
This change adds support for calculating shared and private memory for the Task Manager window. The goal here is to match the values shown in Activity Monitor.
The old "Memory" column already matched Activity Monitor's "Real Memory Size" field.
With this change the "Private" column now matches Activity Monitor's "Private Memory Size" field too.
Unfortunately the "Shared" column doesn't exactly match Activity Monitor's "Shared Memory Size" field. From what I could understand of the libtop source this field is supposed to represent the resident shared memory that isn't being referenced by any other process. Since our code only looks at the memory for a single process we can't detect references by other processes. This means our shared memory value will always be slightly higher than Activity Monitor's.
BUG=25454
TEST=Opened a few tabs and verified that the Private values in Task Manager matched the values in Activity Monitor. Verified that the Shared values were just slightly higher than those in Activity Monitor.
Review URL: http://codereview.chromium.org/5992005
------------------------------------------------------------------------
,
Dec 21 2010
,
Dec 22 2010
I'm working on displaying more memory information in the about:memory page. The only solution I can think of is to run the command line tool "top" and parse its output. Unfortunately the output of top can change from one version to another. While I work on a patch I've asked for help on the darwin-userlevel mailing list: http://lists.apple.com/archives/Darwin-userlevel/2010/Dec/msg00000.html For reference here's the original discussion by viettrungluu on using top vs ps: http://code.google.com/p/chromium/issues/detail?id=9653#c24
,
Jan 7 2011
,
Jan 12 2011
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=71114
------------------------------------------------------------------------
r71114 | sail@chromium.org | Tue Jan 11 16:20:45 PST 2011
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/process_info_snapshot_mac.cc?r1=71114&r2=71113&pathrev=71114
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/about_memory_mac.html?r1=71114&r2=71113&pathrev=71114
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/process_info_snapshot_mac_unittest.cc?r1=71114&r2=71113&pathrev=71114
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/process_info_snapshot.h?r1=71114&r2=71113&pathrev=71114
Use /usr/bin/top in about:memory
Currently we get memory information for about:memory using /bin/ps. Unfortuantely ps doesn't give us information about shared and private memory. Also, it's total virtual memory value doesn't match Activity Monitor's.
This change adds code to get memory information using /usr/bin/top. The new code falls back to ps if there's a parsing error.
Once about:memory displays all the information we need there are still a couple of things left to do:
- refactor ProcessInfoSnapshot to use ProcessMetrics where possible
- do a better job of detecting shared objects between our child processes and show it some how
BUG=25454
TEST=Opened about:memory and verified that the values matched those in Activity Monitor. Tested on both 10.6 and 10.5.
Review URL: http://codereview.chromium.org/6052005
------------------------------------------------------------------------
,
Apr 13 2011
The same on: 11.0.696.43 beta
,
Apr 6 2012
Is this still present on 19.0.1084.15 dev?
,
May 1 2012
does this issue affect the system memory report? (i.e. from Task Manager or Activity Monitor?)
,
Jun 30 2012
Umm... It's only off by 0.61GB according to my testings. I tested each browser I have against the following test: 1. Have every application quit. 2. Check memory free via iStat Menus. 3. Launch browser with predefined (25) tabs. 4. Wait a few minutes for memory to settle. 5. Check memory free and minus from memory free started with. This will at least get some fairly accurate idea of how much memory each browser is using. My results are: FireFox: 0.87GB FireFox with Don't load tabs until selected: 0.53GB Safari: 0.58GB Chromium Version 22.0.1191.0 (144903): 0.98GB Opera: 0.52GB Something that will at least make me happy is adding the "Don't load tabs until selected" option which FireFox has. I use tabs kinda like a "I am going to need this later" feature and hardly go back to the tab unless I have time to. In the mean time... I'll recommend you guys work on memory like how FireFox is at https://areweslimyet.com/ instead of saying to yourself "We seriously overcount our own memory usage." Drive for innovation!
,
Jul 31 2012
I've been following this issue for over a year, and I don't see Chrome's memory usage being overcounted seriously, if at all. To the contrary, I have found it to be very accurate when comparing to every other method of determining memory usage I can find. On the other hand, it is apparent that Chrome's about:memory page seriously undercounts memory usage of other browsers. For example, the Safari process is counted but the Safari Web Content process (where all web content memory is allocated) is not counted. Chrome tends to use more memory with many tabs open, but also frees memory when tabs are closed. Safari tends to retain high memory usage after tabs are closed, regardless of elapsed time or low memory conditions. This issue should be closed. If anyone believes it necessary, an issue to accurately report the memory usage of other browsers, for comparison, should be opened.
,
Aug 2 2012
I've opened 20 tabs in chrome and the same 20 tabs in Safari (no plugins enabled). After waiting a few minutes and loading "about:memory" in Chrome, it says that the memory usage in Chrome is 1,139MB and in Safari it's 220MB. Is this an overcounting issue or a genuine problem with too much memory being used?
,
Aug 2 2012
We may not be measuring Safari's memory usage correctly anymore, now that it has gone multiprocess.
,
Feb 17 2013
This is probably one of those "it's more trouble than it's worth" scenarios but it'd be nice to see this fixed.
,
Mar 10 2013
,
Jul 30 2013
Issue 158824 has been merged into this issue.
,
Oct 18 2013
,
Oct 20 2014
Why Opera v25.0 there are no problems with the processes? As Chrome in Opera for each plug-in, process, application, or there is a separate tab process (Opera Helper). And there are problems with the process " Google Chrome Helper" (not responding). In Opera are the same extensions (from "Chrome web store").
,
Jan 16 2015
Since Oct 2009, google is trying to fix this issue?
,
Jan 16 2015
> Since Oct 2009, google is trying to fix this issue? Look, what do you expect? They've got like a billion more higher priority items than this. They haven't been "trying to fix this issue", they've been observing its existence from a safe distance. I mean, supposing some fool actually got it into their head to really close this issue? It'd only be bad news. "Oh... Chrome uses way more RAM than it's letting on". Who wants to deal with that? Better let sleeping dogs lie. ;)
,
Jan 18 2015
Chrome on OSX is memory eating monster. When having 2-3 windows with 50 tabs each (as results of normal usage), it's taking few gigs of memory (50-300MB for each helper process). It's oven overheating my newest MacBook Pro. So forget to use different profiles. In case of bad-luck crash, no closed tabs are retrieved. Opera is a fast, good and reliable alternative.
,
Jan 18 2015
FYI, as far as memory-friendly alternatives go, I cannot emphasize Firefox enough. I have 839 tabs open right now, and it's running fine: http://cl.ly/image/3C462i450642/Image%202015-01-18%20at%202.49.20%20PM.png And that's low for me. The most I've gone to is over 2000 tabs on my Macbook Pro.
,
May 9 2015
When I opened Task Manager in Chrome on Yosemite, I clicked "Stats for nerds" and saw two things: (1) My Gmail tab, which had been open for 4 hours, was consuming 1,600,000+KB of private memory (2) A link to this issue, which might explain why Gmail is reporting so much memory. Based on this issue, I think my Gmail tab memory usage might be seriously overcounted. Looking at this issue, it seems like the last activity from a Chrome developer was about two years ago. And there is no indication of progress on solving it - it's nearly six years old now. Is there any timeline for solving this issue? I am trying to investigate whether my Gmail tab is using a lot of memory, but this overcounting issue is making me hesitant to come to any reasonable conclusion.
,
May 14 2015
Just stumbled upon this on Mac today at chrome://memory. @primiano: is this something you could address as part of improving memory analysis/tracing? The problem appears to be incorrect counting of shared memory? Cheers, Gab
,
May 14 2015
We are definitely going to address the profiling issue as part of go/memory-infra (aka memory in chrome://tracing). Discussing right now on design docs on how to properly account shared memory. Patches that will deal with the biggest subsystems (shared/discardable/GPU memory manager) are in flight and will be flying in the immediate future [1]). So, you can definitely leave assigned to me if your need is having "a way" to profile memory consumption. On the other side, I can't commit to fix the "stats for nerds" page, at least not in the near future. I think that once we have all the instrumentation in place, somebody will need to hook chrome://memory and friends. [1] See https://code.google.com/p/chromium/issues/list?can=1&q=Hotlist%3DMemoryInfra
,
May 14 2015
Clearing DevTools label, as it is not related to Chrome DevTools.
,
May 21 2015
,
May 21 2015
,
May 31 2015
It's interesting that memory usage profiling work is being done under chrome://tracing, as well as apparently two other chrome:// pages. Is chrome://tracing the preferred way for webapp developers to profile their applications? The tool feels like it's still in its early stages. Frankly, I don't understand the UI of it. I also noticed that there are two memory profilers, (1) chrome://memory-redirect/ which references this bug, and (2) chrome://memory-internals/ which does not reference this bug. Is there a preferred memory profiler? Is there a difference between the two that I'm not understanding? These two pages *appear* to be outputting the same stats, but perhaps memory-redirect is across multiple browsers. If memory-internals is the more-accurate profiler, perhaps Task Manager should link to that instead? Correct me if I'm wrong, but it seems that memory-redirect is subject to deprecation at this point.
,
Jun 1 2015
> The tool feels like it's still in its early stages. Frankly, I don't understand the UI of it. Yes it is in fact. A wiki w/ instructions is going to come soon (later this week). >Is chrome://tracing the preferred way for webapp developers to profile their applications? Chrome tracing is the preferred way to see what's happening inside of chrome. IMHO the 1st thing a webapp developer should look into is DevTools. chrome://tracing comes into play if: a. You are a chrome engineer b. You are a web developer, didn't find anything actionable in devtools and suspect that the slowliness / jank / memory bloat is not directly related with the content but with some chrome internal behavior. In a nutshell the idea behind chrome://tracing is "hey Chrome engineers, I think that my web app is fine but chrome is doing something stupid behind the scenes. Here's a trace, please take a look" See https://www.chromium.org/developers/how-tos/trace-event-profiling-tool for more. >Is there a preferred memory profiler? Is there a difference between the two that I'm not understanding? The difference between chrome://memory-redirect/ and chrome://tracing is pretty much the same between TaskManager and ETW on Windows. The former gives you just total numbers (and this bug is about those numbers being inconsistent on some platforms), the latter a full timeline based profile. I can't tell instead anything about memory-internals. +peria (OWNER of chrome/browser/resources/memory_internals) for more details.
,
Jun 1 2015
chrome://memory-internals was created to help Chrome users report memory issues with their web-browsing histories. Its basic concept is similar to that of chrome://tracing, but the main target of memory-internals was general users. > Is there a difference between the two that I'm not understanding? Basically, chrome://memory and chrome://memory-internals show same memory usages as you see, and memory-internals may show some more detailed information. However, we think memory-internals has a risk(*) to recommend for all users. So task manager does not have a link to it. (*) Each user can copy&paste their browsing history easily, and it may include some privacy information.
,
Jun 2 2015
,
Oct 20 2015
This bug should be closed. The discussion ranges from computing shared memory in Chrome to measuring memory in Safari, and tracks two sets of changes. I really can't tell exactly what problem it's tracking anymore, or what progress has been made to address that problem. Whatever issues people have with Chrome and memory should be appended to other existing relevant bugs, or filed in a new bug.
,
Oct 20 2015
This ticket is linked to from chrome://memory-redirect/ so if it's going to be closed, that page should be modified. Currently it says: "(Bug: We seriously overcount our own memory usage: Issue 25454.)"
,
Oct 20 2015
This bug is officially linked from the Chrome it-self from: chrome://memory-redirect/ which say: > Note: This page will show memory use for all running browsers, not just Chrome. > (Bug: We seriously overcount our own memory usage: Issue 25454.) So if the bug has been solved, the reference should be removed from Chrome then.
,
Oct 20 2015
This is how my memory looks like on OS X on MBR: Private: 6,704,872k ~= 6.7GB? Virtual: 341,882,536k ~= 341GB?
,
Oct 20 2015
,
Oct 21 2015
Hi, I got these messages, but I honestly don't understand. Is this some kind of "bug" or something I need to do? Read the notes, but again, hopefully they're not for me cuz I don't understand the problem. System went wacko last night (my granddaughter had played a game... which I never do) and I saw a comment referring to parental stuff. What am I missing and is there something I can do to help? Again... is this some kind of bug? Migration from PC to Mac in 2012... any connection? Thanks very much! Hey, Hey.... remember, tomorrow's just a future yes-ter-day!
,
Dec 29 2015
SO, WHY AM I STILL HAVING TROUBLE? THIS MEANS NOTHING TO ME, BUT MY MACBOOK PRO IS (AND HAS NEVER BEEN) A HAPPY CAMPER? Hey, Hey.... remember, tomorrow's just a future yes-ter-day!
,
Mar 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c4b4d1a04810d291d4c97639b7b1a115a6d445a commit 2c4b4d1a04810d291d4c97639b7b1a115a6d445a Author: asvitkine <asvitkine@chromium.org> Date: Sat Mar 19 14:18:07 2016 Project Eraser: Kill chrome://memory. This deletes the majority of the code supporting chrome://memory pages. There's still a little bit more of follow-up work to clean up memory_details*.cc files, but those will require some changes to logic and thus is better to do them in a separate CL. BUG= 588790 ,25454 Review URL: https://codereview.chromium.org/1722493002 Cr-Commit-Position: refs/heads/master@{#382198} [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/BUILD.gn [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/app/chromium_strings.grd [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/app/generated_resources.grd [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/app/nibs/TaskManager.xib [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/browser_about_handler_unittest.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/browser_resources.grd [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/defaults.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/defaults.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/history/history_utils.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/memory_details.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/memory_details.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/process_resource_usage.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/profiles/profile_window.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/profiles/profile_window.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/resources/BUILD.gn [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/about_memory.css [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/about_memory.html [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/about_memory.js [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/about_memory_linux.css [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/about_memory_linux.html [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/about_memory_mac.html [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/resources/help/help_page.js [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/OWNERS [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/extension_view.css [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/extension_view.html [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/list.css [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/memory_internals.css [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/memory_internals.html [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/memory_internals.js [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/snapshot_view.css [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals/snapshot_view.html [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/resources/memory_internals_resources.grd [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/task_manager/task_manager.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/task_manager/task_manager.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/chrome_pages.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/chrome_pages.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/cocoa/task_manager_mac.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/cocoa/task_manager_mac.mm [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/views/new_task_manager_view.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/views/new_task_manager_view.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/views/task_manager_view.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/webui/about_ui.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/OWNERS [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/memory_internals_handler.cc [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/memory_internals_handler.h [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.cc [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/memory_internals_proxy.h [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/memory_internals_ui.cc [delete] https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2/chrome/browser/ui/webui/memory_internals/memory_internals_ui.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/browser/web_dev_style/js_checker.py [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/chrome_browser_ui.gypi [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/chrome_repack_resources.gypi [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/chrome_resources.gyp [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/common/url_constants.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/chrome/common/url_constants.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/components/history/core/browser/history_backend_unittest.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/content/browser/child_process_security_policy_impl.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/content/browser/child_process_security_policy_unittest.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/content/public/common/process_type.h [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/ios/chrome/browser/history/history_utils.cc [modify] https://crrev.com/2c4b4d1a04810d291d4c97639b7b1a115a6d445a/tools/gritsettings/resource_ids |
||||||||||||||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||||||||||||||
Status: Available