New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 25396 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2009
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
M-4

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment

Next/Previous tab shortcuts (cmd-opt-arrow) go back/forward when content has focus

Project Member Reported by pinkerton@chromium.org, Oct 21 2009

Issue description

- create a new window with 2 tabs
- in the second tab, load google.com
- make sure the page in tab 2 has focus (not the url bar)
- prefs command-option-left to switch tabs

expected:
- go to other tab

actual:
- page goes back to NTP

If you keep the focus in the url bar the entire time, cmd-option-left/right work 
correctly. If the focus is in the page, cmd-opt-left/right act like back and forwards.
 

Comment 1 by thakis@chromium.org, Oct 21 2009

Status: Started
http://codereview.chromium.org/313004

Comment 2 by bugdro...@gmail.com, Oct 21 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29646 

------------------------------------------------------------------------
r29646 | thakis@chromium.org | 2009-10-21 08:24:04 -0700 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm?r1=29646&r2=29645
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h?r1=29646&r2=29645
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm?r1=29646&r2=29645

Fix cmd-opt-left/right.

This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.

BUG= 25396 
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.

Review URL: http://codereview.chromium.org/313004
------------------------------------------------------------------------

Comment 3 by thakis@chromium.org, Oct 21 2009

Status: Fixed

Comment 4 by bugdro...@gmail.com, Oct 21 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29648 

------------------------------------------------------------------------
r29648 | nsylvain@chromium.org | 2009-10-21 08:39:12 -0700 (Wed, 21 Oct 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm?r1=29648&r2=29647
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h?r1=29648&r2=29647
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm?r1=29648&r2=29647

Revert 29646 - Fix cmdoptleft/right.

This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmdoptleft meant cmdleft and swallowed the event.

BUG= 25396 
TEST=Focus text box in web. cmdoptleft/right should switch tabs, cmdleft/right should move cursor in text box. Focus web background. cmdoptleft/right should switch tabs, cmdleft/right should do history navigation. Focus omnibox. cmdoptleft/right should still switch tabs, cmdleft/right should move cursor. cmd1/2 should switch tabs in all three places, cmdopt1/2 should not do anything.

Review URL: http://codereview.chromium.org/313004

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/306025
------------------------------------------------------------------------

Comment 5 by thakis@chromium.org, Oct 21 2009

Status: Started

Comment 6 by bugdro...@gmail.com, Oct 21 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29660 

------------------------------------------------------------------------
r29660 | thakis@chromium.org | 2009-10-21 10:15:28 -0700 (Wed, 21 Oct 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/chrome_event_processing_window.mm?r1=29660&r2=29659
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.h?r1=29660&r2=29659
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac.mm?r1=29660&r2=29659
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/global_keyboard_shortcuts_mac_unittest.cc?r1=29660&r2=29659

Fix cmd-opt-left/right.

This surfaced because I moved global shortcut handling before menu dispatch recently, and global keyboard handling didn't look at the opt button, so it thought cmd-opt-left meant cmd-left and swallowed the event.

BUG= 25396 
TEST=Focus text box in web. cmd-opt-left/right should switch tabs, cmd-left/right should move cursor in text box. Focus web background. cmd-opt-left/right should switch tabs, cmd-left/right should do history navigation. Focus omnibox. cmd-opt-left/right should still switch tabs, cmd-left/right should move cursor. cmd-1/2 should switch tabs in all three places, cmd-opt-1/2 should not do anything.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29646
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=29648

Review URL: http://codereview.chromium.org/313004
------------------------------------------------------------------------

Comment 7 by thakis@chromium.org, Oct 21 2009

Status: Fixed

Comment 8 by thakis@chromium.org, Oct 21 2009

 Issue 25284  has been merged into this issue.
This bug seems to have resurfaced:

http://code.google.com/p/chromium/issues/detail?id=25709
 Issue 25709  has been merged into this issue.
 Issue 25679  has been merged into this issue.

Comment 12 by rossc...@gmail.com, Oct 24 2009

This is marked as "Fixed" ... but it does not seem to be.
(At least, not in 4.0.223.11)
The fix is checked in, but it didn't make it into this week's dev release. It will be in next 
week's release.
Status: Verified
Platform:
  Hostname: Macintosh-0017f2d64524.local
  Mac OS X Version 10.5.8 (Build 9L27)
  Processor: 2 Intel 2.33 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 4.0.225.0 r30036  <<<Release>>>
  QuickTime Player: 7.6.4
  QuickTime PlayerX: <unknown>
  Flash Player: 10.0.32

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=30582 

------------------------------------------------------------------------
r30582 | thakis@chromium.org | 2009-10-30 08:48:35 -0700 (Fri, 30 Oct 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/mac/WebInputEventFactory.mm?r1=30582&r2=30581

Mark keys with cmd pressed as isSystemKeys.

BUG= 25856 , probably also the Right Fix for 25396
TEST=Go to en.wikipedia.org , make the window very narrow so that there's a horizontal scrollbar. cmd-left/right should go back/forward instead of scrolling horizontally.

Review URL: http://codereview.chromium.org/347022
------------------------------------------------------------------------

Project Member

Comment 16 by bugdroid1@chromium.org, Oct 12 2012

Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 10 2013

Labels: -Mstone-4 M-4
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 13 2013

Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue

Sign in to add a comment