Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Issue 249976 Remove prefixed EME (v0.1b) support & implementation
Starred by 12 users Project Member Reported by ddorwin@chromium.org, Jun 14 2013 Back to list
Status: Fixed
Owner:
Closed: Feb 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug


Sign in to add a comment
Once the object-oriented version of EME is implemented (issue 224786) and sites have switched, we will remove support for v0.1b and delete the implementation. This bug will track that work as well as specific items to remove.
 
1) Rename methods and parameter names at all API levels.
2) Remove |initData| parameter from addKey.
Project Member Comment 2 by bugdroid1@chromium.org, Jun 18 2013
------------------------------------------------------------------------
r207025 | ddorwin@chromium.org | 2013-06-18T17:38:35.208040Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=207025&r2=207024&pathrev=207025
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/webmediaplayer_util.cc?r1=207025&r2=207024&pathrev=207025
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/media_keys.h?r1=207025&r2=207024&pathrev=207025

Remove unused EME v0.1b MediaKeyError values.

This will avoid them being used before the new errors are defined.

BUG= 249976 
R=isherman@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/17310002
------------------------------------------------------------------------
Project Member Comment 3 by bugdroid1@chromium.org, Jun 19 2013
------------------------------------------------------------------------
r207131 | ddorwin@chromium.org | 2013-06-19T00:52:13.305829Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/webmediaplayer_proxy_impl_android.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/renderer/media/webmediaplayer_proxy_impl_android.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/content_decryptor_delegate.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/content_decryptor_delegate.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/android/media_source_delegate.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/android/media_player_manager_impl.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/android/media_source_player_unittest.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi/clear_key_cdm.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/android/webmediaplayer_android.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/webmediaplayer_impl.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/android/media_source_delegate.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/android/media_player_manager_impl.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi/clear_key_cdm.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/android/webmediaplayer_android.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/webmediaplayer_impl.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/android/webmediaplayer_proxy_android.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/pipeline_integration_test_base.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi_decryptor.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/pipeline_integration_test.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/android/media_player_manager.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi_decryptor.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/crypto/aes_decryptor_unittest.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/crypto/aes_decryptor.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/crypto/aes_decryptor.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/media_keys.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/media/media_player_messages_android.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/android/media_drm_bridge.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/proxy_decryptor.cc?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/base/android/media_drm_bridge.h?r1=207131&r2=207130&pathrev=207131
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/proxy_decryptor.h?r1=207131&r2=207130&pathrev=207131

Separate CDM initialization from GenerateKeyRequest & remove key_system parameters.

This eliminates unnecessary parameters and prepares for integration with the new API.

BUG= 249976 , 250048 
TBR=cdn@chromium.org

Review URL: https://codereview.chromium.org/17289006
------------------------------------------------------------------------
Project Member Comment 4 by bugdroid1@chromium.org, Jun 20 2013
------------------------------------------------------------------------
r207580 | ddorwin@chromium.org | 2013-06-20T21:34:15.237493Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/content_decryptor_delegate.h?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi_decryptor.h?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/crypto/aes_decryptor_unittest.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/crypto/aes_decryptor.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/crypto/aes_decryptor.h?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/android/webmediaplayer_android.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi/clear_key_cdm.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/webmediaplayer_impl.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi/clear_key_cdm.h?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/proxy_decryptor.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/proxy_decryptor.h?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/pipeline_integration_test.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/plugins/ppapi/content_decryptor_delegate.cc?r1=207580&r2=207579&pathrev=207580
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/renderer/media/crypto/ppapi_decryptor.cc?r1=207580&r2=207579&pathrev=207580

Removed unused NeedKey callback from Decryptors.

The needkey event comes from the demuxers only.

BUG= 249976 
R=dmichael@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/17309003
------------------------------------------------------------------------
Labels: EME-WD
Labels: -Pri-2 Pri-3
Owner: ----
Labels: -EME-WD EME-Prefixed
Status: Untriaged
Summary: Remove prefixed EME (v0.1b) support & implementation (was: Remove EME v0.1b support & implementation)
Blockedon: chromium:241496
Status: Available
Labels: M-40
Blocking: chromium:324037
Blocking: chromium:342510
Blockedon: chromium:394918
Cc: -jluther@chromium.org ericde@chromium.org renganat...@chromium.org
The first step will be to add a deprecation message when the unprefixed APIs are available by default (issue 394918).
Blocking: chromium:412987
Labels: -M-40 M-41 MovedFrom-40
Status: Untriaged
Moving all non essential bugs to the next Milestone.
Labels: -M-41 M-45
Status: Available
Project Member Comment 19 by bugdroid1@chromium.org, Dec 2 2014
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bab66f5a4aac5b611ea0008f322391e0bb25eaff

commit bab66f5a4aac5b611ea0008f322391e0bb25eaff
Author: xhwang <xhwang@chromium.org>
Date: Tue Dec 02 23:49:50 2014

Move OnNeedKey() to WebMediaPlayerImpl.

OnNeedKey() is needed for both prefixed and unprefixed EME. Move it out of EncryptedMediaPlayerSupport so that EncryptedMediaPlayerSupport is for prefixed EME only.

BUG= 249976 

Review URL: https://codereview.chromium.org/759933003

Cr-Commit-Position: refs/heads/master@{#306493}

[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/content/renderer/media/android/media_source_delegate.cc
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/content/renderer/media/android/media_source_delegate.h
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/content/renderer/media/android/webmediaplayer_android.cc
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/content/renderer/media/android/webmediaplayer_android.h
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/media/blink/encrypted_media_player_support.cc
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/media/blink/encrypted_media_player_support.h
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/media/blink/webmediaplayer_impl.cc
[modify] http://crrev.com/bab66f5a4aac5b611ea0008f322391e0bb25eaff/media/blink/webmediaplayer_impl.h

Blockedon: chromium:442555
Blockedon: chromium:451117
Blocking: chromium:457438
Blocking: chromium:349201
Labels: -M-45 M-47
Labels: -M-47 M-48
This will happen (gradually) sometime after prefixed is disabled by default in M47 (issue 451117).
Blockedon: chromium:367158
The EncryptedMediaIsTypeSupported tests rely on prefixed EME (issue 367158).
Labels: -Pri-3 Pri-2
The first step will be to remove the flag to enable prefixed EME (issue 451117). At that time, we should also remove the ability to disable unprefixed and remove all the related strings for both.
Blockedon: chromium:554652
Labels: EMEscrubbedM49
ericde: Any expected milestone to fix this? Are we still targeting M48?
Labels: -M-48 M-50
Blockedon: chromium:580197
Cc: lcwu@chromium.org
We also need to make sure "all Cast partner apps are moved off of it (prefixed EME)" [1].

lcwu: Is this done now?

https://code.google.com/p/chromium/codesearch#chromium/src/chromecast/browser/cast_browser_main_parts.cc&l=217
lcwu: Kindly ping on #32. Also are there any partners still using prefixed EME on Android TV?
Comment 34 by lcwu@chromium.org, Jan 27 2016
Yes, from our side it is OK to remove the prefixed EME. Thanks.
Project Member Comment 35 by bugdroid1@chromium.org, Feb 20 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7407850b7f1caa33481ec22124c8b5ef4bceac4a

commit 7407850b7f1caa33481ec22124c8b5ef4bceac4a
Author: ddorwin <ddorwin@chromium.org>
Date: Sat Feb 20 01:43:56 2016

EME: Fix the CDM File IO test when run using unprefixed EME.

This test was not registering the unprefixed event handlers, processing the
message as the correct type, or enabling required peristent storage capability.

The two FileIOTest tests may still not be testing both paths, but the prefixed
path will be removed in my next CL.

BUG= 249976 
TEST=ECKEncryptedMediaTest.FileIOTest passes when prefixed EME is manually disabled in the test.

Review URL: https://codereview.chromium.org/1717033002

Cr-Commit-Position: refs/heads/master@{#376601}

[modify] https://crrev.com/7407850b7f1caa33481ec22124c8b5ef4bceac4a/media/test/data/eme_player_js/file_io_test_player.js
[modify] https://crrev.com/7407850b7f1caa33481ec22124c8b5ef4bceac4a/media/test/data/eme_player_js/player_utils.js
[modify] https://crrev.com/7407850b7f1caa33481ec22124c8b5ef4bceac4a/media/test/data/eme_player_js/utils.js

Cc: jrumm...@chromium.org ddorwin@chromium.org
Issue 580197 has been merged into this issue.
Owner: ddorwin@chromium.org
Status: Started
Project Member Comment 38 by bugdroid1@chromium.org, Feb 22 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdb9a2bea13a877eef407fe7359b056b56d8ab2e

commit fdb9a2bea13a877eef407fe7359b056b56d8ab2e
Author: ddorwin <ddorwin@chromium.org>
Date: Mon Feb 22 22:25:10 2016

Remove prefixed EME.

This removes most of the code, including from Blink and WebMediaPlayer*.
Some code that is not trivial to remove still exists. Specifically, there are
some legacy parameters in media::MediaKeys and implementations of it. Also,
although prefixed tests have been disabled, not all related paths have been
removed. In addition, there are some TODOs that will be addressed separately.

The flag to disable (unprefixed) EME is no longer useful and has been removed.

BUG= 249976 
TEST=Unprefixed EME tests still pass.

Review URL: https://codereview.chromium.org/1712903002

Cr-Commit-Position: refs/heads/master@{#376828}

[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/chrome/app/generated_resources.grd
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/chrome/browser/about_flags.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/child/runtime_features.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/child/simple_webmimeregistry_impl.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/child/simple_webmimeregistry_impl.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/renderer/media/android/webmediaplayer_android.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/renderer/media/android/webmediaplayer_android.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/renderer/media/cdm/render_cdm_factory.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/renderer/media/render_media_client.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/BUILD.gn
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/BUILD.gn
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/android/media_drm_bridge.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/key_system_info.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/key_systems.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/key_systems.h
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/base/key_systems_support_uma.cc
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/base/key_systems_support_uma.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/key_systems_unittest.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/media_client.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/media_client.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/base/media_keys.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/BUILD.gn
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/cdm_session_adapter.cc
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/blink/encrypted_media_player_support.cc
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/blink/encrypted_media_player_support.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/media_blink.gyp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/webmediaplayer_util.cc
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/blink/webmediaplayer_util.h
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/cdm/proxy_decryptor.cc
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/cdm/proxy_decryptor.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/media.gyp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/mojo/interfaces/content_decryption_module.mojom
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player.html
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/app_loader.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/clearkey_player.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/eme_app.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/file_io_test_player.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/globals.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/player_utils.js
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/test/data/eme_player_js/prefixed_clearkey_player.js
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/media/test/data/eme_player_js/prefixed_widevine_player.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/test_config.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/utils.js
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/media/test/data/eme_player_js/widevine_player.js
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/fast/events/constructors/media-key-event-constructor-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/fast/events/constructors/media-key-event-constructor.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-prefixed-after-unprefixed.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-unprefixed-after-prefixed.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-can-play-type-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-can-play-type-webm-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-can-play-type-webm.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-can-play-type.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-constants-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-constants.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-events-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-events.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-not-loaded-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-not-loaded.html
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-syntax-expected.txt
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/LayoutTests/media/encrypted-media/prefixed/encrypted-media-syntax.html
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/core/html/HTMLMediaElement.idl
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/Source/core/html/MediaKeyError.h
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/Source/core/html/MediaKeyError.idl
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/Source/core/html/MediaKeyEvent.cpp
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/Source/core/html/MediaKeyEvent.h
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/Source/core/html/MediaKeyEvent.idl
[delete] https://crrev.com/04f05e57fe272290b9ceddb288d919434277165e/third_party/WebKit/Source/core/html/MediaKeyEventInit.idl
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/public/platform/WebMediaPlayer.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/public/platform/WebMediaPlayerEncryptedMediaClient.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/public/platform/WebMimeRegistry.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/fdb9a2bea13a877eef407fe7359b056b56d8ab2e/tools/metrics/histograms/histograms.xml

Status: Fixed
Prefixed EME is now removed in master (M50), so I have closed this issue to reflect this and unblock other issues.

We will continue to land CLs to remove remaining prefixed-related code and implement refactorings that are now possible.
Blocking: 570216
Project Member Comment 43 by bugdroid1@chromium.org, Feb 25 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d09e12187dfb54c3c49d937b8fafc4df09f5227d

commit d09e12187dfb54c3c49d937b8fafc4df09f5227d
Author: ddorwin <ddorwin@chromium.org>
Date: Thu Feb 25 23:20:24 2016

EME: Ensure that registered codecs match the MIME type.

Prefixed EME used a single content type string and thus needed to allow audio
codecs with 'video/' MIME types. This is not true for unprefixed EME, so we can
be more strict now that prefixed has been removed.

This also renames some things to reflect this, reorders some declarations and
calls to enable the enforcement, and removes some unreferenced funcitons.

BUG= 249976 

Review URL: https://codereview.chromium.org/1730383004

Cr-Commit-Position: refs/heads/master@{#377700}

[modify] https://crrev.com/d09e12187dfb54c3c49d937b8fafc4df09f5227d/media/base/key_systems.cc
[modify] https://crrev.com/d09e12187dfb54c3c49d937b8fafc4df09f5227d/media/base/key_systems.h
[modify] https://crrev.com/d09e12187dfb54c3c49d937b8fafc4df09f5227d/media/base/key_systems_unittest.cc

Blocking: 590009
Project Member Comment 46 by bugdroid1@chromium.org, Feb 26 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83daddea0310ac6cf58786e76158f84247ae709c

commit 83daddea0310ac6cf58786e76158f84247ae709c
Author: ddorwin <ddorwin@chromium.org>
Date: Fri Feb 26 02:57:54 2016

EME: Remove the concept of concrete key systems.

All key systems are concrete in unprefixed EME because there are no parent
key systems like there were for prefixed EME.

BUG= 249976 

Review URL: https://codereview.chromium.org/1727833005

Cr-Commit-Position: refs/heads/master@{#377789}

[modify] https://crrev.com/83daddea0310ac6cf58786e76158f84247ae709c/media/base/key_systems.cc
[modify] https://crrev.com/83daddea0310ac6cf58786e76158f84247ae709c/media/base/key_systems.h
[modify] https://crrev.com/83daddea0310ac6cf58786e76158f84247ae709c/media/base/key_systems_unittest.cc

Project Member Comment 49 by bugdroid1@chromium.org, Mar 7 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c55bcebd87beeef0bf808a8fab7d2e57d36e4809

commit c55bcebd87beeef0bf808a8fab7d2e57d36e4809
Author: ddorwin <ddorwin@chromium.org>
Date: Mon Mar 07 22:05:34 2016

Remove EME and MSE from RuntimeEnabledFeatures.

These are stable and no longer need to be configurable.
On Android, only Clear Key will be available when MediaCodec is unavailable.

Also removes the MSE flag and command line switch and unreferenced EME switch.

BUG= 582618 , 249976 

Review URL: https://codereview.chromium.org/1742933002

Cr-Commit-Position: refs/heads/master@{#379660}

[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/chrome/app/generated_resources.grd
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/chrome/browser/about_flags.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/content/child/runtime_features.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/content/public/common/content_switches.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/content/public/common/content_switches.h
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/content/renderer/media/android/webmediaplayer_android.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaEncryptedEvent.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEvent.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemAccess.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemConfiguration.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemMediaCapability.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/mediasource/MediaSource.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/modules/mediasource/SourceBufferList.idl
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/c55bcebd87beeef0bf808a8fab7d2e57d36e4809/third_party/WebKit/public/web/WebRuntimeFeatures.h

Project Member Comment 50 by bugdroid1@chromium.org, May 21 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82484c2ae1f3b905b3a3bc9d34bff39f5791d5cc

commit 82484c2ae1f3b905b3a3bc9d34bff39f5791d5cc
Author: ddorwin <ddorwin@chromium.org>
Date: Sat May 21 03:11:14 2016

EME: Check for invalid Key System names on addition

Prefixed implementations supported invalid names so we only checked in the
unprefixed use path. Now, these should never be provided, so we can check
on addition like other Key System properties.

BUG= 249976 

Review-Url: https://codereview.chromium.org/1910283003
Cr-Commit-Position: refs/heads/master@{#395239}

[modify] https://crrev.com/82484c2ae1f3b905b3a3bc9d34bff39f5791d5cc/media/base/key_systems.cc

Project Member Comment 52 by bugdroid1@chromium.org, Aug 23 2016
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17374bd6ce7a3c35da3377eb74de834c22c1bcb8

commit 17374bd6ce7a3c35da3377eb74de834c22c1bcb8
Author: ddorwin <ddorwin@chromium.org>
Date: Tue Aug 23 21:36:14 2016

EME: Remove obsolete legacy APIs related to versions of prefixed EME

Remove legacy_destination_url and LegacySessionError.

BUG= 249976 
TEST=existing tests

Review-Url: https://codereview.chromium.org/2255943002
Cr-Commit-Position: refs/heads/master@{#413845}

[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/chromecast/browser/media/cast_browser_cdm_factory.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/chromecast/browser/media/cast_browser_cdm_factory.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/chromecast/media/cdm/cast_cdm.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/chromecast/media/cdm/cast_cdm.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/browser/media/cdm/browser_cdm_manager.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/browser/media/cdm/browser_cdm_manager.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/common/media/cdm_messages.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/ppapi_decryptor.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/ppapi_decryptor.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/proxy_media_keys.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/proxy_media_keys.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/render_cdm_factory.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/render_cdm_factory.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/renderer_cdm_manager.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/media/cdm/renderer_cdm_manager.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/pepper/content_decryptor_delegate.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/pepper/content_decryptor_delegate.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/android/android_cdm_factory.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/android/android_cdm_factory.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/android/java/src/org/chromium/media/MediaDrmBridge.java
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/android/media_drm_bridge.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/android/media_drm_bridge.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/cdm_factory.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/base/media_keys.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/blink/cdm_session_adapter.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/blink/cdm_session_adapter.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/aes_decryptor.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/aes_decryptor_unittest.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/cdm_adapter.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/cdm_adapter.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/cdm_adapter_unittest.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/default_cdm_factory.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/default_cdm_factory.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/ppapi/external_clear_key/clear_key_cdm.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/ppapi/ppapi_cdm_adapter.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/cdm/ppapi/ppapi_cdm_adapter.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/clients/mojo_cdm.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/clients/mojo_cdm.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/clients/mojo_cdm_factory.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/clients/mojo_cdm_factory.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/interfaces/content_decryption_module.mojom
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/services/mojo_cdm_service.cc
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/mojo/services/mojo_cdm_service.h
[modify] https://crrev.com/17374bd6ce7a3c35da3377eb74de834c22c1bcb8/media/test/pipeline_integration_test.cc

Sign in to add a comment